)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"05bd0feb4f24d22c7b89a4240b6972da90c3177d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-04 18:38:07 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deterministic ordering of fixed_ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds an order_by clause to the fixed_ips relationship"},{"line_number":10,"context_line":"on the port object to ensure that the fixed_ip ordering is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_609ef157","line":7,"updated":"2016-10-05 01:05:20.000000000","message":"What is the use case to create more than one fixed ip from the network on the same port?","commit_id":"3deafffa5e37302e924656f05d1825fc9fc86f6f"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"e67e587f575128ad6e8fea399de2e68e8913ce6b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-04 18:38:07 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deterministic ordering of fixed_ips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds an order_by clause to the fixed_ips relationship"},{"line_number":10,"context_line":"on the port object to ensure that the fixed_ip ordering is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_5fd54f41","line":7,"in_reply_to":"1a95cdbc_609ef157","updated":"2016-10-05 02:42:11.000000000","message":"Dual-stack. In default devstack currently, a simple port create will get you 2 fixed_ips - one ipv4 and one ipv6.","commit_id":"3deafffa5e37302e924656f05d1825fc9fc86f6f"}],"neutron/tests/unit/db/test_dvr_mac_db.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"dd5d4734ec89f18a70bade83bd50e43e54e605ec","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            dvr_ports \u003d self.mixin.get_ports_on_host_by_subnet("},{"line_number":187,"context_line":"                self.ctx, HOST, subnet[\u0027subnet\u0027][\u0027id\u0027])"},{"line_number":188,"context_line":"            self.assertEqual(len(expected_ids), len(dvr_ports))"},{"line_number":189,"context_line":"            self.assertItemsEqual(expected_ids, [port[\u0027id\u0027] for port in dvr_ports])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_85e9381d","line":189,"updated":"2016-10-05 12:49:10.000000000","message":"Why not sort expected_ids by ip and subnet (like the order_by clause you defined), and then use assertEqual to verify that the order is correct too?","commit_id":"cd767a2158f3157957b8813c8ca509f3c559afdc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e6d7167f3072deec2f606d169fb3ffd935fdbed4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            dvr_ports \u003d self.mixin.get_ports_on_host_by_subnet("},{"line_number":187,"context_line":"                self.ctx, HOST, subnet[\u0027subnet\u0027][\u0027id\u0027])"},{"line_number":188,"context_line":"            self.assertEqual(len(expected_ids), len(dvr_ports))"},{"line_number":189,"context_line":"            self.assertItemsEqual(expected_ids, [port[\u0027id\u0027] for port in dvr_ports])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_b7ae0696","line":189,"in_reply_to":"1a95cdbc_85e9381d","updated":"2016-10-07 07:38:04.000000000","message":"this test isn\u0027t related to order. the ml2 tests ensure consistent ordering","commit_id":"cd767a2158f3157957b8813c8ca509f3c559afdc"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"05bd0feb4f24d22c7b89a4240b6972da90c3177d","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        with self.port(fixed_ips\u003dinitial_fixed_ips) as port:"},{"line_number":808,"context_line":"            show \u003d plugin.get_port(ctx, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":809,"context_line":"            self.assertEqual(port[\u0027port\u0027][\u0027fixed_ips\u0027], show[\u0027fixed_ips\u0027])"},{"line_number":810,"context_line":"            new_fixed_ips \u003d  list(reversed(initial_fixed_ips))"},{"line_number":811,"context_line":"            port[\u0027port\u0027][\u0027fixed_ips\u0027] \u003d new_fixed_ips"},{"line_number":812,"context_line":"            updated \u003d plugin.update_port(ctx, port[\u0027port\u0027][\u0027id\u0027], port)"},{"line_number":813,"context_line":"            self.assertEqual(show[\u0027fixed_ips\u0027], updated[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_0088cd21","line":810,"range":{"start_line":810,"start_character":28,"end_line":810,"end_character":29},"updated":"2016-10-05 01:05:20.000000000","message":"one too many spaces :)","commit_id":"3deafffa5e37302e924656f05d1825fc9fc86f6f"}]}
