)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"586c43d7635e3bad2f0073416f84c7e35392e096","unresolved":false,"context_lines":[{"line_number":15,"context_line":"sure the operator will see it irrespective of what the caller will do"},{"line_number":16,"context_line":"with the exception."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Also, a note to fellow reviewer: No, I don\u0027t think it needs a unit test"},{"line_number":19,"context_line":"case. Do you?"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ib47b67da1e7e4b749abb8b1b93888e23d00da00a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a95cdbc_992193fe","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":13},"updated":"2016-10-05 16:28:34.000000000","message":"i liked the note, it is still ImportError so existing test will work fine unless to you want to check if save_and_reraiseexception is called once either within existing test or a different test","commit_id":"83ef231052b430928152afd0efc4d495b0694cec"}],"neutron/manager.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c12a2865b36d48f42b44dcb1abffda2999a1d7e0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                    plugin_provider)"},{"line_number":156,"context_line":"        except ImportError:"},{"line_number":157,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"                LOG.exception(_LE(\"Plugin \u0027%s\u0027 not found.\"), plugin_provider)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_plugin_instance(self, namespace, plugin_provider):"},{"line_number":161,"context_line":"        plugin_class \u003d self.load_class_for_provider(namespace, plugin_provider)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_9f26d866","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":29},"updated":"2016-10-05 15:36:28.000000000","message":"This won\u0027t contain any meaningful path other than pointing to this line of code? Don\u0027t you think error would be more reasonable?","commit_id":"a1f5fc4795a6064fd63595e059643eb6a69ac257"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"deb3f1911a8fa045f6ae77886037de7f31fa2c3a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                    plugin_provider)"},{"line_number":156,"context_line":"        except ImportError:"},{"line_number":157,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"                LOG.exception(_LE(\"Plugin \u0027%s\u0027 not found.\"), plugin_provider)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_plugin_instance(self, namespace, plugin_provider):"},{"line_number":161,"context_line":"        plugin_class \u003d self.load_class_for_provider(namespace, plugin_provider)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_33f7c0f6","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":29},"in_reply_to":"1a95cdbc_1ff3a89f","updated":"2016-10-05 15:46:45.000000000","message":"Aha, so we\u0027ll get two same traces unless the caller doesn\u0027t handle ImportError?","commit_id":"a1f5fc4795a6064fd63595e059643eb6a69ac257"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ade122324eaa133b2df68c1869852b4ce85eaec6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                    plugin_provider)"},{"line_number":156,"context_line":"        except ImportError:"},{"line_number":157,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"                LOG.exception(_LE(\"Plugin \u0027%s\u0027 not found.\"), plugin_provider)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def _get_plugin_instance(self, namespace, plugin_provider):"},{"line_number":161,"context_line":"        plugin_class \u003d self.load_class_for_provider(namespace, plugin_provider)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_1ff3a89f","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":29},"in_reply_to":"1a95cdbc_9f26d866","updated":"2016-10-05 15:39:30.000000000","message":"I think LOG.exception will report the traceback extracted from the current exception extracted from the program state with sys.exc_info(). Meaning, the exception that was raised by line 154-155. After we log it here, we reraise it.","commit_id":"a1f5fc4795a6064fd63595e059643eb6a69ac257"}]}
