)]}'
{"neutron/db/address_scope_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"38d0e52b0a25a31cd2092eb6b00984ac62c89125","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        a_s \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":73,"context_line":"        address_scope_id \u003d a_s.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":74,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":75,"context_line":"            pool_args \u003d {\u0027project_id\u0027: a_s[\u0027tenant_id\u0027],"},{"line_number":76,"context_line":"                         \u0027id\u0027: address_scope_id,"},{"line_number":77,"context_line":"                         \u0027name\u0027: a_s[\u0027name\u0027],"},{"line_number":78,"context_line":"                         \u0027shared\u0027: a_s[\u0027shared\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_8f98d379","line":75,"range":{"start_line":75,"start_character":44,"end_line":75,"end_character":53},"updated":"2016-10-10 06:34:05.000000000","message":"any reason why we are not using project_id here?","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        a_s \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":73,"context_line":"        address_scope_id \u003d a_s.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":74,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":75,"context_line":"            pool_args \u003d {\u0027project_id\u0027: a_s[\u0027tenant_id\u0027],"},{"line_number":76,"context_line":"                         \u0027id\u0027: address_scope_id,"},{"line_number":77,"context_line":"                         \u0027name\u0027: a_s[\u0027name\u0027],"},{"line_number":78,"context_line":"                         \u0027shared\u0027: a_s[\u0027shared\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_c52fcb9f","line":75,"range":{"start_line":75,"start_character":44,"end_line":75,"end_character":53},"in_reply_to":"1a95cdbc_8f98d379","updated":"2016-10-11 10:37:57.000000000","message":"while I agree with the premise of the change, I am not sure why it\u0027s relevant to the fix.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        a_s \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":73,"context_line":"        address_scope_id \u003d a_s.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":74,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":75,"context_line":"            pool_args \u003d {\u0027project_id\u0027: a_s[\u0027tenant_id\u0027],"},{"line_number":76,"context_line":"                         \u0027id\u0027: address_scope_id,"},{"line_number":77,"context_line":"                         \u0027name\u0027: a_s[\u0027name\u0027],"},{"line_number":78,"context_line":"                         \u0027shared\u0027: a_s[\u0027shared\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_444ac8c6","line":75,"range":{"start_line":75,"start_character":44,"end_line":75,"end_character":53},"in_reply_to":"fa6399be_c52fcb9f","updated":"2016-10-11 18:33:06.000000000","message":"Removed. I was fixing test failures and didn\u0027t clean up properly.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aefd86ebeb09a917d73e0a52f4db391b2f6340b5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Create an address scope.\"\"\""},{"line_number":75,"context_line":"        a_s \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":76,"context_line":"        address_scope_id \u003d a_s.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":77,"context_line":"        pool_args \u003d {\u0027project_id\u0027: a_s[\u0027project_id\u0027],"},{"line_number":78,"context_line":"                     \u0027id\u0027: address_scope_id,"},{"line_number":79,"context_line":"                     \u0027name\u0027: a_s[\u0027name\u0027],"},{"line_number":80,"context_line":"                     \u0027shared\u0027: a_s[\u0027shared\u0027],"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_57daacea","line":77,"range":{"start_line":77,"start_character":40,"end_line":77,"end_character":50},"updated":"2017-01-09 17:47:21.000000000","message":"(No action required) I believe this could in theory be left unchanged. You do leave in some other places, so I thought it\u0027s worth pointing out the slight inconsistency.","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8e5e1e78aa405f359890fa2534bdeedb50bed9f4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Create an address scope.\"\"\""},{"line_number":75,"context_line":"        a_s \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":76,"context_line":"        address_scope_id \u003d a_s.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":77,"context_line":"        pool_args \u003d {\u0027project_id\u0027: a_s[\u0027project_id\u0027],"},{"line_number":78,"context_line":"                     \u0027id\u0027: address_scope_id,"},{"line_number":79,"context_line":"                     \u0027name\u0027: a_s[\u0027name\u0027],"},{"line_number":80,"context_line":"                     \u0027shared\u0027: a_s[\u0027shared\u0027],"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_14db82ee","line":77,"range":{"start_line":77,"start_character":40,"end_line":77,"end_character":50},"in_reply_to":"ba5201f7_57daacea","updated":"2017-01-11 14:56:41.000000000","message":"Reverted to tenant_id.","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_680ed635","line":1019,"range":{"start_line":1019,"start_character":38,"end_line":1019,"end_character":50},"updated":"2016-10-11 10:37:57.000000000","message":"this change does not seem relevant. What guarantees us that the payload will have project_id? API layer? Anyhow, it\u0027s not particularly relevant to the bug.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d5309893836ab2b178d2f3957482b3fae01381e2","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_98218a50","line":1019,"range":{"start_line":1019,"start_character":38,"end_line":1019,"end_character":50},"in_reply_to":"fa6399be_649d0c65","updated":"2016-10-12 10:18:35.000000000","message":"I believe they fail because you also modified the subnetpool reader to expose project_id. It\u0027s not needed either.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_649d0c65","line":1019,"range":{"start_line":1019,"start_character":38,"end_line":1019,"end_character":50},"in_reply_to":"fa6399be_680ed635","updated":"2016-10-11 18:33:06.000000000","message":"The ipam tests fail without this.\n\nThe API layer ensures the project_id attribute is present. It was done as part of [1]. See [2] and [3].\n\n[1] https://review.openstack.org/357977\n[2] https://github.com/openstack/neutron/blob/9.0.0/neutron/api/v2/base.py#L708\n[2] https://github.com/openstack/neutron/blob/9.0.0/neutron/api/v2/attributes.py#L496","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9c2191863b99ea11d7fa6500530631f9baa8dca1","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_d8dce214","line":1019,"range":{"start_line":1019,"start_character":39,"end_line":1019,"end_character":49},"updated":"2016-10-12 10:19:18.000000000","message":"you wouldn\u0027t need to change that here if you would not touch subnet_alloc.py file.","commit_id":"7ebfe799c06a8337a0280f5245ca17f01330ee5b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"92d96482c21f2ef38cdb5d7f7e9a41ad08c9c9b7","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_9e595601","line":1019,"range":{"start_line":1019,"start_character":39,"end_line":1019,"end_character":49},"in_reply_to":"fa6399be_7b1c9477","updated":"2016-10-12 20:48:25.000000000","message":"See https://review.openstack.org/#/c/382659/8/neutron/db/db_base_plugin_v2.py","commit_id":"7ebfe799c06a8337a0280f5245ca17f01330ee5b"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9460838be9a51c7a3815e601ab29491199cd7afb","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_7b1c9477","line":1019,"range":{"start_line":1019,"start_character":39,"end_line":1019,"end_character":49},"in_reply_to":"fa6399be_90779339","updated":"2016-10-12 20:41:57.000000000","message":"We need to change it, because you have to pass project-id as argument for Subnetpool creation fields. We also need to support project-id in SubnetPoolReader, because it is tightly coupled with SubnetPool. In update_subnetpool you are passing subnetpool from DB, and there you have the project-id not tenant-id. The only thing I\u0027m worried about is, what will API pass to db_base_plugin_v2? Tenant-id or project-id? A few months ago, we agreed, that on OVO layer we should have only the project-id, and the user of OVO need to convert the tenant-id to project-id before passing the args to object. Is API converting the tenant-id to project-id somewhere? To be sure that dict passed from API user is containing the project-id?","commit_id":"7ebfe799c06a8337a0280f5245ca17f01330ee5b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4efee87fbe6e45536a9f3192532db6c691aed89d","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_8aa810dd","line":1019,"range":{"start_line":1019,"start_character":39,"end_line":1019,"end_character":49},"in_reply_to":"fa6399be_9e595601","updated":"2016-10-13 12:24:25.000000000","message":"No, I don\u0027t believe we need to modify subnetpool reader, and dict passed into the plugin at all. This work should belong to places where we mess with objects.\n\nCan we please not upload new versions of the patch until we clearly understand why a change is needed? For one, I don\u0027t agree with some late changes. Can we first explain why those needed, with specific test failures identified, and only then proceed?","commit_id":"7ebfe799c06a8337a0280f5245ca17f01330ee5b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"631d5d8f147bacfd170e5adfe5b715150faf23d9","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_90779339","line":1019,"range":{"start_line":1019,"start_character":39,"end_line":1019,"end_character":49},"in_reply_to":"fa6399be_d8dce214","updated":"2016-10-12 15:10:44.000000000","message":"OK, let\u0027s try without these.","commit_id":"7ebfe799c06a8337a0280f5245ca17f01330ee5b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bed165811b26318ff8cc7d11ae189570a6636fef","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_a760ad02","line":1019,"range":{"start_line":1019,"start_character":35,"end_line":1019,"end_character":52},"updated":"2016-10-13 12:22:00.000000000","message":"I don\u0027t believe that\u0027s needed.","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"789851cfcb74257f9e98677781559bdaf5027cf4","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_fb740037","line":1019,"range":{"start_line":1019,"start_character":35,"end_line":1019,"end_character":52},"in_reply_to":"fa6399be_6af1fc00","updated":"2016-10-13 13:24:29.000000000","message":"I think we pass an OVO object, not a DB model. Anyhow, I think the better path is making _update_subnetpool_dict() to properly convert the OVO object passed into dict (so that tenant_id is included), similar to http://paste.fedoraproject.org/449497/36496614/","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bf58649ca77fd41bccb3f8189304f9f68b4c5d0a","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_6af1fc00","line":1019,"range":{"start_line":1019,"start_character":35,"end_line":1019,"end_character":52},"in_reply_to":"fa6399be_a760ad02","updated":"2016-10-13 12:34:58.000000000","message":"It is needed in line 1044. We are passing SubnetPool from DB to SubnetPoolReader, thus SubnetPoolReader have to pars it, and the logic in SPR is that it is parsing the keys that is exposing [1]\n\n[1] https://review.openstack.org/#/c/382659/13/neutron/ipam/subnet_alloc.py@278","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"efb8245527645414e4be23ccb2d7e7dea0ee966f","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        self._validate_address_scope_id(context, sp_reader.address_scope_id,"},{"line_number":1017,"context_line":"                                        id, sp_reader.prefixes,"},{"line_number":1018,"context_line":"                                        sp_reader.ip_version)"},{"line_number":1019,"context_line":"        pool_args \u003d {\u0027project_id\u0027: sp[\u0027project_id\u0027],"},{"line_number":1020,"context_line":"                     \u0027id\u0027: sp_reader.id,"},{"line_number":1021,"context_line":"                     \u0027name\u0027: sp_reader.name,"},{"line_number":1022,"context_line":"                     \u0027ip_version\u0027: sp_reader.ip_version,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_8a38103f","line":1019,"range":{"start_line":1019,"start_character":35,"end_line":1019,"end_character":52},"in_reply_to":"fa6399be_a760ad02","updated":"2016-10-13 12:32:09.000000000","message":"Note: I don\u0027t suggest the whole change is not needed, just that the change for sp side is not needed. The kwarg key should indeed be project_id.","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"87816474668ea9b211af3cbd82d5899511983469","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _update_subnetpool_dict(orig_pool, new_pool):"},{"line_number":89,"context_line":"    updated \u003d dict((k, v) for k, v in orig_pool.to_dict().items()"},{"line_number":90,"context_line":"                   if k not in orig_pool.synthetic_fields)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    new_pool \u003d new_pool.copy()"},{"line_number":93,"context_line":"    new_prefixes \u003d new_pool.pop(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"},{"line_number":94,"context_line":"    for k, v in new_pool.items():"},{"line_number":95,"context_line":"        if k not in orig_pool.fields_no_update:"},{"line_number":96,"context_line":"            updated[k] \u003d v"},{"line_number":97,"context_line":"    if new_prefixes is not constants.ATTR_NOT_SPECIFIED:"},{"line_number":98,"context_line":"        orig_ip_set \u003d netaddr.IPSet(orig_pool.prefixes)"},{"line_number":99,"context_line":"        new_ip_set \u003d netaddr.IPSet(new_prefixes)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa6399be_3000bcaa","line":96,"range":{"start_line":89,"start_character":4,"end_line":96,"end_character":26},"updated":"2016-10-18 09:53:49.000000000","message":"I have added this to be able to return tenant_id compatible change for SubnetPoolReader requirements in lines: 1047, 1048.\nIt is take from Ihar proposal:\nhttps://paste.fedoraproject.org/449497/36496614/","commit_id":"ee5d6ca659333d0cc3ec2a25cca967499e7c7e8a"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0617e9b5b14badf55ae5c563d20b767912964646","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    # calls for update. Then DB is throwing DBError, because address_scope_id"},{"line_number":92,"context_line":"    # is not UUID, but string."},{"line_number":93,"context_line":"    # Temporary workaround to check gate tests."},{"line_number":94,"context_line":"    orig_pool.address_scope_id  # pylint: disable\u003dW0104"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    updated \u003d dict((k, v) for k, v in orig_pool.to_dict().items()"},{"line_number":97,"context_line":"                   if k not in orig_pool.synthetic_fields)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_dfbeb0fe","line":94,"updated":"2016-12-01 19:30:16.000000000","message":"Proved it work! Now, back to find root cause of this issue!","commit_id":"a5d90b001fe2f0e99eaca723c4174ac8c46e21ca"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aefd86ebeb09a917d73e0a52f4db391b2f6340b5","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"    def create_subnetpool(self, context, subnetpool):"},{"line_number":1044,"context_line":"        sp \u003d subnetpool[\u0027subnetpool\u0027]"},{"line_number":1045,"context_line":"        sp_reader \u003d subnet_alloc.SubnetPoolReader(sp)"},{"line_number":1046,"context_line":"        if sp_reader.address_scope_id is constants.ATTR_NOT_SPECIFIED:"},{"line_number":1047,"context_line":"            sp_reader.address_scope_id \u003d None"},{"line_number":1048,"context_line":"        if sp_reader.is_default:"},{"line_number":1049,"context_line":"            self._check_default_subnetpool_exists(context,"},{"line_number":1050,"context_line":"                                                  sp_reader.ip_version)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_095d6cec","line":1047,"range":{"start_line":1046,"start_character":8,"end_line":1047,"end_character":45},"updated":"2017-01-09 17:47:21.000000000","message":"I see that in the reader class, you changed the code so that .address_scope_id is never ATTR_NOT_SPECIFIED. Is it needed?","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"bbff6844726d76bd968582507f263418d93a9900","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"    def create_subnetpool(self, context, subnetpool):"},{"line_number":1042,"context_line":"        sp \u003d subnetpool[\u0027subnetpool\u0027]"},{"line_number":1043,"context_line":"        sp_reader \u003d subnet_alloc.SubnetPoolReader(sp)"},{"line_number":1044,"context_line":"        if sp_reader.address_scope_id is constants.ATTR_NOT_SPECIFIED:"},{"line_number":1045,"context_line":"            sp_reader.address_scope_id \u003d None"},{"line_number":1046,"context_line":"        if sp_reader.is_default:"},{"line_number":1047,"context_line":"            self._check_default_subnetpool_exists(context,"},{"line_number":1048,"context_line":"                                                  sp_reader.ip_version)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a57fde8_80d12dfe","side":"PARENT","line":1045,"range":{"start_line":1044,"start_character":8,"end_line":1045,"end_character":45},"updated":"2017-01-12 16:45:03.000000000","message":"Why this line needs to be removed?","commit_id":"1e2cfe8c06fcc2df52daa77b2b767ed6ffc2b19f"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a911d2267312a685ea039a0d2ce92573da583575","unresolved":false,"context_lines":[{"line_number":1041,"context_line":"    def create_subnetpool(self, context, subnetpool):"},{"line_number":1042,"context_line":"        sp \u003d subnetpool[\u0027subnetpool\u0027]"},{"line_number":1043,"context_line":"        sp_reader \u003d subnet_alloc.SubnetPoolReader(sp)"},{"line_number":1044,"context_line":"        if sp_reader.address_scope_id is constants.ATTR_NOT_SPECIFIED:"},{"line_number":1045,"context_line":"            sp_reader.address_scope_id \u003d None"},{"line_number":1046,"context_line":"        if sp_reader.is_default:"},{"line_number":1047,"context_line":"            self._check_default_subnetpool_exists(context,"},{"line_number":1048,"context_line":"                                                  sp_reader.ip_version)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a57fde8_de7eb2ad","side":"PARENT","line":1045,"range":{"start_line":1044,"start_character":8,"end_line":1045,"end_character":45},"in_reply_to":"9a57fde8_80d12dfe","updated":"2017-01-12 17:13:34.000000000","message":"This line was moved to other file: neutron/ipam/subnet_alloc.py@354","commit_id":"1e2cfe8c06fcc2df52daa77b2b767ed6ffc2b19f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"bbff6844726d76bd968582507f263418d93a9900","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _update_subnetpool_dict(orig_pool, new_pool):"},{"line_number":89,"context_line":"    updated \u003d dict((k, v) for k, v in orig_pool.to_dict().items()"},{"line_number":90,"context_line":"                   if k not in orig_pool.synthetic_fields)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    new_pool \u003d new_pool.copy()"},{"line_number":93,"context_line":"    new_prefixes \u003d new_pool.pop(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a57fde8_6088c9e8","line":90,"range":{"start_line":89,"start_character":4,"end_line":90,"end_character":58},"updated":"2017-01-12 16:45:03.000000000","message":"I\u0027m confuse here, are you taking the original values as the updated fields? Shouldn\u0027t be better to something like...\n\n    updated \u003d dict((k, v) for k, v in new_pool.to_dict().items()\n                   if k not in orig_pool.synthetic_fields)","commit_id":"488a12fe7a0cacae2f95cc21d1aacb42da2f5820"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"dd7a79946a7a47c0cf3f0044705db661f74efdd7","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _update_subnetpool_dict(orig_pool, new_pool):"},{"line_number":89,"context_line":"    updated \u003d dict((k, v) for k, v in orig_pool.to_dict().items()"},{"line_number":90,"context_line":"                   if k not in orig_pool.synthetic_fields)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    new_pool \u003d new_pool.copy()"},{"line_number":93,"context_line":"    new_prefixes \u003d new_pool.pop(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a3c09a3_0d6531e0","line":90,"range":{"start_line":89,"start_character":4,"end_line":90,"end_character":58},"in_reply_to":"7a3c09a3_21fa3443","updated":"2017-01-16 09:50:27.000000000","message":"To explain, why it was added:\nI have added this to be able to return tenant_id compatible change for SubnetPoolReader requirements in lines: 1047, 1048.\nIt is taken from Ihar proposal:\nhttps://paste.fedoraproject.org/449497/36496614/","commit_id":"488a12fe7a0cacae2f95cc21d1aacb42da2f5820"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"7ff72ca63d6745dd19c8eb5db8c603a84b294966","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _update_subnetpool_dict(orig_pool, new_pool):"},{"line_number":89,"context_line":"    updated \u003d dict((k, v) for k, v in orig_pool.to_dict().items()"},{"line_number":90,"context_line":"                   if k not in orig_pool.synthetic_fields)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    new_pool \u003d new_pool.copy()"},{"line_number":93,"context_line":"    new_prefixes \u003d new_pool.pop(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a3c09a3_21fa3443","line":90,"range":{"start_line":89,"start_character":4,"end_line":90,"end_character":58},"in_reply_to":"7a3c09a3_6b2fd6a1","updated":"2017-01-13 14:32:06.000000000","message":"Henry, thanks for clarification.","commit_id":"488a12fe7a0cacae2f95cc21d1aacb42da2f5820"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a911d2267312a685ea039a0d2ce92573da583575","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _update_subnetpool_dict(orig_pool, new_pool):"},{"line_number":89,"context_line":"    updated \u003d dict((k, v) for k, v in orig_pool.to_dict().items()"},{"line_number":90,"context_line":"                   if k not in orig_pool.synthetic_fields)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    new_pool \u003d new_pool.copy()"},{"line_number":93,"context_line":"    new_prefixes \u003d new_pool.pop(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a57fde8_7e25c6c0","line":90,"range":{"start_line":89,"start_character":4,"end_line":90,"end_character":58},"in_reply_to":"9a57fde8_6088c9e8","updated":"2017-01-12 17:13:34.000000000","message":"This one was introduced by Henry. I\u0027ll double check that.","commit_id":"488a12fe7a0cacae2f95cc21d1aacb42da2f5820"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d83a00b5fb12dbd2e6df9c71c6d16dff5e8475b8","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def _update_subnetpool_dict(orig_pool, new_pool):"},{"line_number":89,"context_line":"    updated \u003d dict((k, v) for k, v in orig_pool.to_dict().items()"},{"line_number":90,"context_line":"                   if k not in orig_pool.synthetic_fields)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    new_pool \u003d new_pool.copy()"},{"line_number":93,"context_line":"    new_prefixes \u003d new_pool.pop(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"}],"source_content_type":"text/x-python","patch_set":27,"id":"7a3c09a3_6b2fd6a1","line":90,"range":{"start_line":89,"start_character":4,"end_line":90,"end_character":58},"in_reply_to":"9a57fde8_7e25c6c0","updated":"2017-01-13 02:05:18.000000000","message":"Not me, it was added in PS16 by Artur.","commit_id":"488a12fe7a0cacae2f95cc21d1aacb42da2f5820"}],"neutron/ipam/subnet_alloc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        self._read_id(subnetpool)"},{"line_number":254,"context_line":"        self._read_prefix_bounds(subnetpool)"},{"line_number":255,"context_line":"        self._read_attrs(subnetpool,"},{"line_number":256,"context_line":"                         [\u0027project_id\u0027, \u0027name\u0027, \u0027is_default\u0027, \u0027shared\u0027])"},{"line_number":257,"context_line":"        self.description \u003d subnetpool.get(\u0027description\u0027)"},{"line_number":258,"context_line":"        self._read_address_scope(subnetpool)"},{"line_number":259,"context_line":"        self.subnetpool \u003d {\u0027id\u0027: self.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_28521e14","line":256,"range":{"start_line":256,"start_character":27,"end_line":256,"end_character":37},"updated":"2016-10-11 10:37:57.000000000","message":"I don\u0027t think that this change in the file is related to the bug. The fix should only change the object field name, but this is not an object.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        self._read_id(subnetpool)"},{"line_number":254,"context_line":"        self._read_prefix_bounds(subnetpool)"},{"line_number":255,"context_line":"        self._read_attrs(subnetpool,"},{"line_number":256,"context_line":"                         [\u0027project_id\u0027, \u0027name\u0027, \u0027is_default\u0027, \u0027shared\u0027])"},{"line_number":257,"context_line":"        self.description \u003d subnetpool.get(\u0027description\u0027)"},{"line_number":258,"context_line":"        self._read_address_scope(subnetpool)"},{"line_number":259,"context_line":"        self.subnetpool \u003d {\u0027id\u0027: self.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_675a7185","line":256,"range":{"start_line":256,"start_character":27,"end_line":256,"end_character":37},"in_reply_to":"fa6399be_28521e14","updated":"2016-10-11 18:33:06.000000000","message":"This is definitely related. I am not 100% sure about the design of the SubnetPoolReader class, it apparently needs to match the SubnetPool class properties.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bed165811b26318ff8cc7d11ae189570a6636fef","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        self.subnetpool \u003d {\u0027id\u0027: self.id,"},{"line_number":261,"context_line":"                           \u0027name\u0027: self.name,"},{"line_number":262,"context_line":"                           \u0027project_id\u0027: self.project_id,"},{"line_number":263,"context_line":"                           \u0027prefixes\u0027: self.prefixes,"},{"line_number":264,"context_line":"                           \u0027min_prefix\u0027: self.min_prefix,"},{"line_number":265,"context_line":"                           \u0027min_prefixlen\u0027: self.min_prefixlen,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_6742156a","line":262,"range":{"start_line":262,"start_character":41,"end_line":262,"end_character":56},"updated":"2016-10-13 12:22:00.000000000","message":"no reason for that piece of change. Or I miss something?","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bf58649ca77fd41bccb3f8189304f9f68b4c5d0a","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        self.subnetpool \u003d {\u0027id\u0027: self.id,"},{"line_number":261,"context_line":"                           \u0027name\u0027: self.name,"},{"line_number":262,"context_line":"                           \u0027project_id\u0027: self.project_id,"},{"line_number":263,"context_line":"                           \u0027prefixes\u0027: self.prefixes,"},{"line_number":264,"context_line":"                           \u0027min_prefix\u0027: self.min_prefix,"},{"line_number":265,"context_line":"                           \u0027min_prefixlen\u0027: self.min_prefixlen,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_ca712878","line":262,"range":{"start_line":262,"start_character":41,"end_line":262,"end_character":56},"in_reply_to":"fa6399be_6742156a","updated":"2016-10-13 12:34:58.000000000","message":"It is needed since sp_reader is parsing the values and sets it as sp_reader property. Line 278.\nAnd we are passing project-id from API and from DB.","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aefd86ebeb09a917d73e0a52f4db391b2f6340b5","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        self.prefixes \u003d self._compact_subnetpool_prefix_list(prefix_list)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _read_address_scope(self, subnetpool):"},{"line_number":350,"context_line":"        self.address_scope_id \u003d subnetpool.get(\u0027address_scope_id\u0027, None)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def _compact_subnetpool_prefix_list(self, prefix_list):"},{"line_number":353,"context_line":"        \"\"\"Compact any overlapping prefixes in prefix_list and return the"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_69afd894","line":350,"updated":"2017-01-09 17:47:21.000000000","message":"why do we need this change? it seems like in db mixin, we have some logic that relies on this value being NOT_SPECIFIED.","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8e5e1e78aa405f359890fa2534bdeedb50bed9f4","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        self.prefixes \u003d self._compact_subnetpool_prefix_list(prefix_list)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _read_address_scope(self, subnetpool):"},{"line_number":350,"context_line":"        self.address_scope_id \u003d subnetpool.get(\u0027address_scope_id\u0027, None)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"    def _compact_subnetpool_prefix_list(self, prefix_list):"},{"line_number":353,"context_line":"        \"\"\"Compact any overlapping prefixes in prefix_list and return the"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_03016006","line":350,"in_reply_to":"ba5201f7_69afd894","updated":"2017-01-11 14:56:41.000000000","message":"Thanks for catching this. We were using comparison to ATTR_NOT_SPECIFIED in `create_subnetpool` func, but it can be done here. I\u0027ve moved that logic here, so every time, we will have it checked and assigned correct value.","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"bbff6844726d76bd968582507f263418d93a9900","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        self.prefixes \u003d self._compact_subnetpool_prefix_list(prefix_list)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _read_address_scope(self, subnetpool):"},{"line_number":350,"context_line":"        address_scope_id \u003d subnetpool.get(\u0027address_scope_id\u0027,"},{"line_number":351,"context_line":"                                          constants.ATTR_NOT_SPECIFIED)"},{"line_number":352,"context_line":"        if address_scope_id is constants.ATTR_NOT_SPECIFIED:"},{"line_number":353,"context_line":"            address_scope_id \u003d None"},{"line_number":354,"context_line":"        self.address_scope_id \u003d address_scope_id"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _compact_subnetpool_prefix_list(self, prefix_list):"},{"line_number":357,"context_line":"        \"\"\"Compact any overlapping prefixes in prefix_list and return the"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a57fde8_80b04d8d","line":354,"range":{"start_line":350,"start_character":8,"end_line":354,"end_character":48},"updated":"2017-01-12 16:45:03.000000000","message":"Shouldn\u0027t be better this way?\n\n    self.address_scope_id \u003d subnetpool.get(\u0027address_scope_id\u0027, None)","commit_id":"488a12fe7a0cacae2f95cc21d1aacb42da2f5820"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a911d2267312a685ea039a0d2ce92573da583575","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        self.prefixes \u003d self._compact_subnetpool_prefix_list(prefix_list)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _read_address_scope(self, subnetpool):"},{"line_number":350,"context_line":"        address_scope_id \u003d subnetpool.get(\u0027address_scope_id\u0027,"},{"line_number":351,"context_line":"                                          constants.ATTR_NOT_SPECIFIED)"},{"line_number":352,"context_line":"        if address_scope_id is constants.ATTR_NOT_SPECIFIED:"},{"line_number":353,"context_line":"            address_scope_id \u003d None"},{"line_number":354,"context_line":"        self.address_scope_id \u003d address_scope_id"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _compact_subnetpool_prefix_list(self, prefix_list):"},{"line_number":357,"context_line":"        \"\"\"Compact any overlapping prefixes in prefix_list and return the"}],"source_content_type":"text/x-python","patch_set":27,"id":"9a57fde8_3e6dfe04","line":354,"range":{"start_line":350,"start_character":8,"end_line":354,"end_character":48},"in_reply_to":"9a57fde8_80b04d8d","updated":"2017-01-12 17:13:34.000000000","message":"No, we cannot assume that we won\u0027t have \u0027address_scope_id\u0027 in subnetpool. This already can have a value set to ATTR_NOT_SPECIFIED, so we need to check it. And, if it occurs that we didn\u0027t specify anything, then we need to assign None to it.\nSimilar thing is done in couple different places above, like _read_id or _read_prefix_bound.","commit_id":"488a12fe7a0cacae2f95cc21d1aacb42da2f5820"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c7d2217e1cc71a3a40c866bea595d4268b81d316","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        self.prefixes \u003d self._compact_subnetpool_prefix_list(prefix_list)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _read_address_scope(self, subnetpool):"},{"line_number":350,"context_line":"        address_scope_id \u003d subnetpool.get(\u0027address_scope_id\u0027,"},{"line_number":351,"context_line":"                                          constants.ATTR_NOT_SPECIFIED)"},{"line_number":352,"context_line":"        if address_scope_id is constants.ATTR_NOT_SPECIFIED:"},{"line_number":353,"context_line":"            address_scope_id \u003d None"},{"line_number":354,"context_line":"        self.address_scope_id \u003d address_scope_id"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _compact_subnetpool_prefix_list(self, prefix_list):"},{"line_number":357,"context_line":"        \"\"\"Compact any overlapping prefixes in prefix_list and return the"}],"source_content_type":"text/x-python","patch_set":28,"id":"7a3c09a3_cae25603","line":354,"range":{"start_line":350,"start_character":8,"end_line":354,"end_character":48},"updated":"2017-01-13 22:11:09.000000000","message":"why this?","commit_id":"8b048cc2872d243914ddea0210ba2128d979d1d2"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"717ddf41aaa40c0b0283303590c48d7e72890286","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        self.prefixes \u003d self._compact_subnetpool_prefix_list(prefix_list)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _read_address_scope(self, subnetpool):"},{"line_number":350,"context_line":"        address_scope_id \u003d subnetpool.get(\u0027address_scope_id\u0027,"},{"line_number":351,"context_line":"                                          constants.ATTR_NOT_SPECIFIED)"},{"line_number":352,"context_line":"        if address_scope_id is constants.ATTR_NOT_SPECIFIED:"},{"line_number":353,"context_line":"            address_scope_id \u003d None"},{"line_number":354,"context_line":"        self.address_scope_id \u003d address_scope_id"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _compact_subnetpool_prefix_list(self, prefix_list):"},{"line_number":357,"context_line":"        \"\"\"Compact any overlapping prefixes in prefix_list and return the"}],"source_content_type":"text/x-python","patch_set":28,"id":"7a3c09a3_ca409659","line":354,"range":{"start_line":350,"start_character":8,"end_line":354,"end_character":48},"in_reply_to":"7a3c09a3_cae25603","updated":"2017-01-13 22:19:37.000000000","message":"This change mirrors other methods with _read like [1] or [2]. This is answer for problems, when address_scope_id has value ATTR_NOT_SPECIFIED (which is Sentinel() object) briefly described here [3].\n\n[1] https://review.openstack.org/#/c/382659/28/neutron/ipam/subnet_alloc.py@343\n[2] https://review.openstack.org/#/c/382659/28/neutron/ipam/subnet_alloc.py@285\n[3] https://review.openstack.org/#/c/382659/20/neutron/db/db_base_plugin_v2.py@94","commit_id":"8b048cc2872d243914ddea0210ba2128d979d1d2"}],"neutron/objects/address_scope.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"880ed7d222f9a92788ea0576c860fe7357674744","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        \u0027project_id\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":34,"context_line":"        \u0027shared\u0027: obj_fields.BooleanField(),"},{"line_number":35,"context_line":"        \u0027ip_version\u0027: common_types.IPVersionEnumField(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_c0ae7ce5","line":32,"updated":"2016-10-06 20:37:18.000000000","message":"while you don\u0027t really need to bump version here; but note that the object hash will change, so test_objects will fail in gate. You need to update test_objects.py with new calculated hashes for all objects you touch.","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f33284b6f34b86d42a5cf7b2f72848910ddbc24","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    fields \u003d {"},{"line_number":31,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":32,"context_line":"        \u0027project_id\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":34,"context_line":"        \u0027shared\u0027: obj_fields.BooleanField(),"},{"line_number":35,"context_line":"        \u0027ip_version\u0027: common_types.IPVersionEnumField(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_e2d17b24","line":32,"in_reply_to":"1a95cdbc_c0ae7ce5","updated":"2016-10-09 04:00:47.000000000","message":"Done","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"38d0e52b0a25a31cd2092eb6b00984ac62c89125","unresolved":false,"context_lines":[{"line_number":23,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class AddressScope(base.NeutronDbObject):"},{"line_number":25,"context_line":"    # Version 1.0: Initial version"},{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    db_model \u003d models.AddressScope"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_8f7ff313","line":26,"updated":"2016-10-10 06:34:05.000000000","message":"do we need to bump the version here?","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class AddressScope(base.NeutronDbObject):"},{"line_number":25,"context_line":"    # Version 1.0: Initial version"},{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    db_model \u003d models.AddressScope"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_68aa56d6","line":26,"in_reply_to":"1a95cdbc_8f7ff313","updated":"2016-10-11 10:37:57.000000000","message":"Not really because this object is not exposed on AMQP bus so far.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027ip_version\u0027: common_types.IPVersionEnumField(),"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    fields_need_translation \u003d {"},{"line_number":39,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":40,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_c890c298","line":38,"updated":"2016-10-11 10:37:57.000000000","message":"why? doesn\u0027t the model already support project_id attribute? (this translation is needed only when you need to write a different name in the db model, which is probably not the case here).","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e8539f2c0925b4c69366feddcaa270daea05f30","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027ip_version\u0027: common_types.IPVersionEnumField(),"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    fields_need_translation \u003d {"},{"line_number":39,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":40,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_23ccff34","line":38,"in_reply_to":"fa6399be_c890c298","updated":"2016-10-11 11:47:51.000000000","message":"+1. fields_need_translation is used when DB and OVO layer has different field naming.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027ip_version\u0027: common_types.IPVersionEnumField(),"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    fields_need_translation \u003d {"},{"line_number":39,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":40,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_c40c1897","line":38,"in_reply_to":"fa6399be_c890c298","updated":"2016-10-11 18:33:06.000000000","message":"Done","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"}],"neutron/objects/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"53d60f937ec73d89e3225e4d644090b53706d077","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def __init__(cls, name, bases, dct):"},{"line_number":250,"context_line":"        super(DeclarativeObject, cls).__init__(name, bases, dct)"},{"line_number":251,"context_line":"        if \u0027project_id\u0027 in cls.fields:"},{"line_number":252,"context_line":"            obj_extra_fields_set \u003d set(cls.obj_extra_fields)"},{"line_number":253,"context_line":"            obj_extra_fields_set.add(\u0027tenant_id\u0027)"},{"line_number":254,"context_line":"            cls.obj_extra_fields \u003d list(obj_extra_fields_set)"},{"line_number":255,"context_line":"            setattr(cls, \u0027tenant_id\u0027, property(lambda x: x.project_id))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        fields_no_update_set \u003d set(cls.fields_no_update)"},{"line_number":258,"context_line":"        for base in itertools.chain([cls], bases):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_62d95983","line":255,"range":{"start_line":251,"start_character":8,"end_line":255,"end_character":71},"updated":"2016-10-06 08:08:08.000000000","message":"Those lines are supposed to handle what you need. We should switch all objects to using project_id as the field and tenant_id as an attribute, and then it should work correct.","commit_id":"fb8f3365b08dce6dcaba117809bec9b7c2a280be"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6d5c8878dd54fb1d75547164b9dfb2d0bdccf542","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def __init__(cls, name, bases, dct):"},{"line_number":250,"context_line":"        super(DeclarativeObject, cls).__init__(name, bases, dct)"},{"line_number":251,"context_line":"        if \u0027project_id\u0027 in cls.fields:"},{"line_number":252,"context_line":"            obj_extra_fields_set \u003d set(cls.obj_extra_fields)"},{"line_number":253,"context_line":"            obj_extra_fields_set.add(\u0027tenant_id\u0027)"},{"line_number":254,"context_line":"            cls.obj_extra_fields \u003d list(obj_extra_fields_set)"},{"line_number":255,"context_line":"            setattr(cls, \u0027tenant_id\u0027, property(lambda x: x.project_id))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        fields_no_update_set \u003d set(cls.fields_no_update)"},{"line_number":258,"context_line":"        for base in itertools.chain([cls], bases):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_6b5af12b","line":255,"range":{"start_line":251,"start_character":8,"end_line":255,"end_character":71},"in_reply_to":"1a95cdbc_02cb35a6","updated":"2016-10-06 18:39:55.000000000","message":"Done","commit_id":"fb8f3365b08dce6dcaba117809bec9b7c2a280be"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9f5b8e222a7542941351b9b74d0caf078bb8867","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def __init__(cls, name, bases, dct):"},{"line_number":250,"context_line":"        super(DeclarativeObject, cls).__init__(name, bases, dct)"},{"line_number":251,"context_line":"        if \u0027project_id\u0027 in cls.fields:"},{"line_number":252,"context_line":"            obj_extra_fields_set \u003d set(cls.obj_extra_fields)"},{"line_number":253,"context_line":"            obj_extra_fields_set.add(\u0027tenant_id\u0027)"},{"line_number":254,"context_line":"            cls.obj_extra_fields \u003d list(obj_extra_fields_set)"},{"line_number":255,"context_line":"            setattr(cls, \u0027tenant_id\u0027, property(lambda x: x.project_id))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        fields_no_update_set \u003d set(cls.fields_no_update)"},{"line_number":258,"context_line":"        for base in itertools.chain([cls], bases):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_02cb35a6","line":255,"range":{"start_line":251,"start_character":8,"end_line":255,"end_character":71},"in_reply_to":"1a95cdbc_62d95983","updated":"2016-10-06 08:08:54.000000000","message":"sorry, I meant \u0027...and tenant_id as an extra field/property.\u0027","commit_id":"fb8f3365b08dce6dcaba117809bec9b7c2a280be"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e8539f2c0925b4c69366feddcaa270daea05f30","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            obj_extra_fields_set \u003d set(cls.obj_extra_fields)"},{"line_number":251,"context_line":"            obj_extra_fields_set.add(\u0027tenant_id\u0027)"},{"line_number":252,"context_line":"            cls.obj_extra_fields \u003d list(obj_extra_fields_set)"},{"line_number":253,"context_line":"            setattr(cls, \u0027tenant_id\u0027, property(lambda x: x.project_id))"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        fields_no_update_set \u003d set(cls.fields_no_update)"},{"line_number":256,"context_line":"        for base in itertools.chain([cls], bases):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_39d192ce","line":253,"range":{"start_line":253,"start_character":12,"end_line":253,"end_character":71},"updated":"2016-10-11 11:47:51.000000000","message":"Unit tests are failing because when creating an object without project_id set, the OVO is raising AttributeError for QosPolicy OVO. This patch is trying to address it:\nhttps://review.openstack.org/384949","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"93c1a62bc0c3e1d7f7fc7eac95636edfedc59d99","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                    dict_[field_name].to_dict() if value else None)"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                dict_[field_name] \u003d field.to_primitive(self, field_name, value)"},{"line_number":163,"context_line":"        attributes.populate_project_info(dict_)"},{"line_number":164,"context_line":"        return dict_"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_c57ceeed","side":"PARENT","line":163,"range":{"start_line":163,"start_character":8,"end_line":163,"end_character":47},"updated":"2016-10-12 13:43:13.000000000","message":"I\u0027m thinking that this approach is the best we can get for Ocata. My patch is not solving the problem when project_id is not set, and we are setting the tenant-id for None. In OVO lib, we are always setting the obj_extra_fields in output dict, but then field is not set, it is not populated in resulting dict.","commit_id":"abc31a7ff249fab37f6ac6fb29e44d8b35f73f74"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"631d5d8f147bacfd170e5adfe5b715150faf23d9","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                    dict_[field_name].to_dict() if value else None)"},{"line_number":161,"context_line":"            else:"},{"line_number":162,"context_line":"                dict_[field_name] \u003d field.to_primitive(self, field_name, value)"},{"line_number":163,"context_line":"        attributes.populate_project_info(dict_)"},{"line_number":164,"context_line":"        return dict_"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_7022ff02","side":"PARENT","line":163,"range":{"start_line":163,"start_character":8,"end_line":163,"end_character":47},"in_reply_to":"fa6399be_c57ceeed","updated":"2016-10-12 15:10:44.000000000","message":"I have to admit I don\u0027t know enough about the infrastructure of objects to fully understand what you are saying here.","commit_id":"abc31a7ff249fab37f6ac6fb29e44d8b35f73f74"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"694ebddd655600d4a7825cb3c3dcc92c1a2bfcdf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # Version 1.1: QosDscpMarkingRule introduced"},{"line_number":39,"context_line":"    # Version 1.2: Added QosMinimumBandwidthRule"},{"line_number":40,"context_line":"    # Version 1.3: Added standard attributes (created_at, revision, etc)"},{"line_number":41,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # required by RbacNeutronMetaclass"},{"line_number":44,"context_line":"    rbac_db_model \u003d QosPolicyRBAC"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_a556e259","line":41,"updated":"2016-10-06 20:36:24.000000000","message":"this should be bumped because qos policy objects are exposed on AMQP bus; also in line 40+ you should describe the new version","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f33284b6f34b86d42a5cf7b2f72848910ddbc24","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # Version 1.1: QosDscpMarkingRule introduced"},{"line_number":39,"context_line":"    # Version 1.2: Added QosMinimumBandwidthRule"},{"line_number":40,"context_line":"    # Version 1.3: Added standard attributes (created_at, revision, etc)"},{"line_number":41,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # required by RbacNeutronMetaclass"},{"line_number":44,"context_line":"    rbac_db_model \u003d QosPolicyRBAC"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_82951734","line":41,"in_reply_to":"1a95cdbc_a556e259","updated":"2016-10-09 04:00:47.000000000","message":"Done","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"694ebddd655600d4a7825cb3c3dcc92c1a2bfcdf","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            return [rule for rule in rules if"},{"line_number":218,"context_line":"                    rule[\u0027versioned_object.name\u0027] in obj_names]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":221,"context_line":"        names \u003d []"},{"line_number":222,"context_line":"        if _target_version \u003e\u003d (1, 0):"},{"line_number":223,"context_line":"            names.append(rule_obj_impl.QosBandwidthLimitRule.obj_name())"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_4567de4c","line":220,"updated":"2016-10-06 20:36:24.000000000","message":"you will need to implement conversion rule for the new version of the object","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f33284b6f34b86d42a5cf7b2f72848910ddbc24","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            return [rule for rule in rules if"},{"line_number":218,"context_line":"                    rule[\u0027versioned_object.name\u0027] in obj_names]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":221,"context_line":"        names \u003d []"},{"line_number":222,"context_line":"        if _target_version \u003e\u003d (1, 0):"},{"line_number":223,"context_line":"            names.append(rule_obj_impl.QosBandwidthLimitRule.obj_name())"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_c29b9f64","line":220,"in_reply_to":"1a95cdbc_4567de4c","updated":"2016-10-09 04:00:47.000000000","message":"OK, but I am not sure I got it right.","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    binding_models \u003d {\u0027network\u0027: network_binding_model,"},{"line_number":64,"context_line":"                      \u0027port\u0027: port_binding_model}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    fields_need_translation \u003d {"},{"line_number":67,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_08371ab1","line":66,"updated":"2016-10-11 10:37:57.000000000","message":"I don\u0027t think it\u0027s needed because QosPolicy model inherits from HasProject and hence supports the new name of the attribute.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    binding_models \u003d {\u0027network\u0027: network_binding_model,"},{"line_number":64,"context_line":"                      \u0027port\u0027: port_binding_model}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    fields_need_translation \u003d {"},{"line_number":67,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_0427f012","line":66,"in_reply_to":"fa6399be_08371ab1","updated":"2016-10-11 18:33:06.000000000","message":"Done","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e8539f2c0925b4c69366feddcaa270daea05f30","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    binding_models \u003d {\u0027network\u0027: network_binding_model,"},{"line_number":64,"context_line":"                      \u0027port\u0027: port_binding_model}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    fields_need_translation \u003d {"},{"line_number":67,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_c3e503a9","line":66,"in_reply_to":"fa6399be_08371ab1","updated":"2016-10-11 11:47:51.000000000","message":"Yes, not needed.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                raise exception.IncompatibleObjectVersion("},{"line_number":241,"context_line":"                    objver\u003dtarget_version, objname\u003d\u0027QoSPolicy\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        if _target_version \u003c (1, 4):"},{"line_number":244,"context_line":"            primitive[\u0027tenant_id\u0027] \u003d primitive[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_683a5638","line":243,"updated":"2016-10-11 10:37:57.000000000","message":"this change is not covered by a specific test case. please see e.g. test_object_version_degradation_1_3_to_1_2_null_description for an example.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                    objver\u003dtarget_version, objname\u003d\u0027QoSPolicy\u0027)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        if _target_version \u003c (1, 4):"},{"line_number":244,"context_line":"            primitive[\u0027tenant_id\u0027] \u003d primitive[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_88724a7b","line":244,"updated":"2016-10-11 10:37:57.000000000","message":"we should also drop the old field, otherwise the result will not be serializable into the older version of the object.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bed165811b26318ff8cc7d11ae189570a6636fef","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \u0027port\u0027: port_binding_model}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def obj_load_attr(self, attrname):"},{"line_number":67,"context_line":"        if attrname \u003d\u003d \u0027project_id\u0027:"},{"line_number":68,"context_line":"            return super(QosPolicy, self).obj_load_attr(attrname)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if attrname !\u003d \u0027rules\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_07e1599a","line":67,"updated":"2016-10-13 12:22:00.000000000","message":"would probably make more sense to rearrange branches here a bit, meaning moving lines 70-73 after line 76, and changing the line 70 to \u003d\u003d check, so that the code flow looks more consistent.\n\nAlso, wouldn\u0027t a call to super() always raise ObjectActionError for us?","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bf58649ca77fd41bccb3f8189304f9f68b4c5d0a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \u0027port\u0027: port_binding_model}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def obj_load_attr(self, attrname):"},{"line_number":67,"context_line":"        if attrname \u003d\u003d \u0027project_id\u0027:"},{"line_number":68,"context_line":"            return super(QosPolicy, self).obj_load_attr(attrname)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if attrname !\u003d \u0027rules\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_0a16c0f0","line":67,"in_reply_to":"fa6399be_07e1599a","updated":"2016-10-13 12:34:58.000000000","message":"The super() is returning AttributeError.","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e25550ed020bc9e27ad1a43847ea6ec72d745128","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \u0027port\u0027: port_binding_model}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def obj_load_attr(self, attrname):"},{"line_number":67,"context_line":"        if attrname \u003d\u003d \u0027project_id\u0027:"},{"line_number":68,"context_line":"            return super(QosPolicy, self).obj_load_attr(attrname)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if attrname !\u003d \u0027rules\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_9b1ea15d","line":67,"in_reply_to":"fa6399be_0a16c0f0","updated":"2016-10-13 14:13:10.000000000","message":"You mean NotImplementedError?","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"07d46cb00cadf92d16ab93934cb72dcf0e99246f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \u0027port\u0027: port_binding_model}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def obj_load_attr(self, attrname):"},{"line_number":67,"context_line":"        if attrname \u003d\u003d \u0027project_id\u0027:"},{"line_number":68,"context_line":"            return super(QosPolicy, self).obj_load_attr(attrname)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if attrname !\u003d \u0027rules\u0027:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_3e1663f1","line":67,"in_reply_to":"fa6399be_9b1ea15d","updated":"2016-10-13 14:34:12.000000000","message":"The log says:\n/openstack/neutron/.venv/local/lib/python2.7/site-packages/oslo_versionedobjects/base.py\", line 68, in getter\n    return getattr(self, attrname)\nAttributeError: \u0027_DefaultSecurityGroup\u0027 object has no attribute \u0027_obj_project_id\u0027","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"}],"neutron/objects/subnetpool.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"cb020264e85df45713cae572c43271b7dbb841f5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":27,"context_line":"class SubnetPool(base.NeutronDbObject):"},{"line_number":28,"context_line":"    # Version 1.0: Initial version"},{"line_number":29,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    db_model \u003d models.SubnetPool"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_8b4b3259","line":29,"updated":"2016-10-11 03:35:52.000000000","message":"Bump for Version?","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":27,"context_line":"class SubnetPool(base.NeutronDbObject):"},{"line_number":28,"context_line":"    # Version 1.0: Initial version"},{"line_number":29,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    db_model \u003d models.SubnetPool"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_c86c429f","line":29,"in_reply_to":"fa6399be_8b4b3259","updated":"2016-10-11 10:37:57.000000000","message":"Not really needed because the object is not exposed on AMQP bus.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    fields_need_translation \u003d {"},{"line_number":54,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_88f96acb","line":53,"updated":"2016-10-11 10:37:57.000000000","message":"not needed, see details in previous files","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    fields_need_translation \u003d {"},{"line_number":54,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_2424f40b","line":53,"in_reply_to":"fa6399be_88f96acb","updated":"2016-10-11 18:33:06.000000000","message":"Done","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"}],"neutron/objects/trunk.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"694ebddd655600d4a7825cb3c3dcc92c1a2bfcdf","unresolved":false,"context_lines":[{"line_number":82,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":83,"context_line":"class Trunk(base.NeutronDbObject):"},{"line_number":84,"context_line":"    # Version 1.0: Initial version"},{"line_number":85,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    db_model \u003d models.Trunk"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_85d486bd","line":85,"updated":"2016-10-06 20:36:24.000000000","message":"bump the version, and provide backporting rule.","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f33284b6f34b86d42a5cf7b2f72848910ddbc24","unresolved":false,"context_lines":[{"line_number":82,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":83,"context_line":"class Trunk(base.NeutronDbObject):"},{"line_number":84,"context_line":"    # Version 1.0: Initial version"},{"line_number":85,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    db_model \u003d models.Trunk"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_02d027f5","line":85,"in_reply_to":"1a95cdbc_85d486bd","updated":"2016-10-09 04:00:47.000000000","message":"Done","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    fields_need_translation \u003d {"},{"line_number":106,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_082c7a49","line":105,"updated":"2016-10-11 10:37:57.000000000","message":"not needed","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    fields_need_translation \u003d {"},{"line_number":106,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_4421e8fa","line":105,"in_reply_to":"fa6399be_082c7a49","updated":"2016-10-11 18:33:06.000000000","message":"Done","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e8539f2c0925b4c69366feddcaa270daea05f30","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    synthetic_fields \u003d [\u0027sub_ports\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    fields_need_translation \u003d {"},{"line_number":106,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def create(self):"},{"line_number":110,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_df919248","line":107,"range":{"start_line":105,"start_character":3,"end_line":107,"end_character":5},"updated":"2016-10-11 11:47:51.000000000","message":"fields_need_translation is used when DB field is named differently than OVO field. In this case, project_id is already used in DB. No need for translation.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":135,"context_line":"            primitive[\u0027tenant_id\u0027] \u003d primitive[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_a81d4e11","line":135,"updated":"2016-10-11 10:37:57.000000000","message":"also drop the project_id field","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e8539f2c0925b4c69366feddcaa270daea05f30","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":135,"context_line":"            primitive[\u0027tenant_id\u0027] \u003d primitive[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_e3f9274f","line":135,"in_reply_to":"fa6399be_a81d4e11","updated":"2016-10-11 11:47:51.000000000","message":"+1","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"0617e9b5b14badf55ae5c563d20b767912964646","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        # TODO(dasm): Temporary fix! It needs to be removed and fixed"},{"line_number":56,"context_line":"        # correctly!"},{"line_number":57,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"},{"line_number":60,"context_line":"        policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_9fdd1873","line":57,"updated":"2016-12-01 19:30:16.000000000","message":"Proved, it work! Now, to find root cause of issue :)","commit_id":"a5d90b001fe2f0e99eaca723c4174ac8c46e21ca"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"42dc1a6d41a305c94e060cea0928ec93d07c92ba","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # We need to remove redundant keyword."},{"line_number":58,"context_line":"        # This cannot be done in other place of stacktrace, because neutron"},{"line_number":59,"context_line":"        # needs to be backward compatible."},{"line_number":60,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"},{"line_number":63,"context_line":"        policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_88dbef1a","line":60,"updated":"2017-01-10 12:44:38.000000000","message":"Any unit test for this change?","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8e5e1e78aa405f359890fa2534bdeedb50bed9f4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # We need to remove redundant keyword."},{"line_number":58,"context_line":"        # This cannot be done in other place of stacktrace, because neutron"},{"line_number":59,"context_line":"        # needs to be backward compatible."},{"line_number":60,"context_line":"        policy[\u0027policy\u0027].pop(\u0027tenant_id\u0027, None)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"},{"line_number":63,"context_line":"        policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_4871fca7","line":60,"in_reply_to":"ba5201f7_88dbef1a","updated":"2017-01-11 14:56:41.000000000","message":"Updated tests and added extra keyword to policy to verify, that this change is valid.\nThanks.","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"}],"neutron/services/trunk/plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"38d0e52b0a25a31cd2092eb6b00984ac62c89125","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                                        id\u003duuidutils.generate_uuid(),"},{"line_number":214,"context_line":"                                        name\u003dtrunk.get(\u0027name\u0027, \"\"),"},{"line_number":215,"context_line":"                                        description\u003dtrunk_description,"},{"line_number":216,"context_line":"                                        project_id\u003dtrunk[\u0027tenant_id\u0027],"},{"line_number":217,"context_line":"                                        port_id\u003dtrunk[\u0027port_id\u0027],"},{"line_number":218,"context_line":"                                        status\u003dconstants.DOWN_STATUS,"},{"line_number":219,"context_line":"                                        sub_ports\u003dsub_ports)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_ef707742","line":216,"range":{"start_line":216,"start_character":58,"end_line":216,"end_character":67},"updated":"2016-10-10 06:34:05.000000000","message":"same question as before","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                                        id\u003duuidutils.generate_uuid(),"},{"line_number":214,"context_line":"                                        name\u003dtrunk.get(\u0027name\u0027, \"\"),"},{"line_number":215,"context_line":"                                        description\u003dtrunk_description,"},{"line_number":216,"context_line":"                                        project_id\u003dtrunk[\u0027tenant_id\u0027],"},{"line_number":217,"context_line":"                                        port_id\u003dtrunk[\u0027port_id\u0027],"},{"line_number":218,"context_line":"                                        status\u003dconstants.DOWN_STATUS,"},{"line_number":219,"context_line":"                                        sub_ports\u003dsub_ports)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_e8c5865b","line":216,"range":{"start_line":216,"start_character":58,"end_line":216,"end_character":67},"in_reply_to":"1a95cdbc_ef707742","updated":"2016-10-11 10:37:57.000000000","message":"I believe the change here is correct: we changed the object field name, but retained the key extracted from the API payload. Once the API layer passes project_id for us (or when we stop doing it), we can switch. It should not be the goal of the bug fix.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                                        id\u003duuidutils.generate_uuid(),"},{"line_number":214,"context_line":"                                        name\u003dtrunk.get(\u0027name\u0027, \"\"),"},{"line_number":215,"context_line":"                                        description\u003dtrunk_description,"},{"line_number":216,"context_line":"                                        project_id\u003dtrunk[\u0027tenant_id\u0027],"},{"line_number":217,"context_line":"                                        port_id\u003dtrunk[\u0027port_id\u0027],"},{"line_number":218,"context_line":"                                        status\u003dconstants.DOWN_STATUS,"},{"line_number":219,"context_line":"                                        sub_ports\u003dsub_ports)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_246b1420","line":216,"range":{"start_line":216,"start_character":58,"end_line":216,"end_character":67},"in_reply_to":"fa6399be_e8c5865b","updated":"2016-10-11 18:33:06.000000000","message":"The payload does always contain project_id since [1]. I could use it now if you want.\n\n[1] https://review.openstack.org/357977","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"}],"neutron/tests/tempest/api/test_address_scopes.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"694ebddd655600d4a7825cb3c3dcc92c1a2bfcdf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                      \"Created address scope name should be in the list\")"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.idempotent_id(\u002785e0326b-4c75-4b92-bd6e-7c7de6aaf05c\u0027)"},{"line_number":72,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":73,"context_line":"    def test_show_address_scope(self):"},{"line_number":74,"context_line":"        address_scope \u003d self._create_address_scope(ip_version\u003d4)"},{"line_number":75,"context_line":"        body \u003d self.client.show_address_scope("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_85a2c649","line":72,"updated":"2016-10-06 20:36:24.000000000","message":"meaning, you disable the test for all server versions before Newton? I think those tests should be executed for Mitaka and earlier too. So maybe you need a separate test case for project-id enabled server, but not replace the one we already have.\n\nThoughts?","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f33284b6f34b86d42a5cf7b2f72848910ddbc24","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                      \"Created address scope name should be in the list\")"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.idempotent_id(\u002785e0326b-4c75-4b92-bd6e-7c7de6aaf05c\u0027)"},{"line_number":72,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":73,"context_line":"    def test_show_address_scope(self):"},{"line_number":74,"context_line":"        address_scope \u003d self._create_address_scope(ip_version\u003d4)"},{"line_number":75,"context_line":"        body \u003d self.client.show_address_scope("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_22db631c","line":72,"in_reply_to":"1a95cdbc_85a2c649","updated":"2016-10-09 04:00:47.000000000","message":"Done","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"694ebddd655600d4a7825cb3c3dcc92c1a2bfcdf","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @test.idempotent_id(\u0027108fbdf7-3463-4e47-9871-d07f3dcf5bbb\u0027)"},{"line_number":32,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":33,"context_line":"    def test_create_policy(self):"},{"line_number":34,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":35,"context_line":"                                        description\u003d\u0027test policy desc1\u0027,"},{"line_number":36,"context_line":"                                        shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_a58b42c2","line":33,"updated":"2016-10-06 20:36:24.000000000","message":"ditto","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f33284b6f34b86d42a5cf7b2f72848910ddbc24","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @test.idempotent_id(\u0027108fbdf7-3463-4e47-9871-d07f3dcf5bbb\u0027)"},{"line_number":32,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":33,"context_line":"    def test_create_policy(self):"},{"line_number":34,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027,"},{"line_number":35,"context_line":"                                        description\u003d\u0027test policy desc1\u0027,"},{"line_number":36,"context_line":"                                        shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_42d6aff1","line":33,"in_reply_to":"1a95cdbc_a58b42c2","updated":"2016-10-09 04:00:47.000000000","message":"Done","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"}],"neutron/tests/tempest/api/test_subnetpools.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"694ebddd655600d4a7825cb3c3dcc92c1a2bfcdf","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @test.idempotent_id(\u0027741d08c2-1e3f-42be-99c7-0ea93c5b728c\u0027)"},{"line_number":125,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":126,"context_line":"    def test_get_subnetpool(self):"},{"line_number":127,"context_line":"        created_subnetpool \u003d self._create_subnetpool()"},{"line_number":128,"context_line":"        prefixlen \u003d self._subnetpool_data[\u0027min_prefixlen\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_25be5265","line":125,"updated":"2016-10-06 20:36:24.000000000","message":"ditto","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f33284b6f34b86d42a5cf7b2f72848910ddbc24","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @test.idempotent_id(\u0027741d08c2-1e3f-42be-99c7-0ea93c5b728c\u0027)"},{"line_number":125,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":126,"context_line":"    def test_get_subnetpool(self):"},{"line_number":127,"context_line":"        created_subnetpool \u003d self._create_subnetpool()"},{"line_number":128,"context_line":"        prefixlen \u003d self._subnetpool_data[\u0027min_prefixlen\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_62072b82","line":125,"in_reply_to":"1a95cdbc_25be5265","updated":"2016-10-09 04:00:47.000000000","message":"Done","commit_id":"6f31b98a70d38f838a84ffdb8cc209c7f082443d"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":6271,"context_line":"            subnetpool \u003d models_v2.SubnetPool("},{"line_number":6272,"context_line":"                ip_version\u003d4, default_prefixlen\u003d4, min_prefixlen\u003d4,"},{"line_number":6273,"context_line":"                max_prefixlen\u003d4, shared\u003dFalse, default_quota\u003d4,"},{"line_number":6274,"context_line":"                address_scope_id\u003d\u0027f\u0027, project_id\u003d\u0027dbcheck\u0027,"},{"line_number":6275,"context_line":"                is_default\u003dFalse"},{"line_number":6276,"context_line":"            )"},{"line_number":6277,"context_line":"            ctx.session.add(subnetpool)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_e89ca66b","line":6274,"updated":"2016-10-11 10:37:57.000000000","message":"how is this change relevant? here, we write a model, not an object.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":6271,"context_line":"            subnetpool \u003d models_v2.SubnetPool("},{"line_number":6272,"context_line":"                ip_version\u003d4, default_prefixlen\u003d4, min_prefixlen\u003d4,"},{"line_number":6273,"context_line":"                max_prefixlen\u003d4, shared\u003dFalse, default_quota\u003d4,"},{"line_number":6274,"context_line":"                address_scope_id\u003d\u0027f\u0027, project_id\u003d\u0027dbcheck\u0027,"},{"line_number":6275,"context_line":"                is_default\u003dFalse"},{"line_number":6276,"context_line":"            )"},{"line_number":6277,"context_line":"            ctx.session.add(subnetpool)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_644c2cc8","line":6274,"in_reply_to":"fa6399be_e89ca66b","updated":"2016-10-11 18:33:06.000000000","message":"Done","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9e8539f2c0925b4c69366feddcaa270daea05f30","unresolved":false,"context_lines":[{"line_number":6271,"context_line":"            subnetpool \u003d models_v2.SubnetPool("},{"line_number":6272,"context_line":"                ip_version\u003d4, default_prefixlen\u003d4, min_prefixlen\u003d4,"},{"line_number":6273,"context_line":"                max_prefixlen\u003d4, shared\u003dFalse, default_quota\u003d4,"},{"line_number":6274,"context_line":"                address_scope_id\u003d\u0027f\u0027, project_id\u003d\u0027dbcheck\u0027,"},{"line_number":6275,"context_line":"                is_default\u003dFalse"},{"line_number":6276,"context_line":"            )"},{"line_number":6277,"context_line":"            ctx.session.add(subnetpool)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_43b6538b","line":6274,"in_reply_to":"fa6399be_e89ca66b","updated":"2016-10-11 11:47:51.000000000","message":"I was wondering if we should use SubnetPool OVO here, not the db model. But this is not relevant to this patch.\n\nAnd also the project_id should be uuid generated, not string.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"}],"neutron/tests/unit/ipam/test_subnet_alloc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            default_quota\u003dconstants.ATTR_NOT_SPECIFIED,"},{"line_number":47,"context_line":"                            shared\u003dFalse, is_default\u003dFalse):"},{"line_number":48,"context_line":"        subnetpool \u003d {\u0027subnetpool\u0027: {\u0027name\u0027: name,"},{"line_number":49,"context_line":"                                     \u0027project_id\u0027: self._tenant_id,"},{"line_number":50,"context_line":"                                     \u0027prefixes\u0027: prefix_list,"},{"line_number":51,"context_line":"                                     \u0027min_prefixlen\u0027: min_prefixlen,"},{"line_number":52,"context_line":"                                     \u0027max_prefixlen\u0027: max_prefixlen,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_6887b60f","line":49,"updated":"2016-10-11 10:37:57.000000000","message":"I don\u0027t think we should change the plugin payload as part of the patch","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            default_quota\u003dconstants.ATTR_NOT_SPECIFIED,"},{"line_number":47,"context_line":"                            shared\u003dFalse, is_default\u003dFalse):"},{"line_number":48,"context_line":"        subnetpool \u003d {\u0027subnetpool\u0027: {\u0027name\u0027: name,"},{"line_number":49,"context_line":"                                     \u0027project_id\u0027: self._tenant_id,"},{"line_number":50,"context_line":"                                     \u0027prefixes\u0027: prefix_list,"},{"line_number":51,"context_line":"                                     \u0027min_prefixlen\u0027: min_prefixlen,"},{"line_number":52,"context_line":"                                     \u0027max_prefixlen\u0027: max_prefixlen,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_248794b6","line":49,"in_reply_to":"fa6399be_6887b60f","updated":"2016-10-11 18:33:06.000000000","message":"Tests fail if don\u0027t change this.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bed165811b26318ff8cc7d11ae189570a6636fef","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            default_quota\u003dconstants.ATTR_NOT_SPECIFIED,"},{"line_number":47,"context_line":"                            shared\u003dFalse, is_default\u003dFalse):"},{"line_number":48,"context_line":"        subnetpool \u003d {\u0027subnetpool\u0027: {\u0027name\u0027: name,"},{"line_number":49,"context_line":"                                     \u0027project_id\u0027: self._tenant_id,"},{"line_number":50,"context_line":"                                     \u0027prefixes\u0027: prefix_list,"},{"line_number":51,"context_line":"                                     \u0027min_prefixlen\u0027: min_prefixlen,"},{"line_number":52,"context_line":"                                     \u0027max_prefixlen\u0027: max_prefixlen,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_877009de","line":49,"updated":"2016-10-13 12:22:00.000000000","message":"but why. Can anyone reasonably explain which specific code would fail if we would not change it?","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bf58649ca77fd41bccb3f8189304f9f68b4c5d0a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            default_quota\u003dconstants.ATTR_NOT_SPECIFIED,"},{"line_number":47,"context_line":"                            shared\u003dFalse, is_default\u003dFalse):"},{"line_number":48,"context_line":"        subnetpool \u003d {\u0027subnetpool\u0027: {\u0027name\u0027: name,"},{"line_number":49,"context_line":"                                     \u0027project_id\u0027: self._tenant_id,"},{"line_number":50,"context_line":"                                     \u0027prefixes\u0027: prefix_list,"},{"line_number":51,"context_line":"                                     \u0027min_prefixlen\u0027: min_prefixlen,"},{"line_number":52,"context_line":"                                     \u0027max_prefixlen\u0027: max_prefixlen,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_cac9285b","line":49,"in_reply_to":"fa6399be_877009de","updated":"2016-10-13 12:34:58.000000000","message":"You have to pass the project-id in plugin.create_subnetpool as argument. Otherwise, you will be passing tenant-id to OVO. The user of plugin have to convert tenant-id to project-id. Or simply is required to pass project-id.","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d835154b0824149be8a786e1ffe06d96b7ebb314","unresolved":false,"context_lines":[{"line_number":811,"context_line":"        dict_ \u003d obj.to_dict()"},{"line_number":812,"context_line":"        if self._test_class.fields[\u0027project_id\u0027].nullable:"},{"line_number":813,"context_line":"            self.assertIsNone(obj.project_id)"},{"line_number":814,"context_line":"            self.assertFalse(\u0027project_id\u0027 in dict_)"},{"line_number":815,"context_line":"            self.assertIsNone(dict_[\u0027tenant_id\u0027])"},{"line_number":816,"context_line":"        else:"},{"line_number":817,"context_line":"            self.assertRaises(AttributeError, getattr, obj, \u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_1b92b89e","line":814,"updated":"2016-10-12 20:17:11.000000000","message":"assertNotIn(\u0027project_id\u0027, dict_)","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bed165811b26318ff8cc7d11ae189570a6636fef","unresolved":false,"context_lines":[{"line_number":811,"context_line":"        dict_ \u003d obj.to_dict()"},{"line_number":812,"context_line":"        if self._test_class.fields[\u0027project_id\u0027].nullable:"},{"line_number":813,"context_line":"            self.assertIsNone(obj.project_id)"},{"line_number":814,"context_line":"            self.assertFalse(\u0027project_id\u0027 in dict_)"},{"line_number":815,"context_line":"            self.assertIsNone(dict_[\u0027tenant_id\u0027])"},{"line_number":816,"context_line":"        else:"},{"line_number":817,"context_line":"            self.assertRaises(AttributeError, getattr, obj, \u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_271add7d","line":814,"in_reply_to":"fa6399be_1b92b89e","updated":"2016-10-13 12:22:00.000000000","message":"I would actually expect both to behave identically.","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"bf58649ca77fd41bccb3f8189304f9f68b4c5d0a","unresolved":false,"context_lines":[{"line_number":811,"context_line":"        dict_ \u003d obj.to_dict()"},{"line_number":812,"context_line":"        if self._test_class.fields[\u0027project_id\u0027].nullable:"},{"line_number":813,"context_line":"            self.assertIsNone(obj.project_id)"},{"line_number":814,"context_line":"            self.assertFalse(\u0027project_id\u0027 in dict_)"},{"line_number":815,"context_line":"            self.assertIsNone(dict_[\u0027tenant_id\u0027])"},{"line_number":816,"context_line":"        else:"},{"line_number":817,"context_line":"            self.assertRaises(AttributeError, getattr, obj, \u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_0a1c00c0","line":814,"in_reply_to":"fa6399be_271add7d","updated":"2016-10-13 12:34:58.000000000","message":"I would also but OVO obj_extra_fields are not making this possible, unless we override iter in NeutronDbObj from [1]\n\n[1] https://review.openstack.org/#/c/382659/13/neutron/ipam/subnet_alloc.py","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"59f35025cd13058ba65ea3aac842b159b3a8477d","unresolved":false,"context_lines":[{"line_number":811,"context_line":"        dict_ \u003d obj.to_dict()"},{"line_number":812,"context_line":"        if self._test_class.fields[\u0027project_id\u0027].nullable:"},{"line_number":813,"context_line":"            self.assertIsNone(obj.project_id)"},{"line_number":814,"context_line":"            self.assertFalse(\u0027project_id\u0027 in dict_)"},{"line_number":815,"context_line":"            self.assertIsNone(dict_[\u0027tenant_id\u0027])"},{"line_number":816,"context_line":"        else:"},{"line_number":817,"context_line":"            self.assertRaises(AttributeError, getattr, obj, \u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_aab23492","line":814,"in_reply_to":"fa6399be_271add7d","updated":"2016-10-13 12:53:53.000000000","message":"Of course. My suggestion was merely to use idiomatic testtools parlance.","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d835154b0824149be8a786e1ffe06d96b7ebb314","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        else:"},{"line_number":817,"context_line":"            self.assertRaises(AttributeError, getattr, obj, \u0027project_id\u0027)"},{"line_number":818,"context_line":"            self.assertIsNone(obj.tenant_id)"},{"line_number":819,"context_line":"            self.assertFalse(\u0027project_id\u0027 in dict_)"},{"line_number":820,"context_line":"            self.assertIsNone(dict_[\u0027tenant_id\u0027])"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def test_fields_no_update(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_7bed7424","line":819,"updated":"2016-10-12 20:17:11.000000000","message":"ditto","commit_id":"262741013f231cdace57df954a9419ab6e3e2e5f"}],"neutron/tests/unit/objects/test_objects.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    \u0027SubnetPool\u0027: \u00271.0-a0e03895d1a6e7b9d4ab7b0ca13c3867\u0027,"},{"line_number":56,"context_line":"    \u0027SubnetPoolPrefix\u0027: \u00271.0-13c15144135eb869faa4a76dc3ee3b6c\u0027,"},{"line_number":57,"context_line":"    \u0027SubPort\u0027: \u00271.0-72c8471068db1f0491b5480fe49b52bb\u0027,"},{"line_number":58,"context_line":"    \u0027Trunk\u0027: \u00271.1-aa3922b39e37fbb89886c2ee8715cf49\u0027,"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_2894de35","line":58,"updated":"2016-10-11 10:37:57.000000000","message":"all good","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"}],"neutron/tests/unit/objects/test_trunk.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a359baa2b3d5fd8d84285d2495bc278bdad704d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fa6399be_c8db621a","line":172,"updated":"2016-10-11 10:37:57.000000000","message":"you need to add a test case for your backporting rule dropping project_id.","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d33dfd05fb59fb0806cc51324d047486e27f4b2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fa6399be_8a4a2982","line":172,"in_reply_to":"fa6399be_c8db621a","updated":"2016-10-11 18:33:06.000000000","message":"Done","commit_id":"7ba5b4ef259476b6f48b21d78c8d560bfb5be167"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"42dc1a6d41a305c94e060cea0928ec93d07c92ba","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                           segmentation_type\u003d\u0027vlan\u0027,"},{"line_number":113,"context_line":"                                           segmentation_id\u003dvid))"},{"line_number":114,"context_line":"        trunk \u003d t_obj.Trunk(self.context, port_id\u003dport_id,"},{"line_number":115,"context_line":"                            sub_ports\u003dsub_ports, project_id\u003dtenant_id)"},{"line_number":116,"context_line":"        trunk.create()"},{"line_number":117,"context_line":"        self.assertEqual(sub_ports, trunk.sub_ports)"},{"line_number":118,"context_line":"        return trunk"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_a88b5367","line":115,"range":{"start_line":115,"start_character":60,"end_line":115,"end_character":69},"updated":"2017-01-10 12:44:38.000000000","message":"just some nit: tenant_id is generated in this test case, so it can be changed to project-id now.","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8e5e1e78aa405f359890fa2534bdeedb50bed9f4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                           segmentation_type\u003d\u0027vlan\u0027,"},{"line_number":113,"context_line":"                                           segmentation_id\u003dvid))"},{"line_number":114,"context_line":"        trunk \u003d t_obj.Trunk(self.context, port_id\u003dport_id,"},{"line_number":115,"context_line":"                            sub_ports\u003dsub_ports, project_id\u003dtenant_id)"},{"line_number":116,"context_line":"        trunk.create()"},{"line_number":117,"context_line":"        self.assertEqual(sub_ports, trunk.sub_ports)"},{"line_number":118,"context_line":"        return trunk"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_b78baa67","line":115,"range":{"start_line":115,"start_character":60,"end_line":115,"end_character":69},"in_reply_to":"ba5201f7_a88b5367","updated":"2017-01-11 14:56:41.000000000","message":"Yes, you\u0027re right. Missed that.\nDone","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ddbce2e809f8f6e1c2474606ec82bbae35272a6b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \u0027neutron.objects.rbac_db.RbacNeutronDbObjectMixin\u0027"},{"line_number":92,"context_line":"        \u0027.create_rbac_policy\u0027)"},{"line_number":93,"context_line":"    def test_add_policy(self, *mocks):"},{"line_number":94,"context_line":"        # Enhance default policy_data with extra tenant_id"},{"line_number":95,"context_line":"        policy \u003d self.policy_data.copy()"},{"line_number":96,"context_line":"        policy[\u0027policy\u0027][\u0027tenant_id\u0027] \u003d policy[\u0027policy\u0027][\u0027project_id\u0027]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_06015c38","line":94,"updated":"2017-01-11 20:24:01.000000000","message":"Is it really needed for the test case? Or you try to squash in test coverage for your .pop() call added in create_policy() here? If so, then it\u0027s better to come up with separate test cases for that.","commit_id":"c77f00d2bcf549ad2655d90889752a0e9f9de095"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"ecc1536f16d86e854f358262b40e479def0ad173","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        \u0027neutron.objects.rbac_db.RbacNeutronDbObjectMixin\u0027"},{"line_number":92,"context_line":"        \u0027.create_rbac_policy\u0027)"},{"line_number":93,"context_line":"    def test_add_policy(self, *mocks):"},{"line_number":94,"context_line":"        # Enhance default policy_data with extra tenant_id"},{"line_number":95,"context_line":"        policy \u003d self.policy_data.copy()"},{"line_number":96,"context_line":"        policy[\u0027policy\u0027][\u0027tenant_id\u0027] \u003d policy[\u0027policy\u0027][\u0027project_id\u0027]"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_bc889523","line":94,"in_reply_to":"ba5201f7_06015c38","updated":"2017-01-12 02:37:01.000000000","message":"OK, created separate unittest for policy with extra keyword.","commit_id":"c77f00d2bcf549ad2655d90889752a0e9f9de095"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c7d2217e1cc71a3a40c866bea595d4268b81d316","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import mock"},{"line_number":14,"context_line":"from neutron_lib.plugins import directory"},{"line_number":15,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":28,"id":"7a3c09a3_4a9d8664","side":"PARENT","line":12,"updated":"2017-01-13 22:11:09.000000000","message":"OMG!!!","commit_id":"1a528e817fc3fcb1a3a91c494aabcf75385c02e1"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"717ddf41aaa40c0b0283303590c48d7e72890286","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import mock"},{"line_number":14,"context_line":"from neutron_lib.plugins import directory"},{"line_number":15,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":28,"id":"7a3c09a3_ea0c7244","side":"PARENT","line":12,"in_reply_to":"7a3c09a3_4a9d8664","updated":"2017-01-13 22:19:37.000000000","message":"http://www.nooooooooooooooo.com/","commit_id":"1a528e817fc3fcb1a3a91c494aabcf75385c02e1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9a37f1efb78ac76292734edc0f1df34599b406ac","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                          \u0027description\u0027: \u0027Test policy description\u0027,"},{"line_number":112,"context_line":"                          \u0027shared\u0027: True}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy\u0027) as QosMocked:"},{"line_number":115,"context_line":"            self.qos_plugin.create_policy(self.ctxt, tenant_policy)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        QosMocked.assert_called_once_with(self.ctxt, **policy_details)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7a3c09a3_727329b2","line":114,"range":{"start_line":114,"start_character":67,"end_line":114,"end_character":76},"updated":"2017-01-13 16:07:51.000000000","message":"we usually use no capital letters in variable names, but ok.","commit_id":"8b048cc2872d243914ddea0210ba2128d979d1d2"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"1c4d269eef681266fb60ab54f25a4e3afcb46b42","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                          \u0027description\u0027: \u0027Test policy description\u0027,"},{"line_number":112,"context_line":"                          \u0027shared\u0027: True}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy\u0027) as QosMocked:"},{"line_number":115,"context_line":"            self.qos_plugin.create_policy(self.ctxt, tenant_policy)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        QosMocked.assert_called_once_with(self.ctxt, **policy_details)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7a3c09a3_129585e3","line":114,"range":{"start_line":114,"start_character":67,"end_line":114,"end_character":76},"in_reply_to":"7a3c09a3_727329b2","updated":"2017-01-13 16:19:58.000000000","message":"Ack. Wanted to distinct this from just function or var, and inform, that this is class mock.","commit_id":"8b048cc2872d243914ddea0210ba2128d979d1d2"}],"neutron/tests/unit/services/revisions/test_revision_plugin.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"42dc1a6d41a305c94e060cea0928ec93d07c92ba","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            rev \u003d port[\u0027port\u0027][\u0027revision_number\u0027]"},{"line_number":159,"context_line":"            qos_plugin \u003d directory.get_plugin(\u0027QOS\u0027)"},{"line_number":160,"context_line":"            qos_policy \u003d {\u0027policy\u0027: {\u0027name\u0027: \"policy1\","},{"line_number":161,"context_line":"                                     \u0027project_id\u0027: \"tenant1\"}}"},{"line_number":162,"context_line":"            qos_obj \u003d qos_plugin.create_policy(self.ctx, qos_policy)"},{"line_number":163,"context_line":"            data \u003d {\u0027port\u0027: {\u0027qos_policy_id\u0027: qos_obj[\u0027id\u0027]}}"},{"line_number":164,"context_line":"            response \u003d self._update(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027], data)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_08ab7f8a","line":161,"updated":"2017-01-10 12:44:38.000000000","message":"nit: project_id can be generated, but since it is StringField in OVO, it can stay as string \u0027tenant1\u0027.","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8e5e1e78aa405f359890fa2534bdeedb50bed9f4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            rev \u003d port[\u0027port\u0027][\u0027revision_number\u0027]"},{"line_number":159,"context_line":"            qos_plugin \u003d directory.get_plugin(\u0027QOS\u0027)"},{"line_number":160,"context_line":"            qos_policy \u003d {\u0027policy\u0027: {\u0027name\u0027: \"policy1\","},{"line_number":161,"context_line":"                                     \u0027project_id\u0027: \"tenant1\"}}"},{"line_number":162,"context_line":"            qos_obj \u003d qos_plugin.create_policy(self.ctx, qos_policy)"},{"line_number":163,"context_line":"            data \u003d {\u0027port\u0027: {\u0027qos_policy_id\u0027: qos_obj[\u0027id\u0027]}}"},{"line_number":164,"context_line":"            response \u003d self._update(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027], data)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_77d86280","line":161,"in_reply_to":"ba5201f7_08ab7f8a","updated":"2017-01-11 14:56:41.000000000","message":"Used uuidutils to generate uuid","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8e5e1e78aa405f359890fa2534bdeedb50bed9f4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            rev \u003d network[\u0027network\u0027][\u0027revision_number\u0027]"},{"line_number":171,"context_line":"            qos_plugin \u003d directory.get_plugin(\u0027QOS\u0027)"},{"line_number":172,"context_line":"            qos_policy \u003d {\u0027policy\u0027: {\u0027name\u0027: \"policy1\","},{"line_number":173,"context_line":"                                     \u0027project_id\u0027: \"tenant1\"}}"},{"line_number":174,"context_line":"            qos_obj \u003d qos_plugin.create_policy(self.ctx, qos_policy)"},{"line_number":175,"context_line":"            data \u003d {\u0027network\u0027: {\u0027qos_policy_id\u0027: qos_obj[\u0027id\u0027]}}"},{"line_number":176,"context_line":"            response \u003d self._update(\u0027networks\u0027, network[\u0027network\u0027][\u0027id\u0027], data)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba5201f7_d7cf4eb1","line":173,"updated":"2017-01-11 14:56:41.000000000","message":"Ditto","commit_id":"1b0ed9c94e2079ac007f6c40452fbcc8a2efe136"}]}
