)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"10b036e2376212169cb059b511f29892caaeb00c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The other_config columns in OVSDB are defined as maps with string"},{"line_number":10,"context_line":"keys and string values. The OVS agent was passing an integer"},{"line_number":11,"context_line":"segmentation id and could pass None as the physical_network."},{"line_number":12,"context_line":"Unfortunately, the upstream Python OVS library does not pass the"},{"line_number":13,"context_line":"exceptions through to us."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_f3d6f2ef","line":11,"updated":"2016-10-13 10:12:27.000000000","message":"these keys are not used after I84ff6684ae3fda7d839c14b1a7382871f45ce610 .\ni guess it makes more sense to remove them.","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e37145c78d5bb35f7d44ac5084613c39e7d217ff","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The other_config columns in OVSDB are defined as maps with string"},{"line_number":10,"context_line":"keys and string values. The OVS agent was passing an integer"},{"line_number":11,"context_line":"segmentation id and could pass None as the physical_network."},{"line_number":12,"context_line":"Unfortunately, the upstream Python OVS library does not pass the"},{"line_number":13,"context_line":"exceptions through to us."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_a0fd7e0a","line":11,"in_reply_to":"fa6399be_f3d6f2ef","updated":"2016-10-17 14:38:18.000000000","message":"I am not familiar enough with the code in question to feel comfortable removing anything. All I know is that the values are currently being improperly set. If someone else wants to make another patch to remove the values, I am happy for them to do so. :)","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"10b036e2376212169cb059b511f29892caaeb00c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"keys and string values. The OVS agent was passing an integer"},{"line_number":11,"context_line":"segmentation id and could pass None as the physical_network."},{"line_number":12,"context_line":"Unfortunately, the upstream Python OVS library does not pass the"},{"line_number":13,"context_line":"exceptions through to us."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iafa6be3749b1ee863f5fa71150c708fc46951510"},{"line_number":16,"context_line":"Closes-Bug: #1630920"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_f3a8b279","line":13,"updated":"2016-10-13 10:12:27.000000000","message":"what the library does in that case? just ignore them?","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"1db12c5772453f5d8e88aada2a2457758bd2a43b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"keys and string values. The OVS agent was passing an integer"},{"line_number":11,"context_line":"segmentation id and could pass None as the physical_network."},{"line_number":12,"context_line":"Unfortunately, the upstream Python OVS library does not pass the"},{"line_number":13,"context_line":"exceptions through to us."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iafa6be3749b1ee863f5fa71150c708fc46951510"},{"line_number":16,"context_line":"Closes-Bug: #1630920"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a77a97e_db2f1d86","line":13,"in_reply_to":"fa6399be_23344afa","updated":"2016-11-17 20:35:39.000000000","message":"The extra logging patch has merged.","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e37145c78d5bb35f7d44ac5084613c39e7d217ff","unresolved":false,"context_lines":[{"line_number":10,"context_line":"keys and string values. The OVS agent was passing an integer"},{"line_number":11,"context_line":"segmentation id and could pass None as the physical_network."},{"line_number":12,"context_line":"Unfortunately, the upstream Python OVS library does not pass the"},{"line_number":13,"context_line":"exceptions through to us."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iafa6be3749b1ee863f5fa71150c708fc46951510"},{"line_number":16,"context_line":"Closes-Bug: #1630920"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_23344afa","line":13,"in_reply_to":"fa6399be_f3a8b279","updated":"2016-10-17 14:38:18.000000000","message":"It calls a logger function) and continues. Right now, it doesn\u0027t look like it is actually logging anywhere. Looks possible that we could have it log to our log file. I\u0027ll start another patch to collect the logging info.","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"ee3f9a4ee386f17a1cc14bf1f4fb0908553b601b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Only send string values to OVSDB other_config column"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The other_config columns in OVSDB are defined as maps with string"},{"line_number":10,"context_line":"keys and string values. The OVS agent was passing an integer"},{"line_number":11,"context_line":"segmentation id and could pass None as the physical_network."},{"line_number":12,"context_line":"Unfortunately, the upstream Python OVS library does not pass the"},{"line_number":13,"context_line":"exceptions through to us."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_eb34aefc","line":10,"range":{"start_line":9,"start_character":59,"end_line":10,"end_character":22},"updated":"2016-10-17 19:50:57.000000000","message":"nit: s/string keys and string values/string keys and values","commit_id":"3d500d36608e83d202c1a6c8438ea5961a7debe1"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"10b036e2376212169cb059b511f29892caaeb00c","unresolved":false,"context_lines":[{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        vlan_mapping \u003d {\u0027net_uuid\u0027: net_uuid,"},{"line_number":811,"context_line":"                        \u0027network_type\u0027: network_type,"},{"line_number":812,"context_line":"                        \u0027physical_network\u0027: str(physical_network)}"},{"line_number":813,"context_line":"        if segmentation_id is not None:"},{"line_number":814,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":815,"context_line":"        port_other_config.update(vlan_mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_937e9617","line":812,"updated":"2016-10-13 10:12:27.000000000","message":"i guess there\u0027s no point to put it in case of None.","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e37145c78d5bb35f7d44ac5084613c39e7d217ff","unresolved":false,"context_lines":[{"line_number":809,"context_line":""},{"line_number":810,"context_line":"        vlan_mapping \u003d {\u0027net_uuid\u0027: net_uuid,"},{"line_number":811,"context_line":"                        \u0027network_type\u0027: network_type,"},{"line_number":812,"context_line":"                        \u0027physical_network\u0027: str(physical_network)}"},{"line_number":813,"context_line":"        if segmentation_id is not None:"},{"line_number":814,"context_line":"            vlan_mapping[\u0027segmentation_id\u0027] \u003d str(segmentation_id)"},{"line_number":815,"context_line":"        port_other_config.update(vlan_mapping)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_00a9cadf","line":812,"in_reply_to":"fa6399be_937e9617","updated":"2016-10-17 14:38:18.000000000","message":"The scope of this patch is just to make sure we pass the right values. I don\u0027t want to change any other behaviors. If someone else who is more familiar with exactly how these values are used wants to make a patch removing things, that would be great. I\u0027m just not comfortable enough right now to do so and have other things I\u0027m working on.","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"8d8111be73cb2cca17befff56a15c67ad5c51b4b","unresolved":false,"context_lines":[{"line_number":833,"context_line":"            cur_info \u003d info_by_port.get(port.port_name)"},{"line_number":834,"context_line":"            if cur_info is not None and cur_info[0] !\u003d lvm.vlan:"},{"line_number":835,"context_line":"                other_config \u003d cur_info[1] or {}"},{"line_number":836,"context_line":"                other_config[\u0027tag\u0027] \u003d lvm.vlan"},{"line_number":837,"context_line":"                self.int_br.set_db_attribute("},{"line_number":838,"context_line":"                    \"Port\", port.port_name, \"other_config\", other_config)"},{"line_number":839,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_d76c01d2","line":836,"range":{"start_line":836,"start_character":38,"end_line":836,"end_character":46},"updated":"2016-10-17 12:43:55.000000000","message":"This needs to be a string too.","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e37145c78d5bb35f7d44ac5084613c39e7d217ff","unresolved":false,"context_lines":[{"line_number":833,"context_line":"            cur_info \u003d info_by_port.get(port.port_name)"},{"line_number":834,"context_line":"            if cur_info is not None and cur_info[0] !\u003d lvm.vlan:"},{"line_number":835,"context_line":"                other_config \u003d cur_info[1] or {}"},{"line_number":836,"context_line":"                other_config[\u0027tag\u0027] \u003d lvm.vlan"},{"line_number":837,"context_line":"                self.int_br.set_db_attribute("},{"line_number":838,"context_line":"                    \"Port\", port.port_name, \"other_config\", other_config)"},{"line_number":839,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_80b5da32","line":836,"range":{"start_line":836,"start_character":38,"end_line":836,"end_character":46},"in_reply_to":"fa6399be_d76c01d2","updated":"2016-10-17 14:38:18.000000000","message":"Done.","commit_id":"823ae2f2244aa031dfc7ad9c888e78bf0bac2edf"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bafcb7bea777921b96bc453f21c21a9b7409b254","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        else:"},{"line_number":166,"context_line":"            vlan_mapping \u003d {\u0027net_uuid\u0027: net_uuid,"},{"line_number":167,"context_line":"                            \u0027network_type\u0027: \u0027local\u0027,"},{"line_number":168,"context_line":"                            \u0027physical_network\u0027: \u0027None\u0027}"},{"line_number":169,"context_line":"            int_br.set_db_attribute.assert_called_once_with("},{"line_number":170,"context_line":"                \"Port\", mock.ANY, \"other_config\", vlan_mapping)"},{"line_number":171,"context_line":"            self.assertTrue(needs_binding)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_3eae3f81","line":168,"updated":"2016-11-17 21:10:51.000000000","message":"uh, what happens when this comes back out of the OVS database? Does the physical network become the string \u0027None\u0027?","commit_id":"3d500d36608e83d202c1a6c8438ea5961a7debe1"}]}
