)]}'
{"neutron/plugins/nicira/dbexts/nicira_qos_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"846b3358c8b8542a0bde44f74428c78f4ddf675a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":23,"context_line":"from neutron.db import model_base"},{"line_number":24,"context_line":"from neutron.db import models_v2"},{"line_number":25,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":26,"context_line":"from neutron.openstack.common import uuidutils"},{"line_number":27,"context_line":"from neutron.plugins.nicira.extensions import nvp_qos as ext_qos"},{"line_number":28,"context_line":"from neutron.plugins.nicira import nvplib"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FmDc%3D","line":25,"updated":"2013-07-26 21:55:22.000000000","message":"would you accept my pedant comment to stop aliasing log to logging?\nAs the old logging module has now gone for a long time, perhaps we don\u0027t need it anymore.","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ab370899110ebe5897cdd34399bc4d1dcf3c26b8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":23,"context_line":"from neutron.db import model_base"},{"line_number":24,"context_line":"from neutron.db import models_v2"},{"line_number":25,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":26,"context_line":"from neutron.openstack.common import uuidutils"},{"line_number":27,"context_line":"from neutron.plugins.nicira.extensions import nvp_qos as ext_qos"},{"line_number":28,"context_line":"from neutron.plugins.nicira import nvplib"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fl9M%3D","line":25,"in_reply_to":"AAAAQn%2F%2FmDc%3D","updated":"2013-07-26 22:42:59.000000000","message":"Done","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"846b3358c8b8542a0bde44f74428c78f4ddf675a","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        if qos_queue.get(\u0027qos_marking\u0027) \u003d\u003d \u0027trusted\u0027:"},{"line_number":275,"context_line":"            dscp \u003d qos_queue.pop(\u0027dscp\u0027)"},{"line_number":276,"context_line":"            LOG.warning(_(\"DSCP value (%s) will be ignored with \u0027trusted\u0027 \""},{"line_number":277,"context_line":"                        \"marking\"), dscp)"},{"line_number":278,"context_line":"        max \u003d qos_queue.get(\u0027max\u0027)"},{"line_number":279,"context_line":"        min \u003d qos_queue.get(\u0027min\u0027)"},{"line_number":280,"context_line":"        # Max can be None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FmDg%3D","line":277,"updated":"2013-07-26 21:55:22.000000000","message":"I saw your comment in the other module, but I think we can stick with INFO level. This is nothing that should be picked up by tools monitoring logs for abnormal conditions.\n\nsurely something to document in the API - because the response returned to the caller would differ from the request (dscp disappears)","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ab370899110ebe5897cdd34399bc4d1dcf3c26b8","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        if qos_queue.get(\u0027qos_marking\u0027) \u003d\u003d \u0027trusted\u0027:"},{"line_number":275,"context_line":"            dscp \u003d qos_queue.pop(\u0027dscp\u0027)"},{"line_number":276,"context_line":"            LOG.warning(_(\"DSCP value (%s) will be ignored with \u0027trusted\u0027 \""},{"line_number":277,"context_line":"                        \"marking\"), dscp)"},{"line_number":278,"context_line":"        max \u003d qos_queue.get(\u0027max\u0027)"},{"line_number":279,"context_line":"        min \u003d qos_queue.get(\u0027min\u0027)"},{"line_number":280,"context_line":"        # Max can be None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fl88%3D","line":277,"in_reply_to":"AAAAQn%2F%2FmDg%3D","updated":"2013-07-26 22:42:59.000000000","message":"Done","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"}],"neutron/plugins/nicira/extensions/nvp_qos.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"846b3358c8b8542a0bde44f74428c78f4ddf675a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    return val"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# As per NVP API, if a queue is trusted, DSCP must be omitted; if a queue is"},{"line_number":91,"context_line":"# untrusted, DSCP must be a specified. Whichever default values we choose for"},{"line_number":92,"context_line":"# the tuple (qos_marking, dscp), there will be at least one combination of a"},{"line_number":93,"context_line":"# request with conflicting values: for instance, with the following default:"},{"line_number":94,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FmDI%3D","line":91,"updated":"2013-07-26 21:55:22.000000000","message":"oh you\u0027re giving me so many occasions to unleash my pedantry on you!!!!\n\neither \u0027a specifiied value\u0027 or just \u0027specified\u0027","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ab370899110ebe5897cdd34399bc4d1dcf3c26b8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    return val"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# As per NVP API, if a queue is trusted, DSCP must be omitted; if a queue is"},{"line_number":91,"context_line":"# untrusted, DSCP must be a specified. Whichever default values we choose for"},{"line_number":92,"context_line":"# the tuple (qos_marking, dscp), there will be at least one combination of a"},{"line_number":93,"context_line":"# request with conflicting values: for instance, with the following default:"},{"line_number":94,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fl84%3D","line":91,"in_reply_to":"AAAAQn%2F%2FmDI%3D","updated":"2013-07-26 22:42:59.000000000","message":"Done","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"}],"neutron/tests/unit/nicira/test_nicira_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"846b3358c8b8542a0bde44f74428c78f4ddf675a","unresolved":false,"context_lines":[{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        with mock.patch.object(qos_db.LOG, \u0027warning\u0027) as log:"},{"line_number":668,"context_line":"            with mock.patch.object(nvplib, \u0027do_request\u0027,"},{"line_number":669,"context_line":"                                   new\u003dpost_trusted_queue):"},{"line_number":670,"context_line":"                with self.qos_queue(name\u003d\u0027fake_lqueue\u0027, min\u003d34, max\u003d44,"},{"line_number":671,"context_line":"                                    qos_marking\u003d\u0027trusted\u0027, default\u003dFalse) as q:"},{"line_number":672,"context_line":"                    self.assertEqual(q[\u0027qos_queue\u0027][\u0027dscp\u0027], None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FmCY%3D","line":669,"updated":"2013-07-26 21:55:22.000000000","message":"instead of using new and defining a new function consider\n\nreturn_value \u003d {\u0027uuid\u0027 : \u0027fake_queue\u0027}","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ab370899110ebe5897cdd34399bc4d1dcf3c26b8","unresolved":false,"context_lines":[{"line_number":666,"context_line":""},{"line_number":667,"context_line":"        with mock.patch.object(qos_db.LOG, \u0027warning\u0027) as log:"},{"line_number":668,"context_line":"            with mock.patch.object(nvplib, \u0027do_request\u0027,"},{"line_number":669,"context_line":"                                   new\u003dpost_trusted_queue):"},{"line_number":670,"context_line":"                with self.qos_queue(name\u003d\u0027fake_lqueue\u0027, min\u003d34, max\u003d44,"},{"line_number":671,"context_line":"                                    qos_marking\u003d\u0027trusted\u0027, default\u003dFalse) as q:"},{"line_number":672,"context_line":"                    self.assertEqual(q[\u0027qos_queue\u0027][\u0027dscp\u0027], None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fl80%3D","line":669,"in_reply_to":"AAAAQn%2F%2FmCY%3D","updated":"2013-07-26 22:42:59.000000000","message":"Done","commit_id":"bd72bdf4339258c5a40f9eb9ded3952332109152"}]}