)]}'
{"neutron/plugins/nicira/NeutronPlugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4934283806e3ddaee869c14098ba0c812ae6c604","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"            context, router_id, interface_info)"},{"line_number":1668,"context_line":"        # If the above operation succeded interface_info contains a reference"},{"line_number":1669,"context_line":"        # to a logical switch port"},{"line_number":1670,"context_line":"        port_id \u003d router_iface_info[\u0027port_id\u0027]"},{"line_number":1671,"context_line":"        subnet_id \u003d router_iface_info[\u0027subnet_id\u0027]"},{"line_number":1672,"context_line":"        # Add port to the logical router as well"},{"line_number":1673,"context_line":"        # The owner of the router port is always the same as the owner of the"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FtSg%3D","side":"PARENT","line":1670,"updated":"2013-07-24 17:40:57.000000000","message":"since fix for bug #1061638 the interface for the router can be added by port. Taking this into account, how will this routine behave? Does the nicira plugin even support the operation when the port is specified? My initial take is that it would have never worked, but with your change I guess we now would have a KeyError exception; obviously we can have two patches to deal with the two separate issues (the above mentioned, and the support for add-by-port-id operation), but I wonder if you knew better what\u0027s going on.","commit_id":"b5d1c993de542927632feb530c0e86fcba2d8005"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cab151bc1c44d4f53ff8f030aa6375007689565f","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"            context, router_id, interface_info)"},{"line_number":1668,"context_line":"        # If the above operation succeded interface_info contains a reference"},{"line_number":1669,"context_line":"        # to a logical switch port"},{"line_number":1670,"context_line":"        port_id \u003d router_iface_info[\u0027port_id\u0027]"},{"line_number":1671,"context_line":"        subnet_id \u003d router_iface_info[\u0027subnet_id\u0027]"},{"line_number":1672,"context_line":"        # Add port to the logical router as well"},{"line_number":1673,"context_line":"        # The owner of the router port is always the same as the owner of the"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fo5U%3D","side":"PARENT","line":1670,"in_reply_to":"AAAAQn%2F%2FqNU%3D","updated":"2013-07-26 01:24:40.000000000","message":"I must be barking at the wrong tree then. I tried your change passing the port-id and getting an exception in return :( I need to back and revisit as I don\u0027t have the exact details at hand.","commit_id":"b5d1c993de542927632feb530c0e86fcba2d8005"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6a13fa785b0e92af49b1226d28f117a71fe8489c","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"            context, router_id, interface_info)"},{"line_number":1668,"context_line":"        # If the above operation succeded interface_info contains a reference"},{"line_number":1669,"context_line":"        # to a logical switch port"},{"line_number":1670,"context_line":"        port_id \u003d router_iface_info[\u0027port_id\u0027]"},{"line_number":1671,"context_line":"        subnet_id \u003d router_iface_info[\u0027subnet_id\u0027]"},{"line_number":1672,"context_line":"        # Add port to the logical router as well"},{"line_number":1673,"context_line":"        # The owner of the router port is always the same as the owner of the"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FqNU%3D","side":"PARENT","line":1670,"in_reply_to":"AAAAQn%2F%2FtSg%3D","updated":"2013-07-25 16:09:48.000000000","message":"the feature of adding a router interface by port has alwayes been part of the l3 api.\n\nIt is my understanding that this plugin support adding router interface by port.\nI am going to verify your point on the keyerror exception, but conversely, the orginal code should fail with a keyerror each time we add a router interface by subnet_id because of line 1670.\n\nrouter_iface_info is the data structure returned by add_router_interface in l3_db.py.\n\nIn that data structure port_id and subnet_id attributes are always populated.","commit_id":"b5d1c993de542927632feb530c0e86fcba2d8005"}]}
