)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8e7520909bef116aab69dda4a413b836fffe21db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-09 13:12:21 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating VM with network port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iabc588fbcd5a185077772a9217c02d2f1f396458"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_f6b2194b","line":7,"updated":"2016-10-09 11:11:26.000000000","message":"please see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"9cd0afbc6d00a507b9b3d7fbf5a2fb757553dd79"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"b4f8cd06d34f65e2ae4e55ae25bdcde49938e44a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-09 13:12:21 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating VM with network port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iabc588fbcd5a185077772a9217c02d2f1f396458"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_16af852a","line":7,"in_reply_to":"1a95cdbc_f6b2194b","updated":"2016-10-09 12:54:10.000000000","message":"Done","commit_id":"9cd0afbc6d00a507b9b3d7fbf5a2fb757553dd79"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"037a62af4d71b00fed0fe7f198eaa7f9b4be8ca4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-09 22:28:28 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating VM with sriov port when having  setup, supporting SRIOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding option of sriov_support in config"},{"line_number":10,"context_line":"Functioin for creating network with port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_a2f2a6d0","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":41},"updated":"2016-10-12 02:57:16.000000000","message":"one space should be enough","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"2dd0f2d5c1ea949d2c1484270a0ad2fdb623af13","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-09 22:28:28 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating VM with sriov port when having  setup, supporting SRIOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding option of sriov_support in config"},{"line_number":10,"context_line":"Functioin for creating network with port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_c0d3c702","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":41},"in_reply_to":"fa6399be_a2f2a6d0","updated":"2016-10-13 13:05:54.000000000","message":"Done","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"037a62af4d71b00fed0fe7f198eaa7f9b4be8ca4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Creating VM with sriov port when having  setup, supporting SRIOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding option of sriov_support in config"},{"line_number":10,"context_line":"Functioin for creating network with port"},{"line_number":11,"context_line":"Adding option to setup_network_and_server to run with preexisting network"},{"line_number":12,"context_line":"Adding test for creation of VM with sriov direct port"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_02d7d223","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2016-10-12 02:57:16.000000000","message":"s/Functioin/Function","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"2dd0f2d5c1ea949d2c1484270a0ad2fdb623af13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Creating VM with sriov port when having  setup, supporting SRIOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding option of sriov_support in config"},{"line_number":10,"context_line":"Functioin for creating network with port"},{"line_number":11,"context_line":"Adding option to setup_network_and_server to run with preexisting network"},{"line_number":12,"context_line":"Adding test for creation of VM with sriov direct port"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_e0d0cbf8","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"in_reply_to":"fa6399be_02d7d223","updated":"2016-10-13 13:05:54.000000000","message":"Done","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"037a62af4d71b00fed0fe7f198eaa7f9b4be8ca4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding option of sriov_support in config"},{"line_number":10,"context_line":"Functioin for creating network with port"},{"line_number":11,"context_line":"Adding option to setup_network_and_server to run with preexisting network"},{"line_number":12,"context_line":"Adding test for creation of VM with sriov direct port"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iabc588fbcd5a185077772a9217c02d2f1f396458"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_a21b861a","line":11,"range":{"start_line":11,"start_character":66,"end_line":11,"end_character":73},"updated":"2016-10-12 02:57:16.000000000","message":"exceeds 72 characters\n[1]  Summary of Git commit message structure in https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"2dd0f2d5c1ea949d2c1484270a0ad2fdb623af13","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding option of sriov_support in config"},{"line_number":10,"context_line":"Functioin for creating network with port"},{"line_number":11,"context_line":"Adding option to setup_network_and_server to run with preexisting network"},{"line_number":12,"context_line":"Adding test for creation of VM with sriov direct port"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iabc588fbcd5a185077772a9217c02d2f1f396458"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_00da1f17","line":11,"range":{"start_line":11,"start_character":66,"end_line":11,"end_character":73},"in_reply_to":"fa6399be_a21b861a","updated":"2016-10-13 13:05:54.000000000","message":"Done","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"56b0833a1ac58249de01bad3b948ebd415949d78","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Genadi Chereshnya \u003cgcheresh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-25 16:00:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Creating VM with different kind of ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Create VM with normal, direct and direct-physical ports"},{"line_number":10,"context_line":"and check connectivity to the VM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da4df55a_59cb691e","line":7,"updated":"2016-12-25 14:29:48.000000000","message":"please prefix this with tempest","commit_id":"7bd65ce85cbc2acd5d60ab5e0f18acd921beb1dc"}],"neutron/tests/tempest/scenario/base.py":[{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"5b656ee4a916ea1b9af155fcc26807502000a9b6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":158,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":159,"context_line":"        cls.port_id \u003d cls.create_port(network\u003dcls.network, **kwargs)[\u0027id\u0027]"},{"line_number":160,"context_line":"        return {\u0027port\u0027: cls.port_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_a4a13696","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":36},"updated":"2016-10-10 05:13:44.000000000","message":"isn\u0027t it better to return the whole port?","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"2dd0f2d5c1ea949d2c1484270a0ad2fdb623af13","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":158,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":159,"context_line":"        cls.port_id \u003d cls.create_port(network\u003dcls.network, **kwargs)[\u0027id\u0027]"},{"line_number":160,"context_line":"        return {\u0027port\u0027: cls.port_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_a0e093fb","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":36},"in_reply_to":"1a95cdbc_a4a13696","updated":"2016-10-13 13:05:54.000000000","message":"Don\u0027t think it\u0027s sufficient in this case","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"160a9833d446c67cf2b2566334ce07216f2de20b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ssh_client.test_connection_auth()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def setup_network_and_server(cls, router\u003dNone, network\u003dNone, **kwargs):"},{"line_number":133,"context_line":"        if not network:"},{"line_number":134,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":135,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_0990a0eb","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":75},"updated":"2016-11-01 10:08:10.000000000","message":"I\u0027d break this down to two methods:\n\n def setup_server(cls, router\u003dNone, network\u003dNone, **kwargs):\n    ...\n\n def setup_network_and_server(cls, router\u003dNone, **kwargs):\n    network \u003d cls.create_network()\n    cls.setup_server(router, network, **kwargs)\n\n\nCalling setup_network_and_servers and providing network parameter doesn\u0027t make much sense as in this case it doesn\u0027t setup network.","commit_id":"767ee46fa25c822fc1d556a71093c6a011067dc0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"c7d119e19154cc6dcc86d1fbc9296956b169e6d9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ssh_client.test_connection_auth()"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def setup_network_and_server(cls, router\u003dNone, network\u003dNone, **kwargs):"},{"line_number":133,"context_line":"        if not network:"},{"line_number":134,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":135,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_99a951e2","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":75},"in_reply_to":"ba5da102_0990a0eb","updated":"2016-12-25 12:59:17.000000000","message":"In any case - network is created in the function or is created outside we setup network on the server","commit_id":"767ee46fa25c822fc1d556a71093c6a011067dc0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c4d63a1791d3ea6843e06b79cf23052f4a0fa27a","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def setup_network_and_server(cls, router\u003dNone, network\u003dNone, **kwargs):"},{"line_number":133,"context_line":"        if not network:"},{"line_number":134,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":135,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"},{"line_number":136,"context_line":"            cls.subnet \u003d cls.create_subnet(cls.network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_e9f28cd1","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":23},"updated":"2016-11-01 09:57:30.000000000","message":"nit: need to add a comment saying that if network is supplied, it\u0027s expected to be created using \u0027create_network_with_port\u0027. Otherwise cls.subnet is missing and this could end badly.","commit_id":"767ee46fa25c822fc1d556a71093c6a011067dc0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"c7d119e19154cc6dcc86d1fbc9296956b169e6d9","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def setup_network_and_server(cls, router\u003dNone, network\u003dNone, **kwargs):"},{"line_number":133,"context_line":"        if not network:"},{"line_number":134,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":135,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"},{"line_number":136,"context_line":"            cls.subnet \u003d cls.create_subnet(cls.network)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_195f210f","line":133,"range":{"start_line":133,"start_character":8,"end_line":133,"end_character":23},"in_reply_to":"ba5da102_e9f28cd1","updated":"2016-12-25 12:59:17.000000000","message":"Done","commit_id":"767ee46fa25c822fc1d556a71093c6a011067dc0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3498a141abbfc33822e487b6736dc7e4fd45e823","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        ssh_client.test_connection_auth()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @classmethod"},{"line_number":157,"context_line":"    def setup_network_and_server(cls, router\u003dNone, network\u003dNone, **kwargs):"},{"line_number":158,"context_line":"        \"\"\"Create network resources and a server."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        Creating a network, subnet, router, keypair, security group"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_1bf26b9a","line":157,"range":{"start_line":157,"start_character":51,"end_line":157,"end_character":58},"updated":"2017-01-23 17:21:18.000000000","message":"I suggest to rename this to something like \"nic_settings\" to be in parity with \"openstack server create\" CLI command. The \"network\u003dport\" semantics in the following file seems confusing.","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"5953816946e11a26d28ad7353895dea29e9852ba","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        ssh_client.test_connection_auth()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @classmethod"},{"line_number":157,"context_line":"    def setup_network_and_server(cls, router\u003dNone, network\u003dNone, **kwargs):"},{"line_number":158,"context_line":"        \"\"\"Create network resources and a server."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        Creating a network, subnet, router, keypair, security group"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_420bff23","line":157,"range":{"start_line":157,"start_character":51,"end_line":157,"end_character":58},"in_reply_to":"5a3905b3_1bf26b9a","updated":"2017-01-24 10:49:55.000000000","message":"Done","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"f4b7deddea368ae0a690311ba97203e9719160cc","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        Creating a network, subnet, router, keypair, security group"},{"line_number":161,"context_line":"        and a server."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        # When network is provided, its creator should take care of creating"},{"line_number":164,"context_line":"        # cls.subnet as well"},{"line_number":165,"context_line":"        if not network:"},{"line_number":166,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":167,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_37216fa0","line":164,"range":{"start_line":163,"start_character":8,"end_line":164,"end_character":28},"updated":"2017-01-15 13:21:57.000000000","message":"nit: should be a docstring.","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"5953816946e11a26d28ad7353895dea29e9852ba","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        Creating a network, subnet, router, keypair, security group"},{"line_number":161,"context_line":"        and a server."},{"line_number":162,"context_line":"        \"\"\""},{"line_number":163,"context_line":"        # When network is provided, its creator should take care of creating"},{"line_number":164,"context_line":"        # cls.subnet as well"},{"line_number":165,"context_line":"        if not network:"},{"line_number":166,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":167,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_62163b4d","line":164,"range":{"start_line":163,"start_character":8,"end_line":164,"end_character":28},"in_reply_to":"7a3c09a3_37216fa0","updated":"2017-01-24 10:49:55.000000000","message":"Done","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3498a141abbfc33822e487b6736dc7e4fd45e823","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # cls.subnet as well"},{"line_number":165,"context_line":"        if not network:"},{"line_number":166,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":167,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"},{"line_number":168,"context_line":"            cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        LOG.debug(\"Created network %s\", cls.network[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_7b328fa8","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":19},"updated":"2017-01-23 17:21:18.000000000","message":"Nit: I should pick a more descriptive name like \"network_dict\" to distinguish it from cls.network","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"5953816946e11a26d28ad7353895dea29e9852ba","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        # cls.subnet as well"},{"line_number":165,"context_line":"        if not network:"},{"line_number":166,"context_line":"            cls.network \u003d cls.create_network()"},{"line_number":167,"context_line":"            network \u003d {\u0027uuid\u0027: cls.network[\u0027id\u0027]}"},{"line_number":168,"context_line":"            cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        LOG.debug(\"Created network %s\", cls.network[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_c217ef42","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":19},"in_reply_to":"5a3905b3_7b328fa8","updated":"2017-01-24 10:49:55.000000000","message":"Done","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"03bb939f74d9e7597f2066dd4b87d09dfb53da26","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    @classmethod"},{"line_number":195,"context_line":"    def create_network_with_port(cls, **kwargs):"},{"line_number":196,"context_line":"        cls.network \u003d cls.create_network()"},{"line_number":197,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network)"},{"line_number":198,"context_line":"        cls.port_id \u003d cls.create_port(network\u003dcls.network, **kwargs)[\u0027id\u0027]"},{"line_number":199,"context_line":"        return {\u0027port\u0027: cls.port_id}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a461143_703fa1d6","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":19},"updated":"2017-02-02 12:15:45.000000000","message":"I kind of dislike this trend that got into this scenario directory, which is storing created objects as class attributes. Is there any reason to do so?\n\nI plan to do major refactoring next cycle to get rid of this.","commit_id":"bdf0d86d6339ad675d1184c091216cfe2d39999b"}],"neutron/tests/tempest/scenario/skip_only/__init__.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"160a9833d446c67cf2b2566334ce07216f2de20b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba5da102_c9086830","updated":"2016-11-01 10:08:10.000000000","message":"Suggestion: Maybe neutron/tests/tempest/scenario/skipped/ would be better name compliant with pep8?","commit_id":"767ee46fa25c822fc1d556a71093c6a011067dc0"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"c7d119e19154cc6dcc86d1fbc9296956b169e6d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"da4df55a_39d14558","in_reply_to":"ba5da102_c9086830","updated":"2016-12-25 12:59:17.000000000","message":"Done","commit_id":"767ee46fa25c822fc1d556a71093c6a011067dc0"}],"neutron/tests/tempest/scenario/skipped/test_sriov.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3498a141abbfc33822e487b6736dc7e4fd45e823","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.tests.tempest import config"},{"line_number":18,"context_line":"from neutron.tests.tempest.scenario import base"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_fbccbf8a","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":16},"updated":"2017-01-23 17:21:18.000000000","message":"This should go to L16 and then empty line","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"5953816946e11a26d28ad7353895dea29e9852ba","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.tests.tempest import config"},{"line_number":18,"context_line":"from neutron.tests.tempest.scenario import base"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_aeae4f2b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":16},"in_reply_to":"5a3905b3_fbccbf8a","updated":"2017-01-24 10:49:55.000000000","message":"Done","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3498a141abbfc33822e487b6736dc7e4fd45e823","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: port_type,"},{"line_number":34,"context_line":"                                \u0027name\u0027: \u0027port-sriov\u0027}"},{"line_number":35,"context_line":"            port \u003d self.create_network_with_port(**create_port_body)"},{"line_number":36,"context_line":"            self.setup_network_and_server(network\u003dport)"},{"line_number":37,"context_line":"            self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":38,"context_line":"                                    CONF.validation.image_ssh_user,"},{"line_number":39,"context_line":"                                    self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_5b2eb3fb","line":36,"range":{"start_line":36,"start_character":42,"end_line":36,"end_character":54},"updated":"2017-01-23 17:21:18.000000000","message":":]","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"5953816946e11a26d28ad7353895dea29e9852ba","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: port_type,"},{"line_number":34,"context_line":"                                \u0027name\u0027: \u0027port-sriov\u0027}"},{"line_number":35,"context_line":"            port \u003d self.create_network_with_port(**create_port_body)"},{"line_number":36,"context_line":"            self.setup_network_and_server(network\u003dport)"},{"line_number":37,"context_line":"            self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":38,"context_line":"                                    CONF.validation.image_ssh_user,"},{"line_number":39,"context_line":"                                    self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_6e14674c","line":36,"range":{"start_line":36,"start_character":42,"end_line":36,"end_character":54},"in_reply_to":"5a3905b3_5b2eb3fb","updated":"2017-01-24 10:49:55.000000000","message":"Done","commit_id":"d5d9a964075318f2252a1ef66a8b9ab32a6101e4"}],"neutron/tests/tempest/scenario/test_sriov.py":[{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"5b656ee4a916ea1b9af155fcc26807502000a9b6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def test_create_instance_with_network_port(self):"},{"line_number":32,"context_line":"        create_port_body \u003d {\u0027binding:vnic_type\u0027: \u0027direct\u0027,"},{"line_number":33,"context_line":"                            \u0027name\u0027: \u0027port-sriov\u0027}"},{"line_number":34,"context_line":"        network \u003d self.create_network_with_port(**create_port_body)"},{"line_number":35,"context_line":"        self.setup_network_and_server(network\u003dnetwork)"},{"line_number":36,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":37,"context_line":"                                CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_e4a7bea4","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":15},"updated":"2016-10-10 05:13:44.000000000","message":"you return a port/port id. please rename to port","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"2dd0f2d5c1ea949d2c1484270a0ad2fdb623af13","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def test_create_instance_with_network_port(self):"},{"line_number":32,"context_line":"        create_port_body \u003d {\u0027binding:vnic_type\u0027: \u0027direct\u0027,"},{"line_number":33,"context_line":"                            \u0027name\u0027: \u0027port-sriov\u0027}"},{"line_number":34,"context_line":"        network \u003d self.create_network_with_port(**create_port_body)"},{"line_number":35,"context_line":"        self.setup_network_and_server(network\u003dnetwork)"},{"line_number":36,"context_line":"        self.check_connectivity(self.fip[\u0027floating_ip_address\u0027],"},{"line_number":37,"context_line":"                                CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_e03e0b27","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":15},"in_reply_to":"1a95cdbc_e4a7bea4","updated":"2016-10-13 13:05:54.000000000","message":"Done","commit_id":"ebd40bc9ca7fa051fcb4f4a5527f95cf3e2ab58d"}]}