)]}'
{"neutron/tests/tempest/api/test_address_scopes.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e42544f442351ae50fc99fcca576074435bd5064","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        address_scope \u003d self._create_address_scope(ip_version\u003d4)"},{"line_number":86,"context_line":"        body \u003d self.client.show_address_scope(address_scope[\u0027id\u0027])"},{"line_number":87,"context_line":"        show_addr_scope \u003d body[\u0027address_scope\u0027]"},{"line_number":88,"context_line":"        self.assertIn(\u0027project_id\u0027, show_addr_scope)"},{"line_number":89,"context_line":"        self.assertEqual(self.client.tenant_id, show_addr_scope[\u0027project_id\u0027])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.idempotent_id(\u002785a259b2-ace6-4e32-9657-a9a392b452aa\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_a57497cf","line":88,"updated":"2016-10-11 10:24:26.000000000","message":"should we also check that tenant_id is also present?","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1296400b4777bba3073f8bd6a801949bb42ea1fb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        address_scope \u003d self._create_address_scope(ip_version\u003d4)"},{"line_number":86,"context_line":"        body \u003d self.client.show_address_scope(address_scope[\u0027id\u0027])"},{"line_number":87,"context_line":"        show_addr_scope \u003d body[\u0027address_scope\u0027]"},{"line_number":88,"context_line":"        self.assertIn(\u0027project_id\u0027, show_addr_scope)"},{"line_number":89,"context_line":"        self.assertEqual(self.client.tenant_id, show_addr_scope[\u0027project_id\u0027])"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.idempotent_id(\u002785a259b2-ace6-4e32-9657-a9a392b452aa\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_54ed2b8a","line":88,"in_reply_to":"fa6399be_a57497cf","updated":"2016-10-11 12:07:02.000000000","message":"Done","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f9ad99c4bc403bd7ddfcf858d1dc1f810f6fe17d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        body \u003d self.client.show_address_scope(address_scope[\u0027id\u0027])"},{"line_number":87,"context_line":"        show_addr_scope \u003d body[\u0027address_scope\u0027]"},{"line_number":88,"context_line":"        self.assertIn(\u0027project_id\u0027, show_addr_scope)"},{"line_number":89,"context_line":"        self.assertIn(\u0027tenant_id\u0027, show_addr_scope)"},{"line_number":90,"context_line":"        self.assertEqual(self.client.tenant_id, show_addr_scope[\u0027project_id\u0027])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u002785a259b2-ace6-4e32-9657-a9a392b452aa\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_a07717d3","line":89,"updated":"2016-10-11 15:05:06.000000000","message":"I guess you could also validate the value, but ok.","commit_id":"78841d1757fdd92d3ca1a87d20d3bc22d00da8b0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"73ddfa14af64237c1cab1bbc22c513edff5f8d5d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        body \u003d self.client.show_address_scope(address_scope[\u0027id\u0027])"},{"line_number":87,"context_line":"        show_addr_scope \u003d body[\u0027address_scope\u0027]"},{"line_number":88,"context_line":"        self.assertIn(\u0027project_id\u0027, show_addr_scope)"},{"line_number":89,"context_line":"        self.assertIn(\u0027tenant_id\u0027, show_addr_scope)"},{"line_number":90,"context_line":"        self.assertEqual(self.client.tenant_id, show_addr_scope[\u0027project_id\u0027])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @test.idempotent_id(\u002785a259b2-ace6-4e32-9657-a9a392b452aa\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_620fbfe1","line":89,"in_reply_to":"fa6399be_a07717d3","updated":"2016-10-11 17:06:40.000000000","message":"I definitely should.","commit_id":"78841d1757fdd92d3ca1a87d20d3bc22d00da8b0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d96a0160ff70172b0cc2f3afcb00f6ce4d62a490","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                         returned_address_scope[\u0027name\u0027])"},{"line_number":80,"context_line":"        self.assertFalse(returned_address_scope[\u0027shared\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @test.idempotent_id(\u0027bbd57364-6d57-48e4-b0f1-8b9a998f5e06\u0027)"},{"line_number":83,"context_line":"    @test.requires_ext(extension\u003d\"project-id\", service\u003d\"network\")"},{"line_number":84,"context_line":"    def test_show_address_scope_project_id(self):"},{"line_number":85,"context_line":"        address_scope \u003d self._create_address_scope(ip_version\u003d4)"},{"line_number":86,"context_line":"        body \u003d self.client.show_address_scope(address_scope[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_67918ef0","line":83,"range":{"start_line":82,"start_character":0,"end_line":83,"end_character":65},"updated":"2016-10-11 18:14:22.000000000","message":"I find one thing little odd, as address_scope extension is required to run these tests, since it is enabled by default, is that the reason decorator require_ext on is not used with value address scope in this test module ? if that\u0027s true I feel it would be more safe to have that.","commit_id":"abc31a7ff249fab37f6ac6fb29e44d8b35f73f74"}],"neutron/tests/tempest/api/test_qos.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e42544f442351ae50fc99fcca576074435bd5064","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027, shared\u003dFalse)"},{"line_number":53,"context_line":"        body \u003d self.admin_client.show_qos_policy(policy[\u0027id\u0027])"},{"line_number":54,"context_line":"        show_policy \u003d body[\u0027policy\u0027]"},{"line_number":55,"context_line":"        self.assertIn(\u0027project_id\u0027, show_policy)"},{"line_number":56,"context_line":"        self.assertEqual(self.admin_client.tenant_id,"},{"line_number":57,"context_line":"                         show_policy[\u0027project_id\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_e57e8fad","line":55,"updated":"2016-10-11 10:24:26.000000000","message":"ditto","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1296400b4777bba3073f8bd6a801949bb42ea1fb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        policy \u003d self.create_qos_policy(name\u003d\u0027test-policy\u0027, shared\u003dFalse)"},{"line_number":53,"context_line":"        body \u003d self.admin_client.show_qos_policy(policy[\u0027id\u0027])"},{"line_number":54,"context_line":"        show_policy \u003d body[\u0027policy\u0027]"},{"line_number":55,"context_line":"        self.assertIn(\u0027project_id\u0027, show_policy)"},{"line_number":56,"context_line":"        self.assertEqual(self.admin_client.tenant_id,"},{"line_number":57,"context_line":"                         show_policy[\u0027project_id\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_b4fcc73f","line":55,"in_reply_to":"fa6399be_e57e8fad","updated":"2016-10-11 12:07:02.000000000","message":"Done","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d96a0160ff70172b0cc2f3afcb00f6ce4d62a490","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.assertEqual(self.admin_client.tenant_id,"},{"line_number":60,"context_line":"                         show_policy[\u0027tenant_id\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.idempotent_id(\u0027f8d20e92-f06d-4805-b54f-230f77715815\u0027)"},{"line_number":63,"context_line":"    def test_list_policy_filter_by_name(self):"},{"line_number":64,"context_line":"        self.create_qos_policy(name\u003d\u0027test\u0027, description\u003d\u0027test policy\u0027,"},{"line_number":65,"context_line":"                               shared\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_c7441a76","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":63},"updated":"2016-10-11 18:14:22.000000000","message":"same reasoning here as I had in https://review.openstack.org/#/c/384246/4/neutron/tests/tempest/api/test_address_scopes.py","commit_id":"abc31a7ff249fab37f6ac6fb29e44d8b35f73f74"}],"neutron/tests/tempest/api/test_subnetpools.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e42544f442351ae50fc99fcca576074435bd5064","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        subnetpool \u003d self._create_subnetpool()"},{"line_number":140,"context_line":"        body \u003d self.client.show_subnetpool(subnetpool[\u0027id\u0027])"},{"line_number":141,"context_line":"        show_subnetpool \u003d body[\u0027subnetpool\u0027]"},{"line_number":142,"context_line":"        self.assertIn(\u0027project_id\u0027, show_subnetpool)"},{"line_number":143,"context_line":"        self.assertEqual(self.client.tenant_id, show_subnetpool[\u0027project_id\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @test.idempotent_id(\u0027764f1b93-1c4a-4513-9e7b-6c2fc5e9270c\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_254fa793","line":142,"updated":"2016-10-11 10:24:26.000000000","message":"ditto","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1296400b4777bba3073f8bd6a801949bb42ea1fb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        subnetpool \u003d self._create_subnetpool()"},{"line_number":140,"context_line":"        body \u003d self.client.show_subnetpool(subnetpool[\u0027id\u0027])"},{"line_number":141,"context_line":"        show_subnetpool \u003d body[\u0027subnetpool\u0027]"},{"line_number":142,"context_line":"        self.assertIn(\u0027project_id\u0027, show_subnetpool)"},{"line_number":143,"context_line":"        self.assertEqual(self.client.tenant_id, show_subnetpool[\u0027project_id\u0027])"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    @test.idempotent_id(\u0027764f1b93-1c4a-4513-9e7b-6c2fc5e9270c\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_d4f93b4f","line":142,"in_reply_to":"fa6399be_254fa793","updated":"2016-10-11 12:07:02.000000000","message":"Done","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"}],"neutron/tests/tempest/api/test_trunk.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e42544f442351ae50fc99fcca576074435bd5064","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent(None)"},{"line_number":107,"context_line":"        body \u003d self._show_trunk(trunk[\u0027trunk\u0027][\u0027id\u0027])"},{"line_number":108,"context_line":"        show_trunk \u003d body[\u0027trunk\u0027]"},{"line_number":109,"context_line":"        self.assertIn(\u0027project_id\u0027, show_trunk)"},{"line_number":110,"context_line":"        self.assertEqual(self.client.tenant_id, show_trunk[\u0027project_id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @test.idempotent_id(\u00274ce46c22-a2b6-4659-bc5a-0ef2463cab32\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_c558ab59","line":109,"updated":"2016-10-11 10:24:26.000000000","message":"ditto","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1296400b4777bba3073f8bd6a801949bb42ea1fb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        trunk \u003d self._create_trunk_with_network_and_parent(None)"},{"line_number":107,"context_line":"        body \u003d self._show_trunk(trunk[\u0027trunk\u0027][\u0027id\u0027])"},{"line_number":108,"context_line":"        show_trunk \u003d body[\u0027trunk\u0027]"},{"line_number":109,"context_line":"        self.assertIn(\u0027project_id\u0027, show_trunk)"},{"line_number":110,"context_line":"        self.assertEqual(self.client.tenant_id, show_trunk[\u0027project_id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @test.idempotent_id(\u00274ce46c22-a2b6-4659-bc5a-0ef2463cab32\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_f4947fe9","line":109,"in_reply_to":"fa6399be_c558ab59","updated":"2016-10-11 12:07:02.000000000","message":"Done","commit_id":"9ea2c336bb10374b4b6283887d2b7db3aba9b9bb"}]}