)]}'
{"neutron/tests/unit/db/test_ipam_pluggable_backend.py":[{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"7131560a4d8bee80adec3f980e4f04787bfefdec","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                          ips)"},{"line_number":339,"context_line":"        mocks[\u0027subnets\u0027].allocate.assert_called_once_with(mock.ANY)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_test_fixed_ips_for_port_pd_gateway(self):"},{"line_number":342,"context_line":"        context \u003d mock.Mock()"},{"line_number":343,"context_line":"        pluggable_backend \u003d ipam_pluggable_backend.IpamPluggableBackend()"},{"line_number":344,"context_line":"        with self.subnet(cidr\u003dn_const.PROVISIONAL_IPV6_PD_PREFIX,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_1a34e847","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":17},"updated":"2016-10-10 15:16:57.000000000","message":"test_test?","commit_id":"14ffea4444985eb041181d1bdef9af53ccb4d9f9"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ba3f97e41a3ff7645035b6788bee4245d624397b","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                          ips)"},{"line_number":339,"context_line":"        mocks[\u0027subnets\u0027].allocate.assert_called_once_with(mock.ANY)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_test_fixed_ips_for_port_pd_gateway(self):"},{"line_number":342,"context_line":"        context \u003d mock.Mock()"},{"line_number":343,"context_line":"        pluggable_backend \u003d ipam_pluggable_backend.IpamPluggableBackend()"},{"line_number":344,"context_line":"        with self.subnet(cidr\u003dn_const.PROVISIONAL_IPV6_PD_PREFIX,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c576eb3d","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":17},"in_reply_to":"1a95cdbc_1a34e847","updated":"2016-10-11 11:42:36.000000000","message":"Yeah, the function being tested here is called \"_test_fixed_ips_for_port\". Not sure if there\u0027s an established way to name tests like that.","commit_id":"14ffea4444985eb041181d1bdef9af53ccb4d9f9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b2a7aeed4145dfb38dd97f6caa84019f694ad373","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                          ips)"},{"line_number":339,"context_line":"        mocks[\u0027subnets\u0027].allocate.assert_called_once_with(mock.ANY)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_test_fixed_ips_for_port_pd_gateway(self):"},{"line_number":342,"context_line":"        context \u003d mock.Mock()"},{"line_number":343,"context_line":"        pluggable_backend \u003d ipam_pluggable_backend.IpamPluggableBackend()"},{"line_number":344,"context_line":"        with self.subnet(cidr\u003dn_const.PROVISIONAL_IPV6_PD_PREFIX,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_c79836c3","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":17},"in_reply_to":"fa6399be_c576eb3d","updated":"2016-10-14 17:38:04.000000000","message":"Yes, the way to do it is a double underscore. Just run \"git grep test__\" and you\u0027ll see many examples.","commit_id":"14ffea4444985eb041181d1bdef9af53ccb4d9f9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b2a7aeed4145dfb38dd97f6caa84019f694ad373","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        pluggable_backend \u003d ipam_pluggable_backend.IpamPluggableBackend()"},{"line_number":344,"context_line":"        with self.subnet(cidr\u003dn_const.PROVISIONAL_IPV6_PD_PREFIX,"},{"line_number":345,"context_line":"                         ip_version\u003d6) as subnet:"},{"line_number":346,"context_line":"            subnet \u003d subnet[\u0027subnet\u0027]"},{"line_number":347,"context_line":"            fixed_ips \u003d [{\u0027subnet_id\u0027: subnet[\u0027id\u0027],"},{"line_number":348,"context_line":"                         \u0027ip_address\u0027: \u0027::1\u0027}]"},{"line_number":349,"context_line":"            filtered_ips \u003d (pluggable_backend."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_4f8ecad0","line":346,"updated":"2016-10-14 17:38:04.000000000","message":"Part of me wants to stop the pretense that self.subnet is actually a context manager and de-indent the rest of this method by 4 spaces. Someday, it\u0027d be nice if someone went through and removed the context manager element of it and it\u0027d be nice not to have to change the indentation everywhere. But, this is fine.","commit_id":"14ffea4444985eb041181d1bdef9af53ccb4d9f9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b2a7aeed4145dfb38dd97f6caa84019f694ad373","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                         ip_version\u003d6) as subnet:"},{"line_number":346,"context_line":"            subnet \u003d subnet[\u0027subnet\u0027]"},{"line_number":347,"context_line":"            fixed_ips \u003d [{\u0027subnet_id\u0027: subnet[\u0027id\u0027],"},{"line_number":348,"context_line":"                         \u0027ip_address\u0027: \u0027::1\u0027}]"},{"line_number":349,"context_line":"            filtered_ips \u003d (pluggable_backend."},{"line_number":350,"context_line":"                            _test_fixed_ips_for_port(context,"},{"line_number":351,"context_line":"                                subnet[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_efb31e96","line":348,"range":{"start_line":348,"start_character":25,"end_line":348,"end_character":26},"updated":"2016-10-14 17:38:04.000000000","message":"nit: This should actually be indented one more space.","commit_id":"14ffea4444985eb041181d1bdef9af53ccb4d9f9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b2a7aeed4145dfb38dd97f6caa84019f694ad373","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            subnet \u003d subnet[\u0027subnet\u0027]"},{"line_number":347,"context_line":"            fixed_ips \u003d [{\u0027subnet_id\u0027: subnet[\u0027id\u0027],"},{"line_number":348,"context_line":"                         \u0027ip_address\u0027: \u0027::1\u0027}]"},{"line_number":349,"context_line":"            filtered_ips \u003d (pluggable_backend."},{"line_number":350,"context_line":"                            _test_fixed_ips_for_port(context,"},{"line_number":351,"context_line":"                                subnet[\u0027network_id\u0027],"},{"line_number":352,"context_line":"                                fixed_ips,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_af43e66a","line":349,"updated":"2016-10-14 17:38:04.000000000","message":"Something about the indentation for this multi-line call is distasteful to me.\n\nI think the following would be better and should fit within the 79 char limit.\n\n  filtered_ips \u003d pluggable_backend._test_fixed_ips_for_port(\n      context,\n      subnet[\u0027network_id\u0027],\n      ...","commit_id":"14ffea4444985eb041181d1bdef9af53ccb4d9f9"}]}
