)]}'
{"neutron/objects/base.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"df4a276c26e25f8f4f16df6484b4e5db9df36f63","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @classmethod"},{"line_number":420,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        Fetch first object from DB and convert it to a versioned object."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        :param context:"},{"line_number":425,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_dfd13afd","line":422,"range":{"start_line":422,"start_character":20,"end_line":422,"end_character":26},"updated":"2016-10-11 23:53:42.000000000","message":"row or specifying query object would be helpful here as it will be good enough to inference there is difference between versioned object and one it fetches before it converts","commit_id":"c5e10eba239b6be870ea5fbd6bc98669d09ba7fe"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"222a7b53f59a4c7c7bcc177005806e0711af057f","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @classmethod"},{"line_number":420,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        Fetch first object from DB and convert it to a versioned object."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        :param context:"},{"line_number":425,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_5c3d14ba","line":422,"range":{"start_line":422,"start_character":20,"end_line":422,"end_character":26},"in_reply_to":"fa6399be_5a04587d","updated":"2016-10-12 15:45:53.000000000","message":"yes row/record/element would be better here","commit_id":"c5e10eba239b6be870ea5fbd6bc98669d09ba7fe"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"850e04fc7da47e4da7f5113776b4be60f9599cfb","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @classmethod"},{"line_number":420,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        Fetch first object from DB and convert it to a versioned object."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        :param context:"},{"line_number":425,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_dc7cc4ed","line":422,"range":{"start_line":422,"start_character":20,"end_line":422,"end_character":26},"in_reply_to":"fa6399be_5c3d14ba","updated":"2016-10-12 15:58:43.000000000","message":"Does it mean, I should also update line @447?","commit_id":"c5e10eba239b6be870ea5fbd6bc98669d09ba7fe"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"dabed5d1115fab5ba268a84e7c8dbca9b83751c1","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @classmethod"},{"line_number":420,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        Fetch first object from DB and convert it to a versioned object."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        :param context:"},{"line_number":425,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_bc639019","line":422,"range":{"start_line":422,"start_character":20,"end_line":422,"end_character":26},"in_reply_to":"fa6399be_dc7cc4ed","updated":"2016-10-12 16:01:19.000000000","message":"would be cool to say rows/records/elements there too,","commit_id":"c5e10eba239b6be870ea5fbd6bc98669d09ba7fe"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9b93dd4d76d8020a5f0c1657eeea4aaf6ddf5dcc","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @classmethod"},{"line_number":420,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        Fetch first object from DB and convert it to a versioned object."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        :param context:"},{"line_number":425,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_5a04587d","line":422,"range":{"start_line":422,"start_character":20,"end_line":422,"end_character":26},"in_reply_to":"fa6399be_dfd13afd","updated":"2016-10-12 00:37:14.000000000","message":"There is distinction between `object` and `versioned object` at the end of this sentence. The purpose of added change is to inform, that `get_object` fetches first element from DB not just one.\n\nAre you suggesting to modify wording and replace `object` with row/record?","commit_id":"c5e10eba239b6be870ea5fbd6bc98669d09ba7fe"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"73e031f69d0c24b48c8ce8b4b8854e9822ad242c","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @classmethod"},{"line_number":420,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        Fetch first record from DB and convert it to a versioned object."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        :param context:"},{"line_number":425,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"},{"line_number":426,"context_line":"        :return: single object of NeutronDbObject class"},{"line_number":427,"context_line":"        \"\"\""},{"line_number":428,"context_line":"        lookup_keys \u003d set(kwargs.keys())"},{"line_number":429,"context_line":"        all_keys \u003d itertools.chain([cls.primary_keys], cls.unique_keys)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_193720e4","line":426,"range":{"start_line":422,"start_character":9,"end_line":426,"end_character":55},"updated":"2016-10-12 21:11:26.000000000","message":"Looking here https://review.openstack.org/#/c/381333/6/neutron/objects/base.py made me realize it is important to indicate in this docstring that this method will return the first object found or None. By looking at the bodies of this method and get_one_object, it is not readily evident what the difference in behavior is","commit_id":"fcf92add7d5032541ebebdeb8e824ed3f07f9e39"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"19f5e2f449b6aa471f9d75812ad9fe3637e79d69","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @classmethod"},{"line_number":420,"context_line":"    def get_object(cls, context, **kwargs):"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        Fetch first record from DB and convert it to a versioned object."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        :param context:"},{"line_number":425,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"},{"line_number":426,"context_line":"        :return: single object of NeutronDbObject class"},{"line_number":427,"context_line":"        \"\"\""},{"line_number":428,"context_line":"        lookup_keys \u003d set(kwargs.keys())"},{"line_number":429,"context_line":"        all_keys \u003d itertools.chain([cls.primary_keys], cls.unique_keys)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_39ddc40e","line":426,"range":{"start_line":422,"start_character":9,"end_line":426,"end_character":55},"in_reply_to":"fa6399be_193720e4","updated":"2016-10-12 21:24:39.000000000","message":"Done","commit_id":"fcf92add7d5032541ebebdeb8e824ed3f07f9e39"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"73e031f69d0c24b48c8ce8b4b8854e9822ad242c","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def get_objects(cls, context, _pager\u003dNone, validate_filters\u003dTrue,"},{"line_number":445,"context_line":"                    **kwargs):"},{"line_number":446,"context_line":"        \"\"\""},{"line_number":447,"context_line":"        Fetch all records from DB and convert them to versioned objects."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        :param context:"},{"line_number":450,"context_line":"        :param _pager: a Pager object representing advanced sorting/pagination"},{"line_number":451,"context_line":"                       criteria"},{"line_number":452,"context_line":"        :param validate_filters: Raises an error in case of passing an unknown"},{"line_number":453,"context_line":"                                 filter"},{"line_number":454,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"},{"line_number":455,"context_line":"        :return: list of objects of NeutronDbObject class"},{"line_number":456,"context_line":"        \"\"\""},{"line_number":457,"context_line":"        if validate_filters:"},{"line_number":458,"context_line":"            cls.validate_filters(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_79757c96","line":455,"range":{"start_line":447,"start_character":8,"end_line":455,"end_character":57},"updated":"2016-10-12 21:11:26.000000000","message":"Also, maybe here it will be helpful to indicate that this method may return None","commit_id":"fcf92add7d5032541ebebdeb8e824ed3f07f9e39"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"19f5e2f449b6aa471f9d75812ad9fe3637e79d69","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    def get_objects(cls, context, _pager\u003dNone, validate_filters\u003dTrue,"},{"line_number":445,"context_line":"                    **kwargs):"},{"line_number":446,"context_line":"        \"\"\""},{"line_number":447,"context_line":"        Fetch all records from DB and convert them to versioned objects."},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        :param context:"},{"line_number":450,"context_line":"        :param _pager: a Pager object representing advanced sorting/pagination"},{"line_number":451,"context_line":"                       criteria"},{"line_number":452,"context_line":"        :param validate_filters: Raises an error in case of passing an unknown"},{"line_number":453,"context_line":"                                 filter"},{"line_number":454,"context_line":"        :param kwargs: multiple keys defined by key\u003dvalue pairs"},{"line_number":455,"context_line":"        :return: list of objects of NeutronDbObject class"},{"line_number":456,"context_line":"        \"\"\""},{"line_number":457,"context_line":"        if validate_filters:"},{"line_number":458,"context_line":"            cls.validate_filters(**kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_f9d26cff","line":455,"range":{"start_line":447,"start_character":8,"end_line":455,"end_character":57},"in_reply_to":"fa6399be_79757c96","updated":"2016-10-12 21:24:39.000000000","message":"Done","commit_id":"fcf92add7d5032541ebebdeb8e824ed3f07f9e39"}]}