)]}'
{"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4458ecccb0d3bdaf853761bd9c19ef96ce00adc1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from neutron.extensions import segment"},{"line_number":42,"context_line":"from neutron.ipam import exceptions as ipam_exceptions"},{"line_number":43,"context_line":"from neutron.ipam import utils as ipam_utils"},{"line_number":44,"context_line":"from neutron.objects import network as network_obj"},{"line_number":45,"context_line":"from neutron.objects import subnet as subnet_obj"},{"line_number":46,"context_line":"from neutron.services.segments import exceptions as segment_exc"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_edeb8dae","line":44,"updated":"2016-10-12 18:20:18.000000000","message":"I think you introduced an import problem here","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                network_id\u003dnetwork_id)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if segment_id:"},{"line_number":336,"context_line":"            segment \u003d network_obj.NetworkSegment.get_object(context,"},{"line_number":337,"context_line":"                                                            id\u003dsegment_id)"},{"line_number":338,"context_line":"            if not segment:"},{"line_number":339,"context_line":"                raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_17b701f6","line":336,"updated":"2017-01-10 21:56:18.000000000","message":"_validate_segment is called under transaction, and it\u0027s already validated in line 527. So we should be safe to assume the object exists here.","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                network_id\u003dnetwork_id)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if segment_id:"},{"line_number":336,"context_line":"            segment \u003d network_obj.NetworkSegment.get_object(context,"},{"line_number":337,"context_line":"                                                            id\u003dsegment_id)"},{"line_number":338,"context_line":"            if not segment:"},{"line_number":339,"context_line":"                raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_b5cfe27d","line":336,"in_reply_to":"ba5201f7_17b701f6","updated":"2017-01-11 18:37:55.000000000","message":"Got it, in other words, it\u0027s not necessary to raise the SegmentNotFound exception","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"}],"neutron/db/segments_db.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4458ecccb0d3bdaf853761bd9c19ef96ce00adc1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":"from neutron import context as ncontext"},{"line_number":23,"context_line":"from neutron.db.models import segment as segments_model"},{"line_number":24,"context_line":"from neutron.objects import network as network_obj"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_deprecate._moved_global(\u0027NetworkSegment\u0027, new_module\u003dsegments_model)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_8d2cd103","line":24,"updated":"2016-10-12 18:20:18.000000000","message":"Maybe this line is also contributing to the imports problem","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"60380774dcf575b5f9bacbc22ce59e26684c255e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":"from neutron import context as ncontext"},{"line_number":23,"context_line":"from neutron.db.models import segment as segments_model"},{"line_number":24,"context_line":"from neutron.objects import network as network_obj"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_deprecate._moved_global(\u0027NetworkSegment\u0027, new_module\u003dsegments_model)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_164509b2","line":24,"in_reply_to":"fa6399be_8d2cd103","updated":"2016-10-13 13:55:46.000000000","message":"Thanks, I\u0027ll take a look on this","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4458ecccb0d3bdaf853761bd9c19ef96ce00adc1","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":77,"context_line":"        filters \u003d {"},{"line_number":78,"context_line":"            \u0027network_id\u0027: network_ids,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":"        if filter_dynamic is not None:"},{"line_number":81,"context_line":"            filters[\u0027is_dynamic\u0027]\u003dfilter_dynamic"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_781add6f","line":78,"range":{"start_line":78,"start_character":13,"end_line":78,"end_character":38},"updated":"2016-10-12 18:20:18.000000000","message":"This doesn\u0027t seem right. in NetworkSegment, network_id is a UUIDField and network_ids is an iterable.... But maybe you can teach me something ;-)","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"60380774dcf575b5f9bacbc22ce59e26684c255e","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":77,"context_line":"        filters \u003d {"},{"line_number":78,"context_line":"            \u0027network_id\u0027: network_ids,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":"        if filter_dynamic is not None:"},{"line_number":81,"context_line":"            filters[\u0027is_dynamic\u0027]\u003dfilter_dynamic"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_f6fa5542","line":78,"range":{"start_line":78,"start_character":13,"end_line":78,"end_character":38},"in_reply_to":"fa6399be_781add6f","updated":"2016-10-13 13:55:46.000000000","message":"I was not sure about this, but I found the comment of Trevor[1] that can support this.\n\n[1] https://review.openstack.org/#/c/359379/18/neutron/services/segments/db.py@164","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4458ecccb0d3bdaf853761bd9c19ef96ce00adc1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027network_id\u0027: network_ids,"},{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":"        if filter_dynamic is not None:"},{"line_number":81,"context_line":"            filters[\u0027is_dynamic\u0027]\u003dfilter_dynamic"},{"line_number":82,"context_line":"        records \u003d network_obj.NetworkSegment.get_objects(ncontext.Context(),"},{"line_number":83,"context_line":"                                                         **filters)"},{"line_number":84,"context_line":"        result \u003d {net_id: [] for net_id in network_ids}"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_ed0d4d38","line":81,"range":{"start_line":81,"start_character":33,"end_line":81,"end_character":34},"updated":"2016-10-12 18:20:18.000000000","message":"\u0027 \u003d \u0027","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4458ecccb0d3bdaf853761bd9c19ef96ce00adc1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"def get_segment_by_id(session, segment_id):"},{"line_number":91,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            record \u003d (session.query(segments_model.NetworkSegment)."},{"line_number":94,"context_line":"                      filter_by(id\u003dsegment_id)."},{"line_number":95,"context_line":"                      one())"},{"line_number":96,"context_line":"            return _make_segment_dict(record)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_4d4d596b","line":93,"updated":"2016-10-12 18:20:18.000000000","message":"Making sure you don\u0027t overlook this one","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"60380774dcf575b5f9bacbc22ce59e26684c255e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"def get_segment_by_id(session, segment_id):"},{"line_number":91,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            record \u003d (session.query(segments_model.NetworkSegment)."},{"line_number":94,"context_line":"                      filter_by(id\u003dsegment_id)."},{"line_number":95,"context_line":"                      one())"},{"line_number":96,"context_line":"            return _make_segment_dict(record)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_364ccd9d","line":93,"in_reply_to":"fa6399be_4d4d596b","updated":"2016-10-13 13:55:46.000000000","message":"Yeah, this patch needs more love","commit_id":"f85a9b018988ff3e211177f01ab2fba04e70eea6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f9807995a0c78c681582a483d4c62b20801f1076","unresolved":false,"context_lines":[{"line_number":63,"context_line":"              \u0027network_id\u0027: record.network_id})"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def get_network_segments(context, network_id, filter_dynamic\u003dFalse):"},{"line_number":67,"context_line":"    return get_networks_segments("},{"line_number":68,"context_line":"        context, [network_id], filter_dynamic)[network_id]"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_e35f670c","line":66,"range":{"start_line":66,"start_character":25,"end_line":66,"end_character":32},"updated":"2016-12-01 15:46:02.000000000","message":"changes to context are done in other patch:\nhttps://review.openstack.org/#/c/398873/5/neutron/db/segments_db.py\n\nyou can rebase on that one.","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"efc4cd05bb867728419f6fcc0f3e2a0f6bc26fca","unresolved":false,"context_lines":[{"line_number":63,"context_line":"              \u0027network_id\u0027: record.network_id})"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def get_network_segments(context, network_id, filter_dynamic\u003dFalse):"},{"line_number":67,"context_line":"    return get_networks_segments("},{"line_number":68,"context_line":"        context, [network_id], filter_dynamic)[network_id]"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_0bd27cd2","line":66,"range":{"start_line":66,"start_character":25,"end_line":66,"end_character":32},"in_reply_to":"3a71b18c_e35f670c","updated":"2016-12-02 15:50:46.000000000","message":"It seems like Ann is going to split that patch, I\u0027m gonna rebase this once the new patch is submitted.  Thanks for the info.","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f9807995a0c78c681582a483d4c62b20801f1076","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        ncontext.Context(), **filters)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    if objs:"},{"line_number":108,"context_line":"        return _make_segment_dict(objs[0])"},{"line_number":109,"context_line":"    else:"},{"line_number":110,"context_line":"        LOG.debug(\"No dynamic segment found for \""},{"line_number":111,"context_line":"                  \"Network:%(network_id)s, \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_5b10144f","line":108,"range":{"start_line":108,"start_character":34,"end_line":108,"end_character":41},"updated":"2016-12-01 15:46:02.000000000","message":"it can be: objs.pop()","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"efc4cd05bb867728419f6fcc0f3e2a0f6bc26fca","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        ncontext.Context(), **filters)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    if objs:"},{"line_number":108,"context_line":"        return _make_segment_dict(objs[0])"},{"line_number":109,"context_line":"    else:"},{"line_number":110,"context_line":"        LOG.debug(\"No dynamic segment found for \""},{"line_number":111,"context_line":"                  \"Network:%(network_id)s, \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_6e0f7e2e","line":108,"range":{"start_line":108,"start_character":34,"end_line":108,"end_character":41},"in_reply_to":"3a71b18c_5b10144f","updated":"2016-12-02 15:50:46.000000000","message":"+1","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f9807995a0c78c681582a483d4c62b20801f1076","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def delete_network_segment(session, segment_id):"},{"line_number":121,"context_line":"    \"\"\"Release a dynamic segment for the params provided if one exists.\"\"\""},{"line_number":122,"context_line":"    segment \u003d network_obj.NetworkSegment.get_object(ncontext.Context(),"},{"line_number":123,"context_line":"                                                    id\u003dsegment_id)"},{"line_number":124,"context_line":"    if segment:"},{"line_number":125,"context_line":"        segment.delete()"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_db2fc4f4","line":125,"range":{"start_line":122,"start_character":4,"end_line":125,"end_character":24},"updated":"2016-12-01 15:46:02.000000000","message":"it can use delete_objects().","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"efc4cd05bb867728419f6fcc0f3e2a0f6bc26fca","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def delete_network_segment(session, segment_id):"},{"line_number":121,"context_line":"    \"\"\"Release a dynamic segment for the params provided if one exists.\"\"\""},{"line_number":122,"context_line":"    segment \u003d network_obj.NetworkSegment.get_object(ncontext.Context(),"},{"line_number":123,"context_line":"                                                    id\u003dsegment_id)"},{"line_number":124,"context_line":"    if segment:"},{"line_number":125,"context_line":"        segment.delete()"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_cb4a4483","line":125,"range":{"start_line":122,"start_character":4,"end_line":125,"end_character":24},"in_reply_to":"3a71b18c_db2fc4f4","updated":"2016-12-02 15:50:46.000000000","message":"Maybe, but this is only removing a single row.  If our plans are to use delete_objects for removing one and/or multiple rows we need to do a lot of refactoring of the existing code.","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"6975ffb89382b9f7e988a9df010bee1659199190","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def add_network_segment(context, network_id, segment, segment_index\u003d0,"},{"line_number":42,"context_line":"                        is_dynamic\u003dFalse):"},{"line_number":43,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":44,"context_line":"        record \u003d network_obj.NetworkSegment("},{"line_number":45,"context_line":"            context, id\u003duuidutils.generate_uuid(), network_id\u003dnetwork_id,"},{"line_number":46,"context_line":"            network_type\u003dsegment.get(NETWORK_TYPE),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_4a886a71","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":53},"updated":"2016-12-06 19:15:04.000000000","message":"this is not needed","commit_id":"0d6177bbca115922372bf6ad5b7b245340d406c0"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"6975ffb89382b9f7e988a9df010bee1659199190","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            physical_network\u003dsegment.get(PHYSICAL_NETWORK),"},{"line_number":48,"context_line":"            segmentation_id\u003dsegment.get(SEGMENTATION_ID),"},{"line_number":49,"context_line":"            segment_index\u003dsegment_index, is_dynamic\u003dis_dynamic"},{"line_number":50,"context_line":"        )"},{"line_number":51,"context_line":"        record.create()"},{"line_number":52,"context_line":"        registry.notify(resources.SEGMENT,"},{"line_number":53,"context_line":"                        events.PRECOMMIT_CREATE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_6ac9a6ab","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":9},"updated":"2016-12-06 19:15:04.000000000","message":"nit: this can fit in previous line","commit_id":"0d6177bbca115922372bf6ad5b7b245340d406c0"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"3f41b7f6f4d2eb50875cc9a4a95dadb4a37bf918","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def delete_network_segment(context, segment_id):"},{"line_number":117,"context_line":"    \"\"\"Release a dynamic segment for the params provided if one exists.\"\"\""},{"line_number":118,"context_line":"    segment \u003d network_obj.NetworkSegment.get_object(context, id\u003dsegment_id)"},{"line_number":119,"context_line":"    if segment:"},{"line_number":120,"context_line":"        segment.delete()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_1389f8ca","line":120,"range":{"start_line":118,"start_character":4,"end_line":120,"end_character":24},"updated":"2016-12-08 10:35:45.000000000","message":"It should be done under transaction.","commit_id":"0e047db71911e5ca614c192a44e1b0d6bef477f9"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b26c17aa435b6bbf4b5883504c4386f39f396163","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"def delete_network_segment(context, segment_id):"},{"line_number":117,"context_line":"    \"\"\"Release a dynamic segment for the params provided if one exists.\"\"\""},{"line_number":118,"context_line":"    segment \u003d network_obj.NetworkSegment.get_object(context, id\u003dsegment_id)"},{"line_number":119,"context_line":"    if segment:"},{"line_number":120,"context_line":"        segment.delete()"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"_deprecate._MovedGlobals()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_e1c73a10","line":120,"range":{"start_line":118,"start_character":4,"end_line":120,"end_character":24},"in_reply_to":"3a71b18c_1389f8ca","updated":"2016-12-13 18:11:46.000000000","message":"Done","commit_id":"0e047db71911e5ca614c192a44e1b0d6bef477f9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"SEGMENTATION_ID \u003d segments_model.NetworkSegment.segmentation_id.name"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _make_segment_dict(record):"},{"line_number":34,"context_line":"    \"\"\"Make a segment dictionary out of a DB record.\"\"\""},{"line_number":35,"context_line":"    return {\u0027id\u0027: record.id,"},{"line_number":36,"context_line":"            NETWORK_TYPE: record.network_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_170f0189","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":29},"updated":"2017-01-10 21:56:18.000000000","message":"-\u003e obj?","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":30,"context_line":"SEGMENTATION_ID \u003d segments_model.NetworkSegment.segmentation_id.name"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _make_segment_dict(record):"},{"line_number":34,"context_line":"    \"\"\"Make a segment dictionary out of a DB record.\"\"\""},{"line_number":35,"context_line":"    return {\u0027id\u0027: record.id,"},{"line_number":36,"context_line":"            NETWORK_TYPE: record.network_type,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_35b772d9","line":33,"range":{"start_line":33,"start_character":23,"end_line":33,"end_character":29},"in_reply_to":"ba5201f7_170f0189","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _make_segment_dict(record):"},{"line_number":34,"context_line":"    \"\"\"Make a segment dictionary out of a DB record.\"\"\""},{"line_number":35,"context_line":"    return {\u0027id\u0027: record.id,"},{"line_number":36,"context_line":"            NETWORK_TYPE: record.network_type,"},{"line_number":37,"context_line":"            PHYSICAL_NETWORK: record.physical_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_572189fb","line":34,"range":{"start_line":34,"start_character":42,"end_line":34,"end_character":51},"updated":"2017-01-10 21:56:18.000000000","message":"object","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _make_segment_dict(record):"},{"line_number":34,"context_line":"    \"\"\"Make a segment dictionary out of a DB record.\"\"\""},{"line_number":35,"context_line":"    return {\u0027id\u0027: record.id,"},{"line_number":36,"context_line":"            NETWORK_TYPE: record.network_type,"},{"line_number":37,"context_line":"            PHYSICAL_NETWORK: record.physical_network,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_55e316d9","line":34,"range":{"start_line":34,"start_character":42,"end_line":34,"end_character":51},"in_reply_to":"ba5201f7_572189fb","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def add_network_segment(context, network_id, segment, segment_index\u003d0,"},{"line_number":42,"context_line":"                        is_dynamic\u003dFalse):"},{"line_number":43,"context_line":"    record \u003d network_obj.NetworkSegment("},{"line_number":44,"context_line":"        context, id\u003duuidutils.generate_uuid(), network_id\u003dnetwork_id,"},{"line_number":45,"context_line":"        network_type\u003dsegment.get(NETWORK_TYPE),"},{"line_number":46,"context_line":"        physical_network\u003dsegment.get(PHYSICAL_NETWORK),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_d78ad919","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":10},"updated":"2017-01-10 21:56:18.000000000","message":"maybe better rename into e.g. obj? it\u0027s not exactly a record in database.","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def add_network_segment(context, network_id, segment, segment_index\u003d0,"},{"line_number":42,"context_line":"                        is_dynamic\u003dFalse):"},{"line_number":43,"context_line":"    record \u003d network_obj.NetworkSegment("},{"line_number":44,"context_line":"        context, id\u003duuidutils.generate_uuid(), network_id\u003dnetwork_id,"},{"line_number":45,"context_line":"        network_type\u003dsegment.get(NETWORK_TYPE),"},{"line_number":46,"context_line":"        physical_network\u003dsegment.get(PHYSICAL_NETWORK),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_95001e68","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":10},"in_reply_to":"ba5201f7_d78ad919","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        segmentation_id\u003dsegment.get(SEGMENTATION_ID),"},{"line_number":48,"context_line":"        segment_index\u003dsegment_index, is_dynamic\u003dis_dynamic)"},{"line_number":49,"context_line":"    record.create()"},{"line_number":50,"context_line":"    registry.notify(resources.SEGMENT,"},{"line_number":51,"context_line":"                    events.PRECOMMIT_CREATE,"},{"line_number":52,"context_line":"                    trigger\u003dadd_network_segment,"},{"line_number":53,"context_line":"                    context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_179c615c","line":50,"updated":"2017-01-10 21:56:18.000000000","message":"this is now executed potentially under a separate transaction, if at all, which may be incorrect. Maybe we should keep the subtransaction here.","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        segmentation_id\u003dsegment.get(SEGMENTATION_ID),"},{"line_number":48,"context_line":"        segment_index\u003dsegment_index, is_dynamic\u003dis_dynamic)"},{"line_number":49,"context_line":"    record.create()"},{"line_number":50,"context_line":"    registry.notify(resources.SEGMENT,"},{"line_number":51,"context_line":"                    events.PRECOMMIT_CREATE,"},{"line_number":52,"context_line":"                    trigger\u003dadd_network_segment,"},{"line_number":53,"context_line":"                    context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_55f4f659","line":50,"in_reply_to":"ba5201f7_179c615c","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"    if filter_dynamic is not None:"},{"line_number":76,"context_line":"        filters[\u0027is_dynamic\u0027] \u003d filter_dynamic"},{"line_number":77,"context_line":"    records \u003d network_obj.NetworkSegment.get_objects(context, **filters)"},{"line_number":78,"context_line":"    result \u003d {net_id: [] for net_id in network_ids}"},{"line_number":79,"context_line":"    for record in records:"},{"line_number":80,"context_line":"        result[record.network_id].append(_make_segment_dict(record))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_d7065984","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":11},"updated":"2017-01-10 21:56:18.000000000","message":"objs","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"    if filter_dynamic is not None:"},{"line_number":76,"context_line":"        filters[\u0027is_dynamic\u0027] \u003d filter_dynamic"},{"line_number":77,"context_line":"    records \u003d network_obj.NetworkSegment.get_objects(context, **filters)"},{"line_number":78,"context_line":"    result \u003d {net_id: [] for net_id in network_ids}"},{"line_number":79,"context_line":"    for record in records:"},{"line_number":80,"context_line":"        result[record.network_id].append(_make_segment_dict(record))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_750f3a39","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":11},"in_reply_to":"ba5201f7_d7065984","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        filters[\u0027physical_network\u0027] \u003d physical_network"},{"line_number":99,"context_line":"    if segmentation_id:"},{"line_number":100,"context_line":"        filters[\u0027segmentation_id\u0027] \u003d segmentation_id"},{"line_number":101,"context_line":"    objs \u003d network_obj.NetworkSegment.get_objects(context, **filters)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    if objs:"},{"line_number":104,"context_line":"        return _make_segment_dict(objs[0])"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_17d461bb","line":101,"updated":"2017-01-10 21:56:18.000000000","message":"we probably don\u0027t want to fetch all matching objects, just one. We can use pager with limit\u003d1 to achieve that.","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        filters[\u0027physical_network\u0027] \u003d physical_network"},{"line_number":99,"context_line":"    if segmentation_id:"},{"line_number":100,"context_line":"        filters[\u0027segmentation_id\u0027] \u003d segmentation_id"},{"line_number":101,"context_line":"    objs \u003d network_obj.NetworkSegment.get_objects(context, **filters)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    if objs:"},{"line_number":104,"context_line":"        return _make_segment_dict(objs[0])"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_e749c132","line":101,"in_reply_to":"ba5201f7_17d461bb","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"}],"neutron/objects/network.py":[{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"4bc21cab865a3cc3bbe0de9d1b6727e622cbce2e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    db_model \u003d segment_model.NetworkSegment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields \u003d {"},{"line_number":41,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":42,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":43,"context_line":"        \u0027name\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":44,"context_line":"        \u0027network_type\u0027: obj_fields.StringField(),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_88c2cce7","line":41,"updated":"2016-12-21 15:23:04.000000000","message":"change this to common_types.UUIDField","commit_id":"0e047db71911e5ca614c192a44e1b0d6bef477f9"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"4bc21cab865a3cc3bbe0de9d1b6727e622cbce2e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields \u003d {"},{"line_number":41,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":42,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":43,"context_line":"        \u0027name\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":44,"context_line":"        \u0027network_type\u0027: obj_fields.StringField(),"},{"line_number":45,"context_line":"        \u0027physical_network\u0027: obj_fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_c86f64fa","line":42,"updated":"2016-12-21 15:23:04.000000000","message":"ditto","commit_id":"0e047db71911e5ca614c192a44e1b0d6bef477f9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027SegmentHostMapping\u0027, nullable\u003dTrue)"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    foreign_keys \u003d {"},{"line_number":56,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_9a46b84d","line":53,"updated":"2017-01-10 21:56:18.000000000","message":"I understand that we may need that field, and I understand that it does not add additional load because it\u0027s already loaded, but exposing it as a list of mapping objects is not ideal from UX POV. Can we transform the field into a list of strings (hosts) that will transparently convert from/into SegmentHostMapping objects on read and update?","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            \u0027SegmentHostMapping\u0027, nullable\u003dTrue)"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    foreign_keys \u003d {"},{"line_number":56,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_dbcf347d","line":53,"in_reply_to":"ba5201f7_9a46b84d","updated":"2017-01-11 18:37:55.000000000","message":"I\u0027ve done the changes for the read process, I\u0027m not sure how to do it for update","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6ac4d19aa3cfb9f91187bcd3a19221d7f3647eec","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027segmentation_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027is_dynamic\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":48,"context_line":"        \u0027segment_index\u0027: obj_fields.IntegerField(default\u003d0),"},{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a57fde8_ce8c5638","line":49,"updated":"2017-01-12 11:59:46.000000000","message":"For create/update, it can be handled like in Port object create/update:\nhttps://github.com/openstack/neutron/blob/master/neutron/objects/ports.py#L272","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af4ba3673958366c9b184a735a9c717a40ff565c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027segmentation_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027is_dynamic\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":48,"context_line":"        \u0027segment_index\u0027: obj_fields.IntegerField(default\u003d0),"},{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a57fde8_19e214d6","line":49,"in_reply_to":"9a57fde8_ce8c5638","updated":"2017-01-12 22:10:24.000000000","message":"Gotcha, thanks Artur","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b14379cf6e7c921b638ada9bcd1556f045404656","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027segmentation_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027is_dynamic\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":48,"context_line":"        \u0027segment_index\u0027: obj_fields.IntegerField(default\u003d0),"},{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_2903a40e","line":49,"updated":"2017-01-16 18:19:03.000000000","message":"let\u0027s also rename the field, since now it\u0027s not a mapping, it\u0027s a list of hosts, so maybe use \u0027hosts\u0027?","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"973ebe103812fae1cfb238a5e2e80e1f9d59c9c7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027segmentation_id\u0027: obj_fields.IntegerField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027is_dynamic\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":48,"context_line":"        \u0027segment_index\u0027: obj_fields.IntegerField(default\u003d0),"},{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_e42fcc85","line":49,"in_reply_to":"7a3c09a3_2903a40e","updated":"2017-01-17 17:13:48.000000000","message":"\u0027hosts\u0027 work for me","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a7c20b9eea9de0bc24466e13502cd044c951c47d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    foreign_keys \u003d {"},{"line_number":55,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_92db35ed","line":52,"updated":"2017-01-13 16:19:20.000000000","message":"this synthetic field should be covered with unit tests in test_network.py","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b14379cf6e7c921b638ada9bcd1556f045404656","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    foreign_keys \u003d {"},{"line_number":55,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_ce822694","line":52,"in_reply_to":"7a3c09a3_09c5538d","updated":"2017-01-16 18:19:03.000000000","message":"Yes. Similar to e.g. test_security_group_ids in neutron/tests/unit/objects/test_ports.py","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a70bb523ae59ec0e630d41dc4fe49d03a8f03115","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    foreign_keys \u003d {"},{"line_number":55,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_09c5538d","line":52,"in_reply_to":"7a3c09a3_92db35ed","updated":"2017-01-13 18:57:31.000000000","message":"You mean an UT in NetworkSegmentIfaceObjTestCase class that verifies the content of this list when CRUD operations happens?","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"973ebe103812fae1cfb238a5e2e80e1f9d59c9c7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027segment_host_mapping\u0027: obj_fields.ListOfStringsField(nullable\u003dTrue)"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    synthetic_fields \u003d [\u0027segment_host_mapping\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    foreign_keys \u003d {"},{"line_number":55,"context_line":"        \u0027Network\u0027: {\u0027network_id\u0027: \u0027id\u0027},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_5f014d69","line":52,"in_reply_to":"7a3c09a3_ce822694","updated":"2017-01-17 17:13:48.000000000","message":"Got it, thanks","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a7c20b9eea9de0bc24466e13502cd044c951c47d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _attach_segment_host_mapping(self, hosts):"},{"line_number":78,"context_line":"        # TODO(electrocucaracha): consider introducing an (internal) object for"},{"line_number":79,"context_line":"        # the binding to decouple database operations a bit more"},{"line_number":80,"context_line":"        obj_db_api.delete_objects("},{"line_number":81,"context_line":"            self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":82,"context_line":"            segment_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_b21d9111","line":79,"updated":"2017-01-13 16:19:20.000000000","message":"It\u0027s defined in line 276 already","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a70bb523ae59ec0e630d41dc4fe49d03a8f03115","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _attach_segment_host_mapping(self, hosts):"},{"line_number":78,"context_line":"        # TODO(electrocucaracha): consider introducing an (internal) object for"},{"line_number":79,"context_line":"        # the binding to decouple database operations a bit more"},{"line_number":80,"context_line":"        obj_db_api.delete_objects("},{"line_number":81,"context_line":"            self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":82,"context_line":"            segment_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_a92b5f81","line":79,"in_reply_to":"7a3c09a3_b21d9111","updated":"2017-01-13 18:57:31.000000000","message":"Got it","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a7c20b9eea9de0bc24466e13502cd044c951c47d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                obj_db_api.create_object("},{"line_number":87,"context_line":"                    self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":88,"context_line":"                    {\u0027segment_id\u0027: self.id, \u0027host\u0027: host})"},{"line_number":89,"context_line":"                self.segment_host_mapping \u003d hosts"},{"line_number":90,"context_line":"            self.obj_reset_changes([\u0027segment_host_mapping\u0027])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def obj_load_attr(self, attrname):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_320a81d3","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":49},"updated":"2017-01-13 16:19:20.000000000","message":"This should be done after loop, not inside of it","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a70bb523ae59ec0e630d41dc4fe49d03a8f03115","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                obj_db_api.create_object("},{"line_number":87,"context_line":"                    self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":88,"context_line":"                    {\u0027segment_id\u0027: self.id, \u0027host\u0027: host})"},{"line_number":89,"context_line":"                self.segment_host_mapping \u003d hosts"},{"line_number":90,"context_line":"            self.obj_reset_changes([\u0027segment_host_mapping\u0027])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def obj_load_attr(self, attrname):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_49359bd8","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":49},"in_reply_to":"7a3c09a3_320a81d3","updated":"2017-01-13 18:57:31.000000000","message":"Ouch!","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7fd5fbe78850091b8f53353076d135796056bd59","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        )"},{"line_number":80,"context_line":"        if hosts:"},{"line_number":81,"context_line":"            for host in hosts:"},{"line_number":82,"context_line":"                obj_db_api.create_object("},{"line_number":83,"context_line":"                    self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":84,"context_line":"                    {\u0027segment_id\u0027: self.id, \u0027host\u0027: host})"},{"line_number":85,"context_line":"            self.segment_host_mapping \u003d hosts"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_9753996a","line":82,"updated":"2017-01-17 17:36:38.000000000","message":"you can create mapping objects with OVO too.","commit_id":"b50b7f291568795e63449d6720965c02438852cc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2bdedb701c4e8787f8837a473b66dc2a1704fe95","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        )"},{"line_number":80,"context_line":"        if hosts:"},{"line_number":81,"context_line":"            for host in hosts:"},{"line_number":82,"context_line":"                obj_db_api.create_object("},{"line_number":83,"context_line":"                    self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":84,"context_line":"                    {\u0027segment_id\u0027: self.id, \u0027host\u0027: host})"},{"line_number":85,"context_line":"            self.segment_host_mapping \u003d hosts"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_1096cf3e","line":82,"in_reply_to":"7a3c09a3_9753996a","updated":"2017-01-17 18:52:34.000000000","message":"Done","commit_id":"b50b7f291568795e63449d6720965c02438852cc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7fd5fbe78850091b8f53353076d135796056bd59","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                obj_db_api.create_object("},{"line_number":83,"context_line":"                    self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":84,"context_line":"                    {\u0027segment_id\u0027: self.id, \u0027host\u0027: host})"},{"line_number":85,"context_line":"            self.segment_host_mapping \u003d hosts"},{"line_number":86,"context_line":"            self.obj_reset_changes([\u0027hosts\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def obj_load_attr(self, attrname):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_1765e9b3","line":85,"updated":"2017-01-17 17:36:38.000000000","message":"self.hosts \u003d ?..","commit_id":"b50b7f291568795e63449d6720965c02438852cc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2bdedb701c4e8787f8837a473b66dc2a1704fe95","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                obj_db_api.create_object("},{"line_number":83,"context_line":"                    self.obj_context, segment_model.SegmentHostMapping,"},{"line_number":84,"context_line":"                    {\u0027segment_id\u0027: self.id, \u0027host\u0027: host})"},{"line_number":85,"context_line":"            self.segment_host_mapping \u003d hosts"},{"line_number":86,"context_line":"            self.obj_reset_changes([\u0027hosts\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def obj_load_attr(self, attrname):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_70a553a0","line":85,"in_reply_to":"7a3c09a3_1765e9b3","updated":"2017-01-17 18:52:34.000000000","message":"Ooops","commit_id":"b50b7f291568795e63449d6720965c02438852cc"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"948dd39a8dccd999209971396010bbc5bf683d01","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def create(self):"},{"line_number":60,"context_line":"        fields \u003d self.obj_get_changes()"},{"line_number":61,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":62,"context_line":"            hosts \u003d self.hosts"},{"line_number":63,"context_line":"            if hosts is None:"},{"line_number":64,"context_line":"                hosts \u003d []"},{"line_number":65,"context_line":"            super(NetworkSegment, self).create()"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_083af1e6","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":30},"updated":"2017-01-18 15:39:38.000000000","message":"Shouldn\u0027t it be:\n\n    if \u0027hosts\u0027 in fields:\n        hosts \u003d fields[\u0027hosts\u0027]","commit_id":"1fbab0a51c32f95d4b9269d9f858044ba9f93830"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eea86419780e0178eadaf8014aaa5910b0ed1a2f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def create(self):"},{"line_number":60,"context_line":"        fields \u003d self.obj_get_changes()"},{"line_number":61,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":62,"context_line":"            hosts \u003d self.hosts"},{"line_number":63,"context_line":"            if hosts is None:"},{"line_number":64,"context_line":"                hosts \u003d []"},{"line_number":65,"context_line":"            super(NetworkSegment, self).create()"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_2367b8eb","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":30},"in_reply_to":"7a3c09a3_083af1e6","updated":"2017-01-18 19:41:40.000000000","message":"Seems like default value for lists is [], so there is no need for that.","commit_id":"1fbab0a51c32f95d4b9269d9f858044ba9f93830"}],"neutron/services/segments/db.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f9807995a0c78c681582a483d4c62b20801f1076","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_segments(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":141,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":142,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        pager \u003d base_obj.Pager(sorts, limit, page_reverse, marker)"},{"line_number":144,"context_line":"        return network.NetworkSegment.get_objects(context, pager, **filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_239a3f15","line":143,"updated":"2016-12-01 15:46:02.000000000","message":"You have to add here:\n\n    filters \u003d filters or {}\n\nit is because you are calling get_objects with **filters, and filters can be None.","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"efc4cd05bb867728419f6fcc0f3e2a0f6bc26fca","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_segments(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":141,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":142,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        pager \u003d base_obj.Pager(sorts, limit, page_reverse, marker)"},{"line_number":144,"context_line":"        return network.NetworkSegment.get_objects(context, pager, **filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_eb1b807e","line":143,"in_reply_to":"3a71b18c_239a3f15","updated":"2016-12-02 15:50:46.000000000","message":"Thanks","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f9807995a0c78c681582a483d4c62b20801f1076","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @log_helpers.log_method_call"},{"line_number":147,"context_line":"    def get_segments_count(self, context, filters\u003dNone):"},{"line_number":148,"context_line":"        return network.NetworkSegment.count(context, **filters)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @log_helpers.log_method_call"},{"line_number":151,"context_line":"    def get_segments_by_hosts(self, context, hosts):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_c6f2799a","line":148,"updated":"2016-12-01 15:46:02.000000000","message":"here should be also added:\n    filters \u003d filters or {}","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"6975ffb89382b9f7e988a9df010bee1659199190","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                        segment\u003dsegment)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        # Delete segment in DB"},{"line_number":168,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":169,"context_line":"            segment \u003d network.NetworkSegment.get_object(context, id\u003duuid)"},{"line_number":170,"context_line":"            if not segment:"},{"line_number":171,"context_line":"                raise exceptions.SegmentNotFound(segment_id\u003duuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_8aad229d","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":57},"updated":"2016-12-06 19:15:04.000000000","message":"this is not needed now","commit_id":"0d6177bbca115922372bf6ad5b7b245340d406c0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_segments(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":141,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":142,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        pager \u003d base_obj.Pager(sorts, limit, page_reverse, marker)"},{"line_number":144,"context_line":"        return network.NetworkSegment.get_objects(context, pager, **filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_faa42409","line":143,"updated":"2017-01-10 21:56:18.000000000","message":"filters may, in theory, be None. In which case line 144 would crash. Please initialize filters as:\n\nfilters \u003d filters or {}","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_segments(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":141,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":142,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        pager \u003d base_obj.Pager(sorts, limit, page_reverse, marker)"},{"line_number":144,"context_line":"        return network.NetworkSegment.get_objects(context, pager, **filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_fb3dd82b","line":143,"in_reply_to":"ba5201f7_faa42409","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return network.NetworkSegment.get_objects(context, pager, **filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @log_helpers.log_method_call"},{"line_number":147,"context_line":"    def get_segments_count(self, context, filters\u003dNone):"},{"line_number":148,"context_line":"        return network.NetworkSegment.count(context, **filters)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_1aa808db","line":147,"updated":"2017-01-10 21:56:18.000000000","message":"ditto","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return network.NetworkSegment.get_objects(context, pager, **filters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @log_helpers.log_method_call"},{"line_number":147,"context_line":"    def get_segments_count(self, context, filters\u003dNone):"},{"line_number":148,"context_line":"        return network.NetworkSegment.count(context, **filters)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_7b1808d4","line":147,"in_reply_to":"ba5201f7_1aa808db","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5510c0e9673b448647eb745f11f222fe2251f62c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        return []"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    return network.NetworkSegment.get_objects(context,"},{"line_number":235,"context_line":"                                              physical_network\u003dlist(phys_nets))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"def map_segment_to_hosts(context, segment_id, hosts):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_bae8dc17","line":235,"range":{"start_line":235,"start_character":63,"end_line":235,"end_character":68},"updated":"2017-01-10 21:56:18.000000000","message":"why do we need list() call?","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4045842960a20a46affd3cfb41ac922ad0f8c545","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        return []"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    return network.NetworkSegment.get_objects(context,"},{"line_number":235,"context_line":"                                              physical_network\u003dlist(phys_nets))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"def map_segment_to_hosts(context, segment_id, hosts):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_ac84f80a","line":235,"range":{"start_line":235,"start_character":63,"end_line":235,"end_character":68},"in_reply_to":"ba5201f7_bae8dc17","updated":"2017-01-11 18:37:55.000000000","message":"Done","commit_id":"9d954df9566f541acad5903a949eedc2b9ba210a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6ac4d19aa3cfb9f91187bcd3a19221d7f3647eec","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        filters \u003d filters or {}"},{"line_number":144,"context_line":"        pager \u003d base_obj.Pager(sorts, limit, page_reverse, marker)"},{"line_number":145,"context_line":"        return network.NetworkSegment.get_objects("},{"line_number":146,"context_line":"            context, _pager\u003dpager, **filters)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @log_helpers.log_method_call"},{"line_number":149,"context_line":"    def get_segments_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a57fde8_4ecea65b","line":146,"range":{"start_line":145,"start_character":8,"end_line":146,"end_character":44},"updated":"2017-01-12 11:59:46.000000000","message":"Do we want to return object here or dictionary? I see that it should return make_segment_dict in original code.","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af4ba3673958366c9b184a735a9c717a40ff565c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":143,"context_line":"        filters \u003d filters or {}"},{"line_number":144,"context_line":"        pager \u003d base_obj.Pager(sorts, limit, page_reverse, marker)"},{"line_number":145,"context_line":"        return network.NetworkSegment.get_objects("},{"line_number":146,"context_line":"            context, _pager\u003dpager, **filters)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @log_helpers.log_method_call"},{"line_number":149,"context_line":"    def get_segments_count(self, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_3451b863","line":146,"range":{"start_line":145,"start_character":8,"end_line":146,"end_character":44},"in_reply_to":"9a57fde8_4ecea65b","updated":"2017-01-12 22:10:24.000000000","message":"Done","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6ac4d19aa3cfb9f91187bcd3a19221d7f3647eec","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Delete segment in DB"},{"line_number":171,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":172,"context_line":"            segment \u003d network.NetworkSegment.get_object(context, id\u003duuid)"},{"line_number":173,"context_line":"            if not segment:"},{"line_number":174,"context_line":"                raise exceptions.SegmentNotFound(segment_id\u003duuid)"},{"line_number":175,"context_line":"            segment.delete()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a57fde8_f1081b2b","line":172,"range":{"start_line":172,"start_character":12,"end_line":172,"end_character":19},"updated":"2017-01-12 11:59:46.000000000","message":"This should be renamed to segment_obj, not to overshadow the segment-dict from line 164.\nAnd if segment-obj would not be used anywhere, we can use delete_objects and check if the object was deleted, if not, raise exception.\n\nI assume, that we can use delete_objects to delete single entry in DB, it should be complementary to query.delete() which would return number of entries that were deleted.","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af4ba3673958366c9b184a735a9c717a40ff565c","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        # Delete segment in DB"},{"line_number":171,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":172,"context_line":"            segment \u003d network.NetworkSegment.get_object(context, id\u003duuid)"},{"line_number":173,"context_line":"            if not segment:"},{"line_number":174,"context_line":"                raise exceptions.SegmentNotFound(segment_id\u003duuid)"},{"line_number":175,"context_line":"            segment.delete()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_d7a4f609","line":172,"range":{"start_line":172,"start_character":12,"end_line":172,"end_character":19},"in_reply_to":"9a57fde8_f1081b2b","updated":"2017-01-12 22:10:24.000000000","message":"Well, for this case is very tricky, the notification has to happen before committing the delete sentence.","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6ac4d19aa3cfb9f91187bcd3a19221d7f3647eec","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            # Do some preliminary operations before deleting segment in db"},{"line_number":177,"context_line":"            registry.notify(resources.SEGMENT, events.PRECOMMIT_DELETE,"},{"line_number":178,"context_line":"                            self.delete_segment, context\u003dcontext,"},{"line_number":179,"context_line":"                            segment\u003dsegment)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        registry.notify(resources.SEGMENT, events.AFTER_DELETE,"},{"line_number":182,"context_line":"                        self.delete_segment, context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a57fde8_ce1c567a","line":179,"range":{"start_line":179,"start_character":36,"end_line":179,"end_character":43},"updated":"2017-01-12 11:59:46.000000000","message":"In original code, segment is dict created in line 164. After line 172, this segment will be object, as far as I understand.","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af4ba3673958366c9b184a735a9c717a40ff565c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            # Do some preliminary operations before deleting segment in db"},{"line_number":177,"context_line":"            registry.notify(resources.SEGMENT, events.PRECOMMIT_DELETE,"},{"line_number":178,"context_line":"                            self.delete_segment, context\u003dcontext,"},{"line_number":179,"context_line":"                            segment\u003dsegment)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        registry.notify(resources.SEGMENT, events.AFTER_DELETE,"},{"line_number":182,"context_line":"                        self.delete_segment, context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_f7ce52b3","line":179,"range":{"start_line":179,"start_character":36,"end_line":179,"end_character":43},"in_reply_to":"9a57fde8_ce1c567a","updated":"2017-01-12 22:10:24.000000000","message":"AFAIK, the scope of the segment varible of the variable in the line 172 is until the line 179, but I\u0027ll check it.","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6ac4d19aa3cfb9f91187bcd3a19221d7f3647eec","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    mappings \u003d configurations_dict.get(\u0027bridge_mappings\u0027, {})"},{"line_number":215,"context_line":"    mappings.update(configurations_dict.get(\u0027interface_mappings\u0027, {}))"},{"line_number":216,"context_line":"    mappings.update(configurations_dict.get(\u0027device_mappings\u0027, {}))"},{"line_number":217,"context_line":"    return list(mappings.keys())"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"reported_hosts \u003d set()"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a57fde8_b103f375","line":217,"updated":"2017-01-12 11:59:46.000000000","message":"keys should be a list... Why adding extra typing?","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"af4ba3673958366c9b184a735a9c717a40ff565c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    mappings \u003d configurations_dict.get(\u0027bridge_mappings\u0027, {})"},{"line_number":215,"context_line":"    mappings.update(configurations_dict.get(\u0027interface_mappings\u0027, {}))"},{"line_number":216,"context_line":"    mappings.update(configurations_dict.get(\u0027device_mappings\u0027, {}))"},{"line_number":217,"context_line":"    return list(mappings.keys())"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"reported_hosts \u003d set()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_972a6ee6","line":217,"in_reply_to":"9a57fde8_b103f375","updated":"2017-01-12 22:10:24.000000000","message":"The get_segments_with_phys_nets method[1] uses the output of this method inside of the _update_segment_host_mapping_for_agent method[2], this only ensures that the output of this is a list.\n\n[1] https://review.openstack.org/#/c/385178/6/neutron/services/segments/db.py@235\n[2] https://github.com/openstack/neutron/blob/master/neutron/services/segments/db.py#L273","commit_id":"dd857d98800a0e0baf12fb7f415f4507be7380bc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a7c20b9eea9de0bc24466e13502cd044c951c47d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def _make_segment_dict(segment_db, fields\u003dNone):"},{"line_number":48,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":49,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":50,"context_line":"               \u0027name\u0027: segment_db[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_f2ee39eb","line":47,"range":{"start_line":47,"start_character":27,"end_line":47,"end_character":37},"updated":"2017-01-13 16:19:20.000000000","message":"if this consistently receives an object now, then it should be renamed into segment or segment_obj","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a70bb523ae59ec0e630d41dc4fe49d03a8f03115","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def _make_segment_dict(segment_db, fields\u003dNone):"},{"line_number":48,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":49,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":50,"context_line":"               \u0027name\u0027: segment_db[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_e90e4733","line":47,"range":{"start_line":47,"start_character":27,"end_line":47,"end_character":37},"in_reply_to":"7a3c09a3_f2ee39eb","updated":"2017-01-13 18:57:31.000000000","message":"Done","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a7c20b9eea9de0bc24466e13502cd044c951c47d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               db.PHYSICAL_NETWORK: segment_db[db.PHYSICAL_NETWORK],"},{"line_number":53,"context_line":"               db.NETWORK_TYPE: segment_db[db.NETWORK_TYPE],"},{"line_number":54,"context_line":"               db.SEGMENTATION_ID: segment_db[db.SEGMENTATION_ID],"},{"line_number":55,"context_line":"               \u0027hosts\u0027: [mapping for mapping in"},{"line_number":56,"context_line":"                         segment_db.segment_host_mapping],"},{"line_number":57,"context_line":"               \u0027segment_index\u0027: segment_db[\u0027segment_index\u0027]}"},{"line_number":58,"context_line":"        return db_utils.resource_fields(res, fields)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_52ab8d89","line":56,"range":{"start_line":55,"start_character":24,"end_line":56,"end_character":57},"updated":"2017-01-13 16:19:20.000000000","message":"you can just assign segment_db.segment_host_mapping directly","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a70bb523ae59ec0e630d41dc4fe49d03a8f03115","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               db.PHYSICAL_NETWORK: segment_db[db.PHYSICAL_NETWORK],"},{"line_number":53,"context_line":"               db.NETWORK_TYPE: segment_db[db.NETWORK_TYPE],"},{"line_number":54,"context_line":"               db.SEGMENTATION_ID: segment_db[db.SEGMENTATION_ID],"},{"line_number":55,"context_line":"               \u0027hosts\u0027: [mapping for mapping in"},{"line_number":56,"context_line":"                         segment_db.segment_host_mapping],"},{"line_number":57,"context_line":"               \u0027segment_index\u0027: segment_db[\u0027segment_index\u0027]}"},{"line_number":58,"context_line":"        return db_utils.resource_fields(res, fields)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_29112f53","line":56,"range":{"start_line":55,"start_character":24,"end_line":56,"end_character":57},"in_reply_to":"7a3c09a3_52ab8d89","updated":"2017-01-13 18:57:31.000000000","message":"Done","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b14379cf6e7c921b638ada9bcd1556f045404656","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Delete an existing segment.\"\"\""},{"line_number":165,"context_line":"        segment \u003d self.get_segment(context, uuid)"},{"line_number":166,"context_line":"        # Do some preliminary operations before deleting the segment"},{"line_number":167,"context_line":"        registry.notify(resources.SEGMENT, events.BEFORE_DELETE,"},{"line_number":168,"context_line":"                        self.delete_segment, context\u003dcontext,"},{"line_number":169,"context_line":"                        segment\u003dsegment)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_a9cdd45e","line":167,"updated":"2017-01-16 18:19:03.000000000","message":"here, we send a dict as a payload. I think it would make sense to either send objects everywhere, or dicts everywhere. Can we rewrite the method so that it fetches the object using _get_segment instead of a dict in line 165?","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"973ebe103812fae1cfb238a5e2e80e1f9d59c9c7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Delete an existing segment.\"\"\""},{"line_number":165,"context_line":"        segment \u003d self.get_segment(context, uuid)"},{"line_number":166,"context_line":"        # Do some preliminary operations before deleting the segment"},{"line_number":167,"context_line":"        registry.notify(resources.SEGMENT, events.BEFORE_DELETE,"},{"line_number":168,"context_line":"                        self.delete_segment, context\u003dcontext,"},{"line_number":169,"context_line":"                        segment\u003dsegment)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_6544b61a","line":167,"in_reply_to":"7a3c09a3_a9cdd45e","updated":"2017-01-17 17:13:48.000000000","message":"I\u0027m going to start with sending only objects.","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a7c20b9eea9de0bc24466e13502cd044c951c47d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            # Do some preliminary operations before deleting segment in db"},{"line_number":178,"context_line":"            registry.notify(resources.SEGMENT, events.PRECOMMIT_DELETE,"},{"line_number":179,"context_line":"                            self.delete_segment, context\u003dcontext,"},{"line_number":180,"context_line":"                            segment\u003dsegment_obj)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        registry.notify(resources.SEGMENT, events.AFTER_DELETE,"},{"line_number":183,"context_line":"                        self.delete_segment, context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_32bb61c6","line":180,"range":{"start_line":180,"start_character":28,"end_line":180,"end_character":47},"updated":"2017-01-13 16:19:20.000000000","message":"are notification consumers ready to consume an object, or we should pass it segment_obj.db_obj for safety?","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a70bb523ae59ec0e630d41dc4fe49d03a8f03115","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            # Do some preliminary operations before deleting segment in db"},{"line_number":178,"context_line":"            registry.notify(resources.SEGMENT, events.PRECOMMIT_DELETE,"},{"line_number":179,"context_line":"                            self.delete_segment, context\u003dcontext,"},{"line_number":180,"context_line":"                            segment\u003dsegment_obj)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        registry.notify(resources.SEGMENT, events.AFTER_DELETE,"},{"line_number":183,"context_line":"                        self.delete_segment, context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_86185086","line":180,"range":{"start_line":180,"start_character":28,"end_line":180,"end_character":47},"in_reply_to":"7a3c09a3_32bb61c6","updated":"2017-01-13 18:57:31.000000000","message":"I tried in the previous PS[1] but it was failing some UT like neutron.tests.unit.extensions.test_segment.TestMl2HostSegmentMappingLinuxBridge.test_segment_deletion_removes_host_mapping\n\n[1] https://review.openstack.org/#/c/385178/9..10/neutron/services/segments/db.py@a180","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b14379cf6e7c921b638ada9bcd1556f045404656","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            # Do some preliminary operations before deleting segment in db"},{"line_number":178,"context_line":"            registry.notify(resources.SEGMENT, events.PRECOMMIT_DELETE,"},{"line_number":179,"context_line":"                            self.delete_segment, context\u003dcontext,"},{"line_number":180,"context_line":"                            segment\u003dsegment_obj)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        registry.notify(resources.SEGMENT, events.AFTER_DELETE,"},{"line_number":183,"context_line":"                        self.delete_segment, context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_a99f944e","line":180,"range":{"start_line":180,"start_character":28,"end_line":180,"end_character":47},"in_reply_to":"7a3c09a3_86185086","updated":"2017-01-16 18:19:03.000000000","message":"OK. It\u0027s interesting that we sometimes send db record that has host_segment_mapping, and sometimes a dict (that has \u0027hosts\u0027) as event payload.\n\nI guess it should be ok to consolidate those to always send objects.","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b14379cf6e7c921b638ada9bcd1556f045404656","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        registry.notify(resources.SEGMENT, events.AFTER_DELETE,"},{"line_number":183,"context_line":"                        self.delete_segment, context\u003dcontext,"},{"line_number":184,"context_line":"                        segment\u003dsegment)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"def update_segment_host_mapping(context, host, current_segment_ids):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_894018a7","line":184,"updated":"2017-01-16 18:19:03.000000000","message":"would it make more sense to send segment_obj here, since it reflects a later state of the resource?","commit_id":"4ae4f0dabbffd617da39eb5e5a0d319c90499da8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1a673f3fb9cb7673edc43514a1463467eae64974","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def _make_segment_dict(segment_db, fields\u003dNone):"},{"line_number":48,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":49,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":50,"context_line":"               \u0027name\u0027: segment_db[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_e35690cd","line":47,"range":{"start_line":47,"start_character":27,"end_line":47,"end_character":37},"updated":"2017-01-18 19:44:20.000000000","message":"I think you were going to rename that into segment_obj?","commit_id":"1fbab0a51c32f95d4b9269d9f858044ba9f93830"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f782459dd5603fc804b6ce3ab86e98d8464eb063","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               db.PHYSICAL_NETWORK: segment_db[db.PHYSICAL_NETWORK],"},{"line_number":53,"context_line":"               db.NETWORK_TYPE: segment_db[db.NETWORK_TYPE],"},{"line_number":54,"context_line":"               db.SEGMENTATION_ID: segment_db[db.SEGMENTATION_ID],"},{"line_number":55,"context_line":"               \u0027hosts\u0027: [mapping for mapping in"},{"line_number":56,"context_line":"                         segment_db.segment_host_mapping],"},{"line_number":57,"context_line":"               \u0027segment_index\u0027: segment_db[\u0027segment_index\u0027]}"},{"line_number":58,"context_line":"        return db_utils.resource_fields(res, fields)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a3c09a3_c3ec342c","line":56,"range":{"start_line":55,"start_character":24,"end_line":56,"end_character":57},"updated":"2017-01-18 19:42:32.000000000","message":"ok now you should extract that as-is, without conversion.","commit_id":"1fbab0a51c32f95d4b9269d9f858044ba9f93830"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3ad63833956cfbffdf09b0296f23a64a1425289","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def _make_segment_dict(segment_db, fields\u003dNone):"},{"line_number":48,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":49,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":50,"context_line":"               \u0027name\u0027: segment_db[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a3905b3_d9edd98c","line":47,"range":{"start_line":47,"start_character":27,"end_line":47,"end_character":37},"updated":"2017-01-19 20:36:49.000000000","message":"so how about renaming it into segment_obj?","commit_id":"2af8df5f65aa2af8d5eef5b0774cd2e00e27037a"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f9807995a0c78c681582a483d4c62b20801f1076","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        segment \u003d self.segment(**keys)"},{"line_number":110,"context_line":"        self._validate_resource(segment, keys, \u0027segment\u0027)"},{"line_number":111,"context_line":"        if expected:"},{"line_number":112,"context_line":"            print(segment[\u0027segment\u0027])"},{"line_number":113,"context_line":"            print(expected)"},{"line_number":114,"context_line":"            self._compare_resource(segment, expected, \u0027segment\u0027)"},{"line_number":115,"context_line":"        return segment"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_460ca994","line":113,"range":{"start_line":112,"start_character":12,"end_line":113,"end_character":27},"updated":"2016-12-01 15:46:02.000000000","message":"print?","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"efc4cd05bb867728419f6fcc0f3e2a0f6bc26fca","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        segment \u003d self.segment(**keys)"},{"line_number":110,"context_line":"        self._validate_resource(segment, keys, \u0027segment\u0027)"},{"line_number":111,"context_line":"        if expected:"},{"line_number":112,"context_line":"            print(segment[\u0027segment\u0027])"},{"line_number":113,"context_line":"            print(expected)"},{"line_number":114,"context_line":"            self._compare_resource(segment, expected, \u0027segment\u0027)"},{"line_number":115,"context_line":"        return segment"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_6e369ee8","line":113,"range":{"start_line":112,"start_character":12,"end_line":113,"end_character":27},"in_reply_to":"3a71b18c_460ca994","updated":"2016-12-02 15:50:46.000000000","message":"Ouch, I forgot to remove it","commit_id":"79b1029c47c04586fc5b70cde91224848e5ce381"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"6975ffb89382b9f7e988a9df010bee1659199190","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        segment \u003d self.segment(**keys)"},{"line_number":110,"context_line":"        self._validate_resource(segment, keys, \u0027segment\u0027)"},{"line_number":111,"context_line":"        if expected:"},{"line_number":112,"context_line":"            print(segment[\u0027segment\u0027])"},{"line_number":113,"context_line":"            print(expected)"},{"line_number":114,"context_line":"            self._compare_resource(segment, expected, \u0027segment\u0027)"},{"line_number":115,"context_line":"        return segment"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_ea75b631","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":27},"updated":"2016-12-06 19:15:04.000000000","message":"leftover?","commit_id":"0d6177bbca115922372bf6ad5b7b245340d406c0"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7fd5fbe78850091b8f53353076d135796056bd59","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"            standard_attr.StandardAttribute,"},{"line_number":1316,"context_line":"            attrs)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def _create_test_segment_host_mapping(self):"},{"line_number":1319,"context_line":"        attrs \u003d self.get_random_object_fields(net_obj.SegmentHostMapping)"},{"line_number":1320,"context_line":"        self._segment_host_mapping \u003d net_obj.SegmentHostMapping("},{"line_number":1321,"context_line":"            self.context, **attrs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_f7d4dd20","line":1318,"updated":"2017-01-17 17:36:38.000000000","message":"I think it\u0027s too specific to segment object, and hence should go into test_network.py","commit_id":"b50b7f291568795e63449d6720965c02438852cc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2bdedb701c4e8787f8837a473b66dc2a1704fe95","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"            standard_attr.StandardAttribute,"},{"line_number":1316,"context_line":"            attrs)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def _create_test_segment_host_mapping(self):"},{"line_number":1319,"context_line":"        attrs \u003d self.get_random_object_fields(net_obj.SegmentHostMapping)"},{"line_number":1320,"context_line":"        self._segment_host_mapping \u003d net_obj.SegmentHostMapping("},{"line_number":1321,"context_line":"            self.context, **attrs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_907b9f27","line":1318,"in_reply_to":"7a3c09a3_f7d4dd20","updated":"2017-01-17 18:52:34.000000000","message":"I was trying to collect all creation tests methods in a single place for future refactoring.  Anyway, I\u0027m going to remove it, it\u0027s not required anymore for the UT.","commit_id":"b50b7f291568795e63449d6720965c02438852cc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a3ad63833956cfbffdf09b0296f23a64a1425289","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"    def _create_test_segment(self, network):"},{"line_number":1342,"context_line":"        attr \u003d self.get_random_object_fields(net_obj.NetworkSegment)"},{"line_number":1343,"context_line":"        obj \u003d net_obj.NetworkSegment(self.context, **attr)"},{"line_number":1344,"context_line":"        obj.create()"},{"line_number":1345,"context_line":"        self._segment \u003d net_obj.NetworkSegment("},{"line_number":1346,"context_line":"            self.context, id\u003duuidutils.generate_uuid(),"},{"line_number":1347,"context_line":"            network_id\u003dnetwork[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a3905b3_79eea58c","line":1344,"updated":"2017-01-19 20:36:49.000000000","message":"seems like a mistake? We create same segment twice?","commit_id":"2af8df5f65aa2af8d5eef5b0774cd2e00e27037a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"f73bd659d36c43dc42e6bc0c13e72ae6af3ab6e3","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"    def _create_test_segment(self, network):"},{"line_number":1342,"context_line":"        attr \u003d self.get_random_object_fields(net_obj.NetworkSegment)"},{"line_number":1343,"context_line":"        obj \u003d net_obj.NetworkSegment(self.context, **attr)"},{"line_number":1344,"context_line":"        obj.create()"},{"line_number":1345,"context_line":"        self._segment \u003d net_obj.NetworkSegment("},{"line_number":1346,"context_line":"            self.context, id\u003duuidutils.generate_uuid(),"},{"line_number":1347,"context_line":"            network_id\u003dnetwork[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a3905b3_01c8c354","line":1344,"in_reply_to":"5a3905b3_79eea58c","updated":"2017-01-19 22:30:47.000000000","message":"I need to stop testing this in the gates, thanks man and sorry for bothering you with trivial changes","commit_id":"2af8df5f65aa2af8d5eef5b0774cd2e00e27037a"}],"neutron/tests/unit/objects/test_network.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7fd5fbe78850091b8f53353076d135796056bd59","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.update_obj_fields({\u0027network_id\u0027: network.id})"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_hosts(self):"},{"line_number":58,"context_line":"        host1 \u003d self._create_test_segment_host_mapping()"},{"line_number":59,"context_line":"        host2 \u003d self._create_test_segment_host_mapping()"},{"line_number":60,"context_line":"        hosts \u003d {host1.host, host2.host}"},{"line_number":61,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_976c7936","line":58,"updated":"2017-01-17 17:36:38.000000000","message":"can we avoid creating mappings like that, and instead just set .hosts on the object before calling .create()? That will show that create/update works for the field too.","commit_id":"b50b7f291568795e63449d6720965c02438852cc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7fd5fbe78850091b8f53353076d135796056bd59","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        obj \u003d network.NetworkSegment(self.context, id\u003dobj.id)"},{"line_number":66,"context_line":"        self.assertEqual(hosts, obj.hosts)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        host3 \u003d self._create_test_segment_host_mapping()"},{"line_number":69,"context_line":"        obj.hosts \u003d {host3.host}"},{"line_number":70,"context_line":"        obj.update()"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a3c09a3_97a2b997","line":68,"updated":"2017-01-17 17:36:38.000000000","message":"you should be able to create/delete host mappings with just setting obj.hosts and calling .update() Please avoid creating mappings like that to make sure update works for the field too.","commit_id":"b50b7f291568795e63449d6720965c02438852cc"}],"neutron/tests/unit/plugins/ml2/test_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"af604c72fe2faffe9c08d4f2cc8e9bc267f43541","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return sorted(segments, key\u003dlambda d: d[\u0027segmentation_id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse,"},{"line_number":76,"context_line":"                         network_id\u003duuidutils.generate_uuid()):"},{"line_number":77,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":78,"context_line":"        for segment in segments:"},{"line_number":79,"context_line":"            segments_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_a9281f9b","line":76,"updated":"2017-01-24 00:13:20.000000000","message":"ok, if that\u0027s the intention that\u0027s fine. I would prefer in that case to just use a statically defined UUID to be more explicit about its staticness :)","commit_id":"bb178353835dd5ecc296d5e4310d41b4b2172f29"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"095846268c22bac04cf54d2a9278f5cbe9a8221e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return sorted(segments, key\u003dlambda d: d[\u0027segmentation_id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse,"},{"line_number":76,"context_line":"                         network_id\u003duuidutils.generate_uuid()):"},{"line_number":77,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":78,"context_line":"        for segment in segments:"},{"line_number":79,"context_line":"            segments_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_43f15dcc","line":76,"updated":"2017-01-23 22:15:35.000000000","message":"this won\u0027t work the way you want it do. Default arguments are evaluated at function definition time, so generate_uuid() will only be called once and will be used for all subsequent calls. It may be okay for the current use case, but I recommend make it default to None and then add a line in the function to do \u0027network_id \u003d network_id or uuidutils.generate_uuid()\u0027. Otherwise other people may be misled into thinking it will generate a random uuid for each call.\n\n\nFor a demonstration of what I mean, look at this paste:\n\nhttp://paste.openstack.org/show/596156/","commit_id":"bb178353835dd5ecc296d5e4310d41b4b2172f29"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ce8fcb701457d980c7ad0dda5de6fe32e932b7b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return sorted(segments, key\u003dlambda d: d[\u0027segmentation_id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse,"},{"line_number":76,"context_line":"                         network_id\u003duuidutils.generate_uuid()):"},{"line_number":77,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":78,"context_line":"        for segment in segments:"},{"line_number":79,"context_line":"            segments_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_83634541","line":76,"in_reply_to":"5a3905b3_43f15dcc","updated":"2017-01-23 22:26:15.000000000","message":"I think the intention here is as in the old version, to use the same value for all implicit calls.","commit_id":"bb178353835dd5ecc296d5e4310d41b4b2172f29"}]}
