)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e1b9494a4f09be189a8f39d70da48ec1dfb58dd9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When calling metering-label-rules POST API with wrong"},{"line_number":10,"context_line":"metering_label_id, neutron server returns 500."},{"line_number":11,"context_line":"This patch adds a check for metering_label_id."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8d167a9d0d7f766755acb732fc15598e475112ac"},{"line_number":14,"context_line":"Closes-Bug: 1633006"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_1965471d","line":12,"updated":"2016-10-13 10:51:56.000000000","message":"Please include APIImpact flag with a brief description of the change. See https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"ed0f9de6052822a997c146e6eec76c404c3794c1"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"34df2386f3984af78265ddad0b175011612d4a8c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When calling metering-label-rules POST API with wrong"},{"line_number":10,"context_line":"metering_label_id, neutron server returns 500."},{"line_number":11,"context_line":"This patch adds a check for metering_label_id."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8d167a9d0d7f766755acb732fc15598e475112ac"},{"line_number":14,"context_line":"Closes-Bug: 1633006"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_237631d7","line":12,"in_reply_to":"fa6399be_1965471d","updated":"2016-10-14 01:19:17.000000000","message":"+1","commit_id":"ed0f9de6052822a997c146e6eec76c404c3794c1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"98e9da39902df383cdd3689f4d21ab5c3248e622","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When calling metering-label-rules POST API with wrong"},{"line_number":10,"context_line":"metering_label_id, neutron server returns 500."},{"line_number":11,"context_line":"This patch adds a check for metering_label_id."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8d167a9d0d7f766755acb732fc15598e475112ac"},{"line_number":14,"context_line":"Closes-Bug: 1633006"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_8a42db3c","line":12,"in_reply_to":"fa6399be_237631d7","updated":"2016-10-20 05:20:23.000000000","message":"No. It\u0027s unnecessary because this patch doesn\u0027t change behavior of API. It just fixes unexpected Neutron error.","commit_id":"ed0f9de6052822a997c146e6eec76c404c3794c1"}],"neutron/db/metering/metering_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"75654c82766d481ed9b9af160fd7fe6dcccba67a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            label_id \u003d m[\u0027metering_label_id\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            # Confirm that the label is valid"},{"line_number":148,"context_line":"            self.get_metering_label(context, label_id)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            ip_prefix \u003d m[\u0027remote_ip_prefix\u0027]"},{"line_number":151,"context_line":"            direction \u003d m[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_33322aa8","line":148,"updated":"2016-10-20 07:38:17.000000000","message":"why does this need to be done under the DB transaction?","commit_id":"ed0f9de6052822a997c146e6eec76c404c3794c1"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0df4eae95543e602bbf53d39d845c248d66dce75","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            label_id \u003d m[\u0027metering_label_id\u0027]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"            # Confirm that the label is valid"},{"line_number":148,"context_line":"            self.get_metering_label(context, label_id)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"            ip_prefix \u003d m[\u0027remote_ip_prefix\u0027]"},{"line_number":151,"context_line":"            direction \u003d m[\u0027direction\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d152c366","line":148,"in_reply_to":"fa6399be_33322aa8","updated":"2016-10-20 10:28:00.000000000","message":"It doesn\u0027t need to be under transaction as you said. Done.","commit_id":"ed0f9de6052822a997c146e6eec76c404c3794c1"}]}
