)]}'
{"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a8d92d6b1b0889a491ac43a350e4519b02d202f1","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                try:"},{"line_number":160,"context_line":"                    self.disable_dhcp_helper(deleted_id)"},{"line_number":161,"context_line":"                except Exception:"},{"line_number":162,"context_line":"                    self.needs_resync \u003d True"},{"line_number":163,"context_line":"                    LOG.exception(_(\u0027Unable to sync network state on deleted \u0027"},{"line_number":164,"context_line":"                                    \u0027network %s\u0027) % deleted_id)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fhi8%3D","line":162,"updated":"2013-07-29 20:33:48.000000000","message":"I wonder if needs_resync \u003d True is really the right thing the do here, even though your fix does not really change how the code used to work; the thing is, if the agent is unable to disable dhcp for the deleted networks for whatever reason, it will keep on pounding the server for resources that have become stale.","commit_id":"3d5bec962c1e5bb923107f54585c94a9b24f2d30"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4d8361bcab0f7746f5d282d344829bcaf51802ee","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                try:"},{"line_number":160,"context_line":"                    self.disable_dhcp_helper(deleted_id)"},{"line_number":161,"context_line":"                except Exception:"},{"line_number":162,"context_line":"                    self.needs_resync \u003d True"},{"line_number":163,"context_line":"                    LOG.exception(_(\u0027Unable to sync network state on deleted \u0027"},{"line_number":164,"context_line":"                                    \u0027network %s\u0027) % deleted_id)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FdVE%3D","line":162,"in_reply_to":"AAAAQn%2F%2FhEA%3D","updated":"2013-07-30 21:41:30.000000000","message":"I think that there is scope for improving the robustness of such a critical method. Instead of just capping the number of tries I would try to get to the root cause by improving the exception handling of the command that fails. A follow-up bug report might be useful for tracking purposes, but we\u0027d really need to have more info about the underlying error that triggered your patch in order to deal with it effectively.","commit_id":"3d5bec962c1e5bb923107f54585c94a9b24f2d30"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"bc7ac08a4a9f740943da8b7cca23661e98e56bdc","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                try:"},{"line_number":160,"context_line":"                    self.disable_dhcp_helper(deleted_id)"},{"line_number":161,"context_line":"                except Exception:"},{"line_number":162,"context_line":"                    self.needs_resync \u003d True"},{"line_number":163,"context_line":"                    LOG.exception(_(\u0027Unable to sync network state on deleted \u0027"},{"line_number":164,"context_line":"                                    \u0027network %s\u0027) % deleted_id)"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FhEA%3D","line":162,"in_reply_to":"AAAAQn%2F%2Fhi8%3D","updated":"2013-07-30 19:05:39.000000000","message":"Yes, the original function had two issues with it: 1.) this function should not abort disabling remaining networks once there is an error with disabling the current one.  and 2.) it continues indefinitely on bad networks.  \n\nThis change addresses only the first issue.  The other issue could be addressed by another bugfix?  I am thinking a disable may only be retried a number of times (a configurable) on a network before giving up.","commit_id":"3d5bec962c1e5bb923107f54585c94a9b24f2d30"}]}