)]}'
{"neutron/agent/ovsdb/impl_idl.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"35fb15af1ed8ccd440658f0ebec965b8c26b00ef","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        return cmd.ListIfacesCommand(self, bridge)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"class NeutronOvsdbIdl(OvsdbIdl):"},{"line_number":286,"context_line":"    def __init__(self, context):"},{"line_number":287,"context_line":"        vlog.use_oslo_logger()"},{"line_number":288,"context_line":"        super(NeutronOvsdbIdl, self).__init__(context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_4192e858","line":285,"updated":"2016-10-26 08:26:55.000000000","message":"I know that DragonFlow subclasses OvsdbIdl, so I broke this out into a separate class. Another option would be to add a use_oslo_logger\u003dFalse argument to OvsdbIdl\u0027s __init__() if the logger override is something other projects are potentially interested in, but still want to make it optional.\n\nIf we do keep NeutronOvsdbIdl, it might make sense in another patch to have transaction() above return the a vanilla Transaction object, and NeutronOvsdbIdl.transaction return a NeutronOVSDBTransaction. OVN calls Transaction directly.","commit_id":"93104d3d703153cb99d67dfe62097f8332d1af97"}],"neutron/agent/ovsdb/native/connection.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d97d4b085020b2d85061a674c9d8cdd66c056dfe","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.agent.ovsdb.native import idlutils"},{"line_number":26,"context_line":"from neutron.agent.ovsdb.native import vlog"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"vlog.use_neutron_logger()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TransactionQueue(Queue.Queue, object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_226c0008","line":28,"updated":"2016-10-17 23:02:07.000000000","message":"I should probably find a way to make this optional/not happen at import in case some project like ovn/dragonflow want to do things differently.","commit_id":"c27ed618a1a15792ec2b1d15e94757297a2d962c"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"cfa4b274dd31d1d374adcc6b09609b7e740a503a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.agent.ovsdb.native import idlutils"},{"line_number":26,"context_line":"from neutron.agent.ovsdb.native import vlog"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"vlog.use_neutron_logger()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TransactionQueue(Queue.Queue, object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_ffab251b","line":28,"in_reply_to":"fa6399be_226c0008","updated":"2016-10-26 01:50:31.000000000","message":"+1","commit_id":"c27ed618a1a15792ec2b1d15e94757297a2d962c"}],"neutron/agent/ovsdb/native/vlog.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bdf11195807a1285a5c4ef23a226d9a904cb9f2e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # NOTE(twilson) Replace functions directly instead of subclassing so that"},{"line_number":25,"context_line":"    # debug messages contain the correct function/filename/line information"},{"line_number":26,"context_line":"    idl.vlog.emer \u003d LOG.critical"},{"line_number":27,"context_line":"    idl.vlog.err \u003d LOG.error"},{"line_number":28,"context_line":"    idl.vlog.warn \u003d LOG.warning"},{"line_number":29,"context_line":"    idl.vlog.info \u003d LOG.info"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_71aecce8","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":7},"updated":"2016-10-17 20:48:26.000000000","message":"Maybe we could set that for more loggers like poller, jsonrpc, stream and reconnect too? Or would that make the ovs-agent logs way too chatty?","commit_id":"c27ed618a1a15792ec2b1d15e94757297a2d962c"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"777fd559594e6ade2593de97d2a05d623d3d5ced","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    # NOTE(twilson) Replace functions directly instead of subclassing so that"},{"line_number":25,"context_line":"    # debug messages contain the correct function/filename/line information"},{"line_number":26,"context_line":"    idl.vlog.emer \u003d LOG.critical"},{"line_number":27,"context_line":"    idl.vlog.err \u003d LOG.error"},{"line_number":28,"context_line":"    idl.vlog.warn \u003d LOG.warning"},{"line_number":29,"context_line":"    idl.vlog.info \u003d LOG.info"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_e24be85d","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":7},"in_reply_to":"fa6399be_71aecce8","updated":"2016-10-17 22:20:41.000000000","message":"We could just by setting overriding the methods directly on ovs.vlog.Vlog. The poller is pretty chatty. Here\u0027s a grep of just the vlogs from running TestOVSAgent.test_no_stale_flows_after_port_delete.\n\nhttp://paste.openstack.org/show/586048/\n\nThe unexpected response stuff appears to be because of the abort_all() calls in Idl.run if the cur_cfg has changed. The type errors should be fixed by https://review.openstack.org/#/c/383540/.\n\nMaybe we could add an [ovs]ovsdb_native_log_level config option if the above is too much. It\u0027d be really helpful to have for debugging the native ovsdb impl.","commit_id":"c27ed618a1a15792ec2b1d15e94757297a2d962c"}]}
