)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b5050dba4a8f801558e2e9818bacc7d206c5937c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:28:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Add a dl_type match for action\u003dct flows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9040d8c50ee30f5daef7ea931a28cd0cf7855f3e"},{"line_number":10,"context_line":"Closes-bug: #1634757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_f96c450a","line":7,"updated":"2016-10-19 08:11:57.000000000","message":"Do you have more information about this bug (I didn\u0027t find mentioning dl_type is required for ct action in man page)?\nIs the bug reproducible on gate so we can be sure this patch fixes the issue?\nIs dl_type required only for commit or also for lookups?","commit_id":"44dfc2ed355f264e78d3ce9bbfaa2259a272bedc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"171a8bc84154292747507db024e61bc149875790","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:28:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Add a dl_type match for action\u003dct flows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9040d8c50ee30f5daef7ea931a28cd0cf7855f3e"},{"line_number":10,"context_line":"Closes-bug: #1634757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_8a012509","line":7,"in_reply_to":"fa6399be_7f71f543","updated":"2016-10-19 09:22:08.000000000","message":"So I looked at ovs and not sure I understand it correctly.\nThe condition is  (flow-\u003ect_state \u0026 CS_INVALID \u0026\u0026 oc-\u003eflags \u0026 NX_CT_F_COMMIT). Doesn\u0027t it mean that the ct state must be invalid and action is ct(commit)?\n\nIf the condition applies to !dl_type_is_ip_any(flow-\u003edl_type) then it seems we should also consider lookup ct actions.","commit_id":"44dfc2ed355f264e78d3ce9bbfaa2259a272bedc"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"0293b538d8db107b2bb3cb97fb749c4bf2e41da9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:28:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Add a dl_type match for action\u003dct flows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9040d8c50ee30f5daef7ea931a28cd0cf7855f3e"},{"line_number":10,"context_line":"Closes-bug: #1634757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_dd76623d","line":7,"in_reply_to":"fa6399be_8a012509","updated":"2016-10-20 05:27:10.000000000","message":"What is lookup ct action?\n\nI think I\u0027ve added dl_type to all actions\u003dct flows in order to satisfy the dl_type_is_ip_any(...) conditional.","commit_id":"44dfc2ed355f264e78d3ce9bbfaa2259a272bedc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"393b652607511080bfbc149b55de0becfc9d70c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:28:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Add a dl_type match for action\u003dct flows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9040d8c50ee30f5daef7ea931a28cd0cf7855f3e"},{"line_number":10,"context_line":"Closes-bug: #1634757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_e41706ec","line":7,"in_reply_to":"fa6399be_dd76623d","updated":"2016-10-20 09:19:17.000000000","message":"For example this: https://github.com/openstack/neutron/blob/master/neutron/agent/linux/openvswitch_firewall/firewall.py#L410\n\nbut I see all such rules already have dl_type, so we\u0027re good :) also tests provide this patch really works with new ovs.","commit_id":"44dfc2ed355f264e78d3ce9bbfaa2259a272bedc"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"148020350e962ca6013069502349b173af32cfed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:28:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Add a dl_type match for action\u003dct flows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9040d8c50ee30f5daef7ea931a28cd0cf7855f3e"},{"line_number":10,"context_line":"Closes-bug: #1634757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_7f71f543","line":7,"in_reply_to":"fa6399be_f96c450a","updated":"2016-10-19 08:52:47.000000000","message":"Please check the lp bug page for the ovs commit that triggers this problem.\n\nOvs is now requiring any actions\u003dct flows to have a dl_type match field.","commit_id":"44dfc2ed355f264e78d3ce9bbfaa2259a272bedc"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"87f968f8a1715f1740501e9e4aacffe8d02be1b3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:28:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Add a dl_type match for action\u003dct flows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9040d8c50ee30f5daef7ea931a28cd0cf7855f3e"},{"line_number":10,"context_line":"Closes-bug: #1634757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_d9c94127","line":8,"updated":"2016-10-19 08:09:53.000000000","message":"it is better to add some commit message for this patch","commit_id":"44dfc2ed355f264e78d3ce9bbfaa2259a272bedc"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"148020350e962ca6013069502349b173af32cfed","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:28:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Add a dl_type match for action\u003dct flows"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9040d8c50ee30f5daef7ea931a28cd0cf7855f3e"},{"line_number":10,"context_line":"Closes-bug: #1634757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_2472107d","line":8,"in_reply_to":"fa6399be_d9c94127","updated":"2016-10-19 08:52:47.000000000","message":"Done","commit_id":"44dfc2ed355f264e78d3ce9bbfaa2259a272bedc"}]}