)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7ebbfb5937195abd4574bdf0673682ed3af4124f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shihanzhang \u003cshihanzhang@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:16:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean conntrack entries with a separate thead worker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we delete a security group memeber, the l2 agents will clean"},{"line_number":10,"context_line":"related conntrack entries, but using CLI command \u0027conntrack\u0027 in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_e172a6e2","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":45},"updated":"2016-10-19 21:30:04.000000000","message":"thread","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"d0606537fcbdba6c393f2dec54be4936fd1371e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shihanzhang \u003cshihanzhang@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-19 15:16:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean conntrack entries with a separate thead worker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we delete a security group memeber, the l2 agents will clean"},{"line_number":10,"context_line":"related conntrack entries, but using CLI command \u0027conntrack\u0027 in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_4cbf0660","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":45},"in_reply_to":"fa6399be_e172a6e2","updated":"2016-10-20 01:10:24.000000000","message":"Done","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7ebbfb5937195abd4574bdf0673682ed3af4124f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean conntrack entries with a separate thead worker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we delete a security group memeber, the l2 agents will clean"},{"line_number":10,"context_line":"related conntrack entries, but using CLI command \u0027conntrack\u0027 in"},{"line_number":11,"context_line":"l2 agents is expensive, and it also slows down regular dataplane"},{"line_number":12,"context_line":"wiring."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_217d7eb1","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":39},"updated":"2016-10-19 21:30:04.000000000","message":"member","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"d0606537fcbdba6c393f2dec54be4936fd1371e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean conntrack entries with a separate thead worker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we delete a security group memeber, the l2 agents will clean"},{"line_number":10,"context_line":"related conntrack entries, but using CLI command \u0027conntrack\u0027 in"},{"line_number":11,"context_line":"l2 agents is expensive, and it also slows down regular dataplane"},{"line_number":12,"context_line":"wiring."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_6cb68a8b","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":39},"in_reply_to":"fa6399be_217d7eb1","updated":"2016-10-20 01:10:24.000000000","message":"Done","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7ebbfb5937195abd4574bdf0673682ed3af4124f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"related conntrack entries, but using CLI command \u0027conntrack\u0027 in"},{"line_number":11,"context_line":"l2 agents is expensive, and it also slows down regular dataplane"},{"line_number":12,"context_line":"wiring."},{"line_number":13,"context_line":"This patch adds a separate thead worker to clean the conntrack entries."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4c5d0f3174fc8344cf79a4ba957f0a0180d092a0"},{"line_number":16,"context_line":"Closes-bug: #1513765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_614db698","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":32},"updated":"2016-10-19 21:30:04.000000000","message":"thread","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"d0606537fcbdba6c393f2dec54be4936fd1371e6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"related conntrack entries, but using CLI command \u0027conntrack\u0027 in"},{"line_number":11,"context_line":"l2 agents is expensive, and it also slows down regular dataplane"},{"line_number":12,"context_line":"wiring."},{"line_number":13,"context_line":"This patch adds a separate thead worker to clean the conntrack entries."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4c5d0f3174fc8344cf79a4ba957f0a0180d092a0"},{"line_number":16,"context_line":"Closes-bug: #1513765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_8cb91e7c","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":32},"in_reply_to":"fa6399be_614db698","updated":"2016-10-20 01:10:24.000000000","message":"Done","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"556f646157f70f6b26179e616ccfe79530b9d437","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        for id in deleted_sg_ids:"},{"line_number":822,"context_line":"            self.devices_with_updated_sg_members.pop(id, None)"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    def _remove_conntrack_entries_from_sg_updates(self):"},{"line_number":825,"context_line":"        def _clean_conntrack_entries():"},{"line_number":826,"context_line":"            self._clean_deleted_sg_rule_conntrack_entries()"},{"line_number":827,"context_line":"            self._clean_updated_sg_member_conntrack_entries()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_7cb9f82d","line":824,"updated":"2016-10-19 12:21:31.000000000","message":"Can we follow l3 agent approach [1]\n\n1) We define a deviceUpdate, like RouterUpdate[2] which holds all needed info for removing conntrac entries like _pre_defer_filtered_ports, _pre_defer_unfiltered_ports, pre_sg_members, pre_sg_rules,...\n\n2) And a queue like RouterProcessingQueue[3], which holds these device updates\n\n3) In filter_defer_apply_off, we create deviceUpdate with needed info and add it to the queue, like the same way we do in l3 agent [4] i.e\n   update \u003d queue.RouterUpdate(\n            r[\u0027id\u0027],\n            queue.PRIORITY_SYNC_ROUTERS_TASK,\n            router\u003dr,\n            timestamp\u003dtimestamp)\n   self._queue.add(update)\n4) Green pool threads([1] and [5]) will be listening on the queue, will read the info and delete conntrack entries.\n\nWhat do you think?\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L526\n[2] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_processing_queue.py#L29\n[3] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/router_processing_queue.py#L140\n[4] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L583\n[5] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L472","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"d0606537fcbdba6c393f2dec54be4936fd1371e6","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        for id in deleted_sg_ids:"},{"line_number":822,"context_line":"            self.devices_with_updated_sg_members.pop(id, None)"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"    def _remove_conntrack_entries_from_sg_updates(self):"},{"line_number":825,"context_line":"        def _clean_conntrack_entries():"},{"line_number":826,"context_line":"            self._clean_deleted_sg_rule_conntrack_entries()"},{"line_number":827,"context_line":"            self._clean_updated_sg_member_conntrack_entries()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_6c3beaeb","line":824,"in_reply_to":"fa6399be_7cb9f82d","updated":"2016-10-20 01:10:24.000000000","message":"venkata antil, thx for your suggestion, i think your idea is same with kevin, i will try it","commit_id":"d98a085032be39f23a3e7f979d78e4131a69e33b"}]}