)]}'
{"neutron/plugins/plumgrid/drivers/fake_plumlib.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b3250def6407b0f5815558938c2abc97683b91ed","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Plumlib():"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self):"},{"line_number":27,"context_line":"        LOG.info(\u0027Python PLUMgrid Fake Library Started \u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Ff2M%3D","line":24,"updated":"2013-07-30 07:52:59.000000000","message":"A brief description would be great to understand the function of this class","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"038959e45748c4b3058a34f0545c7df72fdc9728","unresolved":false,"context_lines":[{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class Plumlib():"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def __init__(self):"},{"line_number":27,"context_line":"        LOG.info(\u0027Python PLUMgrid Fake Library Started \u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fe9M%3D","line":24,"in_reply_to":"AAAAQn%2F%2Ff2M%3D","updated":"2013-07-30 13:49:14.000000000","message":"Done","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"}],"neutron/plugins/plumgrid/drivers/plumlib.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b3250def6407b0f5815558938c2abc97683b91ed","unresolved":false,"context_lines":[{"line_number":21,"context_line":"to the PLUMgrid Network Management System called Director"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from plumgridlib import plumlib"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Ff2I%3D","line":24,"updated":"2013-07-30 07:52:59.000000000","message":"should this be added to requirements.txt?","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"038959e45748c4b3058a34f0545c7df72fdc9728","unresolved":false,"context_lines":[{"line_number":21,"context_line":"to the PLUMgrid Network Management System called Director"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from plumgridlib import plumlib"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fe9o%3D","line":24,"in_reply_to":"AAAAQn%2F%2Ff2I%3D","updated":"2013-07-30 13:49:14.000000000","message":"only open source tools/libraries are there, this library is not YET open sourced","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b3250def6407b0f5815558938c2abc97683b91ed","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Plumlib(object):"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    Class PLUMgrid Python Library"},{"line_number":34,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Ff1Y%3D","line":31,"updated":"2013-07-30 07:52:59.000000000","message":"What is the purpose of this wrapper around plumlib. Can plumlib be used directly where it is needed?","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"038959e45748c4b3058a34f0545c7df72fdc9728","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Plumlib(object):"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    Class PLUMgrid Python Library"},{"line_number":34,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fe9U%3D","line":31,"in_reply_to":"AAAAQn%2F%2Ff1Y%3D","updated":"2013-07-30 13:49:14.000000000","message":"mostly for controlling different versions of PLUMlib library and also for unit testing, this is why its needed","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b3250def6407b0f5815558938c2abc97683b91ed","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Plumlib(object):"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    Class PLUMgrid Python Library"},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Ff2A%3D","line":32,"updated":"2013-07-30 07:52:59.000000000","message":"minor nit: \n\n\"\"\"A one line docstring looks like this and ends in a period.\"\"\"","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"038959e45748c4b3058a34f0545c7df72fdc9728","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class Plumlib(object):"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":"    Class PLUMgrid Python Library"},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fe9Q%3D","line":32,"in_reply_to":"AAAAQn%2F%2Ff2A%3D","updated":"2013-07-30 13:49:14.000000000","message":"Done","commit_id":"febdb0a4547a4c5c1342667b734de4c9614e7814"}],"neutron/plugins/plumgrid/plumgrid_plugin/plumgrid_plugin.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9b19a4221a7d50c65d44c1afc4f83f915dda0056","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Neutron Plug-in for PLUMgrid Virtual Networking Infrastructure (VNI)"},{"line_number":20,"context_line":"This plugin will forward authenticated REST API calls"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fl3Q%3D","line":17,"updated":"2013-07-26 23:51:25.000000000","message":"This is not a new file, It was not my intention to delete and create a new one, when I did the renaming something went wrong. My apologies!","commit_id":"e6af5c5d3841efec966d12d0d22087ff1b78c66e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f6e385846fdbedd795c7e83c6830186faad28a51","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # PLUMgrid Director configuration"},{"line_number":67,"context_line":"        # TODO(Edgar) These are placeholders for next PLUMgrid release"},{"line_number":68,"context_line":"        cfg.CONF.PLUMgridDirector.username"},{"line_number":69,"context_line":"        cfg.CONF.PLUMgridDirector.password"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Plugin DB initialization"},{"line_number":72,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Flsk%3D","line":69,"updated":"2013-07-27 02:01:45.000000000","message":"Understand that username and password are not supported at the backend yet, but L68-69 seem odd. Would recommend removing them.","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # PLUMgrid Director configuration"},{"line_number":67,"context_line":"        # TODO(Edgar) These are placeholders for next PLUMgrid release"},{"line_number":68,"context_line":"        cfg.CONF.PLUMgridDirector.username"},{"line_number":69,"context_line":"        cfg.CONF.PLUMgridDirector.password"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # Plugin DB initialization"},{"line_number":72,"context_line":"        db.configure_db()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiIU%3D","line":69,"in_reply_to":"AAAAQn%2F%2Flsk%3D","updated":"2013-07-29 22:31:43.000000000","message":"ok, I will remove them","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ee6e42a5514e401eee935431b36781da9e91679b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # PLUMgrid Director info validation"},{"line_number":86,"context_line":"        LOG.info(_(\u0027Neutron PLUMgrid Director: %s\u0027), director_plumgrid)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        if not director_plumgrid:"},{"line_number":89,"context_line":"            raise SystemExit(_(\u0027Neutron PLUMgrid Director: \u0027"},{"line_number":90,"context_line":"                               \u0027Director value is missing in config file\u0027))"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FjnA%3D","line":88,"updated":"2013-07-29 09:35:10.000000000","message":"Since director_server has a default value in config (\u0027localhost\u0027) is there a case when director_plumgrid is empty ?","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # PLUMgrid Director info validation"},{"line_number":86,"context_line":"        LOG.info(_(\u0027Neutron PLUMgrid Director: %s\u0027), director_plumgrid)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        if not director_plumgrid:"},{"line_number":89,"context_line":"            raise SystemExit(_(\u0027Neutron PLUMgrid Director: \u0027"},{"line_number":90,"context_line":"                               \u0027Director value is missing in config file\u0027))"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiIQ%3D","line":88,"in_reply_to":"AAAAQn%2F%2FjnA%3D","updated":"2013-07-29 22:31:43.000000000","message":"make sense, I will remove this conditional","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f6e385846fdbedd795c7e83c6830186faad28a51","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            raise SystemExit(_(\u0027Neutron PLUMgrid Director: \u0027"},{"line_number":90,"context_line":"                               \u0027Director value is missing in config file\u0027))"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._plumlib \u003d importutils.import_object(PLUM_DRIVER)"},{"line_number":93,"context_line":"        self._plumlib.director_conn(director_plumgrid, director_port, timeout)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def create_network(self, context, network):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FlsU%3D","line":92,"updated":"2013-07-27 02:01:45.000000000","message":"It seems that the driver is statically defined (L39), so why load it dynamically?","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            raise SystemExit(_(\u0027Neutron PLUMgrid Director: \u0027"},{"line_number":90,"context_line":"                               \u0027Director value is missing in config file\u0027))"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self._plumlib \u003d importutils.import_object(PLUM_DRIVER)"},{"line_number":93,"context_line":"        self._plumlib.director_conn(director_plumgrid, director_port, timeout)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def create_network(self, context, network):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiIE%3D","line":92,"in_reply_to":"AAAAQn%2F%2FlsU%3D","updated":"2013-07-29 22:31:43.000000000","message":"I will ask to bare with me on this, I am planning to make it dynamically changed in next commit","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f6e385846fdbedd795c7e83c6830186faad28a51","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                self._plumlib.create_network(tenant_id, net_db)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                err_message \u003d _(\"PLUMgrid Director communication failed\")"},{"line_number":120,"context_line":"                LOG.Exception(err_message)"},{"line_number":121,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Flro%3D","line":119,"updated":"2013-07-27 02:01:45.000000000","message":"nit: Seems like the error message is constant across the module, why not just create a constant or make it a part of the exception. Will save some strings being created. :-)","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                self._plumlib.create_network(tenant_id, net_db)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                err_message \u003d _(\"PLUMgrid Director communication failed\")"},{"line_number":120,"context_line":"                LOG.Exception(err_message)"},{"line_number":121,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiEU%3D","line":119,"in_reply_to":"AAAAQn%2F%2Flro%3D","updated":"2013-07-29 22:31:43.000000000","message":"Done","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ee6e42a5514e401eee935431b36781da9e91679b","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                err_message \u003d _(\"PLUMgrid Director communication failed\")"},{"line_number":120,"context_line":"                LOG.Exception(err_message)"},{"line_number":121,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # return created network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fjmg%3D","line":120,"updated":"2013-07-29 09:35:10.000000000","message":"LOG.exception? here and everywhere below","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                err_message \u003d _(\"PLUMgrid Director communication failed\")"},{"line_number":120,"context_line":"                LOG.Exception(err_message)"},{"line_number":121,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        # return created network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiIA%3D","line":120,"in_reply_to":"AAAAQn%2F%2Fjmg%3D","updated":"2013-07-29 22:31:43.000000000","message":"Done","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ee6e42a5514e401eee935431b36781da9e91679b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                LOG.Exception(err_message)"},{"line_number":176,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def get_network(self, context, id, fields\u003dNone):"},{"line_number":179,"context_line":"        session \u003d context.session"},{"line_number":180,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":181,"context_line":"            net \u003d super(NeutronPluginPLUMgridV2, self).get_network(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fjls%3D","line":178,"updated":"2013-07-29 09:35:10.000000000","message":"what is the point of overriding NeutronDbPluginV2.get_network()?","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                LOG.Exception(err_message)"},{"line_number":176,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def get_network(self, context, id, fields\u003dNone):"},{"line_number":179,"context_line":"        session \u003d context.session"},{"line_number":180,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":181,"context_line":"            net \u003d super(NeutronPluginPLUMgridV2, self).get_network(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiH0%3D","line":178,"in_reply_to":"AAAAQn%2F%2Fjls%3D","updated":"2013-07-29 22:31:43.000000000","message":"removed","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ee6e42a5514e401eee935431b36781da9e91679b","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                                                                   id, None)"},{"line_number":183,"context_line":"        return self._fields(net, fields)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":186,"context_line":"                     sorts\u003dNone,"},{"line_number":187,"context_line":"                     limit\u003dNone, marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":188,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fjlo%3D","line":185,"updated":"2013-07-29 09:35:10.000000000","message":"ditto","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                                                                   id, None)"},{"line_number":183,"context_line":"        return self._fields(net, fields)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":186,"context_line":"                     sorts\u003dNone,"},{"line_number":187,"context_line":"                     limit\u003dNone, marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":188,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiHo%3D","line":185,"in_reply_to":"AAAAQn%2F%2Fjlo%3D","updated":"2013-07-29 22:31:43.000000000","message":"same answer","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ee6e42a5514e401eee935431b36781da9e91679b","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                LOG.Exception(err_message)"},{"line_number":288,"context_line":"                raise plum_excep.PLUMgridException(err_message)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":291,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":292,"context_line":"            port_db \u003d super(NeutronPluginPLUMgridV2,"},{"line_number":293,"context_line":"                            self).get_port(context, id, fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FjlY%3D","line":290,"updated":"2013-07-29 09:35:10.000000000","message":"ditto","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                LOG.Exception(err_message)"},{"line_number":288,"context_line":"                raise plum_excep.PLUMgridException(err_message)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def get_port(self, context, id, fields\u003dNone):"},{"line_number":291,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":292,"context_line":"            port_db \u003d super(NeutronPluginPLUMgridV2,"},{"line_number":293,"context_line":"                            self).get_port(context, id, fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiHk%3D","line":290,"in_reply_to":"AAAAQn%2F%2FjlY%3D","updated":"2013-07-29 22:31:43.000000000","message":"I need to send the proper port information with the VIF driver for PLUMgrid which is IOVISOR","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ee6e42a5514e401eee935431b36781da9e91679b","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            self._port_viftype_binding(context, port_db)"},{"line_number":296,"context_line":"        return self._fields(port_db, fields)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":299,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":300,"context_line":"            ports_db \u003d super(NeutronPluginPLUMgridV2,"},{"line_number":301,"context_line":"                             self).get_ports(context, filters, fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FjlQ%3D","line":298,"updated":"2013-07-29 09:35:10.000000000","message":"ditto","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            self._port_viftype_binding(context, port_db)"},{"line_number":296,"context_line":"        return self._fields(port_db, fields)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def get_ports(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":299,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":300,"context_line":"            ports_db \u003d super(NeutronPluginPLUMgridV2,"},{"line_number":301,"context_line":"                             self).get_ports(context, filters, fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiHg%3D","line":298,"in_reply_to":"AAAAQn%2F%2FjlQ%3D","updated":"2013-07-29 22:31:43.000000000","message":"same answer","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"2b3ea4bed5e62772193e12e8e6e76b557e4a4e63","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            s \u003d subnet[\u0027subnet\u0027]"},{"line_number":290,"context_line":"            ipnet \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"            #PLUMgrid Director reserves the last IP address for GW"},{"line_number":293,"context_line":"            #when is not defined"},{"line_number":294,"context_line":"            if s[\u0027gateway_ip\u0027] is attributes.ATTR_NOT_SPECIFIED:"},{"line_number":295,"context_line":"                gw_ip \u003d str(netaddr.IPAddress(ipnet.last - 1))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZfA%3D","line":292,"updated":"2013-07-31 19:31:06.000000000","message":"Minor nit: Space after \"#\" in this comment and in other places in this file.","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9f8c3182647299361fd7ccedda52a2779efcc68e","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            s \u003d subnet[\u0027subnet\u0027]"},{"line_number":290,"context_line":"            ipnet \u003d netaddr.IPNetwork(s[\u0027cidr\u0027])"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"            #PLUMgrid Director reserves the last IP address for GW"},{"line_number":293,"context_line":"            #when is not defined"},{"line_number":294,"context_line":"            if s[\u0027gateway_ip\u0027] is attributes.ATTR_NOT_SPECIFIED:"},{"line_number":295,"context_line":"                gw_ip \u003d str(netaddr.IPAddress(ipnet.last - 1))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZVQ%3D","line":292,"in_reply_to":"AAAAQn%2F%2FZfA%3D","updated":"2013-07-31 20:53:57.000000000","message":"Done","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"2b3ea4bed5e62772193e12e8e6e76b557e4a4e63","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"            #PLUMgrid Director reserves the last IP address for GW"},{"line_number":293,"context_line":"            #when is not defined"},{"line_number":294,"context_line":"            if s[\u0027gateway_ip\u0027] is attributes.ATTR_NOT_SPECIFIED:"},{"line_number":295,"context_line":"                gw_ip \u003d str(netaddr.IPAddress(ipnet.last - 1))"},{"line_number":296,"context_line":"                subnet[\u0027subnet\u0027][\u0027gateway_ip\u0027] \u003d gw_ip"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZds%3D","line":294,"updated":"2013-07-31 19:31:06.000000000","message":"Do you want a unit test to verify this?","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9f8c3182647299361fd7ccedda52a2779efcc68e","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"            #PLUMgrid Director reserves the last IP address for GW"},{"line_number":293,"context_line":"            #when is not defined"},{"line_number":294,"context_line":"            if s[\u0027gateway_ip\u0027] is attributes.ATTR_NOT_SPECIFIED:"},{"line_number":295,"context_line":"                gw_ip \u003d str(netaddr.IPAddress(ipnet.last - 1))"},{"line_number":296,"context_line":"                subnet[\u0027subnet\u0027][\u0027gateway_ip\u0027] \u003d gw_ip"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZU8%3D","line":294,"in_reply_to":"AAAAQn%2F%2FZds%3D","updated":"2013-07-31 20:53:57.000000000","message":"will be covered by the core unit tests","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"2b3ea4bed5e62772193e12e8e6e76b557e4a4e63","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                subnet[\u0027subnet\u0027][\u0027gateway_ip\u0027] \u003d gw_ip"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            #PLUMgrid reserves the first IP"},{"line_number":299,"context_line":"            if s[\u0027allocation_pools\u0027] \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":300,"context_line":"                allocation_pool \u003d self._allocate_pools_for_subnet(context, s)"},{"line_number":301,"context_line":"                subnet[\u0027subnet\u0027][\u0027allocation_pools\u0027] \u003d allocation_pool"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZdk%3D","line":299,"updated":"2013-07-31 19:31:06.000000000","message":"Should you write a unit test to verify this?","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9f8c3182647299361fd7ccedda52a2779efcc68e","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                subnet[\u0027subnet\u0027][\u0027gateway_ip\u0027] \u003d gw_ip"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"            #PLUMgrid reserves the first IP"},{"line_number":299,"context_line":"            if s[\u0027allocation_pools\u0027] \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":300,"context_line":"                allocation_pool \u003d self._allocate_pools_for_subnet(context, s)"},{"line_number":301,"context_line":"                subnet[\u0027subnet\u0027][\u0027allocation_pools\u0027] \u003d allocation_pool"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZVI%3D","line":299,"in_reply_to":"AAAAQn%2F%2FZdk%3D","updated":"2013-07-31 20:53:57.000000000","message":"added in next ptach","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"}],"neutron/tests/unit/plumgrid/test_plumgrid_plugin.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f6e385846fdbedd795c7e83c6830186faad28a51","unresolved":false,"context_lines":[{"line_number":70,"context_line":"class TestPlumgridPluginPortsV2(test_plugin.TestPortsV2,"},{"line_number":71,"context_line":"                                PLUMgridPluginV2TestCase):"},{"line_number":72,"context_line":"    def test_range_allocation(self):"},{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class TestPlumgridPluginSubnetsV2(test_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FltE%3D","line":73,"updated":"2013-07-27 02:01:45.000000000","message":"It will be preferable to use skipTest instead. BTW, just curious, is there a reason for not running these tests?","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9cfead136dd62f7b3efa276a3438bc1951bdbbb0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"class TestPlumgridPluginPortsV2(test_plugin.TestPortsV2,"},{"line_number":71,"context_line":"                                PLUMgridPluginV2TestCase):"},{"line_number":72,"context_line":"    def test_range_allocation(self):"},{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class TestPlumgridPluginSubnetsV2(test_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FhNk%3D","line":73,"in_reply_to":"AAAAQn%2F%2FltE%3D","updated":"2013-07-29 22:31:43.000000000","message":"Good suggestion!\nThis plugin uses its own allocation mechanism, the first IP address is always reserved for DHCP server.","commit_id":"12d1cffcb3c437508d5b2578cc854475e2be5ee2"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"2b3ea4bed5e62772193e12e8e6e76b557e4a4e63","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            director_plumgrid \u003d FAKE_DIRECTOR"},{"line_number":45,"context_line":"            director_port \u003d FAKE_PORT"},{"line_number":46,"context_line":"            timeout \u003d FAKE_TIMEOUT"},{"line_number":47,"context_line":"            #self.plum_driver \u003d importutils.import_object(PLUM_DRIVER)"},{"line_number":48,"context_line":"            self._plumlib \u003d importutils.import_object(PLUM_DRIVER)"},{"line_number":49,"context_line":"            self._plumlib.director_conn(director_plumgrid,"},{"line_number":50,"context_line":"                                        director_port, timeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZfs%3D","line":47,"updated":"2013-07-31 19:31:06.000000000","message":"Maybe remove this rather than leave it commented out.","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"9f8c3182647299361fd7ccedda52a2779efcc68e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            director_plumgrid \u003d FAKE_DIRECTOR"},{"line_number":45,"context_line":"            director_port \u003d FAKE_PORT"},{"line_number":46,"context_line":"            timeout \u003d FAKE_TIMEOUT"},{"line_number":47,"context_line":"            #self.plum_driver \u003d importutils.import_object(PLUM_DRIVER)"},{"line_number":48,"context_line":"            self._plumlib \u003d importutils.import_object(PLUM_DRIVER)"},{"line_number":49,"context_line":"            self._plumlib.director_conn(director_plumgrid,"},{"line_number":50,"context_line":"                                        director_port, timeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FZVU%3D","line":47,"in_reply_to":"AAAAQn%2F%2FZfs%3D","updated":"2013-07-31 20:53:57.000000000","message":"good catch, will do!","commit_id":"145ec329cfe26b0a17091bfb1275b1122db1dac8"}]}
