)]}'
{"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"46e6fed9783dc4669185d23b7272eb7f1990836d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            eventlet.sleep(0.1)"},{"line_number":194,"context_line":"            if self.dhcp_ready_ports:"},{"line_number":195,"context_line":"                ports_to_send \u003d self.dhcp_ready_ports"},{"line_number":196,"context_line":"                self.dhcp_ready_ports \u003d set()"},{"line_number":197,"context_line":"                try:"},{"line_number":198,"context_line":"                    self.plugin_rpc.dhcp_ready_on_ports(ports_to_send)"},{"line_number":199,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_a8dc8319","side":"PARENT","line":196,"updated":"2016-10-20 21:00:49.000000000","message":"This is not a simplification. You are changing the behavior of this notification loop. We want to notify the server only once for each port that has a reservation setup. So we set aside the ports we are going to notify the server about in this iteration in ports_to_send and then we empty self.dhcp_ready_ports, because we don\u0027t want to send notifications again for ports in ports_to_send. Only if we fail notifying the server, then we put the ports in ports_to_send back into self.dhcp_ready_ports (see L214)","commit_id":"9a0d2c46dfa5f7bd0ddeb79fec80bb9b2265bbcb"}]}