)]}'
{"doc/source/devref/api_layer.rst":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"30e02971a09071e6b9e831f8927dd27c5342dcb5","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Enable"},{"line_number":91,"context_line":"~~~~~~"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"To enable pecan in neutron-server, just set the following option in the config:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. code-block:: ini"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_f4ac2c37","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":79},"updated":"2016-10-25 23:58:25.000000000","message":"this info can be located here as well http://docs-draft.openstack.org/12/390412/1/check/gate-neutron-docs-ubuntu-xenial/11f848a//doc/build/html/devref/api_layer.html#enable either a link to it should be added, or it should more details like which conf, i see this parameter in neutron.conf wouldn\u0027t it be better saying specifically ?","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Enable"},{"line_number":91,"context_line":"~~~~~~"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"To enable pecan in neutron-server, just set the following option in the config:"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. code-block:: ini"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_ceb13549","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":79},"in_reply_to":"da6895a0_f4ac2c37","updated":"2016-11-01 20:18:17.000000000","message":"isn\u0027t that link just the doc job for this review?\n\nI don\u0027t think I should mention what config because anyone can name their config whatever they want and use it with --config-file.  As long as neutron-server is started with any config file with this option then it will work.","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5710e2fd54bddc766a4edb34a5ff80a67ed32b4d","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Neutron pecan makes extensive use of pecan hooks.  These hooks are used to do"},{"line_number":157,"context_line":"preprocessing and postprocessing of requests.  Each hook defines either a"},{"line_number":158,"context_line":"before method, after method, or on_error method.  More information about pecan"},{"line_number":159,"context_line":"hooks can be found on the `pecan hooks docs \u003chttp://pecan.readthedocs.io/en/latest/hooks.html\u003e`_."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Neutron pecan hooks are located in the `hooks package \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/hooks\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_e8dc54e6","line":158,"updated":"2016-10-31 20:30:43.000000000","message":"+1","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68b5315a383c6ba105e578e6fbd46fce1935020d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"~~~~~"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Neutron pecan makes extensive use of pecan hooks.  These hooks are used to do"},{"line_number":157,"context_line":"preprocessing and postprocessing of requests.  Each hook defines either a"},{"line_number":158,"context_line":"before method, after method, or on_error method.  More information about pecan"},{"line_number":159,"context_line":"hooks can be found on the `pecan hooks docs \u003chttp://pecan.readthedocs.io/en/latest/hooks.html\u003e`_."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Neutron pecan hooks are located in the `hooks package \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/hooks\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_46fe1c38","line":158,"range":{"start_line":157,"start_character":47,"end_line":158,"end_character":47},"updated":"2016-10-25 10:27:49.000000000","message":"Looking further down, I can see that each hook can define before method, after method and or error method. The wording in this sentence suggests they are mutually exclusive. I would change it to: \"Each hook can define one or several of the following: a before method, an after method and / or an on_error_method\"","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Neutron pecan makes extensive use of pecan hooks.  These hooks are used to do"},{"line_number":157,"context_line":"preprocessing and postprocessing of requests.  Each hook defines either a"},{"line_number":158,"context_line":"before method, after method, or on_error method.  More information about pecan"},{"line_number":159,"context_line":"hooks can be found on the `pecan hooks docs \u003chttp://pecan.readthedocs.io/en/latest/hooks.html\u003e`_."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Neutron pecan hooks are located in the `hooks package \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/hooks\u003e`_."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_0e196d22","line":158,"in_reply_to":"ba5da102_e8dc54e6","updated":"2016-11-01 20:18:17.000000000","message":"Done","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5710e2fd54bddc766a4edb34a5ff80a67ed32b4d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Creates the context object that the neutron pecan controllers will"},{"line_number":171,"context_line":"eventually pass down to the plugins.  It puts the context object into the"},{"line_number":172,"context_line":"pecan request\u0027s own context object under the key \u0027neutron_context\u0027.  They are"},{"line_number":173,"context_line":"not the same context, they are only similar in name."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"ExceptionTranslationHook"},{"line_number":176,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_08d8a8ee","line":173,"updated":"2016-10-31 20:30:43.000000000","message":"Yeah, maybe just a sentence explaining that the pecan context contains a bunch of pecan-specific things like the request object, etc and it\u0027s never passed into the plugins.","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"30e02971a09071e6b9e831f8927dd27c5342dcb5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Before"},{"line_number":168,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Creates the context object that the neutron pecan controllers will"},{"line_number":171,"context_line":"eventually pass down to the plugins.  It puts the context object into the"},{"line_number":172,"context_line":"pecan request\u0027s own context object under the key \u0027neutron_context\u0027.  They are"},{"line_number":173,"context_line":"not the same context, they are only similar in name."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"ExceptionTranslationHook"},{"line_number":176,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_5f2a517f","line":173,"range":{"start_line":170,"start_character":0,"end_line":173,"end_character":52},"updated":"2016-10-25 23:58:25.000000000","message":"could you explain little bit about difference or atleast one difference b/w pecan\u0027s context and neutron_context?","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Creates the context object that the neutron pecan controllers will"},{"line_number":171,"context_line":"eventually pass down to the plugins.  It puts the context object into the"},{"line_number":172,"context_line":"pecan request\u0027s own context object under the key \u0027neutron_context\u0027.  They are"},{"line_number":173,"context_line":"not the same context, they are only similar in name."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"ExceptionTranslationHook"},{"line_number":176,"context_line":"++++++++++++++++++++++++"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_2e1631f1","line":173,"in_reply_to":"ba5da102_08d8a8ee","updated":"2016-11-01 20:18:17.000000000","message":"Done","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5710e2fd54bddc766a4edb34a5ff80a67ed32b4d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"++++++++++++++++++++++++"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"On Error"},{"line_number":179,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Translates internal neutron exceptions into the HTTP exceptions."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_28e72cb1","line":179,"updated":"2016-10-31 20:30:43.000000000","message":"the *corresponding* HTTP exceptions.","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"++++++++++++++++++++++++"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"On Error"},{"line_number":179,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Translates internal neutron exceptions into the HTTP exceptions."},{"line_number":182,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_2eed51ef","line":179,"in_reply_to":"ba5da102_28e72cb1","updated":"2016-11-01 20:18:17.000000000","message":"Done","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5710e2fd54bddc766a4edb34a5ff80a67ed32b4d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"OwnershipValidationHook"},{"line_number":195,"context_line":"+++++++++++++++++++++++"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Before"},{"line_number":198,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"On POSTs, validates that the resource being created has parent\u0027s that are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_48e2a0a0","line":197,"updated":"2016-10-31 20:30:43.000000000","message":"the project_id or tenant_id of the authenticated user if it\u0027s not admin.","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"OwnershipValidationHook"},{"line_number":195,"context_line":"+++++++++++++++++++++++"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Before"},{"line_number":198,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"On POSTs, validates that the resource being created has parent\u0027s that are"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_8eb2dd04","line":197,"in_reply_to":"ba5da102_48e2a0a0","updated":"2016-11-01 20:18:17.000000000","message":"Done","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68b5315a383c6ba105e578e6fbd46fce1935020d","unresolved":false,"context_lines":[{"line_number":197,"context_line":"Before"},{"line_number":198,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"On POSTs, validates that the resource being created has parent\u0027s that are"},{"line_number":201,"context_line":"owned by the project_id or tenant_id."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"QuotaEnforcementHook"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_06fb44c2","line":200,"range":{"start_line":200,"start_character":56,"end_line":200,"end_character":64},"updated":"2016-10-25 10:27:49.000000000","message":"parents","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":197,"context_line":"Before"},{"line_number":198,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"On POSTs, validates that the resource being created has parent\u0027s that are"},{"line_number":201,"context_line":"owned by the project_id or tenant_id."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"QuotaEnforcementHook"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_aeb7a1f3","line":200,"range":{"start_line":200,"start_character":56,"end_line":200,"end_character":64},"in_reply_to":"da6895a0_06fb44c2","updated":"2016-11-01 20:18:17.000000000","message":"Done","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68b5315a383c6ba105e578e6fbd46fce1935020d","unresolved":false,"context_lines":[{"line_number":257,"context_line":"Before"},{"line_number":258,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Verifies that the resource and/or its attributes being modified (POSTs, PUTs,"},{"line_number":261,"context_line":"DELETEs) can do so by checking with the policy engine."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"After"},{"line_number":264,"context_line":"\u0027\u0027\u0027\u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_11438043","line":261,"range":{"start_line":260,"start_character":0,"end_line":261,"end_character":54},"updated":"2016-10-25 10:27:49.000000000","message":"Maybe this would be clearer and simpler:\n\nVerifies with the policy engine that POSTs, PUT\u0027s and DELETE\u0027s can modify the resource and/or its attributes.","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"Before"},{"line_number":258,"context_line":"\u0027\u0027\u0027\u0027\u0027\u0027"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Verifies that the resource and/or its attributes being modified (POSTs, PUTs,"},{"line_number":261,"context_line":"DELETEs) can do so by checking with the policy engine."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"After"},{"line_number":264,"context_line":"\u0027\u0027\u0027\u0027\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_8e801df9","line":261,"range":{"start_line":260,"start_character":0,"end_line":261,"end_character":54},"in_reply_to":"da6895a0_11438043","updated":"2016-11-01 20:18:17.000000000","message":"Done","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"68b5315a383c6ba105e578e6fbd46fce1935020d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"Next, it iterates through all enabled extensions and retrieves the list of"},{"line_number":282,"context_line":"ResourceExtensions returned by every extension\u0027s get_resources method. Then,"},{"line_number":283,"context_line":"it translates each one into a CollectionsController or an ItemController"},{"line_number":284,"context_line":"defined in the `Controllers`_ section and sets that controller to be the"},{"line_number":285,"context_line":"controller for it\u0027s particular resource and/or collection.  This is later"},{"line_number":286,"context_line":"used by the _lookup method in each controller to grab the resource and/or"},{"line_number":287,"context_line":"collection\u0027s controller."},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_b1d49447","line":285,"range":{"start_line":284,"start_character":42,"end_line":285,"end_character":57},"updated":"2016-10-25 10:27:49.000000000","message":"Consider the following simplification:\n\n\"assigns that controller to its particular resource and/or collection\"","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"5117a229b3ac17f35474ad6878f3a179196c495a","unresolved":false,"context_lines":[{"line_number":281,"context_line":"Next, it iterates through all enabled extensions and retrieves the list of"},{"line_number":282,"context_line":"ResourceExtensions returned by every extension\u0027s get_resources method. Then,"},{"line_number":283,"context_line":"it translates each one into a CollectionsController or an ItemController"},{"line_number":284,"context_line":"defined in the `Controllers`_ section and sets that controller to be the"},{"line_number":285,"context_line":"controller for it\u0027s particular resource and/or collection.  This is later"},{"line_number":286,"context_line":"used by the _lookup method in each controller to grab the resource and/or"},{"line_number":287,"context_line":"collection\u0027s controller."},{"line_number":288,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_ae85e107","line":285,"range":{"start_line":284,"start_character":42,"end_line":285,"end_character":57},"in_reply_to":"da6895a0_b1d49447","updated":"2016-11-01 20:18:17.000000000","message":"Done","commit_id":"67fd6703f80c77597d78ee0764cf02fc1c0e02a8"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"9697178e17b6946fb18365c713aa40a9cd0f29c9","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Neutron\u0027s WSGI server is started from the `server module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/server/__init__.py\u003e`_"},{"line_number":42,"context_line":"and the entry point `serve_wsgi` is called to build an instance of the"},{"line_number":43,"context_line":"`NeutronApiService`_, which is then returned to the server module,"},{"line_number":44,"context_line":"which spawns a `Eventlet`_ `GreenPool`_ that will run the WSGI"},{"line_number":45,"context_line":"application and respond to requests from clients."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a6eadb0_e97c41b7","line":43,"updated":"2016-12-14 19:51:54.000000000","message":"As per the code, NeutronApiService() is used for legacy only and not for pecan ? wsgi_pecan.pecan_wsgi_server() in eventlet/server/__init.py directly calls run_wsgi_app.","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e7cdb23ad9e0d094c97ac464208c941a9589f618","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    [DEFAULT]"},{"line_number":98,"context_line":"    web_framework \u003d pecan"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"To disable, just comment the option out or set it to \"legacy\".  For example:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. code-block:: ini"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_9401873c","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":42},"updated":"2016-11-04 17:57:56.000000000","message":"Given that we are already contemplating making pecan the default (https://review.openstack.org/#/c/393535), I suggest removing this, so we don\u0027t have inaccurate documentation in the near future","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"707e911cc638b354d63f5c9509040efe5bf106e1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    [DEFAULT]"},{"line_number":98,"context_line":"    web_framework \u003d pecan"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"To disable, just comment the option out or set it to \"legacy\".  For example:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. code-block:: ini"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_f702beb3","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":42},"in_reply_to":"ba5da102_9401873c","updated":"2016-11-16 23:50:14.000000000","message":"that was more of an explosion test for pecan being the default.  Explosions did indeed happen so I\u0027d rather not change that to this now.","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7b00cd7673d4621c8ec1aee323118cada2b4cbb2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    [DEFAULT]"},{"line_number":98,"context_line":"    web_framework \u003d pecan"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"To disable, just comment the option out or set it to \"legacy\".  For example:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. code-block:: ini"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_4711385c","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":42},"in_reply_to":"ba5da102_f702beb3","updated":"2016-11-18 23:42:11.000000000","message":"LOL.... Yeah, let\u0027s avoid explosions","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"fa6ddc9ba77f688dc8341e4a035e973cf561d67b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"is started.  This module is where the actual `Pecan app module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/app.py\u003e`_"},{"line_number":113,"context_line":"is retrieved from pecan and used to start the WSGI service.  Similarily, if"},{"line_number":114,"context_line":"operators wanted to use another WSGI service, then the operator would just"},{"line_number":115,"context_line":"need to point their service to the setup_app function in the `Pecan app module`_."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Upon application setup, the `Controllers`_ are setup, the `Hooks`_ are"},{"line_number":118,"context_line":"defined, the application created, the `Middleware`_ loaded, and the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_0d7b138d","line":115,"range":{"start_line":115,"start_character":35,"end_line":115,"end_character":44},"updated":"2016-11-17 23:28:31.000000000","message":"Could you add ` around this function name?","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"34657ce3f7119ee4e33f4f33409df6ecfb0de350","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Neutron\u0027s WSGI server is started from the `server module`_ and if pecan is"},{"line_number":111,"context_line":"enabled, then the `pecan wsgi server \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/server/wsgi_pecan.py\u003e`_"},{"line_number":112,"context_line":"is started.  This module is where the actual `Pecan app module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/app.py\u003e`_"},{"line_number":113,"context_line":"is retrieved from pecan and used to start the WSGI service.  Similarily, if"},{"line_number":114,"context_line":"operators wanted to use another WSGI service, then the operator would just"},{"line_number":115,"context_line":"need to point their service to the setup_app function in the `Pecan app module`_."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Upon application setup, the `Controllers`_ are setup, the `Hooks`_ are"},{"line_number":118,"context_line":"defined, the application created, the `Middleware`_ loaded, and the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_fecf2b26","line":115,"range":{"start_line":113,"start_character":61,"end_line":115,"end_character":81},"updated":"2016-11-03 18:28:53.000000000","message":"i am having trouble understanding above line. Can you please explain this?","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"707e911cc638b354d63f5c9509040efe5bf106e1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"Neutron\u0027s WSGI server is started from the `server module`_ and if pecan is"},{"line_number":111,"context_line":"enabled, then the `pecan wsgi server \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/server/wsgi_pecan.py\u003e`_"},{"line_number":112,"context_line":"is started.  This module is where the actual `Pecan app module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/app.py\u003e`_"},{"line_number":113,"context_line":"is retrieved from pecan and used to start the WSGI service.  Similarily, if"},{"line_number":114,"context_line":"operators wanted to use another WSGI service, then the operator would just"},{"line_number":115,"context_line":"need to point their service to the setup_app function in the `Pecan app module`_."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Upon application setup, the `Controllers`_ are setup, the `Hooks`_ are"},{"line_number":118,"context_line":"defined, the application created, the `Middleware`_ loaded, and the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_41934f4f","line":115,"range":{"start_line":113,"start_character":61,"end_line":115,"end_character":81},"in_reply_to":"ba5da102_fecf2b26","updated":"2016-11-16 23:50:14.000000000","message":"I can probably just provide a link to common wsgi app scenarios.","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"fa6ddc9ba77f688dc8341e4a035e973cf561d67b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Middleware"},{"line_number":122,"context_line":"~~~~~~~~~~"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The WSGI middleware for pecan is loaded with the _wrap_app function in the"},{"line_number":125,"context_line":"`Pecan app module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/app.py\u003e`_."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Currently, this is the only way to load in middleware for pecan, and there"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_ed4ed76d","line":124,"range":{"start_line":124,"start_character":49,"end_line":124,"end_character":58},"updated":"2016-11-17 23:28:31.000000000","message":"Would be good to wrap this word with ` to add italics.","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e7cdb23ad9e0d094c97ac464208c941a9589f618","unresolved":false,"context_lines":[{"line_number":122,"context_line":"~~~~~~~~~~"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The WSGI middleware for pecan is loaded with the _wrap_app function in the"},{"line_number":125,"context_line":"`Pecan app module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/app.py\u003e`_."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Currently, this is the only way to load in middleware for pecan, and there"},{"line_number":128,"context_line":"isn\u0027t an easily configurable pipeline like legacy has with `paste deploy \u003chttp://pythonpaste.org/deploy/\u003e`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_07b54bcf","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":100},"updated":"2016-11-04 17:57:56.000000000","message":"Since you already defined the label above in the Startup section, you can shorten this to just `Pecan app module`_","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"707e911cc638b354d63f5c9509040efe5bf106e1","unresolved":false,"context_lines":[{"line_number":122,"context_line":"~~~~~~~~~~"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The WSGI middleware for pecan is loaded with the _wrap_app function in the"},{"line_number":125,"context_line":"`Pecan app module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/app.py\u003e`_."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Currently, this is the only way to load in middleware for pecan, and there"},{"line_number":128,"context_line":"isn\u0027t an easily configurable pipeline like legacy has with `paste deploy \u003chttp://pythonpaste.org/deploy/\u003e`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_619a0b65","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":100},"in_reply_to":"ba5da102_07b54bcf","updated":"2016-11-16 23:50:14.000000000","message":"will do","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"fa6ddc9ba77f688dc8341e4a035e973cf561d67b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"RootController routes requests that include the /v2.0 path to the V2Controller"},{"line_number":139,"context_line":"in the `root module`_.  From there, the controllers are determined by the"},{"line_number":140,"context_line":"NeutronManager in the `manager module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/manager.py\u003e`_"},{"line_number":141,"context_line":"and the _lookup method in each controller."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"Each collections resource (/networks, /subnets, /ports, etc) will most likely"},{"line_number":144,"context_line":"be handled by the CollectionsController in the `resource module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/resource.py\u003e`_."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_cd8bdb66","line":141,"range":{"start_line":141,"start_character":8,"end_line":141,"end_character":15},"updated":"2016-11-17 23:28:31.000000000","message":"Missing italics.","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1402240fc416554a3e0863e9dce782abcd19bee7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"be handled by the CollectionsController in the `resource module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/resource.py\u003e`_."},{"line_number":145,"context_line":"Each item resource (/networks/{network_id}, /subnets/{subnet_id},"},{"line_number":146,"context_line":"/ports/{port_id}, etc) will most likely be handled by the ItemController in"},{"line_number":147,"context_line":"the `resource module`_.  An exception to this is for the quotas resource and"},{"line_number":148,"context_line":"extensions resource, which define their own special controllers in the"},{"line_number":149,"context_line":"`quota module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/quota.py\u003e`_"},{"line_number":150,"context_line":"and the `extensions module `extensions module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/extensions.py\u003e`_,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_51ac818b","line":147,"range":{"start_line":147,"start_character":57,"end_line":147,"end_character":73},"updated":"2016-11-21 01:37:26.000000000","message":"I think this needs to be updated in light of https://review.openstack.org/#/c/399791","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e7cdb23ad9e0d094c97ac464208c941a9589f618","unresolved":false,"context_lines":[{"line_number":147,"context_line":"the `resource module`_.  An exception to this is for the quotas resource and"},{"line_number":148,"context_line":"extensions resource, which define their own special controllers in the"},{"line_number":149,"context_line":"`quota module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/quota.py\u003e`_"},{"line_number":150,"context_line":"and the `extensions module `extensions module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/extensions.py\u003e`_,"},{"line_number":151,"context_line":"respectively."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Hooks"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_272faff7","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":26},"updated":"2016-11-04 17:57:56.000000000","message":"we don\u0027t need this","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"707e911cc638b354d63f5c9509040efe5bf106e1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"the `resource module`_.  An exception to this is for the quotas resource and"},{"line_number":148,"context_line":"extensions resource, which define their own special controllers in the"},{"line_number":149,"context_line":"`quota module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/quota.py\u003e`_"},{"line_number":150,"context_line":"and the `extensions module `extensions module \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/pecan_wsgi/controllers/extensions.py\u003e`_,"},{"line_number":151,"context_line":"respectively."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Hooks"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_c19f5f4e","line":150,"range":{"start_line":150,"start_character":8,"end_line":150,"end_character":26},"in_reply_to":"ba5da102_272faff7","updated":"2016-11-16 23:50:14.000000000","message":"will do","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"dc77e0877b633ff79619a526ea43f53671974fcf","unresolved":false,"context_lines":[{"line_number":171,"context_line":"eventually pass down to the plugins.  It puts the context object into the"},{"line_number":172,"context_line":"pecan request\u0027s own context object under the key \u0027neutron_context\u0027.  They are"},{"line_number":173,"context_line":"not the same context, they are only similar in name.  The pecan context is only"},{"line_number":174,"context_line":"a data structure that contains information related to the request.  It will not"},{"line_number":175,"context_line":"be passed down to the plugin layer like the neutron context."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"ExceptionTranslationHook"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_44390441","line":174,"updated":"2016-11-04 15:59:42.000000000","message":"It will be helpful to have an example of the information that is passed in pecan context.","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"707e911cc638b354d63f5c9509040efe5bf106e1","unresolved":false,"context_lines":[{"line_number":171,"context_line":"eventually pass down to the plugins.  It puts the context object into the"},{"line_number":172,"context_line":"pecan request\u0027s own context object under the key \u0027neutron_context\u0027.  They are"},{"line_number":173,"context_line":"not the same context, they are only similar in name.  The pecan context is only"},{"line_number":174,"context_line":"a data structure that contains information related to the request.  It will not"},{"line_number":175,"context_line":"be passed down to the plugin layer like the neutron context."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"ExceptionTranslationHook"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_e1ae1b84","line":174,"in_reply_to":"ba5da102_44390441","updated":"2016-11-16 23:50:14.000000000","message":"will do","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"fa6ddc9ba77f688dc8341e4a035e973cf561d67b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"QueryParametersHook"},{"line_number":238,"context_line":"+++++++++++++++++++"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"This hook needs to have a lower priority than the `PolicyHook`_ because it\u0027s"},{"line_number":241,"context_line":"after method depends on what the `PolicyHook`_ \u0027s after method does."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Before"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_0dc15354","line":240,"range":{"start_line":240,"start_character":16,"end_line":240,"end_character":40},"updated":"2016-11-17 23:28:31.000000000","message":"Could you add couple words of explanation, what does it mean (or at least refer to docs)? How priorities are configured in Pecan?","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e7cdb23ad9e0d094c97ac464208c941a9589f618","unresolved":false,"context_lines":[{"line_number":237,"context_line":"QueryParametersHook"},{"line_number":238,"context_line":"+++++++++++++++++++"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"This hook needs to have a lower priority than the `PolicyHook`_ because it\u0027s"},{"line_number":241,"context_line":"after method depends on what the `PolicyHook`_ \u0027s after method does."},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"Before"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_27f24f70","line":240,"range":{"start_line":240,"start_character":72,"end_line":240,"end_character":76},"updated":"2016-11-04 17:57:56.000000000","message":"s/it\u0027s/its","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1402240fc416554a3e0863e9dce782abcd19bee7","unresolved":false,"context_lines":[{"line_number":279,"context_line":"Next, it iterates through all enabled extensions and sets any pecan controllers"},{"line_number":280,"context_line":"that an extension defines.  An extension can define its own pecan controllers"},{"line_number":281,"context_line":"by implementing the get_pecan_resources classmethod in the extension\u0027s class."},{"line_number":282,"context_line":"An example of this is the `quotas extension \u003chttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/quotasv2.py\u003e`_."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Next, it iterates through all enabled extensions and retrieves the list of"},{"line_number":285,"context_line":"ResourceExtensions returned by every extension\u0027s get_resources method. Then,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_51c3a137","line":282,"range":{"start_line":282,"start_character":0,"end_line":282,"end_character":43},"updated":"2016-11-21 01:37:26.000000000","message":"This also needs to be updated in light of https://review.openstack.org/#/c/399791","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"34657ce3f7119ee4e33f4f33409df6ecfb0de350","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Next, it iterates through all enabled extensions and retrieves the list of"},{"line_number":285,"context_line":"ResourceExtensions returned by every extension\u0027s get_resources method. Then,"},{"line_number":286,"context_line":"it translates each one into a CollectionsController or an ItemController"},{"line_number":287,"context_line":"defined in the `Controllers`_ section and assigns that controller to its"},{"line_number":288,"context_line":"particular resource and/or collection.  This is later used by the _lookup"},{"line_number":289,"context_line":"method in each controller to grab the resource and/or collection\u0027s controller."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_b8df8ad4","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":72},"updated":"2016-11-03 18:28:53.000000000","message":"it seems that only instances of CollectionsController is being created in initialize_all() method","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1402240fc416554a3e0863e9dce782abcd19bee7","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Next, it iterates through all enabled extensions and retrieves the list of"},{"line_number":285,"context_line":"ResourceExtensions returned by every extension\u0027s get_resources method. Then,"},{"line_number":286,"context_line":"it translates each one into a CollectionsController or an ItemController"},{"line_number":287,"context_line":"defined in the `Controllers`_ section and assigns that controller to its"},{"line_number":288,"context_line":"particular resource and/or collection.  This is later used by the _lookup"},{"line_number":289,"context_line":"method in each controller to grab the resource and/or collection\u0027s controller."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_51dac117","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":72},"in_reply_to":"7a77a97e_21de5311","updated":"2016-11-21 01:37:26.000000000","message":"initialize_all() creates also instances of ShimCollectionsController, though. Besides mentioning this fact here, I think it would be good if somewhere in this document there is an explanation of why we need ShimCollectionsController","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"707e911cc638b354d63f5c9509040efe5bf106e1","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"Next, it iterates through all enabled extensions and retrieves the list of"},{"line_number":285,"context_line":"ResourceExtensions returned by every extension\u0027s get_resources method. Then,"},{"line_number":286,"context_line":"it translates each one into a CollectionsController or an ItemController"},{"line_number":287,"context_line":"defined in the `Controllers`_ section and assigns that controller to its"},{"line_number":288,"context_line":"particular resource and/or collection.  This is later used by the _lookup"},{"line_number":289,"context_line":"method in each controller to grab the resource and/or collection\u0027s controller."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_21de5311","line":286,"range":{"start_line":286,"start_character":0,"end_line":286,"end_character":72},"in_reply_to":"ba5da102_b8df8ad4","updated":"2016-11-16 23:50:14.000000000","message":"good catch, ItemController is created by the CollectionsController\u0027s _lookup method.","commit_id":"6c2c5a264f8733b54ad9acf23728c8250ae762f9"}]}
