)]}'
{"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"046e4662cb961fca34e6ce245dc1161a56b3271c","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _remove_data(self, transaction, ports_data\u003dNone):"},{"line_number":126,"context_line":"        if not transaction:"},{"line_number":127,"context_line":"            return None"},{"line_number":128,"context_line":"        if not self._is_revert_point(transaction):"},{"line_number":129,"context_line":"            return None"},{"line_number":130,"context_line":"        session_info \u003d transaction.session.info.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_0787f7b5","line":127,"updated":"2017-01-13 22:53:38.000000000","message":"This can just be \u0027return\u0027, same below","commit_id":"6e2016f1912a19a39223ac51eaed970d59ee17cd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8692c794b299c179d0513f2ac46215cdfb0be2ac","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    _unregister_list \u003d []"},{"line_number":46,"context_line":"    _sessions \u003d []"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __del__(self):"},{"line_number":49,"context_line":"        for session in self._unregister_list:"},{"line_number":50,"context_line":"            self.unregister_db_events(session)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_3d6c6b07","line":48,"updated":"2017-02-25 06:09:25.000000000","message":"__del__ is generally not guaranteed to execute in cpython, so I doubt we need that. if that\u0027s to clean up registrations e.g. for test environment, then you should write a fixture that would explicitly clean up what\u0027s due; alternatively, you may instead use self.addCleanup().","commit_id":"0a1366e380790ff8bc3d28f25da4e79c1049347e"}],"neutron/tests/unit/db/test_ipam_pluggable_backend.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8692c794b299c179d0513f2ac46215cdfb0be2ac","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        self._test_update_db_subnet(pool_mock, subnet, expected_subnet,"},{"line_number":756,"context_line":"                                    old_pools)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    @mock.patch(\u0027neutron.ipam.driver.Pool\u0027)"},{"line_number":759,"context_line":"    def test_update_db_subnet_new_pools_exception(self, pool_mock):"},{"line_number":760,"context_line":"        context \u003d mock.Mock()"},{"line_number":761,"context_line":"        mocks \u003d self._prepare_mocks_with_pool_mock(pool_mock)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_bda93b26","side":"PARENT","line":758,"updated":"2017-02-25 06:09:25.000000000","message":"why do you remove the test? it seems to cover one of rollback cases. Can you keep it, and also you probably need to add more test cases for scenarios that you suggest are missing.","commit_id":"4f5537f6e736514b78de1cd1324fb1ef68eef8f7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"aad082c0707dab2010843ac47a33cd6fd5b3b6fc","unresolved":false,"context_lines":[{"line_number":800,"context_line":"            changes.add, revert_on_fail\u003dFalse)"},{"line_number":801,"context_line":"        mocks[\u0027ipam\u0027]._ipam_allocate_ips.assert_called_once_with("},{"line_number":802,"context_line":"            context, mocks[\u0027driver\u0027], db_port,"},{"line_number":803,"context_line":"            changes.remove, revert_on_fail\u003dFalse)"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"class TestRollback(test_db_base.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_9c2d7caa","side":"PARENT","line":803,"updated":"2017-03-03 18:35:35.000000000","message":"Ihar - I\u0027m not sure what this would test any more as these two calls (allocate/deallocate) are no longer made in the code, and the DBDeadlock assert was being triggered by the mock on L784.","commit_id":"4f5537f6e736514b78de1cd1324fb1ef68eef8f7"}]}
