)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"707a09ecefae5a6ac372c8c7afcdc772a1b94eb9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add fullstack test for check DSCP marks outbounds"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New fullstack test is added to check if packets which"},{"line_number":10,"context_line":"should be send from port with DSCP mark set are really"},{"line_number":11,"context_line":"send to another port with this DSCP mark."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4b26c3c644eb6f2f7813658c99d16fbc3cc61e06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_9fcc82bc","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":14},"updated":"2016-11-03 11:27:58.000000000","message":"sent ?","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7e2526807b66bf15d99def7eea9a48d75ef55fdb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add fullstack test for check DSCP marks outbounds"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New fullstack test is added to check if packets which"},{"line_number":10,"context_line":"should be send from port with DSCP mark set are really"},{"line_number":11,"context_line":"send to another port with this DSCP mark."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4b26c3c644eb6f2f7813658c99d16fbc3cc61e06"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_01f1ec6a","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":14},"in_reply_to":"ba5da102_9fcc82bc","updated":"2016-11-03 15:12:56.000000000","message":"Done","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"707a09ecefae5a6ac372c8c7afcdc772a1b94eb9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New fullstack test is added to check if packets which"},{"line_number":10,"context_line":"should be send from port with DSCP mark set are really"},{"line_number":11,"context_line":"send to another port with this DSCP mark."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4b26c3c644eb6f2f7813658c99d16fbc3cc61e06"},{"line_number":14,"context_line":"Closes-Bug: #1625570"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_5fd66a4f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":4},"updated":"2016-11-03 11:27:58.000000000","message":"sent ?","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7e2526807b66bf15d99def7eea9a48d75ef55fdb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New fullstack test is added to check if packets which"},{"line_number":10,"context_line":"should be send from port with DSCP mark set are really"},{"line_number":11,"context_line":"send to another port with this DSCP mark."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4b26c3c644eb6f2f7813658c99d16fbc3cc61e06"},{"line_number":14,"context_line":"Closes-Bug: #1625570"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_21f43059","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":4},"in_reply_to":"ba5da102_5fd66a4f","updated":"2016-11-03 15:12:56.000000000","message":"Done","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"}],"neutron/tests/common/agents/l2_extensions.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"26d507ae5ae337a403c8a0d4e553c418bf12990d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    common_utils.wait_until_true(_dscp_marking_rule_applied)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_dfad4885","line":60,"updated":"2016-11-02 12:41:07.000000000","message":"nit: rule \u003d\u003e dscp_mark ?","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5bbf9e52d29e5af15068f5173aad3c6845423ffd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    common_utils.wait_until_true(_dscp_marking_rule_applied)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_ba7a6286","line":60,"in_reply_to":"ba5da102_dfad4885","updated":"2016-11-02 13:00:08.000000000","message":"+1","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    common_utils.wait_until_true(_dscp_marking_rule_applied)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_307ca0b4","line":60,"in_reply_to":"ba5da102_dfad4885","updated":"2016-11-02 19:50:38.000000000","message":"Done","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9e899c8feb90d6a16ccca244fdc2087f98b331fa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8b9c7ac1","line":63,"range":{"start_line":63,"start_character":17,"end_line":63,"end_character":38},"updated":"2016-11-02 11:15:38.000000000","message":"You should quote this expresion:\n\"\u0027(ip[1] \u0026 0xfc  \u003d\u003d %s)\u0027\"","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5bbf9e52d29e5af15068f5173aad3c6845423ffd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_7a18ca75","line":63,"range":{"start_line":63,"start_character":30,"end_line":63,"end_character":31},"updated":"2016-11-02 13:00:08.000000000","message":"super nit: between \u00270xfc\u0027 and \u0027\u003d\u003d\u0027 there are 2 spaces where there should be only one.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_f05ce84c","line":63,"range":{"start_line":63,"start_character":30,"end_line":63,"end_character":31},"in_reply_to":"ba5da102_7a18ca75","updated":"2016-11-02 19:50:38.000000000","message":"fixed. You are sniper :)","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"26d507ae5ae337a403c8a0d4e553c418bf12990d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_df7f0815","line":63,"range":{"start_line":63,"start_character":17,"end_line":63,"end_character":38},"in_reply_to":"ba5da102_8b9c7ac1","updated":"2016-11-02 12:41:07.000000000","message":"I think that\u0027s not necessary, since the command and arguments are held on a list of strings,  the system will implicitly take it as a \"xxxxxx\" single arg when passed to the underlaying tcpdump.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_b046f078","line":63,"range":{"start_line":63,"start_character":17,"end_line":63,"end_character":38},"in_reply_to":"ba5da102_8b9c7ac1","updated":"2016-11-02 19:50:38.000000000","message":"I tried to add quote to this expression and then my tcpdump gave me error \"illegal token\", without quotes it\u0027s working fine.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1d5a65ead2a876234e7a5de754955b10ff6a85ec","unresolved":false,"context_lines":[{"line_number":60,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, rule):"},{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_954e4f6d","line":63,"range":{"start_line":63,"start_character":17,"end_line":63,"end_character":38},"in_reply_to":"ba5da102_df7f0815","updated":"2016-11-02 13:12:45.000000000","message":"The string will be written directly without quotes and its needed.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5bbf9e52d29e5af15068f5173aad3c6845423ffd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"},{"line_number":67,"context_line":"    tcpdump_async.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_daa2b6fb","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":19},"updated":"2016-11-02 13:00:08.000000000","message":"This can be added to line 61 to reduce the size of the change by 1.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name]"},{"line_number":62,"context_line":"    if rule:"},{"line_number":63,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc  \u003d\u003d %s)\" % (rule \u003c\u003c 2)]"},{"line_number":64,"context_line":"    cmd +\u003d [\"-nlt\"]"},{"line_number":65,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"},{"line_number":66,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"},{"line_number":67,"context_line":"    tcpdump_async.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_5034b4fa","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":19},"in_reply_to":"ba5da102_daa2b6fb","updated":"2016-11-02 19:50:38.000000000","message":"Done","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5bbf9e52d29e5af15068f5173aad3c6845423ffd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for line in tcpdump_async.iter_stdout():"},{"line_number":76,"context_line":"        pattern \u003d re.compile("},{"line_number":77,"context_line":"            r\"IP (?P\u003csrc_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}) \u003e \""},{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_5a5306e2","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":28},"updated":"2016-11-02 13:00:08.000000000","message":"This should only be compiled once, at the module level, and not once per-stdout-line-per-call. Compiling a regex is a bit expensive and we shouldn\u0027t do it more than once.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0ffb2405c041732a477ebe66c03961cbf4743de5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for line in tcpdump_async.iter_stdout():"},{"line_number":76,"context_line":"        pattern \u003d re.compile("},{"line_number":77,"context_line":"            r\"IP (?P\u003csrc_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}) \u003e \""},{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_9a7afeef","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":28},"in_reply_to":"ba5da102_5a5306e2","updated":"2016-11-02 13:04:49.000000000","message":"We could match on the regex without compile, for tests it shall be ok, and apparently python has a cache for regexes to avoid compiling the same thing twice (when you just match)","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"87f329b081f5fceb87075f50748277684e60b839","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for line in tcpdump_async.iter_stdout():"},{"line_number":76,"context_line":"        pattern \u003d re.compile("},{"line_number":77,"context_line":"            r\"IP (?P\u003csrc_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}) \u003e \""},{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_fa469a79","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":28},"in_reply_to":"ba5da102_9a7afeef","updated":"2016-11-02 13:07:27.000000000","message":"Didn\u0027t know that. Still, every little second helps with reducing gate job times, and explicit is better than implicit :)","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for line in tcpdump_async.iter_stdout():"},{"line_number":76,"context_line":"        pattern \u003d re.compile("},{"line_number":77,"context_line":"            r\"IP (?P\u003csrc_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}) \u003e \""},{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_53503e0b","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":28},"in_reply_to":"ba5da102_9a7afeef","updated":"2016-11-02 19:50:38.000000000","message":"Done","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        pass"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for line in tcpdump_async.iter_stdout():"},{"line_number":76,"context_line":"        pattern \u003d re.compile("},{"line_number":77,"context_line":"            r\"IP (?P\u003csrc_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}) \u003e \""},{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_73538217","line":76,"range":{"start_line":76,"start_character":21,"end_line":76,"end_character":28},"in_reply_to":"ba5da102_fa469a79","updated":"2016-11-02 19:50:38.000000000","message":"Done","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5bbf9e52d29e5af15068f5173aad3c6845423ffd","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for line in tcpdump_async.iter_stdout():"},{"line_number":76,"context_line":"        pattern \u003d re.compile("},{"line_number":77,"context_line":"            r\"IP (?P\u003csrc_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}) \u003e \""},{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"},{"line_number":80,"context_line":"        if m:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_9ad11e5a","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":49},"updated":"2016-11-02 13:00:08.000000000","message":"Awesome regex. Can this be made into a constant \"IP_ADDR_REGEX\"? this will reduce code duplication a bit.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    for line in tcpdump_async.iter_stdout():"},{"line_number":76,"context_line":"        pattern \u003d re.compile("},{"line_number":77,"context_line":"            r\"IP (?P\u003csrc_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}) \u003e \""},{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"},{"line_number":80,"context_line":"        if m:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_13bec6fe","line":77,"range":{"start_line":77,"start_character":28,"end_line":77,"end_character":49},"in_reply_to":"ba5da102_9ad11e5a","updated":"2016-11-02 19:50:38.000000000","message":"Done","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5bbf9e52d29e5af15068f5173aad3c6845423ffd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"},{"line_number":80,"context_line":"        if m:"},{"line_number":81,"context_line":"            return (m.group(\"src_ip\") \u003d\u003d sender_vm.ip and"},{"line_number":82,"context_line":"                    m.group(\"dst_ip\") \u003d\u003d receiver_vm.ip)"},{"line_number":83,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_7aa8ca77","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":18},"updated":"2016-11-02 13:00:08.000000000","message":"I\u0027m a bit confused as to the purpose of the function. The commit message hints that this should return True if a packet with the specified DSCP was discovered between the 2 parties. If that is the case, shouldn\u0027t we return if this check is True, otherwise continue on to the next stdout line to check if that one matches, etc? i.e.\n\n if m and (m.group() \u003d\u003d sender_vm.ip and ... receiver_vm.ip):\n     return True\n else:\n     continue  # this is explicit and shouldn\u0027t be added to code","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \"(?P\u003cdst_ip\u003e(\\d{1,3}\\.){3}\\d{1,3}): ICMP .*$\")"},{"line_number":79,"context_line":"        m \u003d pattern.match(line)"},{"line_number":80,"context_line":"        if m:"},{"line_number":81,"context_line":"            return (m.group(\"src_ip\") \u003d\u003d sender_vm.ip and"},{"line_number":82,"context_line":"                    m.group(\"dst_ip\") \u003d\u003d receiver_vm.ip)"},{"line_number":83,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_f3f792d0","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":18},"in_reply_to":"ba5da102_7aa8ca77","updated":"2016-11-02 19:50:38.000000000","message":"changed","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b67a9737a1b0c6b11b345a6dd2a2eac810491878","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def extract_mod_nw_tos_action(flows):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_3c0b87d7","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":38},"updated":"2016-11-03 09:26:01.000000000","message":"nit: why don\u0027t you open the parenthesis in the constant?\nr\"(\\d{1,3}\\.){3}\\d{1,3}\"\n\nExpression in L77,78 looks unbalanced","commit_id":"d296555c3745d7e586fd83283e964b168f7782d4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"027aae492803448a3669400614408d062f1f6585","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def extract_mod_nw_tos_action(flows):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_97fc6cb9","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":38},"in_reply_to":"ba5da102_3c0b87d7","updated":"2016-11-03 09:57:44.000000000","message":"Parenthesis is for mark group in regex, not part of \"ip address regex\".\nWhat exactly looks unbalanced for You?","commit_id":"d296555c3745d7e586fd83283e964b168f7782d4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ae18eff41e902619737e6e4985dd9e811f8376be","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def extract_mod_nw_tos_action(flows):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_4c77aa9f","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":38},"in_reply_to":"ba5da102_77b8b875","updated":"2016-11-03 10:50:45.000000000","message":"Done","commit_id":"d296555c3745d7e586fd83283e964b168f7782d4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"67414e962c2b712cc208e313a0396e34075bed6a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def extract_mod_nw_tos_action(flows):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_77b8b875","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":38},"in_reply_to":"ba5da102_97fc6cb9","updated":"2016-11-03 10:12:42.000000000","message":"Because in this string you are closing an unopen parenthesis (I know it\u0027s closed in the string in L77,78). It\u0027s only a cosmethic change.","commit_id":"d296555c3745d7e586fd83283e964b168f7782d4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"bf5979a8cf98e56c7485e9ba2f41aff1e080d629","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def extract_mod_nw_tos_action(flows):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_d79ee461","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":38},"in_reply_to":"ba5da102_97fc6cb9","updated":"2016-11-03 10:00:31.000000000","message":"This regex here has a \u0027)\u0027 without an opening \u0027(\u0027 - looks a bit weird.","commit_id":"d296555c3745d7e586fd83283e964b168f7782d4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"088aeaee22a6f9b2657e77cd382761d99272f4a1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def extract_mod_nw_tos_action(flows):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_299a686e","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":38},"in_reply_to":"ba5da102_d79ee461","updated":"2016-11-03 10:33:09.000000000","message":"Ahh. I didn\u0027t see it, sorry. I will fix it in few minutes :)","commit_id":"d296555c3745d7e586fd83283e964b168f7782d4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"707a09ecefae5a6ac372c8c7afcdc772a1b94eb9","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, dscp_mark):"},{"line_number":64,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name, \"-nlt\"]"},{"line_number":65,"context_line":"    if dscp_mark:"},{"line_number":66,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc \u003d\u003d %s)\" % (dscp_mark \u003c\u003c 2)]"},{"line_number":67,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_a20bed22","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":19},"updated":"2016-11-03 11:27:58.000000000","message":"Out-of-scope: Maybe we should think about encapsulating tcpdump to a class providing parsing capabilities and exposing data to use via sane api.","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37514e3bc09080a251e16e9287eea5156cd945fd","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def wait_for_dscp_marked_packet(sender_vm, receiver_vm, dscp_mark):"},{"line_number":64,"context_line":"    cmd \u003d [\"tcpdump\", \"-i\", receiver_vm.port.name, \"-nlt\"]"},{"line_number":65,"context_line":"    if dscp_mark:"},{"line_number":66,"context_line":"        cmd +\u003d [\"(ip[1] \u0026 0xfc \u003d\u003d %s)\" % (dscp_mark \u003c\u003c 2)]"},{"line_number":67,"context_line":"    tcpdump_async \u003d async_process.AsyncProcess(cmd, run_as_root\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_bd3dcec5","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":19},"in_reply_to":"ba5da102_a20bed22","updated":"2016-11-03 11:45:03.000000000","message":"I agree","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"707a09ecefae5a6ac372c8c7afcdc772a1b94eb9","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if m and (m.group(\"src_ip\") \u003d\u003d sender_vm.ip and"},{"line_number":83,"context_line":"            m.group(\"dst_ip\") \u003d\u003d receiver_vm.ip):"},{"line_number":84,"context_line":"            return True"},{"line_number":85,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_9f37224c","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":16},"updated":"2016-11-03 11:27:58.000000000","message":"Do you think it would make sense to raise an exception here that would state that no dscp marked packets were received instead of returning True or False?\n\nCurrently if this fails, we will get an error saying something like \"False is not True\" while with exception we would have a meaningful message.","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7e2526807b66bf15d99def7eea9a48d75ef55fdb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if m and (m.group(\"src_ip\") \u003d\u003d sender_vm.ip and"},{"line_number":83,"context_line":"            m.group(\"dst_ip\") \u003d\u003d receiver_vm.ip):"},{"line_number":84,"context_line":"            return True"},{"line_number":85,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_c14d34c5","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":16},"in_reply_to":"ba5da102_82d0a9ca","updated":"2016-11-03 15:12:56.000000000","message":"Done","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"37514e3bc09080a251e16e9287eea5156cd945fd","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if m and (m.group(\"src_ip\") \u003d\u003d sender_vm.ip and"},{"line_number":83,"context_line":"            m.group(\"dst_ip\") \u003d\u003d receiver_vm.ip):"},{"line_number":84,"context_line":"            return True"},{"line_number":85,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_82d0a9ca","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":16},"in_reply_to":"ba5da102_9f37224c","updated":"2016-11-03 11:45:03.000000000","message":"Ok. I will change it it to raise exception if no proper packet is received","commit_id":"ac2411f2178541321381ee54346f0346aedbcf86"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b9e422f0101d7d21d5b556d292b2a5c35e192560","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"(\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TcpdumpException(Exception):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_f929e18a","line":22,"updated":"2016-11-04 15:22:37.000000000","message":"this does not look like it is v6 friendly","commit_id":"f61a66351f767778c3b28f083bcbc8dd298b1701"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bde3ef5dff4795a8911a59022fa7a1dc286557c7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"(\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TcpdumpException(Exception):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_f60e59e4","line":22,"in_reply_to":"9a629dbe_63744dcf","updated":"2016-11-07 12:16:04.000000000","message":"Done","commit_id":"f61a66351f767778c3b28f083bcbc8dd298b1701"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7dad4bade896c9d334d97d79e21f31b981def6ac","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"(\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TcpdumpException(Exception):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a629dbe_63744dcf","line":22,"in_reply_to":"ba5da102_745b132f","updated":"2016-11-07 12:06:36.000000000","message":"please change this to have a V4 and then i am good to go","commit_id":"f61a66351f767778c3b28f083bcbc8dd298b1701"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0c182fa9066b810825e72d43b4403d80105685b5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import utils as common_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"IP_ADDR_REGEX \u003d r\"(\\d{1,3}\\.){3}\\d{1,3}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TcpdumpException(Exception):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_745b132f","line":22,"in_reply_to":"ba5da102_f929e18a","updated":"2016-11-04 16:55:45.000000000","message":"The tests run for ipv4 only so ipv6 is YAGNI at this point","commit_id":"f61a66351f767778c3b28f083bcbc8dd298b1701"}],"neutron/tests/fullstack/test_qos.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5bbf9e52d29e5af15068f5173aad3c6845423ffd","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        qos_policy[\u0027rules\u0027].append(rule)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _check_received_packet(self, sender, receiver, dscp_mark):"},{"line_number":219,"context_line":"        valid_packet_received \u003d l2_extensions.wait_for_dscp_marked_packet("},{"line_number":220,"context_line":"            sender, receiver, dscp_mark)"},{"line_number":221,"context_line":"        self.assertTrue(valid_packet_received)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_9ad4be20","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":29},"updated":"2016-11-02 13:00:08.000000000","message":"nit: don\u0027t really need this variable.","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0ffb2405c041732a477ebe66c03961cbf4743de5","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        qos_policy[\u0027rules\u0027].append(rule)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _check_received_packet(self, sender, receiver, dscp_mark):"},{"line_number":219,"context_line":"        valid_packet_received \u003d l2_extensions.wait_for_dscp_marked_packet("},{"line_number":220,"context_line":"            sender, receiver, dscp_mark)"},{"line_number":221,"context_line":"        self.assertTrue(valid_packet_received)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_dace362c","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":29},"in_reply_to":"ba5da102_9ad4be20","updated":"2016-11-02 13:04:49.000000000","message":"but makes the code more meaningful :) (gives an explicit meaning to the True/False result), at the expense of 1 line of code ;)","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"648a5b9993797827d316eed41171c8a80aa879fd","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        qos_policy[\u0027rules\u0027].append(rule)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _check_received_packet(self, sender, receiver, dscp_mark):"},{"line_number":219,"context_line":"        valid_packet_received \u003d l2_extensions.wait_for_dscp_marked_packet("},{"line_number":220,"context_line":"            sender, receiver, dscp_mark)"},{"line_number":221,"context_line":"        self.assertTrue(valid_packet_received)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_93d016cb","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":29},"in_reply_to":"ba5da102_dab39698","updated":"2016-11-02 19:50:38.000000000","message":"I changed it","commit_id":"819383291097998fd37a781d148824168cb37ce0"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"87f329b081f5fceb87075f50748277684e60b839","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        qos_policy[\u0027rules\u0027].append(rule)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def _check_received_packet(self, sender, receiver, dscp_mark):"},{"line_number":219,"context_line":"        valid_packet_received \u003d l2_extensions.wait_for_dscp_marked_packet("},{"line_number":220,"context_line":"            sender, receiver, dscp_mark)"},{"line_number":221,"context_line":"        self.assertTrue(valid_packet_received)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_dab39698","line":219,"range":{"start_line":219,"start_character":8,"end_line":219,"end_character":29},"in_reply_to":"ba5da102_dace362c","updated":"2016-11-02 13:07:27.000000000","message":"tomato tomayto","commit_id":"819383291097998fd37a781d148824168cb37ce0"}]}
