)]}'
{"neutron/api/v2/base.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"51636c9e023a19d962ec346ffa68d6802104a502","unresolved":false,"context_lines":[{"line_number":548,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        Controller._populate_tenant_id(context, res_dict, is_create)"},{"line_number":551,"context_line":"        LOG.warn(\"#### RES DICT:%s\", res_dict)"},{"line_number":552,"context_line":"        LOG.warn(\"#### ATTR INFO:%s\", attr_info)"},{"line_number":553,"context_line":"        Controller._verify_attributes(res_dict, attr_info)"},{"line_number":554,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiaM%3D","line":551,"updated":"2013-07-29 16:01:43.000000000","message":"has it got here during debugging?","commit_id":"13c806064e032e54e6ddadc8cfe4bf1261644274"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0a9e3748a3e6560f388c36665d3e5e17473b0e02","unresolved":false,"context_lines":[{"line_number":548,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"        Controller._populate_tenant_id(context, res_dict, is_create)"},{"line_number":551,"context_line":"        LOG.warn(\"#### RES DICT:%s\", res_dict)"},{"line_number":552,"context_line":"        LOG.warn(\"#### ATTR INFO:%s\", attr_info)"},{"line_number":553,"context_line":"        Controller._verify_attributes(res_dict, attr_info)"},{"line_number":554,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fb6w%3D","line":551,"in_reply_to":"AAAAQn%2F%2FiaM%3D","updated":"2013-07-31 08:34:41.000000000","message":"This is very important experimental code.\nIt will make code go faster by 200%\n\nThis is guaranteed by the interplanetary academy of the professional cobra python programmers","commit_id":"13c806064e032e54e6ddadc8cfe4bf1261644274"}],"neutron/db/portsecurity_db.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"b4a30f3b5cb653eaa9c2458352c214f54bee980e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            binding \u003d query.filter("},{"line_number":119,"context_line":"                PortSecurityBinding.port_id \u003d\u003d port_id).one()"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            binding.update({psec.PORTSECURITY: port_security_enabled})"},{"line_number":122,"context_line":"            port_res[psec.PORTSECURITY] \u003d port_security_enabled"},{"line_number":123,"context_line":"        except exc.NoResultFound:"},{"line_number":124,"context_line":"            raise psec.PortSecurityBindingNotFound()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FiiA%3D","line":121,"updated":"2013-07-29 15:37:17.000000000","message":"I know this line is unchanged, but it might worth changing to\n binding.port_security_enabled \u003d port_security_enabled\nhere and below","commit_id":"73f783df03fb17c34c5b6c1c789d79f270191601"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"b4a30f3b5cb653eaa9c2458352c214f54bee980e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            binding.update({psec.PORTSECURITY: port_security_enabled})"},{"line_number":139,"context_line":"            network_res[psec.PORTSECURITY] \u003d port_security_enabled"},{"line_number":140,"context_line":"        except exc.NoResultFound:"},{"line_number":141,"context_line":"            raise psec.PortSecurityBindingNotFound()"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _make_network_port_security_dict(self, port_security, fields\u003dNone):"},{"line_number":144,"context_line":"        res \u003d {\u0027network_id\u0027: port_security[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FihY%3D","line":141,"updated":"2013-07-29 15:37:17.000000000","message":"It seems strange to raise PortSecurityBindingNotFound for NetworkSecurityBinding not found case","commit_id":"73f783df03fb17c34c5b6c1c789d79f270191601"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ecd07ef08b8043bf791a5026eb4db4f88ebe1fbf","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            binding.update({psec.PORTSECURITY: port_security_enabled})"},{"line_number":139,"context_line":"            network_res[psec.PORTSECURITY] \u003d port_security_enabled"},{"line_number":140,"context_line":"        except exc.NoResultFound:"},{"line_number":141,"context_line":"            raise psec.PortSecurityBindingNotFound()"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _make_network_port_security_dict(self, port_security, fields\u003dNone):"},{"line_number":144,"context_line":"        res \u003d {\u0027network_id\u0027: port_security[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FifA%3D","line":141,"in_reply_to":"AAAAQn%2F%2FihY%3D","updated":"2013-07-29 15:58:36.000000000","message":"It is not a \u0027network security binding\u0027 but the default port security binding for all ports on the network.\n\nThis is why it always raises the same exception.\n\nI agree it is cacophonic at least.","commit_id":"73f783df03fb17c34c5b6c1c789d79f270191601"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"51636c9e023a19d962ec346ffa68d6802104a502","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            binding \u003d query.filter("},{"line_number":136,"context_line":"                NetworkSecurityBinding.network_id \u003d\u003d network_id).one()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            binding.update({psec.PORTSECURITY: port_security_enabled})"},{"line_number":139,"context_line":"            network_res[psec.PORTSECURITY] \u003d port_security_enabled"},{"line_number":140,"context_line":"        except exc.NoResultFound:"},{"line_number":141,"context_line":"            raise psec.PortSecurityBindingNotFound()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FiZ0%3D","line":138,"updated":"2013-07-29 16:01:43.000000000","message":"please fix that one as well. sorry for not leaving comment for the previous patchset","commit_id":"13c806064e032e54e6ddadc8cfe4bf1261644274"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"269d2d0fbbf398dc63872a970c8e32d0a3c7b422","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def _extend_port_dict_security_group(self, port_res, port_db):"},{"line_number":436,"context_line":"        # Security group bindings will be retrieved from the sqlalchemy"},{"line_number":437,"context_line":"        # model. As they\u0027re loaded eagerly with ports because of the"},{"line_number":438,"context_line":"        # joined laoad they will not cause an extra query."},{"line_number":439,"context_line":"        security_group_ids \u003d [sec_group_mapping[\u0027security_group_id\u0027] for"},{"line_number":440,"context_line":"                              sec_group_mapping in port_db.security_groups]"},{"line_number":441,"context_line":"        port_res[ext_sg.SECURITYGROUPS] \u003d security_group_ids"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fb9U%3D","line":438,"updated":"2013-07-31 08:21:35.000000000","message":"laoad*","commit_id":"13c806064e032e54e6ddadc8cfe4bf1261644274"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0a9e3748a3e6560f388c36665d3e5e17473b0e02","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def _extend_port_dict_security_group(self, port_res, port_db):"},{"line_number":436,"context_line":"        # Security group bindings will be retrieved from the sqlalchemy"},{"line_number":437,"context_line":"        # model. As they\u0027re loaded eagerly with ports because of the"},{"line_number":438,"context_line":"        # joined laoad they will not cause an extra query."},{"line_number":439,"context_line":"        security_group_ids \u003d [sec_group_mapping[\u0027security_group_id\u0027] for"},{"line_number":440,"context_line":"                              sec_group_mapping in port_db.security_groups]"},{"line_number":441,"context_line":"        port_res[ext_sg.SECURITYGROUPS] \u003d security_group_ids"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fb6k%3D","line":438,"in_reply_to":"AAAAQn%2F%2Fb9U%3D","updated":"2013-07-31 08:34:41.000000000","message":"yeah, I say laoad\nproblem, bro?","commit_id":"13c806064e032e54e6ddadc8cfe4bf1261644274"}],"neutron/plugins/nicira/NeutronPlugin.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"b4a30f3b5cb653eaa9c2458352c214f54bee980e","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                    raise nvp_exc.NvpPluginException(err_msg\u003derr_msg)"},{"line_number":977,"context_line":"            # Don\u0027t do field selection here otherwise we won\u0027t be able"},{"line_number":978,"context_line":"            # to add provider networks fields"},{"line_number":979,"context_line":"            net_result \u003d self._make_network_dict(network, fields\u003dNone)"},{"line_number":980,"context_line":"            self._extend_network_dict_provider(context, net_result)"},{"line_number":981,"context_line":"            self._extend_network_qos_queue(context, net_result)"},{"line_number":982,"context_line":"        return self._fields(net_result, fields)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fij4%3D","line":979,"updated":"2013-07-29 15:37:17.000000000","message":"nit: fields\u003dNone is default value","commit_id":"73f783df03fb17c34c5b6c1c789d79f270191601"}]}
