)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e09279dc896f8e59ab8d5d99a35f407b11b09012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba5da102_093b799d","updated":"2016-10-28 14:19:57.000000000","message":"This commit message needs to be improved. Please read the following references:\n\nhttp://docs.openstack.org/developer/hacking/#commit-messages\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"767ea4409ece6b4c53c8b7298c91d9a7b06d0b04"}],"neutron/tests/unit/db/test_allowedaddresspairs_db.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9d0a30af3f023dfb898e8f07932e7d3d47c03b4f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                          \u0027ip_address\u0027: \u002710.0.0.1222\u0027}]"},{"line_number":176,"context_line":"        self._create_port_with_address_pairs(address_pairs, 400)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_create_port_bad_mac_and_bad_ip(self):"},{"line_number":179,"context_line":"        address_pairs \u003d [{\u0027mac_address\u0027: \u0027invalid_mac\u0027,"},{"line_number":180,"context_line":"                          \u0027ip_address\u0027: \u002710.0.0.1222\u0027}]"},{"line_number":181,"context_line":"        self._create_port_with_address_pairs(address_pairs, 400)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_ee6587e1","line":178,"updated":"2016-10-27 13:52:23.000000000","message":"This method really doesn\u0027t add any value. This test class sets up a plugin with this create_port method: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_allowedaddresspairs_db.py#L55. As you can see, this create_port calls in line 62 this method: https://github.com/openstack/neutron/blob/master/neutron/db/allowedaddresspairs_db.py#L31. The code there first authenticates the mac address and then the ip address. However, you will never get to the IP address authentication. The mac address authentication is going to fail before getting there. In other words, this test case is does the same as test_create_port_bad_mac in L168 above.","commit_id":"2d190222b03a84fcd88c384ff0c3d557bb337d7b"}]}
