)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2d599b25ec374ed14cee58eb480bd79c9d8ee3e8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The agent extensions code is migrating to neutron-lib.  This change"},{"line_number":10,"context_line":"reflects that migration in neutron."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"IMPORTANT: Please do not merge this code until 1 month after"},{"line_number":13,"context_line":"https://review.openstack.org/385045 merges."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie8f0e70b11435d627f73e3fed45f946e863e90bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_d5d66426","line":12,"updated":"2016-10-29 10:22:00.000000000","message":"Feel free to take this off and ping me when you\u0027re ready.","commit_id":"60fe28103475a6cb712572dc9ad5955218bf9ec8"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"6930e38fadfdb7361a62e6ac347daecf70d29831","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The agent extensions code is migrating to neutron-lib.  This change"},{"line_number":10,"context_line":"reflects that migration in neutron."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"IMPORTANT: Please do not merge this code until 1 month after"},{"line_number":13,"context_line":"https://review.openstack.org/385045 merges."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie8f0e70b11435d627f73e3fed45f946e863e90bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_b441b5ab","line":12,"in_reply_to":"ba5da102_d5d66426","updated":"2016-11-01 17:29:12.000000000","message":"Will do, thanks!","commit_id":"60fe28103475a6cb712572dc9ad5955218bf9ec8"}],"doc/source/contributor/internals/agent_extensions.rst":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ac96e16596772d75bc6aa202f583068a9c7bcab9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"The relevant modules are:"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"* neutron_lib.agent.extension"},{"line_number":103,"context_line":"* neutron_lib.agent.l2_extension_api"},{"line_number":104,"context_line":"* neutron_lib.agent.l3_extension_api"},{"line_number":105,"context_line":"* neutron.agent.agent_extensions_manager"},{"line_number":106,"context_line":"* neutron.agent.l2.l2_agent_extensions_manager"},{"line_number":107,"context_line":"* neutron.agent.l3.l3_agent_extensions_manager"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7f515b1d_11b85d28","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":36},"updated":"2017-09-22 13:44:12.000000000","message":"I think we need to drop the \"_api\" off the end... The modules names as-is here don\u0027t exist.","commit_id":"cdeda527d5638e5ee4ab81c5c331a8517b37023f"}],"neutron/agent/l2/extensions/qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ca57c18a3fc02c5042648153f110c9913943606c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_lib.agent import l2_extension"},{"line_number":20,"context_line":"from neutron_lib import exceptions"},{"line_number":21,"context_line":"from oslo_concurrency import lockutils"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_b83a8ae4","line":20,"range":{"start_line":20,"start_character":24,"end_line":20,"end_character":34},"updated":"2017-06-30 07:37:03.000000000","message":"not used\n\n ./neutron/agent/l2/extensions/qos.py:20:1: F401 \u0027exceptions\u0027 imported but unused","commit_id":"d7548455d2c5d7793e8eef9893116d71d3b0fc4a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"31bde36bdf088fdcb0b3a06815981687ce8d8a55","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron_lib import constants"},{"line_number":20,"context_line":"from neutron_lib.services.qos import constants as qos_consts"},{"line_number":21,"context_line":"from neutron_lib.agent import l2_extension"},{"line_number":22,"context_line":"from oslo_concurrency import lockutils"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f4b6375_ac503c33","line":21,"updated":"2017-11-07 14:43:40.000000000","message":"it should be above L19 to make pep8 happy","commit_id":"040b6e061d6e56084b32547a09f032e380d01df6"}],"neutron/agent/l3/l3_agent_extension.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"6f7ba7da4609624288cfa399438e70541e74fc0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3f4b6375_9e98ed75","updated":"2017-11-08 14:23:16.000000000","message":"I looks like there was a change here that added a new method. While this new method has been added to neutron-lib it doesn\u0027t appear to be released yet. So I think this patch needs to wait for neutron-lib 1.12.0.\n\nSee patches on: https://review.openstack.org/#/q/message:%22Add+a+new+method+ha_state_change+to+L3+agent+extension%22","commit_id":"4dd305a9748f64b1bcefc4fe7073dabccb280605"}],"neutron/conf/agent/common.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ac96e16596772d75bc6aa202f583068a9c7bcab9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                      \"XenAPI session to pass commands to Dom0.\")),"},{"line_number":101,"context_line":"]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"AGENT_EXT_MANAGER_OPTS \u003d ["},{"line_number":104,"context_line":"    cfg.ListOpt(\u0027extensions\u0027,"},{"line_number":105,"context_line":"                default\u003d[],"},{"line_number":106,"context_line":"                help\u003d_(\u0027Extensions list to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":11,"id":"7f515b1d_3170f972","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":22},"updated":"2017-09-22 13:44:12.000000000","message":"I must be missing something; why are we adding this opt here?\n\nI thought it was already defined in: https://github.com/openstack/neutron/blob/master/neutron/conf/agent/agent_extensions_manager.py","commit_id":"cdeda527d5638e5ee4ab81c5c331a8517b37023f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c52559c0aca0ce98e73811175627ca05ff22dbed","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    conf.register_opts(ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"def register_agent_extension(conf):"},{"line_number":210,"context_line":"    conf.register_opts(AGENT_EXT_MANAGER_OPTS, \u0027AGENT\u0027)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_b0921f56","line":209,"updated":"2017-10-09 13:31:54.000000000","message":"This is already defined in [1] why do we need to duplicate it here?\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/conf/agent/agent_extensions_manager.py","commit_id":"78bc156a2bea512fdabc3bceab82ffcc00936e25"}]}