)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"0ba811d51c20ec605f07bbd59ea9723c5ab3b847","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Destroy embedded eswitch when device\u0027s VFs are not used"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case that no VF is used there is no use for the embedded eswitch,"},{"line_number":10,"context_line":"we can delete it and free memory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id94aaf2b56dbc1c4175b39e8f51bc33b1c4689f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_4bb28907","line":10,"updated":"2016-11-01 12:17:41.000000000","message":"Maybe change for: In case there is no VF used, we can safely delete the embedded eswitch and free it from memory.","commit_id":"c0dab627efd085c763d7fd10f4596089ab512a2b"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"8d2b032c182e4dff7af7670ef099b9269664e999","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Destroy embedded eswitch when device\u0027s VFs are not used"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case that no VF is used there is no use for the embedded eswitch,"},{"line_number":10,"context_line":"we can delete it and free memory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id94aaf2b56dbc1c4175b39e8f51bc33b1c4689f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_6b0f4d88","line":10,"in_reply_to":"ba5da102_4bb28907","updated":"2016-11-01 12:21:22.000000000","message":"Done","commit_id":"c0dab627efd085c763d7fd10f4596089ab512a2b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9944b5a69b9c808f0bfd623643d21372ed490c92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9a629dbe_7d1c8677","line":13,"updated":"2016-11-09 09:03:55.000000000","message":"any link to bug?","commit_id":"af6a074837b6a03a57dd00fad3ee7abe91afd5c1"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/eswitch_manager.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b0c974429773e62d8473b9e9b45194d416ec9903","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if embedded_switch and not embedded_switch.get_num_assigned_devices():"},{"line_number":411,"context_line":"            for pci_slot in embedded_switch.get_pci_slot_list():"},{"line_number":412,"context_line":"                del self.pci_slot_map[pci_slot]"},{"line_number":413,"context_line":"            for _key, switches in six.iteritems(self.emb_switches_map):"},{"line_number":414,"context_line":"                if embedded_switch in switches:"},{"line_number":415,"context_line":"                    switches.remove(embedded_switch),"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_71224f03","line":413,"updated":"2016-11-21 11:51:53.000000000","message":"Don\u0027t you just want self.emb_switches_map.values() ? This dictionary is tiny in python terms so a yielding iterator isn\u0027t necessary.","commit_id":"4bd28e798dfb5e17035725b5aa0316eb5e00e8fe"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"23a494e174d683f85e7b8d6f8b2bbb20972e5567","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if embedded_switch and not embedded_switch.get_num_assigned_devices():"},{"line_number":411,"context_line":"            for pci_slot in embedded_switch.get_pci_slot_list():"},{"line_number":412,"context_line":"                del self.pci_slot_map[pci_slot]"},{"line_number":413,"context_line":"            for _key, switches in six.iteritems(self.emb_switches_map):"},{"line_number":414,"context_line":"                if embedded_switch in switches:"},{"line_number":415,"context_line":"                    switches.remove(embedded_switch),"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_0c153d48","line":413,"in_reply_to":"7a77a97e_71224f03","updated":"2016-11-22 16:04:49.000000000","message":"Done","commit_id":"4bd28e798dfb5e17035725b5aa0316eb5e00e8fe"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b0c974429773e62d8473b9e9b45194d416ec9903","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                del self.pci_slot_map[pci_slot]"},{"line_number":413,"context_line":"            for _key, switches in six.iteritems(self.emb_switches_map):"},{"line_number":414,"context_line":"                if embedded_switch in switches:"},{"line_number":415,"context_line":"                    switches.remove(embedded_switch),"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _get_emb_eswitch(self, device_mac, pci_slot):"},{"line_number":418,"context_line":"        \"\"\"Get embedded switch."}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_911febb6","line":415,"updated":"2016-11-21 11:51:53.000000000","message":"trailing comma","commit_id":"4bd28e798dfb5e17035725b5aa0316eb5e00e8fe"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"23a494e174d683f85e7b8d6f8b2bbb20972e5567","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                del self.pci_slot_map[pci_slot]"},{"line_number":413,"context_line":"            for _key, switches in six.iteritems(self.emb_switches_map):"},{"line_number":414,"context_line":"                if embedded_switch in switches:"},{"line_number":415,"context_line":"                    switches.remove(embedded_switch),"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def _get_emb_eswitch(self, device_mac, pci_slot):"},{"line_number":418,"context_line":"        \"\"\"Get embedded switch."}],"source_content_type":"text/x-python","patch_set":11,"id":"7a77a97e_ec43a16a","line":415,"in_reply_to":"7a77a97e_911febb6","updated":"2016-11-22 16:04:49.000000000","message":"Done","commit_id":"4bd28e798dfb5e17035725b5aa0316eb5e00e8fe"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"9944b5a69b9c808f0bfd623643d21372ed490c92","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                            \u0027device\u0027: mac,"},{"line_number":348,"context_line":"                            \u0027profile\u0027: {\u0027pci_slot\u0027: pci_slot}}"},{"line_number":349,"context_line":"                    self.ext_manager.delete_port(self.context, port)"},{"line_number":350,"context_line":"                    self.eswitch_mgr.destroy_emb_switch(mac, pci_slot)"},{"line_number":351,"context_line":"                else:"},{"line_number":352,"context_line":"                    LOG.warning(_LW(\"port_id to device with MAC \""},{"line_number":353,"context_line":"                                    \"%s not found\"), mac)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_b87d4c70","line":350,"updated":"2016-11-09 09:03:55.000000000","message":"shouldn\u0027t this be on the last used device (VF) only?","commit_id":"af6a074837b6a03a57dd00fad3ee7abe91afd5c1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"beb81804b7add61db8bd576d0d805a1821c57214","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                            \u0027profile\u0027: {\u0027pci_slot\u0027: pci_slot}}"},{"line_number":349,"context_line":"                    self.ext_manager.delete_port(self.context, port)"},{"line_number":350,"context_line":"                    # remove the embedded eswitch if no devices are assigend"},{"line_number":351,"context_line":"                    self.eswitch_mgr.destroy_unassigned_emb_switch(mac,"},{"line_number":352,"context_line":"                                                                   pci_slot)"},{"line_number":353,"context_line":"                else:"},{"line_number":354,"context_line":"                    LOG.warning(_LW(\"port_id to device with MAC \""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_628c2c36","line":351,"updated":"2016-11-14 15:57:37.000000000","message":"I think it would make more sense to check if there are no ports left on the eswitch:\n\nif embedded_switch and not embedded_switch.get_num_assigned_devices():","commit_id":"b862bbb43b92c649a65b53871205f2dd6f0aecb6"}]}
