)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9e325fdf41dcdc92c6158f2b945bd64c77dcc613","unresolved":false,"context_lines":[{"line_number":11,"context_line":"DHCP ports can still be created automatically on service subnets."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I736262f2a7d3f3d7dfdc5276e2364aca7187d18b"},{"line_number":14,"context_line":"Closes-Bug: #1636963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_b7f1ad03","line":14,"updated":"2016-11-02 00:22:06.000000000","message":"The bug report concerns me. By creating a network that allows only compute:nova devices you could potentially not uplink the subnet via a router because now the router interface port can\u0027t be created...this is getting a slippery slope...","commit_id":"26c33609b5dfc4a9b5676b3a58ec6823f92a4834"}],"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9e325fdf41dcdc92c6158f2b945bd64c77dcc613","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":602,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"},{"line_number":605,"context_line":"            query \u003d query.outerjoin(ServiceType)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_57b5b12e","line":602,"updated":"2016-11-02 00:22:06.000000000","message":"I am always wary of special casing. Are we sure that dhcp ports are the only one exempt by this rule? Have you considered moving this logic in the caller? What if users after this complain that they see ports that they were not expected to see?\n\nThe manifestation of this bug is one of the reason why I disliked the use of device owners as a filter mechanism, not that I could predict the bug itself or suggest to do things differently now :)","commit_id":"26c33609b5dfc4a9b5676b3a58ec6823f92a4834"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"22d67d807766d69b381f72d539bb00aa0f83ceb7","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":602,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"},{"line_number":605,"context_line":"            query \u003d query.outerjoin(ServiceType)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_9ace902c","line":602,"in_reply_to":"ba5da102_17c4198f","updated":"2016-11-02 02:20:31.000000000","message":"Yeah, it\u0027s almost like we want to add \u0027network:dhcp\u0027 to the types if DHCP is enabled and there\u0027s a type set, but then users will be confused by seeing something they didn\u0027t configure.  I\u0027ll keep thinking...","commit_id":"26c33609b5dfc4a9b5676b3a58ec6823f92a4834"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c2eeea0a0d9ca429b16d0e9b402338f72416c75c","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":602,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"},{"line_number":605,"context_line":"            query \u003d query.outerjoin(ServiceType)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_7739d5a3","line":602,"in_reply_to":"ba5da102_17c4198f","updated":"2016-11-02 00:26:52.000000000","message":"s/override/force/","commit_id":"26c33609b5dfc4a9b5676b3a58ec6823f92a4834"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1a2036ab10224d76957014c34166f8d061755c0c","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":602,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"},{"line_number":605,"context_line":"            query \u003d query.outerjoin(ServiceType)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_17c4198f","line":602,"in_reply_to":"ba5da102_57b5b12e","updated":"2016-11-02 00:26:24.000000000","message":"Rather than special casing I wonder if it\u0027s better to provide a way for the caller to \u0027override\u0027 the creation of a specific device owner irrespective of the subnet\u0027s service types.","commit_id":"26c33609b5dfc4a9b5676b3a58ec6823f92a4834"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"c437712314d3a2c4b15d319fc69546ffbf9d5223","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":602,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"},{"line_number":605,"context_line":"            query \u003d query.outerjoin(ServiceType)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8b839a55","line":602,"in_reply_to":"ba5da102_9ace902c","updated":"2016-11-02 10:52:28.000000000","message":"Yeah, that\u0027s exactly the alternate approach I was thinking about last night. I think that makes more sense in the context of re-using the existing subnet selection logic, but as you say it could be confusing to users. But then again, so could seeing a \u0027network:dhcp\u0027 port on a subnet without that service type...","commit_id":"26c33609b5dfc4a9b5676b3a58ec6823f92a4834"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"fba5e49a06e667970978be805bff17032a4c8eee","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":601,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":602,"context_line":"            # TODO(korzen) use SubnetServiceType OVO here"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_98e0232b","line":601,"range":{"start_line":601,"start_character":50,"end_line":601,"end_character":51},"updated":"2016-12-06 15:58:01.000000000","message":"Just a quick thought on this. According to the Service Type\u0027s semantics, if the subnet has dhcp enabled, then it should have a service type of network:dhcp in its service type table. So the fix should be adding network:dhcp in the subnet\u0027s service type table when the subnet is created with dhcp enabled.","commit_id":"f44f9241c0e65d155fd8c3a4fd5a0d184f7b5a9a"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"5923ef585594c5f91fda3bae97d3721aa4c36eeb","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":601,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":602,"context_line":"            # TODO(korzen) use SubnetServiceType OVO here"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_c0ecfd91","line":601,"range":{"start_line":601,"start_character":50,"end_line":601,"end_character":51},"in_reply_to":"3a71b18c_728cf435","updated":"2016-12-08 14:13:21.000000000","message":"I agree in most part. A couple of points:\n  -- seems to me all the subnets created with neutron, by default, can be used for nova:compute\n  -- if a subnet created without --service-type allows to be used for any allocation, then additional service types (such as network:dhcp) should only be applied when the config option appears on the call. \n\nBut I think given what the service type does right now, the fix should be fine.","commit_id":"f44f9241c0e65d155fd8c3a4fd5a0d184f7b5a9a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a53c5fd9962ffd43f67426238f1a48355756fb2b","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        return query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _query_filter_service_subnets(self, query, service_type):"},{"line_number":601,"context_line":"        if service_type !\u003d const.DEVICE_OWNER_DHCP:"},{"line_number":602,"context_line":"            # TODO(korzen) use SubnetServiceType OVO here"},{"line_number":603,"context_line":"            ServiceType \u003d sst_model.SubnetServiceType"},{"line_number":604,"context_line":"            query \u003d query.add_entity(ServiceType)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_728cf435","line":601,"range":{"start_line":601,"start_character":50,"end_line":601,"end_character":51},"in_reply_to":"3a71b18c_98e0232b","updated":"2016-12-08 03:53:46.000000000","message":"Robert, thanks for the comment.\n\nThat is the other option that we had discussed in PS1.  We simply chose this way so the user doesn\u0027t see a type in the subnet that they didn\u0027t add.  If we went this route then we would have to not allow network:dhcp to be removed from the list of types as well except when dhcp is disabled.\n\nBut I\u0027m also not sure this would work since if a subnet without a type is created, but we add network:dhcp, then a \"normal\" allocation from it for a compute port will fail since compute:* isn\u0027t in the type list.\n\nMaybe a better solution is to allow network:dhcp to succeed if dhcp is enabled on the subnet.  The result would be the same, but then at least we have something to trigger the right behavior.\n\nWe can talk about it in the L3 meeting tomorrow, I added it to the agenda.","commit_id":"f44f9241c0e65d155fd8c3a4fd5a0d184f7b5a9a"}],"neutron/tests/unit/extensions/test_subnet_service_types.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"00f98363599edfdc88992f16d9f80a1890f362e9","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_create_dhcp_port_compute_subnet(self):"},{"line_number":278,"context_line":"        with self.network() as network:"},{"line_number":279,"context_line":"            pass"},{"line_number":280,"context_line":"        res \u003d self._create_service_subnet([\u0027compute:nova\u0027], network\u003dnetwork)"},{"line_number":281,"context_line":"        subnet \u003d self.deserialize(\u0027json\u0027, res)[\u0027subnet\u0027]"},{"line_number":282,"context_line":"        network \u003d network[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_003c5c92","line":279,"range":{"start_line":279,"start_character":12,"end_line":279,"end_character":16},"updated":"2016-12-01 14:27:08.000000000","message":"shouldn\u0027t be better to use skipTest method?\n\nself.skipTest(\"Skip test for ...\")","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"cca28d202b16cff7f752408a481a3379a38e1430","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_create_dhcp_port_compute_subnet(self):"},{"line_number":278,"context_line":"        with self.network() as network:"},{"line_number":279,"context_line":"            pass"},{"line_number":280,"context_line":"        res \u003d self._create_service_subnet([\u0027compute:nova\u0027], network\u003dnetwork)"},{"line_number":281,"context_line":"        subnet \u003d self.deserialize(\u0027json\u0027, res)[\u0027subnet\u0027]"},{"line_number":282,"context_line":"        network \u003d network[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_db81754f","line":279,"range":{"start_line":279,"start_character":12,"end_line":279,"end_character":16},"in_reply_to":"3a71b18c_003c5c92","updated":"2016-12-01 14:38:15.000000000","message":"This isn\u0027t skipping the test, it\u0027s just allowing the flow to continue without executing any code in the \"with\" block after initializing the network object for the block below. See https://docs.python.org/3/tutorial/controlflow.html#pass-statements","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"544c38167cf0b78236d8c39d1ac20090f7f55455","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_create_dhcp_port_compute_subnet(self, enable_dhcp\u003dTrue):"},{"line_number":279,"context_line":"        with self.network() as network:"},{"line_number":280,"context_line":"            pass"},{"line_number":281,"context_line":"        res \u003d self._create_service_subnet([\u0027compute:nova\u0027],"},{"line_number":282,"context_line":"                                          network\u003dnetwork,"},{"line_number":283,"context_line":"                                          enable_dhcp\u003denable_dhcp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_b2f17297","line":280,"updated":"2016-12-16 14:02:20.000000000","message":"It\u0027s old crap. We used to cleanup the network on context manager exit, but now we don\u0027t. The review oberhead to replace all of the uses with a function call instead of a context manager is massive, so it just continues this way. :)","commit_id":"1800ae63c2c1b6366f555c2f943e97f361c9ecd4"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"6cbfe45f5124bb0752d20ea1a7a6f9e3679148e5","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_create_dhcp_port_compute_subnet(self, enable_dhcp\u003dTrue):"},{"line_number":279,"context_line":"        with self.network() as network:"},{"line_number":280,"context_line":"            pass"},{"line_number":281,"context_line":"        res \u003d self._create_service_subnet([\u0027compute:nova\u0027],"},{"line_number":282,"context_line":"                                          network\u003dnetwork,"},{"line_number":283,"context_line":"                                          enable_dhcp\u003denable_dhcp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_77d9b1f2","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":16},"updated":"2016-12-12 17:21:24.000000000","message":"Just curious. I see a lot of code as in above in the unit tests, but wonder why.\n\nnetwork() has \u0027yield\u0027 as the last statement.","commit_id":"1800ae63c2c1b6366f555c2f943e97f361c9ecd4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"053fe4c4595fe9fe201e2251c4c09d7d49beedb1","unresolved":false,"context_lines":[{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_create_dhcp_port_compute_subnet(self, enable_dhcp\u003dTrue):"},{"line_number":279,"context_line":"        with self.network() as network:"},{"line_number":280,"context_line":"            pass"},{"line_number":281,"context_line":"        res \u003d self._create_service_subnet([\u0027compute:nova\u0027],"},{"line_number":282,"context_line":"                                          network\u003dnetwork,"},{"line_number":283,"context_line":"                                          enable_dhcp\u003denable_dhcp)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_4b7cc020","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":16},"in_reply_to":"3a71b18c_77d9b1f2","updated":"2016-12-12 19:41:29.000000000","message":"It\u0027s just creating a network for the test, someone posted a link once to the document describing it I just don\u0027t have it handy.","commit_id":"1800ae63c2c1b6366f555c2f943e97f361c9ecd4"}],"releasenotes/notes/dhcp-for-service-subnets-06f03d902f2fb738.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4b66f70d07381aba26a8c28681cdedf6c4d19ee7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - A special case has been added to allow the creation of dhcp ports"},{"line_number":4,"context_line":"    on Service Subnets that do not have the service type \"network:dhcp\"."},{"line_number":5,"context_line":"    This fixes the recurring error seen when neutron attempts to"},{"line_number":6,"context_line":"    automatically create a dhcp port on a dhcp-enabled subnet after the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_e303e70d","line":3,"range":{"start_line":3,"start_character":59,"end_line":3,"end_character":63},"updated":"2016-12-01 15:40:23.000000000","message":"nit: DHCP","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"cb8e3c594d012103cc0415965099e1dbeda7c687","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - A special case has been added to allow the creation of dhcp ports"},{"line_number":4,"context_line":"    on Service Subnets that do not have the service type \"network:dhcp\"."},{"line_number":5,"context_line":"    This fixes the recurring error seen when neutron attempts to"},{"line_number":6,"context_line":"    automatically create a dhcp port on a dhcp-enabled subnet after the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_2636cd03","line":3,"range":{"start_line":3,"start_character":59,"end_line":3,"end_character":63},"in_reply_to":"3a71b18c_e303e70d","updated":"2016-12-01 15:50:00.000000000","message":"Done","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4b66f70d07381aba26a8c28681cdedf6c4d19ee7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - A special case has been added to allow the creation of dhcp ports"},{"line_number":4,"context_line":"    on Service Subnets that do not have the service type \"network:dhcp\"."},{"line_number":5,"context_line":"    This fixes the recurring error seen when neutron attempts to"},{"line_number":6,"context_line":"    automatically create a dhcp port on a dhcp-enabled subnet after the"},{"line_number":7,"context_line":"    subnet is created."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_8613215c","line":6,"updated":"2016-12-01 15:40:23.000000000","message":"DHCP here too","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"cb8e3c594d012103cc0415965099e1dbeda7c687","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - A special case has been added to allow the creation of dhcp ports"},{"line_number":4,"context_line":"    on Service Subnets that do not have the service type \"network:dhcp\"."},{"line_number":5,"context_line":"    This fixes the recurring error seen when neutron attempts to"},{"line_number":6,"context_line":"    automatically create a dhcp port on a dhcp-enabled subnet after the"},{"line_number":7,"context_line":"    subnet is created."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_463bc9eb","line":6,"in_reply_to":"3a71b18c_8613215c","updated":"2016-12-01 15:50:00.000000000","message":"Done","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4b66f70d07381aba26a8c28681cdedf6c4d19ee7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    on Service Subnets that do not have the service type \"network:dhcp\"."},{"line_number":5,"context_line":"    This fixes the recurring error seen when neutron attempts to"},{"line_number":6,"context_line":"    automatically create a dhcp port on a dhcp-enabled subnet after the"},{"line_number":7,"context_line":"    subnet is created."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_6317d751","line":7,"updated":"2016-12-01 15:40:23.000000000","message":"Should add a link to the bug, I think this should work:\n\nSee bug report `1636963 \u003chttps://bugs.launchpad.net/neutron/+bug/1636963\u003e`_ for more details.","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"cb8e3c594d012103cc0415965099e1dbeda7c687","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    on Service Subnets that do not have the service type \"network:dhcp\"."},{"line_number":5,"context_line":"    This fixes the recurring error seen when neutron attempts to"},{"line_number":6,"context_line":"    automatically create a dhcp port on a dhcp-enabled subnet after the"},{"line_number":7,"context_line":"    subnet is created."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a71b18c_6640c557","line":7,"in_reply_to":"3a71b18c_6317d751","updated":"2016-12-01 15:50:00.000000000","message":"Done","commit_id":"49d0baa7f8d880585002f39043b0df8723ef8f58"}]}
