)]}'
{"quantum/agent/linux/ovs_lib.py":[{"author":{"_account_id":2531,"name":"Xu Chen","email":"xchenum@gmail.com","username":"xchenum"},"change_message_id":"ac11ce431202539d535c7040aba976b1432506eb","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"def get_bridge_external_bridge_id(root_helper, bridge):"},{"line_number":313,"context_line":"    args \u003d [\"ovs-vsctl\", \"--timeout\u003d2\", \"br-get-external-id\","},{"line_number":314,"context_line":"            bridge, \"bridge-id\"]"},{"line_number":315,"context_line":"    try:"},{"line_number":316,"context_line":"        return utils.execute(args, root_helper\u003droot_helper).strip()"},{"line_number":317,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FYiQ%3D","line":314,"updated":"2013-11-07 16:19:16.000000000","message":"Note that, for openvswitch 2.0, the bridge-id for br-ex is by default empty, unlike OVS 1.4 in my testbed. There is no code in neutron now that actually sets/ensures the bridge-id for br-ex, so this is actually broken - ports on the routers are showing as down..","commit_id":"48efc596247ef0f7b5c412a77cd3cd9d84398398"}],"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4ac5057ffd8cd72c7611e7ae27382ad14420acd2","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                            \"%(device)s: %(e)s\"),"},{"line_number":680,"context_line":"                          {\u0027device\u0027: device, \u0027e\u0027: e})"},{"line_number":681,"context_line":"                resync \u003d True"},{"line_number":682,"context_line":"                continue"},{"line_number":683,"context_line":"        return resync"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def treat_devices_removed(self, devices):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FfOk%3D","line":682,"updated":"2013-07-30 12:01:09.000000000","message":"Does the get_device_details() have a side effect, such that every device needs to be processed? Otherwise, could return immediately, no?","commit_id":"48efc596247ef0f7b5c412a77cd3cd9d84398398"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4ac5057ffd8cd72c7611e7ae27382ad14420acd2","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                LOG.debug(_(\"port_removed failed for %(device)s: %(e)s\"),"},{"line_number":717,"context_line":"                          {\u0027device\u0027: device, \u0027e\u0027: e})"},{"line_number":718,"context_line":"                resync \u003d True"},{"line_number":719,"context_line":"                continue"},{"line_number":720,"context_line":"            if details[\u0027exists\u0027]:"},{"line_number":721,"context_line":"                LOG.info(_(\"Port %s updated.\"), device)"},{"line_number":722,"context_line":"                # Nothing to do regarding local networking"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FfNc%3D","line":719,"updated":"2013-07-30 12:01:09.000000000","message":"Is the desire to try to update all of the devices, even if a resync is required for one of them?","commit_id":"48efc596247ef0f7b5c412a77cd3cd9d84398398"}],"quantum/tests/unit/openvswitch/test_ovs_quantum_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4ac5057ffd8cd72c7611e7ae27382ad14420acd2","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                self.assertTrue(device_removed.called)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class AncillaryBridgesTest(base.BaseTestCase):"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def setUp(self):"},{"line_number":202,"context_line":"        super(AncillaryBridgesTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FfMs%3D","line":199,"updated":"2013-07-30 12:01:09.000000000","message":"Tests for detecting when resync is needed (for the new functions added)?","commit_id":"48efc596247ef0f7b5c412a77cd3cd9d84398398"}]}