)]}'
{"neutron/db/metering/metering_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6687241ee59df4bab9b0607122ac04714ca1a20d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    excluded\u003dm[\u0027excluded\u0027],"},{"line_number":163,"context_line":"                    remote_ip_prefix\u003dip_prefix)"},{"line_number":164,"context_line":"                context.session.add(metering_db)"},{"line_number":165,"context_line":"                # we need to make dict here where metering_db exists within"},{"line_number":166,"context_line":"                # current session"},{"line_number":167,"context_line":"                metering_dict \u003d self._make_metering_label_rule_dict("},{"line_number":168,"context_line":"                    metering_db)"},{"line_number":169,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":170,"context_line":"            raise metering.MeteringLabelNotFound(label_id\u003dlabel_id)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_a4d6b1ee","line":168,"range":{"start_line":165,"start_character":16,"end_line":168,"end_character":32},"updated":"2016-11-18 05:04:50.000000000","message":"I\u0027m trying to think in a scenario where you can create a rule successfully without assigning anything to metering_db. In other words, I don\u0027t think that is necessary to move this method.","commit_id":"2cdf8a181f79406221d9cf790e56b7101dc583c0"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8b7b9fb071bcaa7e45e9c32b928d22adfbcf395e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    excluded\u003dm[\u0027excluded\u0027],"},{"line_number":163,"context_line":"                    remote_ip_prefix\u003dip_prefix)"},{"line_number":164,"context_line":"                context.session.add(metering_db)"},{"line_number":165,"context_line":"                # we need to make dict here where metering_db exists within"},{"line_number":166,"context_line":"                # current session"},{"line_number":167,"context_line":"                metering_dict \u003d self._make_metering_label_rule_dict("},{"line_number":168,"context_line":"                    metering_db)"},{"line_number":169,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":170,"context_line":"            raise metering.MeteringLabelNotFound(label_id\u003dlabel_id)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_42014a05","line":168,"range":{"start_line":165,"start_character":16,"end_line":168,"end_character":32},"in_reply_to":"7a77a97e_a4d6b1ee","updated":"2016-11-18 09:28:23.000000000","message":"We need to move _make_dict if it try to load some relationships from db using db object in it. But seems here this not needed as  _make_metering_label_rule_dict not trying to load routers. I will push new patch set, thanks.","commit_id":"2cdf8a181f79406221d9cf790e56b7101dc583c0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"20e53e1cfa80c8251b794d67aebb05446617e91e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                shared\u003dm[\u0027shared\u0027])"},{"line_number":60,"context_line":"            context.session.add(metering_db)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        return self._make_metering_label_dict(metering_db)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def delete_metering_label(self, context, label_id):"},{"line_number":65,"context_line":"        with db_api.context_manager.writer.using(context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_0799d61f","line":62,"updated":"2016-11-21 13:36:46.000000000","message":"What would be the penalty for *always* making dicts from objs inside  the transaction? It seems to me that if _make_\u003cfoo\u003e_dict() doesn\u0027t load relationships then it should be fast so the penalty will be small. A consistent usage pattern might be easier to maintain, and if someone adds a relationship load to a make_dict it won\u0027t break.","commit_id":"43b75bfb59f5ceb1a197489978a589829d53c246"}]}
