)]}'
{"devstack/lib/rally":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7152741b812784ba7583a5acc217f46527c83b6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"if [ -z \"$RALLY_SCENARIO\" ]"},{"line_number":2,"context_line":"then"},{"line_number":3,"context_line":"    enable_service q-trunk"},{"line_number":4,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_0a120757","line":1,"updated":"2016-11-02 21:54:11.000000000","message":"may I ask for details on why we cannot have trunk service plugin enabled when executing rally scenarios?","commit_id":"ee60da4c5e7daac9ce80900f0e9b51e5f95ce5f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4f5ed22e32847ffdb917e5ac4f6a5b5680748142","unresolved":false,"context_lines":[{"line_number":1,"context_line":"if [ -z \"$RALLY_SCENARIO\" ]"},{"line_number":2,"context_line":"then"},{"line_number":3,"context_line":"    enable_service q-trunk"},{"line_number":4,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_aa9e7b04","line":1,"in_reply_to":"ba5da102_0a120757","updated":"2016-11-02 22:22:03.000000000","message":"This if is enabling trunk when RALLY_SCENARIO is defined.","commit_id":"ee60da4c5e7daac9ce80900f0e9b51e5f95ce5f9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aed661bc6390e95a4e4f9ab92d831ff1938662e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"if [ -z \"$RALLY_SCENARIO\" ]"},{"line_number":2,"context_line":"then"},{"line_number":3,"context_line":"    enable_service q-trunk"},{"line_number":4,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ba5da102_a5b30c09","line":1,"in_reply_to":"ba5da102_aa9e7b04","updated":"2016-11-02 22:42:46.000000000","message":"Nope, you use -z here.\n\nAlso, consider moving that logic into gate hook, since there is nothing non-gate-specific in that variable. I prefer we don\u0027t fill devstack plugin with gate details.","commit_id":"ee60da4c5e7daac9ce80900f0e9b51e5f95ce5f9"}]}
