)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba5da102_8dbe03ac","updated":"2016-11-03 21:42:39.000000000","message":"Add custom OVO field type for UUID Field\n\nOslo Versioned Objects implementation of the UUID Field doesn\u0027t carry\nout any form of validation. It is only a wrapper around a string\ntype. This might cause issues in code that assumes the stored value is\nvalidated.\n\nThis patchset re-defines the OVO UUIDField class to validate the values\nstored in it. Also, all the objects using UUIDField are updated to\nrefer to the new custom type.\n\nCloses-Bug: #1614537","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"0ec0655b5b942ed45a99ba579880b6d2b4e90ff3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zainub Wahid \u003czainub.wahid@pivot-tech.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-03 09:52:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron Objects do not override the UUIDFIELD to actually vallidate UUIDs"},{"line_number":8,"context_line":"Changes bug: 1614537"},{"line_number":9,"context_line":"Similar to above solution but few extra solution."},{"line_number":10,"context_line":"Override the UUIDField in Neutron/objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_01e00ccc","line":7,"updated":"2016-11-03 15:13:56.000000000","message":"The commit message should state what the commit changes. This statement doesn\u0027t make it clear whether \"do not override\" is the incorrect behavior that you\u0027re fixing or the correct behavior that you\u0027re implementing.\n\nSomething like \"Stop Neutron Objects from overriding UUIDFIELD\" or \"Make Neutron Objects override UUIDFIELD\" would be better.\n\nIf it\u0027s difficult to reflect the \"why\", it can be helpful to use the words \"Problem\" and \"Solution\" or \"Fix\" in the body.\n\ne.g.\nProblem: UUIDs aren\u0027t being validated because Neutron objects override the UUIDFIELD\n\nFix: Make Neutron Objects NOT override the UUIDFIELD so that the UUID can be validated","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"0ec0655b5b942ed45a99ba579880b6d2b4e90ff3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-03 09:52:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron Objects do not override the UUIDFIELD to actually vallidate UUIDs"},{"line_number":8,"context_line":"Changes bug: 1614537"},{"line_number":9,"context_line":"Similar to above solution but few extra solution."},{"line_number":10,"context_line":"Override the UUIDField in Neutron/objects"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba5da102_a175a0cb","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":7},"updated":"2016-11-03 15:13:56.000000000","message":"Is this correct? I\u0027ve seen \"Closes\" or \"Partial\" but I\u0027m not sure what \"Changes bug\" means. Does it fix the bug? \"Changes bug\" sounds like causing one sort of bug to become a different sort of bug rather than actually fixing it.","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0e5d555c6b5f65103a90e3ecdc52cbbb538c93af","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-08 10:34:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make UUIDField actually validate UUIDs"},{"line_number":8,"context_line":"Partial bug: 1614537"},{"line_number":9,"context_line":"Instead of using oslo-versioned UUIDs, I wrote UUIDField class in "},{"line_number":10,"context_line":"common_types and import it in all other Neutron objects. "},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a629dbe_20b11e90","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":11},"updated":"2016-11-08 19:14:31.000000000","message":"Why do you think this is only a partial fix to the bug? I maybe wrong, but I think it closes the bug, so you should use:\n\nCloses-Bug: #1614537\n\nAlso please move this line right above the Change-Id, leaving one blank line above and below it","commit_id":"e4c5757edcc9733fcdbaeea85849e12c4ee8c26d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0e5d555c6b5f65103a90e3ecdc52cbbb538c93af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make UUIDField actually validate UUIDs"},{"line_number":8,"context_line":"Partial bug: 1614537"},{"line_number":9,"context_line":"Instead of using oslo-versioned UUIDs, I wrote UUIDField class in "},{"line_number":10,"context_line":"common_types and import it in all other Neutron objects. "},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I20b24ee57c521b1c68977c2ff7ae56b56875dd64"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a629dbe_206e7e2f","line":9,"updated":"2016-11-08 19:14:31.000000000","message":"Please remove blank character at end of line","commit_id":"e4c5757edcc9733fcdbaeea85849e12c4ee8c26d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0e5d555c6b5f65103a90e3ecdc52cbbb538c93af","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make UUIDField actually validate UUIDs"},{"line_number":8,"context_line":"Partial bug: 1614537"},{"line_number":9,"context_line":"Instead of using oslo-versioned UUIDs, I wrote UUIDField class in "},{"line_number":10,"context_line":"common_types and import it in all other Neutron objects. "},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I20b24ee57c521b1c68977c2ff7ae56b56875dd64"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a629dbe_8073ca14","line":10,"updated":"2016-11-08 19:14:31.000000000","message":"Please remove blank character at end of line","commit_id":"e4c5757edcc9733fcdbaeea85849e12c4ee8c26d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"821529622d4703af73b4d758bf97a52e0dc752ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make UUIDField actually validate UUIDs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of using oslo-versioned UUIDs, I wrote UUIDField class in"},{"line_number":10,"context_line":"common_types and import it in all other Neutron objects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1614537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5a74a57a_858b651e","line":9,"updated":"2016-11-28 18:15:41.000000000","message":"nit: IMHO the commit message is not mentioning the problem statement or it\u0027s assuming it.  Even when it\u0027s related with LP, it\u0027s a good practice[1] to put some context here.\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"1c364b9ace943d842ce5126e7a6ac07b940ace1a"}],"neutron/objects/common_types.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"0ec0655b5b942ed45a99ba579880b6d2b4e90ff3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    AUTO_TYPE \u003d IPNetwork()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"class UUID(obj_fields.UUID):"},{"line_number":208,"context_line":"    def ceorce(self, obj, attr, value):"},{"line_number":209,"context_line":"        uuid.UUID(value)"},{"line_number":210,"context_line":"        return str(value)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_a1f6808c","line":208,"range":{"start_line":208,"start_character":8,"end_line":208,"end_character":14},"updated":"2016-11-03 15:13:56.000000000","message":"Is this supposed to be the word \"coerce\" as in force something to do something? If so, it\u0027s misspelled.","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":207,"context_line":"class UUID(obj_fields.UUID):"},{"line_number":208,"context_line":"    def ceorce(self, obj, attr, value):"},{"line_number":209,"context_line":"        uuid.UUID(value)"},{"line_number":210,"context_line":"        return str(value)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"class UUIDField(obj_fields.AutoTypedField):"},{"line_number":213,"context_line":"    AUTO_TYPE \u003d UUID()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_137e9069","line":210,"updated":"2016-11-03 21:42:39.000000000","message":"I think you need the super class coerce method. Please look at other coerce methods in this module as examples","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4fb95da75a4f64dae63692915a713af4e693cc9a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import itertools"},{"line_number":15,"context_line":"import six"},{"line_number":16,"context_line":"import uuid"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a629dbe_64b9f8cb","line":15,"updated":"2016-11-10 22:17:30.000000000","message":"I searched through the Neutron repo and found that six is considered a third party library. As a consequence, this import should be in the next section, i.e.right after line 21 below","commit_id":"aaf96b4061dc72fe4d500e83bfb3b503203826fd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"064b73508e15fd919b4036d51d093a6f38bb5e16","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    AUTO_TYPE \u003d IPNetwork()"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"class UUID(obj_fields.UUID):"},{"line_number":214,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":215,"context_line":"        uuid.UUID(str(value))"},{"line_number":216,"context_line":"        return str(value)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_cbfa1943","line":213,"updated":"2016-11-25 14:37:31.000000000","message":"add TODO suggesting to switch back to oslo.versionedobjects type when validation is enabled there","commit_id":"9c682c2e5282fe62677feaf4992c0b2e0f6db80f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9052f3fa8a87d6691cc3a1f36789e6e8ea9b80fe","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    AUTO_TYPE \u003d IPNetwork()"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"class UUID(obj_fields.UUID):"},{"line_number":214,"context_line":"    def coerce(self, obj, attr, value):"},{"line_number":215,"context_line":"        uuid.UUID(str(value))"},{"line_number":216,"context_line":"        return str(value)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_8e974f47","line":213,"in_reply_to":"5a74a57a_cbfa1943","updated":"2016-11-25 14:49:01.000000000","message":"Done","commit_id":"9c682c2e5282fe62677feaf4992c0b2e0f6db80f"}],"neutron/objects/extensions/standardattributes.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"STANDARD_ATTRIBUTES \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_988d5fd5","line":13,"updated":"2016-11-03 21:42:39.000000000","message":"This change is completely unrelated to this patchset. It is recommended that only changes related to the topic described in your commit message are included in a patchset","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4fb95da75a4f64dae63692915a713af4e693cc9a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"STANDARD_ATTRIBUTES \u003d {"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a629dbe_44723412","side":"PARENT","line":12,"updated":"2016-11-10 22:17:30.000000000","message":"This change is unrelated to this patchset and unnecessary. Please restore this file to its previous state","commit_id":"efe87156c50145a8036b57426a43f54fad1da894"}],"neutron/objects/qos/policy.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.objects.db import api as obj_db_api"},{"line_number":31,"context_line":"from neutron.objects.qos import rule as rule_obj_impl"},{"line_number":32,"context_line":"from neutron.objects import rbac_db"},{"line_number":33,"context_line":"from neutron.objects import common_types"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":36,"context_line":"class QosPolicy(rbac_db.NeutronRbacObject):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_3828d399","line":33,"updated":"2016-11-03 21:42:39.000000000","message":"This import is out of alphabetical order it should go right after line 29 above. Please look at the 5th bullet here: http://docs.openstack.org/developer/hacking/#imports","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"}],"neutron/objects/trunk.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.objects import base"},{"line_number":23,"context_line":"from neutron.services.trunk import exceptions as t_exc"},{"line_number":24,"context_line":"from neutron.services.trunk import models"},{"line_number":25,"context_line":"from neutron.objects import common_types"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":28,"context_line":"class SubPort(base.NeutronDbObject):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_b3016407","line":25,"updated":"2016-11-03 21:42:39.000000000","message":"This import is out of order. It should go right after line 22 above. Please look at the 5th bullet here: http://docs.openstack.org/developer/hacking/#imports","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"}],"neutron/services/l3_router/service_providers/driver_controller.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d3f930ce948534fc5ad96d75d061ca3dcb68b2aa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        drv \u003d self._get_provider_for_create(context, router)"},{"line_number":81,"context_line":"        _ensure_driver_supports_request(drv, router)"},{"line_number":82,"context_line":"        self._stm.add_resource_association(context, \u0027L3_ROUTER_NAT\u0027,"},{"line_number":83,"context_line":"                                           drv.name, router[\u0027id\u0027])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _clear_router_provider(self, resource, event, trigger, context,"},{"line_number":86,"context_line":"                               router_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":35,"id":"3a71b18c_a8002e67","side":"PARENT","line":83,"updated":"2016-12-06 17:30:07.000000000","message":"This one shouldn\u0027t be touched. There are no Neutron versioned objects involved here. Please revert this file to its original state.","commit_id":"ef6a3d87891887f810187aabd3783ef9ac3145af"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c8785898ccbc67981aa147d7fdab7315fdc60166","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        _ensure_driver_supports_request(drv, router)"},{"line_number":82,"context_line":"        self._stm.add_resource_association(context, \u0027L3_ROUTER_NAT\u0027,"},{"line_number":83,"context_line":"                                           drv.name,"},{"line_number":84,"context_line":"                                           uuidutils.generate_uuid())"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _clear_router_provider(self, resource, event, trigger, context,"},{"line_number":87,"context_line":"                               router_id, **kwargs):"}],"source_content_type":"text/x-python","patch_set":37,"id":"3a71b18c_06bb9176","line":84,"updated":"2016-12-07 21:20:46.000000000","message":"I think you forgot to revert this line to its original form. Remember, this line should not be modified because this has nothing to do with Neutron versioned objects. It has to be restored to look exactly like the version on the left side of the screen. I checked the failures you have in Jenkins and they are all due to this line. They all get a traceback like this: http://paste.openstack.org/show/591726/. If you look at the last line, the failure is caused here.","commit_id":"0c74e7947f5aa47dba958b644025f86bd960ba52"}],"neutron/tests/unit/api/rpc/handlers/test_resources_rpc.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron import context"},{"line_number":27,"context_line":"from neutron.objects import base as objects_base"},{"line_number":28,"context_line":"from neutron.tests import base"},{"line_number":29,"context_line":"from neutron.objects import common_types"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"TEST_EVENT \u003d \u0027test_event\u0027"},{"line_number":32,"context_line":"TEST_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_5311e850","line":29,"updated":"2016-11-03 21:42:39.000000000","message":"This import is out of order. It should go right after line 27 above. Please look at the 5th bullet here: http://docs.openstack.org/developer/hacking/#imports","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4fb95da75a4f64dae63692915a713af4e693cc9a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron import context"},{"line_number":27,"context_line":"from neutron.objects import base as objects_base"},{"line_number":28,"context_line":"from neutron.tests import base"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"TEST_EVENT \u003d \u0027test_event\u0027"},{"line_number":32,"context_line":"TEST_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a629dbe_a46cf008","side":"PARENT","line":29,"updated":"2016-11-10 22:17:30.000000000","message":"This change is unrelated to this patchset and incorrect. Please restore this line","commit_id":"efe87156c50145a8036b57426a43f54fad1da894"}],"neutron/tests/unit/extensions/test_servicetype.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b8359a5ecc2fa6c2e2dfc1ed324d79f90feb2bab","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.manager.add_resource_association(ctx, constants.DUMMY,"},{"line_number":125,"context_line":"                                              \u0027dummy2\u0027, \u00273\u0027)"},{"line_number":126,"context_line":"        names_by_id \u003d self.manager.get_provider_names_by_resource_ids("},{"line_number":127,"context_line":"            ctx, [\u00271\u0027, \u00272\u0027, \u00273\u0027, \u00274\u0027])"},{"line_number":128,"context_line":"        # unmatched IDs will be excluded from the result"},{"line_number":129,"context_line":"        self.assertEqual({\u00271\u0027: \u0027dummy1\u0027, \u00272\u0027: \u0027dummy1\u0027, \u00273\u0027: \u0027dummy2\u0027},"},{"line_number":130,"context_line":"                         names_by_id)"}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_be5e5d43","side":"PARENT","line":127,"range":{"start_line":127,"start_character":18,"end_line":127,"end_character":31},"updated":"2016-12-01 17:34:47.000000000","message":"Hint: Look at lines 121, 123, 125, 129. Do you see these same values there? What does this mean for the modified version of this method that you wrote on the right side of the screen?","commit_id":"8427c0592f5b7042feb269c91092091c9be61c13"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3c5286081d647161c9c8e388ed8f66010f158370","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.manager.add_resource_association(ctx, constants.DUMMY,"},{"line_number":128,"context_line":"                                              \u0027dummy2\u0027,"},{"line_number":129,"context_line":"                                              uuidutils.generate_uuid())"},{"line_number":130,"context_line":"        names_by_id \u003d self.manager.get_provider_names_by_resource_ids("},{"line_number":131,"context_line":"            ctx, uuidutils.generate_uuid())"},{"line_number":132,"context_line":"        # unmatched IDs will be excluded from the result"},{"line_number":133,"context_line":"        self.assertEqual({uuidutils.generate_uuid(): \u0027dummy1\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_9a832956","line":130,"updated":"2016-12-02 19:43:17.000000000","message":"Let\u0027s understand what this test case is trying to do. The name of the test case is \u0027test_get_provider_names_by_resource_ids\u0027. So the whole point of this test case is to test method \u0027get_provider_names_by_resource_ids\u0027 (which is what you are calling in this line):\n\n1) From its name, we can deduce that \u0027get_provider_names_by_resource_ids\u0027 does a search where we are going to provide a list of ids (uuid\u0027s) and the response should be the provider names associated with those uuid\u0027s. In fact the result is going to be a dictionary of the form {uuid1: provider name1, uuid2: provider name2,....}\n\n2) But for the search to be successful, the provider names must already be associated with the uuid\u0027s that we provide as inputs. In fact, we know from the comment in line 132 below that if a uuid has not been associated previously with a provider name, it will be excluded from the dictionary that will be returned\n\n3) In lines 121 to 129 you establish the association of provider names (dummy1, dummy2) with with 3 uuid\u0027s. So what uuid\u0027s do you need to provide as input in the call to get_provider_names_by_resource_ids\u0027 in this line?","commit_id":"5b92866389d9fec09114babd55ea27220bfbe35b"}],"neutron/tests/unit/objects/extensions/test_standardattributes.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.objects import base as objects_base"},{"line_number":22,"context_line":"from neutron.tests.unit.objects import test_base"},{"line_number":23,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":24,"context_line":"from neutron.objects import common_types"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class FakeDbModelWithStandardAttributes("},{"line_number":27,"context_line":"        standard_attr.HasStandardAttributes, model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_b3288487","line":24,"updated":"2016-11-03 21:42:39.000000000","message":"This import is out of order. It should go right after line 21 above. Please look at the 5th bullet here: http://docs.openstack.org/developer/hacking/#imports","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0e5d555c6b5f65103a90e3ecdc52cbbb538c93af","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    obj_fields.BooleanField: tools.get_random_boolean,"},{"line_number":396,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":397,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":398,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":399,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":400,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":401,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_e082c6ff","line":398,"updated":"2016-11-08 19:14:31.000000000","message":"All your failures in the gate-neutron-python27-ubuntu-xenial, gate-neutron-python34, gate-neutron-python35 and neutron-coverage-ubuntu-xenial jobs (all unit tests) are the same:\n\nTraceback (most recent call last):\n    File \"neutron/tests/unit/objects/test_base.py\", line 537, in setUp\n        super(BaseObjectIfaceTestCase, self).setUp()\n    File \"neutron/tests/unit/objects/test_base.py\", line 461, in setUp\n        for _ in range(3)\n    File \"neutron/tests/unit/objects/test_base.py\", line 494, in get_random_fields\n        generator \u003d FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]\n        KeyError: \u003cclass \u0027oslo_versionedobjects.fields.UUIDField\u0027\u003e\n\nAs you can see, when generating random values for fields, some unit tests are still looking for the Oslo Versioned Objects UUID field in this dictionary. I think we need to have another line like this (while keeping the one you changed):\n\nobj_fields.UUIDField: uuidutils.generate_uuid,\n\nThis is done in the case of IPNetworkField. Looks at lines 405 and 406 below","commit_id":"e4c5757edcc9733fcdbaeea85849e12c4ee8c26d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"8ddc3a5ea65a5a1404b2ebc6e97597f4d4bbc769","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    obj_fields.BooleanField: tools.get_random_boolean,"},{"line_number":396,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":397,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":398,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":399,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":400,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":401,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a629dbe_87cc966b","line":398,"in_reply_to":"9a629dbe_e082c6ff","updated":"2016-11-09 15:28:21.000000000","message":"If some object requires to generate obj_fields.UUIDField, this means that something is still not converted to use new type...","commit_id":"e4c5757edcc9733fcdbaeea85849e12c4ee8c26d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b85f01ae66fd8cb8ce2f0d29001de5b55202088e","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    obj_fields.BooleanField: tools.get_random_boolean,"},{"line_number":396,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":397,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":398,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":399,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":400,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":401,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":402,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_a76c3a36","line":399,"range":{"start_line":398,"start_character":4,"end_line":399,"end_character":50},"updated":"2016-11-09 15:31:21.000000000","message":"I;m still seeing some code using obj_fields.UUIDField:\nhttps://github.com/openstack/neutron/blob/master/neutron/objects/network.py#L232\nhttps://github.com/openstack/neutron/blob/master/neutron/objects/router.py#L70\n\nFunny thing, that this lines are not available in this PS... the network.py and router.py does not have those lines...","commit_id":"5afcede472d5ccbd84c00629334fb07e0e16f63d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fae71d68bdfeb565b5a65235ccc1983e53dc2a97","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    obj_fields.BooleanField: tools.get_random_boolean,"},{"line_number":396,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":397,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":398,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":399,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":400,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":401,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":402,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_a627d3c8","line":399,"range":{"start_line":398,"start_character":4,"end_line":399,"end_character":50},"in_reply_to":"9a629dbe_4167c64c","updated":"2016-11-09 19:12:41.000000000","message":"Of course, another option is the rebase button in gerrit","commit_id":"5afcede472d5ccbd84c00629334fb07e0e16f63d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3f5ba959f414d23e5d689511b75b7c05d6e874b5","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    obj_fields.BooleanField: tools.get_random_boolean,"},{"line_number":396,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":397,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":398,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":399,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":400,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":401,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":402,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_4167c64c","line":399,"range":{"start_line":398,"start_character":4,"end_line":399,"end_character":50},"in_reply_to":"9a629dbe_a76c3a36","updated":"2016-11-09 17:55:38.000000000","message":"Ahhh, now I know what is happening....\n\n@Zainub,\n\nYou are using an old version of the Neutron repo that doesn\u0027t include yet the code that Artur is pointing out. However, when Jenkins runs tests on your patchset, it is using the most recent version of the Neutron code, that includes the lines that Artur is pointing to.\n\nYou have to pull the latest version of the Neutron master branch and rebase your branch on top of it, so it includes the latest code from the community. I just downloaded your branch to my local repo and rebased it on the latest master. Now I can see the lines Artur is pointing to.\n\nOnce you do the rebase, I would remove line 399 and submit another revision to your patchset to gerrit.\n\nSince your are a new contributor, I want to make sure you have all you need to continue:\n\n1) Do you know how to rebase your branch on top of master?\n2) Did you start a new branch before making changes for this patchset? I ask this because I notices that gerrit show that the branch is master\n3) I have noticed that you are making changes to your patchset in Gerrit directly. Do you know how to amend a patchset locally in your computer and submit that amend to Gerrit?\n\nIf the answer to these questions is no, don\u0027t worry. We will help you :-) Just respond to this indicating that you need help.","commit_id":"5afcede472d5ccbd84c00629334fb07e0e16f63d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"064b73508e15fd919b4036d51d093a6f38bb5e16","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":399,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":400,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":401,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":402,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":403,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":404,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_0bbed164","line":401,"updated":"2016-11-25 14:37:31.000000000","message":"I believe we can remove this line now","commit_id":"9c682c2e5282fe62677feaf4992c0b2e0f6db80f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9052f3fa8a87d6691cc3a1f36789e6e8ea9b80fe","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":399,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":400,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":401,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":402,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":403,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":404,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_ee9a836d","line":401,"in_reply_to":"5a74a57a_0bbed164","updated":"2016-11-25 14:49:01.000000000","message":"Done","commit_id":"9c682c2e5282fe62677feaf4992c0b2e0f6db80f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"862a8d747ec80403e4a439da6ae0f7e1df11b86c","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":399,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":400,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":401,"context_line":"    obj_fileds.UUIDField: uuidutils.generate_uuid,"},{"line_number":402,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":403,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":404,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a74a57a_d322c651","line":401,"updated":"2016-11-25 18:50:34.000000000","message":"it\u0027s not needed. you should instead fix tests failed in PS13 (we will need to change non-UUID ids in some test cases to proper UUIDs).","commit_id":"3526ac1be201b4e588969345e8367d5627f6d9c0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"890fe99338bd1f50ef23b4a508f5049e1145e9f8","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":399,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":400,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":401,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":402,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":403,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":404,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_67c12854","line":401,"updated":"2016-11-26 01:13:09.000000000","message":"You really don\u0027t need this line. Trust Ihar and me :-) Please remove it. Once you do this, let\u0027s get down to the job of fixing the 6 unit tests that are failing:\n\n1) Look at the results of job gate-neutron-python27-ubuntu-xenial (the failures for the python34, python35 and coverage jobs will be fixed once we fix this one because they run the same unit tests): http://logs.openstack.org/50/393150/15/check/gate-neutron-python27-ubuntu-xenial/6d8d5a7/console.html#_2016-11-25_19_53_48_219705\n\n2) As you can see, there are six failures. If you scroll down the failures, you will see that they are all due to: \u0027ValueError: badly formed hexadecimal UUID string\u0027\n\n3) Let\u0027s explore the traceback of the first failure at more detail: http://paste.openstack.org/show/590510/\n\n4) Look at lines 9 and 10 of the traceback. They point to a test, line 140 of neutron/tests/unit/extensions/test_servicetype.py: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/extensions/test_servicetype.py#L140. As you can see, the test is calling a method named add_resource_association.\n\n5) With that information in hand, we go down the traceback, and see in line 11 that add_resource_association is in neutron/db/servicetype_db.py: https://github.com/openstack/neutron/blob/master/neutron/db/servicetype_db.py#L80\n\n6) As you can see in the signature of that method, its last argument is resource_id. If you continue going down the traceback, you will see this argument is passed to several methods until it gets to your coerce method (line 23 in the traceback) here: https://review.openstack.org/#/c/393150/15/neutron/objects/common_types.py@215. Guess what: SUCCESS! Your change is doing exactly what it is supposed to do do: validate that the values stored in the uuid field of an object are indeed valid uuid\u0027s\n\n7) Now let\u0027s go back to the test: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/extensions/test_servicetype.py#L140. The test is passing to add_resource_association \u0027123-123\u0027 as the value for resource_id. That is not a valid uuid. All you need to do is change in the test in line \u0027123-123\u0027 to uuidutils.generate_uuid() (this generates a valid uuid). For this to work, you will have to add this line to your imports: \n\nfrom oslo_utils import uuidutils\n\nWith these changes, test neutron.tests.unit.extensions.test_servicetype.ServiceTypeManagerTestCase.test_add_resource_association runs successfully. I just tried it! We fixed failure 1!\n\nIf you perform a similar analysis for the other 5 failures, you will be able to fix all of them.","commit_id":"a40acc25f412f93f8a89f2c310e99ad6c2c848ab"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"821529622d4703af73b4d758bf97a52e0dc752ad","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    obj_fields.DateTimeField: tools.get_random_datetime,"},{"line_number":398,"context_line":"    obj_fields.IntegerField: tools.get_random_integer,"},{"line_number":399,"context_line":"    obj_fields.StringField: tools.get_random_string,"},{"line_number":400,"context_line":"    common_types.UUIDField: uuidutils.generate_uuid,"},{"line_number":401,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":402,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":403,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_e5cc19bd","line":400,"range":{"start_line":400,"start_character":4,"end_line":400,"end_character":52},"updated":"2016-11-28 18:15:41.000000000","message":"Most of the gate failures happens because there are OVO Implementations that haven\u0027t covered yet:\n\n* Agent - https://github.com/openstack/neutron/blob/master/neutron/objects/agent.py#L32\n* Floating IP - https://github.com/openstack/neutron/blob/master/neutron/objects/floatingip.py#L33\n* Network - https://github.com/openstack/neutron/blob/master/neutron/objects/network.py#L248\n* Service Type - https://github.com/openstack/neutron/blob/master/neutron/objects/servicetype.py#L34\n\nCould you modify those classes as well?","commit_id":"1c364b9ace943d842ce5126e7a6ac07b940ace1a"}],"neutron/tests/unit/objects/test_common_types.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values"},{"line_number":252,"context_line":"    def test_stringify(self):"},{"line_number":253,"context_line":"        for in_val, out_val in self.coerce_good_values:"},{"line_number":254,"context_line":"            self.assertEqual(\u0027%s\u0027 % in_val, self.field.stringify(in_val)) "}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_13593035","line":254,"updated":"2016-11-03 21:42:39.000000000","message":"Please remove the white space at the end of this line","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"}],"neutron/tests/unit/objects/test_rbac_db.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81c6cb1da9640679c103de6c80af95c767df656c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.objects import rbac_db"},{"line_number":27,"context_line":"from neutron.tests.unit.objects import test_base"},{"line_number":28,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":29,"context_line":"from neutron.objects import common_types"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class FakeDbModel(dict):"},{"line_number":32,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_d3797894","line":29,"updated":"2016-11-03 21:42:39.000000000","message":"This import is out of order. It should go right after line 24 above. Please look at the 5th bullet here: http://docs.openstack.org/developer/hacking/#imports","commit_id":"c0aa42e2708620d7369deb50fd98b44a0ff02670"}],"neutron/tests/unit/services/l3_router/service_providers/test_driver_controller.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d3f930ce948534fc5ad96d75d061ca3dcb68b2aa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def test__set_router_provider_attr_lookups(self):"},{"line_number":85,"context_line":"        # ensure correct drivers are looked up based on attrs"},{"line_number":86,"context_line":"        cases \u003d ["},{"line_number":87,"context_line":"            (\u0027dvrha\u0027, dict(id\u003duuidutils.generate_uuid(), distributed\u003dTrue, ha\u003dTrue)),"},{"line_number":88,"context_line":"            (\u0027dvr\u0027, dict(id\u003duuidutils.generate_uuid(), distributed\u003dTrue, ha\u003dFalse)),"},{"line_number":89,"context_line":"            (\u0027ha\u0027, dict(id\u003duuidutils.generate_uuid(), distributed\u003dFalse, ha\u003dTrue)),"},{"line_number":90,"context_line":"            (\u0027single_node\u0027, dict(id\u003duuidutils.generate_uuid(), distributed\u003dFalse,"},{"line_number":91,"context_line":"                                 ha\u003dFalse)),"},{"line_number":92,"context_line":"            (\u0027ha\u0027, dict(id\u003duuidutils.generate_uuid(), ha\u003dTrue,"},{"line_number":93,"context_line":"                        distributed\u003dconstants.ATTR_NOT_SPECIFIED)),"},{"line_number":94,"context_line":"            (\u0027dvr\u0027, dict(id\u003duuidutils.generate_uuid(), distributed\u003dTrue,"},{"line_number":95,"context_line":"                        ha\u003dconstants.ATTR_NOT_SPECIFIED)),"},{"line_number":96,"context_line":"            (\u0027single_node\u0027, dict(id\u003duuidutils.generate_uuid(), ha\u003dFalse,"},{"line_number":97,"context_line":"                                 distributed\u003dconstants.ATTR_NOT_SPECIFIED)),"},{"line_number":98,"context_line":"            (\u0027single_node\u0027, dict(id\u003duuidutils.generate_uuid(), distributed\u003dFalse,"},{"line_number":99,"context_line":"                                 ha\u003dconstants.ATTR_NOT_SPECIFIED)),"},{"line_number":100,"context_line":"            (\u0027single_node\u0027, dict(id\u003duuidutils.generate_uuid(),"},{"line_number":101,"context_line":"                                 distributed\u003dconstants.ATTR_NOT_SPECIFIED,"},{"line_number":102,"context_line":"                                 ha\u003dconstants.ATTR_NOT_SPECIFIED)),"},{"line_number":103,"context_line":"        ]"},{"line_number":104,"context_line":"        for driver, body in cases:"},{"line_number":105,"context_line":"            self.dc._set_router_provider(\u0027router\u0027, \u0027PRECOMMIT_CREATE\u0027, self,"},{"line_number":106,"context_line":"                                         self.ctx, body, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":35,"id":"3a71b18c_9b857ad0","line":103,"range":{"start_line":87,"start_character":0,"end_line":103,"end_character":9},"updated":"2016-12-06 17:30:07.000000000","message":"Since we are reverting https://review.openstack.org/#/c/393150/35/neutron/services/l3_router/service_providers/driver_controller.py to its original state, this should also be reverted to its original state","commit_id":"ba3ec26ba300abe61a364f6f95c815246321f96c"}]}
