)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea39d21ebe7633dd375736e429a95da56e03321f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-23 12:14:02 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use neutron-lib for well known plugin types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron-lib 1.0.0 supports a partial list of the well known"},{"line_number":10,"context_line":"plugin types. Lets start to move to using those."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a74a57a_2a533e6c","line":7,"updated":"2016-11-28 17:56:20.000000000","message":"This particular change is only for L3, title is a little too generic","commit_id":"07d81a2ec7b77b558b46870059a7c87ec7e6898f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eab59b77a51609eb0d37c9b258dd441a15fdb2b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-23 12:14:02 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use neutron-lib for well known plugin types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron-lib 1.0.0 supports a partial list of the well known"},{"line_number":10,"context_line":"plugin types. Lets start to move to using those."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da4df55a_e61c6dc3","line":7,"in_reply_to":"5a74a57a_2a533e6c","updated":"2016-12-26 09:07:05.000000000","message":"Done","commit_id":"07d81a2ec7b77b558b46870059a7c87ec7e6898f"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e1cacc50eb6d6a1bbcb6222a32c41388d4fe4c16","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Neutron well-known service type constants:"},{"line_number":20,"context_line":"CORE \u003d constants.CORE"},{"line_number":21,"context_line":"DUMMY \u003d \"DUMMY\""},{"line_number":22,"context_line":"LOADBALANCER \u003d \"LOADBALANCER\""},{"line_number":23,"context_line":"LOADBALANCERV2 \u003d \"LOADBALANCERV2\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_435a9e51","line":20,"updated":"2016-12-02 14:55:31.000000000","message":"Based on our neutron-lib contribution guide [1], consuming rehomed code in neutron should remove the code itself from neutron. This gives subprojects using the rehomed neutron source \"incentive\" to move to lib (by virtue of not breaking).\n\n\nIs there a reason to not remove these constants in neutron as per [1]?\n\n\nIMHO this patch should be removing these constants (now in lib) and replacing all their usage in neutron with the constants in neutron-lib.\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/doc/source/contributing.rst#phase-4-consume","commit_id":"07d81a2ec7b77b558b46870059a7c87ec7e6898f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eab59b77a51609eb0d37c9b258dd441a15fdb2b1","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Neutron well-known service type constants:"},{"line_number":20,"context_line":"CORE \u003d constants.CORE"},{"line_number":21,"context_line":"DUMMY \u003d \"DUMMY\""},{"line_number":22,"context_line":"LOADBALANCER \u003d \"LOADBALANCER\""},{"line_number":23,"context_line":"LOADBALANCERV2 \u003d \"LOADBALANCERV2\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_067a51f1","line":20,"in_reply_to":"3a71b18c_435a9e51","updated":"2016-12-26 09:07:05.000000000","message":"Done","commit_id":"07d81a2ec7b77b558b46870059a7c87ec7e6898f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea39d21ebe7633dd375736e429a95da56e03321f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"FIREWALL \u003d \"FIREWALL\""},{"line_number":25,"context_line":"VPN \u003d \"VPN\""},{"line_number":26,"context_line":"METERING \u003d \"METERING\""},{"line_number":27,"context_line":"L3_ROUTER_NAT \u003d constants.L3"},{"line_number":28,"context_line":"FLAVORS \u003d \"FLAVORS\""},{"line_number":29,"context_line":"QOS \u003d \"QOS\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a74a57a_4af23a9b","line":27,"updated":"2016-11-28 17:56:20.000000000","message":"So will there be a follow-on to change all the remaining occurrences of L3_ROUTER_NAT in neutron ?","commit_id":"07d81a2ec7b77b558b46870059a7c87ec7e6898f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eab59b77a51609eb0d37c9b258dd441a15fdb2b1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"FIREWALL \u003d \"FIREWALL\""},{"line_number":25,"context_line":"VPN \u003d \"VPN\""},{"line_number":26,"context_line":"METERING \u003d \"METERING\""},{"line_number":27,"context_line":"L3_ROUTER_NAT \u003d constants.L3"},{"line_number":28,"context_line":"FLAVORS \u003d \"FLAVORS\""},{"line_number":29,"context_line":"QOS \u003d \"QOS\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_66879dd7","line":27,"in_reply_to":"5a74a57a_4af23a9b","updated":"2016-12-26 09:07:05.000000000","message":"no, i\u0027ll clean up on this one","commit_id":"07d81a2ec7b77b558b46870059a7c87ec7e6898f"}]}
