)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d4f6bc2168bf771d73d4d96224cdb483f6d449c9","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"                            \u0027ns\u0027: ns_name})"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"def send_ip_addr_adv_notif(ns_name, iface_name, address, count\u003d3):"},{"line_number":1026,"context_line":"    \"\"\"Send advance notification of an IP address assignment."},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    If the address is in the IPv4 family, send gratuitous ARP."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_9296c54a","line":1025,"updated":"2016-11-08 16:36:38.000000000","message":"The default should be a shared constant between the config object definition and here.","commit_id":"9d18771c1cc1a61cc27669b77173f622d6894958"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bca6485cc67faca825ba2e8cbb5cb040deb398d2","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"                            \u0027ns\u0027: ns_name})"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"def send_ip_addr_adv_notif(ns_name, iface_name, address, count\u003d3):"},{"line_number":1026,"context_line":"    \"\"\"Send advance notification of an IP address assignment."},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    If the address is in the IPv4 family, send gratuitous ARP."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_4d83b004","line":1025,"in_reply_to":"9a629dbe_8d214850","updated":"2016-11-08 16:56:03.000000000","message":"I agree that the function being in ip_lib is a bit of a pain. If we think it\u0027s not safe to keep a custom default here; then it should not be safe to touch the function at all. Meaning we would need a new function or smth.\n\nI prefer just take a small risk.","commit_id":"9d18771c1cc1a61cc27669b77173f622d6894958"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ecdcd42ef043279d0dadceee6a1fc4429197963e","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"                            \u0027ns\u0027: ns_name})"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"def send_ip_addr_adv_notif(ns_name, iface_name, address, count\u003d3):"},{"line_number":1026,"context_line":"    \"\"\"Send advance notification of an IP address assignment."},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    If the address is in the IPv4 family, send gratuitous ARP."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_f2d701eb","line":1025,"in_reply_to":"9a629dbe_9296c54a","updated":"2016-11-08 16:39:14.000000000","message":"I am ok with it too, but why exactly? Those in theory may be untangled. The main thing for backwards compatibility is that in all existing places where we use the function, we pass the value of the option, overriding the default.","commit_id":"9d18771c1cc1a61cc27669b77173f622d6894958"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"2f9acd718eba144d28753b9df959d594a799ce10","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"                            \u0027ns\u0027: ns_name})"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"def send_ip_addr_adv_notif(ns_name, iface_name, address, count\u003d3):"},{"line_number":1026,"context_line":"    \"\"\"Send advance notification of an IP address assignment."},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    If the address is in the IPv4 family, send gratuitous ARP."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_8d214850","line":1025,"in_reply_to":"9a629dbe_ad0fec2c","updated":"2016-11-08 16:53:07.000000000","message":"I stand corrected, this being an ip_lib function it should be generic to its currently one and only user.","commit_id":"9d18771c1cc1a61cc27669b77173f622d6894958"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ae56e918f67d163cef4f1d9fad6620598de065aa","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"                            \u0027ns\u0027: ns_name})"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"def send_ip_addr_adv_notif(ns_name, iface_name, address, count\u003d3):"},{"line_number":1026,"context_line":"    \"\"\"Send advance notification of an IP address assignment."},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    If the address is in the IPv4 family, send gratuitous ARP."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_ad0fec2c","line":1025,"in_reply_to":"9a629dbe_f2d701eb","updated":"2016-11-08 16:46:32.000000000","message":"I don\u0027t really care - though I also see that the fact we went with magical number 3 is a coincidence and not because of it\u0027s a default value for send_arp_for_ha.","commit_id":"9d18771c1cc1a61cc27669b77173f622d6894958"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9733b4f36fd927913645a2a2fa3ca5c4283d8fad","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"                            \u0027ns\u0027: ns_name})"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"def send_ip_addr_adv_notif(ns_name, iface_name, address, count\u003d3):"},{"line_number":1026,"context_line":"    \"\"\"Send advance notification of an IP address assignment."},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"    If the address is in the IPv4 family, send gratuitous ARP."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_72169156","line":1025,"in_reply_to":"9a629dbe_f2d701eb","updated":"2016-11-08 16:45:51.000000000","message":"That\u0027s of course assuming the function is not part of public neutron api; which I think the commit message suggests it\u0027s not.","commit_id":"9d18771c1cc1a61cc27669b77173f622d6894958"}]}