)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"76a8655a92a39fe6302eee2e64f2f6306a938e79","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install OVS from git if current version \u003c 2.5.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVS version 2.5.1 there are several bug fixes to issues that Neutron"},{"line_number":10,"context_line":"encounters. This fix allows devstack to install a newer version of OVS,"},{"line_number":11,"context_line":"by default version 2.5.1."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_a29d125b","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":48},"updated":"2016-11-09 12:40:55.000000000","message":"Can you please write which patches do we need? Maybe we could create a bug for ubuntu to rebase their package.","commit_id":"6dc941f3b4b4ddc220842889902a4a2753b9ceb4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"251339b595e6fd7446f131aa6838e5d42cdce7d4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install OVS from git if current version \u003c 2.5.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVS version 2.5.1 there are several bug fixes to issues that Neutron"},{"line_number":10,"context_line":"encounters. This fix allows devstack to install a newer version of OVS,"},{"line_number":11,"context_line":"by default version 2.5.1."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_8f59ae37","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":48},"in_reply_to":"9a629dbe_191d50bd","updated":"2016-11-11 13:30:25.000000000","message":"It would be helpful to identify which issues we have so we don\u0027t need to fallback to compiled ovs in our jobs.","commit_id":"6dc941f3b4b4ddc220842889902a4a2753b9ceb4"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"cf292c2570d138cc7e62f02c8a869b703f44a848","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install OVS from git if current version \u003c 2.5.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVS version 2.5.1 there are several bug fixes to issues that Neutron"},{"line_number":10,"context_line":"encounters. This fix allows devstack to install a newer version of OVS,"},{"line_number":11,"context_line":"by default version 2.5.1."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_191d50bd","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":48},"in_reply_to":"9a629dbe_a29d125b","updated":"2016-11-09 13:29:26.000000000","message":"Sure.\n\nI think @horms already opened a bug report to Ubuntu about OVS 2.5.1 in Xenial, but I can\u0027t find it.","commit_id":"6dc941f3b4b4ddc220842889902a4a2753b9ceb4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30adf0c6538600dcdf4e0811a765a8a520583e44","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Specifically, for bug 1640283, we need the following commit from OVS:"},{"line_number":14,"context_line":"8c0b419a0b9ac0141d6973dcc80306dfc6a83d31 ofproto/trace: Fix \"unchanged\""},{"line_number":15,"context_line":"output for Final flow"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The version is overridable by NEUTRON_OVERRIDE_OVS_BRANCH variable."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a629dbe_7c013639","line":15,"updated":"2016-11-14 13:54:12.000000000","message":"Thanks for the bug report :) So IIUC we won\u0027t need to compile OVS for functional job after all. And we need kernel module to make local VxLAN working anyway.","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ab5a7ae0827fdcb55013af5a40eeabc801aa2029","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVS version 2.5.1 there are several bug fixes to issues that Neutron"},{"line_number":10,"context_line":"encounters. This fix allows devstack to install a newer version of OVS,"},{"line_number":11,"context_line":"by default version 2.5.1."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Specifically, for bug 1640283, we need the following commit from OVS:"},{"line_number":14,"context_line":"8c0b419a0b9ac0141d6973dcc80306dfc6a83d31 ofproto/trace: Fix \"unchanged\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_72b05844","line":11,"updated":"2016-11-16 01:15:19.000000000","message":"We install some version on branch-2.5, not 2.5.1.","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"52a7b8d99457ff946767cd12b119f5e11c6612e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVS version 2.5.1 there are several bug fixes to issues that Neutron"},{"line_number":10,"context_line":"encounters. This fix allows devstack to install a newer version of OVS,"},{"line_number":11,"context_line":"by default version 2.5.1."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Specifically, for bug 1640283, we need the following commit from OVS:"},{"line_number":14,"context_line":"8c0b419a0b9ac0141d6973dcc80306dfc6a83d31 ofproto/trace: Fix \"unchanged\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_f4ffeda7","line":11,"in_reply_to":"7a77a97e_72b05844","updated":"2016-11-16 07:19:50.000000000","message":"In the next patch set, we install branch 2.5.1, as per your recommendation.","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"}],"devstack/lib/ovs":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"06a05d493e607bd9636e665d70644855e02f13a3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# is_kernel_supported_for_ovs26() - compilation of openvswitch 2.6 kernel module"},{"line_number":53,"context_line":"#                                   supports only kernels above 4.4.x, function"},{"line_number":54,"context_line":"#                                   determines whether compilation from source"},{"line_number":55,"context_line":"#                                   will succeed on this machine"},{"line_number":56,"context_line":"function is_kernel_supported_for_ovs26 {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a629dbe_8c2189b7","line":53,"updated":"2016-11-14 09:35:32.000000000","message":"From ovs/acinclude.m4, 3.10 to 4.8 seem to be supported.\n(with v2.6.1.  4.8 isn\u0027t supported in 2.6.0. that\u0027s why I\u0027m against scattering is_kernel_supported_xxx and ovs git tag in different files.......)","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"2b06e631afa0ff8d02c2b56edea12305867c853d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# is_kernel_supported_for_ovs26() - compilation of openvswitch 2.6 kernel module"},{"line_number":53,"context_line":"#                                   supports only kernels above 4.4.x, function"},{"line_number":54,"context_line":"#                                   determines whether compilation from source"},{"line_number":55,"context_line":"#                                   will succeed on this machine"},{"line_number":56,"context_line":"function is_kernel_supported_for_ovs26 {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a629dbe_f293bcfe","line":53,"in_reply_to":"9a629dbe_8c2189b7","updated":"2016-11-14 10:11:21.000000000","message":"Will change to is_kernel_supported_for_ovs261.\n\nWill change conditions.\n\nThis is the structure that already existed. I could move the block (lines 47-63 in this patchset) from gate_hook.sh to here, and call it upgrade_ovs. Is that acceptable?","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30adf0c6538600dcdf4e0811a765a8a520583e44","unresolved":false,"context_lines":[{"line_number":70,"context_line":"function is_ovs_version_ok {"},{"line_number":71,"context_line":"    minimum_version\u003d\"2.5.1\""},{"line_number":72,"context_line":"    version_string\u003d$(ovs-vswitchd -V | awk \u0027/^ovs-vswitchd/ { print $NF}\u0027)"},{"line_number":73,"context_line":"    if [ \"$(echo \\\"$version_string\\n$version\\\" | sort -V)\" \u003d\u003d \"$minimum_version\" ]; then"},{"line_number":74,"context_line":"        return 0"},{"line_number":75,"context_line":"    fi"},{"line_number":76,"context_line":"    return 1"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a629dbe_3ca41e07","line":73,"range":{"start_line":73,"start_character":56,"end_line":73,"end_character":58},"updated":"2016-11-14 13:54:12.000000000","message":"Shouldn\u0027t be there something like \"head -n1\" ?","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30adf0c6538600dcdf4e0811a765a8a520583e44","unresolved":false,"context_lines":[{"line_number":70,"context_line":"function is_ovs_version_ok {"},{"line_number":71,"context_line":"    minimum_version\u003d\"2.5.1\""},{"line_number":72,"context_line":"    version_string\u003d$(ovs-vswitchd -V | awk \u0027/^ovs-vswitchd/ { print $NF}\u0027)"},{"line_number":73,"context_line":"    if [ \"$(echo \\\"$version_string\\n$version\\\" | sort -V)\" \u003d\u003d \"$minimum_version\" ]; then"},{"line_number":74,"context_line":"        return 0"},{"line_number":75,"context_line":"    fi"},{"line_number":76,"context_line":"    return 1"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a629dbe_3c6dfecc","line":73,"range":{"start_line":73,"start_character":36,"end_line":73,"end_character":44},"updated":"2016-11-14 13:54:12.000000000","message":"What is this var?","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"56e0e211edeb2902b8fe765835f829858064f048","unresolved":false,"context_lines":[{"line_number":70,"context_line":"function is_ovs_version_ok {"},{"line_number":71,"context_line":"    minimum_version\u003d\"2.5.1\""},{"line_number":72,"context_line":"    version_string\u003d$(ovs-vswitchd -V | awk \u0027/^ovs-vswitchd/ { print $NF}\u0027)"},{"line_number":73,"context_line":"    if [ \"$(echo \\\"$version_string\\n$version\\\" | sort -V)\" \u003d\u003d \"$minimum_version\" ]; then"},{"line_number":74,"context_line":"        return 0"},{"line_number":75,"context_line":"    fi"},{"line_number":76,"context_line":"    return 1"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a629dbe_970fc52d","line":73,"range":{"start_line":73,"start_character":56,"end_line":73,"end_character":58},"in_reply_to":"9a629dbe_3ca41e07","updated":"2016-11-14 13:59:32.000000000","message":"Will fix.","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"26775f0e236ea5e32b6828bb1a0dae773c27d068","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kversion\u003d\"$major.$minor\""},{"line_number":60,"context_line":"    minimum_version\u003d\"3.10\""},{"line_number":61,"context_line":"    maximum_version\u003d\"4.8\""},{"line_number":62,"context_line":"    if [ \"$(echo \\\"$kversion\\n$minimum_version\\\" | sort -V | head -1)\" !\u003d \"$minimum_version\" ]; then"},{"line_number":63,"context_line":"        return 1"},{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":"    if [ \"$(echo \\\"$kversion\\n$maximum_version\\\" | sort -V | tail -1)\" !\u003d \"$maximum_version\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a77a97e_5af8fce5","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":16},"updated":"2016-11-15 09:22:44.000000000","message":"Don\u0027t you miss \"-e\" on all echo commands?","commit_id":"3faf90fa2ea807a9b0a196ffea7a6830f546e2df"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"f1004b59545a83f6f2afae0b5980245255d7478f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kversion\u003d\"$major.$minor\""},{"line_number":60,"context_line":"    minimum_version\u003d\"3.10\""},{"line_number":61,"context_line":"    maximum_version\u003d\"4.8\""},{"line_number":62,"context_line":"    if [ \"$(echo \\\"$kversion\\n$minimum_version\\\" | sort -V | head -1)\" !\u003d \"$minimum_version\" ]; then"},{"line_number":63,"context_line":"        return 1"},{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":"    if [ \"$(echo \\\"$kversion\\n$maximum_version\\\" | sort -V | tail -1)\" !\u003d \"$maximum_version\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a77a97e_9af614d6","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":16},"in_reply_to":"7a77a97e_5af8fce5","updated":"2016-11-15 09:25:28.000000000","message":"Yes I do. Will fix.","commit_id":"3faf90fa2ea807a9b0a196ffea7a6830f546e2df"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e48b2213eb566937eab277c912719ce1f456dffa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":91,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":92,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        fi"},{"line_number":95,"context_line":"        remove_ovs_packages"},{"line_number":96,"context_line":"        compile_ovs True /usr /var"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7a77a97e_a209cc97","line":93,"updated":"2016-11-15 18:04:11.000000000","message":"I think we should add an echo warning here that says we\u0027re going to compile from $OVS_BRANCH and it may potentially failed due to kernel is not supported.","commit_id":"61b5e0587e2c1ca35417a123e82287927c992353"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"97aed60eebf4ec06ab1c5d00a362d6256db64785","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":91,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":92,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        fi"},{"line_number":95,"context_line":"        remove_ovs_packages"},{"line_number":96,"context_line":"        compile_ovs True /usr /var"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7a77a97e_c49b2a71","line":93,"in_reply_to":"7a77a97e_a209cc97","updated":"2016-11-15 23:43:09.000000000","message":"Done","commit_id":"61b5e0587e2c1ca35417a123e82287927c992353"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ab5a7ae0827fdcb55013af5a40eeabc801aa2029","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kversion\u003d\"$major.$minor\""},{"line_number":60,"context_line":"    minimum_version\u003d\"3.10\""},{"line_number":61,"context_line":"    maximum_version\u003d\"4.8\""},{"line_number":62,"context_line":"    if [ \"$(echo -e $kversion\\\\n$minimum_version | sort -V | head -1)\" !\u003d \"$minimum_version\" ]; then"},{"line_number":63,"context_line":"        return 1"},{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":"    if [ \"$(echo -e $kversion\\\\n$maximum_version | sort -V | tail -1)\" !\u003d \"$maximum_version\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_b2bf50fa","line":62,"updated":"2016-11-16 01:15:19.000000000","message":"Using sort -VC and checking its exit status might be simpler.","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"52a7b8d99457ff946767cd12b119f5e11c6612e4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    kversion\u003d\"$major.$minor\""},{"line_number":60,"context_line":"    minimum_version\u003d\"3.10\""},{"line_number":61,"context_line":"    maximum_version\u003d\"4.8\""},{"line_number":62,"context_line":"    if [ \"$(echo -e $kversion\\\\n$minimum_version | sort -V | head -1)\" !\u003d \"$minimum_version\" ]; then"},{"line_number":63,"context_line":"        return 1"},{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":"    if [ \"$(echo -e $kversion\\\\n$maximum_version | sort -V | tail -1)\" !\u003d \"$maximum_version\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_3430859e","line":62,"in_reply_to":"7a77a97e_b2bf50fa","updated":"2016-11-16 07:19:50.000000000","message":"Done","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ab5a7ae0827fdcb55013af5a40eeabc801aa2029","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # we use a current (2016-08-19) HEAD commit from branch-2.5 that contains"},{"line_number":89,"context_line":"            # a fix for usage of VXLAN tunnels on a single node:"},{"line_number":90,"context_line":"            # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":91,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":92,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_92c0947e","line":91,"updated":"2016-11-16 01:15:19.000000000","message":"IMO, it\u0027s better to use v2.5.1 here.","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"52a7b8d99457ff946767cd12b119f5e11c6612e4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # we use a current (2016-08-19) HEAD commit from branch-2.5 that contains"},{"line_number":89,"context_line":"            # a fix for usage of VXLAN tunnels on a single node:"},{"line_number":90,"context_line":"            # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":91,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":92,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_5427c163","line":91,"in_reply_to":"7a77a97e_92c0947e","updated":"2016-11-16 07:19:50.000000000","message":"Done","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ab5a7ae0827fdcb55013af5a40eeabc801aa2029","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            # a fix for usage of VXLAN tunnels on a single node:"},{"line_number":90,"context_line":"            # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":91,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":92,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        else"},{"line_number":95,"context_line":"            echo \"WARNING: Unsupported kernel for OVS compilation. Trying default branch.\""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_b291109c","line":92,"updated":"2016-11-16 01:15:19.000000000","message":"Adding a comment such as below may help.\n\n# Xenial kernel version is not compatible with branch-2.5","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"52a7b8d99457ff946767cd12b119f5e11c6612e4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            # a fix for usage of VXLAN tunnels on a single node:"},{"line_number":90,"context_line":"            # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":91,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":92,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        else"},{"line_number":95,"context_line":"            echo \"WARNING: Unsupported kernel for OVS compilation. Trying default branch.\""}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_742afd2d","line":92,"in_reply_to":"7a77a97e_b291109c","updated":"2016-11-16 07:19:50.000000000","message":"Done","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ab5a7ae0827fdcb55013af5a40eeabc801aa2029","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        else"},{"line_number":95,"context_line":"            echo \"WARNING: Unsupported kernel for OVS compilation. Trying default branch.\""},{"line_number":96,"context_line":"            if [ \"$NEUTRON_OVERRIDE_OVS_BRANCH\" ]; then"},{"line_number":97,"context_line":"                OVS_BRANCH\u003d$NEUTRON_OVERRIDE_OVS_BRANCH"},{"line_number":98,"context_line":"            fi"},{"line_number":99,"context_line":"        fi"},{"line_number":100,"context_line":"        echo \"Compiling OVS branch: $OVS_BRANCH\""},{"line_number":101,"context_line":"        remove_ovs_packages"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_724cd842","line":98,"range":{"start_line":96,"start_character":5,"end_line":98,"end_character":1},"updated":"2016-11-16 01:15:19.000000000","message":"With NEUTRON_OVERRIDE_OVS_BRANCH, is_kernel_supported_xxx functions are meaningless.\nI suggest moving this block to L.86, skipping those tests.","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"52a7b8d99457ff946767cd12b119f5e11c6612e4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":94,"context_line":"        else"},{"line_number":95,"context_line":"            echo \"WARNING: Unsupported kernel for OVS compilation. Trying default branch.\""},{"line_number":96,"context_line":"            if [ \"$NEUTRON_OVERRIDE_OVS_BRANCH\" ]; then"},{"line_number":97,"context_line":"                OVS_BRANCH\u003d$NEUTRON_OVERRIDE_OVS_BRANCH"},{"line_number":98,"context_line":"            fi"},{"line_number":99,"context_line":"        fi"},{"line_number":100,"context_line":"        echo \"Compiling OVS branch: $OVS_BRANCH\""},{"line_number":101,"context_line":"        remove_ovs_packages"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_94215950","line":98,"range":{"start_line":96,"start_character":5,"end_line":98,"end_character":1},"in_reply_to":"7a77a97e_724cd842","updated":"2016-11-16 07:19:50.000000000","message":"Done","commit_id":"1f9abf59537d5f449206b59f70d8ae1cad8d5151"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8cdf94737a6151bbb6f65bf1019a61b62f0ac8e8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# is_kernel_supported_for_ovs25() - compilation of openvswitch 2.5 kernel module"},{"line_number":35,"context_line":"#                                   supports only kernels up to 4.3.x, function"},{"line_number":36,"context_line":"#                                   determines whether compilation from source"},{"line_number":37,"context_line":"#                                   will succeed on this machine"},{"line_number":38,"context_line":"function is_kernel_supported_for_ovs25 {"},{"line_number":39,"context_line":"    major\u003d$(uname -r | cut -d\\. -f 1)"},{"line_number":40,"context_line":"    minor\u003d$(uname -r | cut -d\\. -f 2)"},{"line_number":41,"context_line":"    if [ $major -le 3 ]; then"},{"line_number":42,"context_line":"        # All 3.x branches and lesser are supported"},{"line_number":43,"context_line":"        return 0"},{"line_number":44,"context_line":"    elif [ $major -eq 4 -a $minor -le 3 ]; then"},{"line_number":45,"context_line":"        # If it\u0027s version 4, minor must not be higher than 3"},{"line_number":46,"context_line":"        return 0"},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    return 1"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# is_version_le() - Helper function to test if the first version string is less"},{"line_number":53,"context_line":"#                   than or equal to the second version string"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a77a97e_534c2d42","line":50,"range":{"start_line":34,"start_character":0,"end_line":50,"end_character":1},"updated":"2016-11-16 11:33:55.000000000","message":"(No action required) Seems like the function could also benefit from the new is_version_le helper. But since it works already, probably better not to touch it right now.","commit_id":"5ec6db5e2d000daf72e6825d4face8ba4f60c644"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8cdf94737a6151bbb6f65bf1019a61b62f0ac8e8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"function is_ovs_version_ok {"},{"line_number":84,"context_line":"    minimum_version\u003d\"2.5.1\""},{"line_number":85,"context_line":"    version_string\u003d$(ovs-vswitchd -V | awk \u0027/^ovs-vswitchd/ { print $NF}\u0027)"},{"line_number":86,"context_line":"    if [ \"$(echo -e $version_string\\\\n$minimum_version | sort -V | head -1)\" \u003d\u003d \"$minimum_version\" ]; then"},{"line_number":87,"context_line":"        return 0"},{"line_number":88,"context_line":"    fi"},{"line_number":89,"context_line":"    return 1"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a77a97e_d62cab4c","line":86,"range":{"start_line":86,"start_character":9,"end_line":86,"end_character":76},"updated":"2016-11-16 11:33:55.000000000","message":"so why don\u0027t we use is_version_le here?","commit_id":"5ec6db5e2d000daf72e6825d4face8ba4f60c644"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c9361551cb9343f1e4603f8a77e60b32bdff676c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"function is_ovs_version_ok {"},{"line_number":84,"context_line":"    minimum_version\u003d\"2.5.1\""},{"line_number":85,"context_line":"    version_string\u003d$(ovs-vswitchd -V | awk \u0027/^ovs-vswitchd/ { print $NF}\u0027)"},{"line_number":86,"context_line":"    if [ \"$(echo -e $version_string\\\\n$minimum_version | sort -V | head -1)\" \u003d\u003d \"$minimum_version\" ]; then"},{"line_number":87,"context_line":"        return 0"},{"line_number":88,"context_line":"    fi"},{"line_number":89,"context_line":"    return 1"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a77a97e_0cb1b2e1","line":86,"range":{"start_line":86,"start_character":9,"end_line":86,"end_character":76},"in_reply_to":"7a77a97e_d62cab4c","updated":"2016-11-16 12:21:24.000000000","message":"Will fix.","commit_id":"5ec6db5e2d000daf72e6825d4face8ba4f60c644"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8cdf94737a6151bbb6f65bf1019a61b62f0ac8e8","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            OVS_BRANCH\u003d$NEUTRON_OVERRIDE_OVS_BRANCH"},{"line_number":98,"context_line":"        elif is_kernel_supported_for_ovs25; then"},{"line_number":99,"context_line":"            # The order of conditions here is such that on Trusty we install"},{"line_number":100,"context_line":"            # version 2.5.1, and on Xenial we upgrade to 2.6.1 (Since Xenial"},{"line_number":101,"context_line":"            # kernel is not compatible with 2.6.1)"},{"line_number":102,"context_line":"            OVS_BRANCH\u003d\"v2.5.1\""},{"line_number":103,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":104,"context_line":"            OVS_BRANCH\u003d\"v2.6.1\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a77a97e_96f233d1","line":101,"range":{"start_line":100,"start_character":36,"end_line":101,"end_character":50},"updated":"2016-11-16 11:33:55.000000000","message":"It does not make sense to me. \u0027we install X on Y, because Y does not support X\u0027","commit_id":"5ec6db5e2d000daf72e6825d4face8ba4f60c644"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"c9361551cb9343f1e4603f8a77e60b32bdff676c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            OVS_BRANCH\u003d$NEUTRON_OVERRIDE_OVS_BRANCH"},{"line_number":98,"context_line":"        elif is_kernel_supported_for_ovs25; then"},{"line_number":99,"context_line":"            # The order of conditions here is such that on Trusty we install"},{"line_number":100,"context_line":"            # version 2.5.1, and on Xenial we upgrade to 2.6.1 (Since Xenial"},{"line_number":101,"context_line":"            # kernel is not compatible with 2.6.1)"},{"line_number":102,"context_line":"            OVS_BRANCH\u003d\"v2.5.1\""},{"line_number":103,"context_line":"        elif is_kernel_supported_for_ovs261; then"},{"line_number":104,"context_line":"            OVS_BRANCH\u003d\"v2.6.1\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a77a97e_6c9f8650","line":101,"range":{"start_line":100,"start_character":36,"end_line":101,"end_character":50},"in_reply_to":"7a77a97e_96f233d1","updated":"2016-11-16 12:21:24.000000000","message":"Sorry, typo. Will fix.","commit_id":"5ec6db5e2d000daf72e6825d4face8ba4f60c644"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"32346f9682fae153672d789161515437065b9b78","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# is_version_le() - Helper function to test if the first version string is less"},{"line_number":53,"context_line":"#                   than or equal to the second version string"},{"line_number":54,"context_line":"function is_version_le {"},{"line_number":55,"context_line":"    version1\u003d$1"},{"line_number":56,"context_line":"    version2\u003d$2"},{"line_number":57,"context_line":"    echo -e \"$version1\\\\n$version2\" | sort -VC"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"5a74a57a_e8cc12bd","line":54,"updated":"2016-11-28 07:17:31.000000000","message":"devstack/functions has vercmp function.\nPlease remember to use that when you change this file next time. ;)","commit_id":"7403bccbc351d53bbc31d6ba8017e68c754f93fd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"77873cbc8ea2223e095dd0a35dcb0fa481d6faec","unresolved":false,"context_lines":[{"line_number":54,"context_line":"function is_version_le {"},{"line_number":55,"context_line":"    version1\u003d$1"},{"line_number":56,"context_line":"    version2\u003d$2"},{"line_number":57,"context_line":"    echo -e \"$version1\\\\n$version2\" | sort -VC"},{"line_number":58,"context_line":"    return $?"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7a77a97e_67ca3f70","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":46},"updated":"2016-11-16 12:31:32.000000000","message":"Do we want to print the value to stdout here? I\u0027d suggest to not do this side-effect and use \u0027\u003e /dev/null\u0027 here.","commit_id":"7403bccbc351d53bbc31d6ba8017e68c754f93fd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ba35039df86b568fa83bea4c5c2bfca2a2a291c3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"function is_version_le {"},{"line_number":55,"context_line":"    version1\u003d$1"},{"line_number":56,"context_line":"    version2\u003d$2"},{"line_number":57,"context_line":"    echo -e \"$version1\\\\n$version2\" | sort -VC"},{"line_number":58,"context_line":"    return $?"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"7a77a97e_47038342","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":46},"in_reply_to":"7a77a97e_67ca3f70","updated":"2016-11-16 12:36:44.000000000","message":"Sorry, I missed -C is quiet :)","commit_id":"7403bccbc351d53bbc31d6ba8017e68c754f93fd"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"6be023b9e07805385a5094d6cbdb7714f12f3ba9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        remove_ovs_packages"},{"line_number":54,"context_line":"        compile_ovs True /usr /var"},{"line_number":55,"context_line":"        start_new_ovs"},{"line_number":56,"context_line":"    elif is_ovs_version_too_old; then"},{"line_number":57,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.5.1\"}"},{"line_number":58,"context_line":"        remove_ovs_packages"},{"line_number":59,"context_line":"        compile_ovs False /usr /var"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_5d4ee26f","line":56,"updated":"2016-11-09 08:08:47.000000000","message":"I think this whole block should be:\n\nif is_ovs_version_ok; then\n    :\nelif is_kernel_supported_for_ovs25; then\n    blah\nelif is_kernel_supported_for_ovs26; then\n    blah\nfi","commit_id":"6dc941f3b4b4ddc220842889902a4a2753b9ceb4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5cc2cb8b33e9c62a964bcc08ab4c7ecb215890ad","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        remove_ovs_packages"},{"line_number":54,"context_line":"        compile_ovs True /usr /var"},{"line_number":55,"context_line":"        start_new_ovs"},{"line_number":56,"context_line":"    elif is_ovs_version_too_old; then"},{"line_number":57,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.5.1\"}"},{"line_number":58,"context_line":"        remove_ovs_packages"},{"line_number":59,"context_line":"        compile_ovs False /usr /var"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_4b7069a4","line":56,"in_reply_to":"9a629dbe_5d4ee26f","updated":"2016-11-11 13:51:54.000000000","message":"+1","commit_id":"6dc941f3b4b4ddc220842889902a4a2753b9ceb4"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"332d1f1e2ac5d16a39f9d09df39e9c448a9d1890","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        remove_ovs_packages"},{"line_number":54,"context_line":"        compile_ovs True /usr /var"},{"line_number":55,"context_line":"        start_new_ovs"},{"line_number":56,"context_line":"    elif is_ovs_version_too_old; then"},{"line_number":57,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.5.1\"}"},{"line_number":58,"context_line":"        remove_ovs_packages"},{"line_number":59,"context_line":"        compile_ovs False /usr /var"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_5d898225","line":56,"in_reply_to":"9a629dbe_5d4ee26f","updated":"2016-11-09 08:17:47.000000000","message":"Done","commit_id":"6dc941f3b4b4ddc220842889902a4a2753b9ceb4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5cc2cb8b33e9c62a964bcc08ab4c7ecb215890ad","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        remove_ovs_packages"},{"line_number":54,"context_line":"        compile_ovs True /usr /var"},{"line_number":55,"context_line":"        start_new_ovs"},{"line_number":56,"context_line":"    elif is_ovs_version_too_old; then"},{"line_number":57,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.5.1\"}"},{"line_number":58,"context_line":"        remove_ovs_packages"},{"line_number":59,"context_line":"        compile_ovs False /usr /var"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_ab6105d5","line":56,"in_reply_to":"9a629dbe_5d898225","updated":"2016-11-11 13:51:54.000000000","message":"Where?","commit_id":"6dc941f3b4b4ddc220842889902a4a2753b9ceb4"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"30adf0c6538600dcdf4e0811a765a8a520583e44","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    configure_host_for_func_testing"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    if is_ovs_version_ok; then"},{"line_number":48,"context_line":"        :"},{"line_number":49,"context_line":"    elif is_kernel_supported_for_ovs25; then"},{"line_number":50,"context_line":"        # The OVS_BRANCH variable is used by git checkout. In the case below,"},{"line_number":51,"context_line":"        # we use a current (2016-08-19) HEAD commit from branch-2.5 that contains"},{"line_number":52,"context_line":"        # a fix for usage of VXLAN tunnels on a single node:"},{"line_number":53,"context_line":"        # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":54,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":55,"context_line":"        remove_ovs_packages"},{"line_number":56,"context_line":"        compile_ovs True /usr /var"},{"line_number":57,"context_line":"        start_new_ovs"},{"line_number":58,"context_line":"    elif is_kernel_supported_for_ovs26; then"},{"line_number":59,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":60,"context_line":"        remove_ovs_packages"},{"line_number":61,"context_line":"        compile_ovs True /usr /var"},{"line_number":62,"context_line":"        start_new_ovs"},{"line_number":63,"context_line":"    fi"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    load_conf_hook iptables_verify"},{"line_number":66,"context_line":"    # Make the workspace owned by the stack user"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a629dbe_7cd056f8","line":63,"range":{"start_line":47,"start_character":0,"end_line":63,"end_character":6},"updated":"2016-11-14 13:54:12.000000000","message":"I suggest to separate it now to a new function:\n\n function compile_ovs_if_needed_and_supported() {\n     if ! is_ovs_version_ok; then\n         if is_kernel_supported_for_ovs25; then\n             OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}\n         elif is_kernel_supported_for_ovs26; then\n             OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}\n         else\n             return\n         remove_ovs_packages\n         compile_ovs True /usr /var\n         start_new_ovs\n    fi","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"56e0e211edeb2902b8fe765835f829858064f048","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    configure_host_for_func_testing"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    if is_ovs_version_ok; then"},{"line_number":48,"context_line":"        :"},{"line_number":49,"context_line":"    elif is_kernel_supported_for_ovs25; then"},{"line_number":50,"context_line":"        # The OVS_BRANCH variable is used by git checkout. In the case below,"},{"line_number":51,"context_line":"        # we use a current (2016-08-19) HEAD commit from branch-2.5 that contains"},{"line_number":52,"context_line":"        # a fix for usage of VXLAN tunnels on a single node:"},{"line_number":53,"context_line":"        # https://github.com/openvswitch/ovs/commit/741f47cf35df2bfc7811b2cff75c9bb8d05fd26f"},{"line_number":54,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-042326c3fcf61e8638fa15926f984ce5ae142f4b}"},{"line_number":55,"context_line":"        remove_ovs_packages"},{"line_number":56,"context_line":"        compile_ovs True /usr /var"},{"line_number":57,"context_line":"        start_new_ovs"},{"line_number":58,"context_line":"    elif is_kernel_supported_for_ovs26; then"},{"line_number":59,"context_line":"        OVS_BRANCH\u003d${NEUTRON_OVERRIDE_OVS_BRANCH:-\"v2.6.1\"}"},{"line_number":60,"context_line":"        remove_ovs_packages"},{"line_number":61,"context_line":"        compile_ovs True /usr /var"},{"line_number":62,"context_line":"        start_new_ovs"},{"line_number":63,"context_line":"    fi"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    load_conf_hook iptables_verify"},{"line_number":66,"context_line":"    # Make the workspace owned by the stack user"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a629dbe_f74ba15d","line":63,"range":{"start_line":47,"start_character":0,"end_line":63,"end_character":6},"in_reply_to":"9a629dbe_7cd056f8","updated":"2016-11-14 13:59:32.000000000","message":"Will do. I think this is what @iwamoto was going for too.","commit_id":"6e143a423f2ce1ad153b05101df7ba81d02356d1"}]}