)]}'
{"neutron/objects/base.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"5b4df67b28fa2cd039623b0d27193b9c6a195fe9","unresolved":false,"context_lines":[{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    @classmethod"},{"line_number":634,"context_line":"    def any_object(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":635,"context_line":"        if validate_filters:"},{"line_number":636,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":637,"context_line":"        return obj_db_api.any_object("},{"line_number":638,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_e99c2510","line":635,"updated":"2016-11-10 09:30:28.000000000","message":"No doc-string, I\u0027m thinking if any_object is the right name for this new method. What does it mean \u0027any object\u0027?","commit_id":"7b0a98f8c111d89b87c8d58964de7a0a16547e34"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ec53ea5ad85139418e996a9f635b7eb85ca0bc82","unresolved":false,"context_lines":[{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    @classmethod"},{"line_number":634,"context_line":"    def any_object(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":635,"context_line":"        if validate_filters:"},{"line_number":636,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":637,"context_line":"        return obj_db_api.any_object("},{"line_number":638,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_dbe9beb8","line":635,"in_reply_to":"9a629dbe_e99c2510","updated":"2016-11-10 23:17:52.000000000","message":"\u0027any_object\u0027 means to check if there is any object present in the DB. Any suggestions for a better name?","commit_id":"7b0a98f8c111d89b87c8d58964de7a0a16547e34"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"8cf0b88ebee015a20699489f09f63894084b7f00","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        )"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    @classmethod"},{"line_number":634,"context_line":"    def any_object(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":635,"context_line":"        \"\"\""},{"line_number":636,"context_line":"        Check if object is present in DB."},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_a36be183","line":634,"range":{"start_line":634,"start_character":8,"end_line":634,"end_character":18},"updated":"2016-11-11 19:22:32.000000000","message":"it seems \"object_exists\" would be better method name","commit_id":"ae312d1982820250daeda4db74953e2938978142"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"d999e685818e875ab03e979dd44cf28f10143ccb","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        )"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    @classmethod"},{"line_number":634,"context_line":"    def any_object(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":635,"context_line":"        \"\"\""},{"line_number":636,"context_line":"        Check if object is present in DB."},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_2d2ce5aa","line":634,"range":{"start_line":634,"start_character":8,"end_line":634,"end_character":18},"in_reply_to":"9a629dbe_7df4dd86","updated":"2016-11-14 16:28:42.000000000","message":"Done","commit_id":"ae312d1982820250daeda4db74953e2938978142"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"addf0ae1a634f3104b3d4e6d68074c22ec026391","unresolved":false,"context_lines":[{"line_number":631,"context_line":"        )"},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"    @classmethod"},{"line_number":634,"context_line":"    def any_object(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":635,"context_line":"        \"\"\""},{"line_number":636,"context_line":"        Check if object is present in DB."},{"line_number":637,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_7df4dd86","line":634,"range":{"start_line":634,"start_character":8,"end_line":634,"end_character":18},"in_reply_to":"9a629dbe_a36be183","updated":"2016-11-14 10:29:59.000000000","message":"Yes, I agree that object_exists is better name. Let\u0027s discuss it during upgrade meeting.","commit_id":"ae312d1982820250daeda4db74953e2938978142"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68a57ac428b3cc9cf962e406dfa9deb875417242","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        )"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exists(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_b1a680bf","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":21},"updated":"2016-11-15 16:56:36.000000000","message":"should be objects_exist?","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"84d9afb41eef8758d4e08c422293f2a7d8ec8491","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        )"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exists(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_840f722d","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":21},"in_reply_to":"7a77a97e_b1a680bf","updated":"2016-11-15 23:24:49.000000000","message":"Done","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68a57ac428b3cc9cf962e406dfa9deb875417242","unresolved":false,"context_lines":[{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exists(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        :param context:"},{"line_number":598,"context_line":"        :param validate_filters: Raises an error in case of passing an unknown"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_31cc3089","line":595,"range":{"start_line":595,"start_character":17,"end_line":595,"end_character":23},"updated":"2016-11-15 16:56:36.000000000","message":"more like object*s*?","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"acf48dd117470f366599aedf32c51028f4a211bf","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        )"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_408534ab","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":20},"updated":"2016-11-16 10:09:57.000000000","message":"You are missing \u0027s\u0027 at the end of objects\nobjects_exist.","commit_id":"744ae4972941dd4c0e17a419a7c0ff28351547d8"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"459c02fd9ea5fd82e587d32e3190a1e25fcc9aab","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        )"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_459602f1","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":20},"in_reply_to":"7a77a97e_408534ab","updated":"2016-11-16 20:42:53.000000000","message":"Since I am checking only for the single first object here: [1], I am using a singular object_exist\n\n[1] - https://review.openstack.org/#/c/395748/6/neutron/objects/db/api.py@104","commit_id":"744ae4972941dd4c0e17a419a7c0ff28351547d8"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"acf48dd117470f366599aedf32c51028f4a211bf","unresolved":false,"context_lines":[{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        :param context:"},{"line_number":598,"context_line":"        :param validate_filters: Raises an error in case of passing an unknown"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_a0bc486d","line":595,"range":{"start_line":595,"start_character":17,"end_line":595,"end_character":26},"updated":"2016-11-16 10:09:57.000000000","message":"objects are","commit_id":"744ae4972941dd4c0e17a419a7c0ff28351547d8"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"459c02fd9ea5fd82e587d32e3190a1e25fcc9aab","unresolved":false,"context_lines":[{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        :param context:"},{"line_number":598,"context_line":"        :param validate_filters: Raises an error in case of passing an unknown"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_c503f240","line":595,"range":{"start_line":595,"start_character":17,"end_line":595,"end_character":26},"in_reply_to":"7a77a97e_a0bc486d","updated":"2016-11-16 20:42:53.000000000","message":"Same reason as mentioned above.","commit_id":"744ae4972941dd4c0e17a419a7c0ff28351547d8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bfb92430b4672d9893fd69c384c593d5a1b156ec","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        )"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_e937964a","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":20},"updated":"2016-11-18 11:28:47.000000000","message":"I was suggesting objects_exist before, because it is less specific about the number of objects, and would reflect the plural form of get_objects. The name you picked now, it suggests that there will be a single object, which is not necessarily the case.","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"17b3ff7acb8c58ff9ae75506988029766de4a59a","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        )"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_1003c30e","line":593,"range":{"start_line":593,"start_character":8,"end_line":593,"end_character":20},"in_reply_to":"7a77a97e_e937964a","updated":"2016-11-21 18:02:51.000000000","message":"Done","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bfb92430b4672d9893fd69c384c593d5a1b156ec","unresolved":false,"context_lines":[{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        :param context:"},{"line_number":598,"context_line":"        :param validate_filters: Raises an error in case of passing an unknown"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_c90bba7b","line":595,"range":{"start_line":595,"start_character":17,"end_line":595,"end_character":26},"updated":"2016-11-18 11:28:47.000000000","message":"objects are?","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"17b3ff7acb8c58ff9ae75506988029766de4a59a","unresolved":false,"context_lines":[{"line_number":592,"context_line":"    @classmethod"},{"line_number":593,"context_line":"    def object_exist(cls, context, validate_filters\u003dTrue, **kwargs):"},{"line_number":594,"context_line":"        \"\"\""},{"line_number":595,"context_line":"        Check if object is present in DB."},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        :param context:"},{"line_number":598,"context_line":"        :param validate_filters: Raises an error in case of passing an unknown"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_500d3b36","line":595,"range":{"start_line":595,"start_character":17,"end_line":595,"end_character":26},"in_reply_to":"7a77a97e_c90bba7b","updated":"2016-11-21 18:02:51.000000000","message":"Done","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bfb92430b4672d9893fd69c384c593d5a1b156ec","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        \"\"\""},{"line_number":603,"context_line":"        if validate_filters:"},{"line_number":604,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":605,"context_line":"        return obj_db_api.object_exist("},{"line_number":606,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs)"},{"line_number":607,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_a9c2fee6","line":605,"range":{"start_line":605,"start_character":15,"end_line":605,"end_character":38},"updated":"2016-11-18 11:28:47.000000000","message":"I don\u0027t even think you need a separate function inside obj_db_api for that. You can just call to obj_db_api.get_object() and just convert the result to a boolean.","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5530310b690d33611a110a1fb9fc2f05cce6df74","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_objects("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_5bb560cb","line":621,"updated":"2016-11-23 13:16:02.000000000","message":"would using get_object be slightly quicker (since there we don\u0027t need to fetch everything if we care about the first element only)?","commit_id":"ed2512807d902e9f72a40bb2453a501658e2ab0f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"9ba745848b09753cb3a9ac012d0feb087b8f8d4b","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_objects("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_f60395b6","line":621,"in_reply_to":"5a74a57a_1874c09a","updated":"2016-11-23 17:44:39.000000000","message":"Done. I am using DB API get_object() since it doesn\u0027t complain on primary keys.","commit_id":"ed2512807d902e9f72a40bb2453a501658e2ab0f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"7690ddd5b90ef73f852af1b244ef91aa87a3c820","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_objects("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_aeed478d","line":621,"in_reply_to":"5a74a57a_5bb560cb","updated":"2016-11-23 16:18:14.000000000","message":"Since get_object() needs primary key as filters to return, there might be places where this method is called on non-primary keys as filters. In those places, this method (with get_object) would return False even though it is present in DB. Hence, to avoid that, I have used get_objects() instead of get_object(). Please let me if this thought is correct.","commit_id":"ed2512807d902e9f72a40bb2453a501658e2ab0f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"9f289e511bedddb14b5c7b3447ecf742f02d7462","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_objects("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_31352546","line":621,"in_reply_to":"5a74a57a_5bb560cb","updated":"2016-11-23 13:49:56.000000000","message":"Ups, I did not spot the get_objects, thought it stayed get_object.","commit_id":"ed2512807d902e9f72a40bb2453a501658e2ab0f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d7f1d0199ff46a54f932883835b7e321fd1fb67f","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_objects("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_e54e7dc0","line":621,"in_reply_to":"5a74a57a_aeed478d","updated":"2016-11-23 16:49:13.000000000","message":"Good point about that primary keys. \n\nBut in this case, should we use get_objects or count()? For me count() should be faster then fetching all objects and convert them to OVO.","commit_id":"ed2512807d902e9f72a40bb2453a501658e2ab0f"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6d2e88fc5a0b924d85792b9ec58c96f6bb6a9b41","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_objects("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a74a57a_1874c09a","line":621,"in_reply_to":"5a74a57a_e54e7dc0","updated":"2016-11-23 16:55:59.000000000","message":"On the second though, objects DB API get_object() is not checking for primary keys, so it should not error out when calling without primary keys. \n\nThe NeutronDbObject.get_object() is checking for all primary keys or unique keys for SQL model.\n\nSo we should use obj_db_api.get_object (which would do .first() ) or obj_db_api.count, which would do the SQLAlchemy .count() function.","commit_id":"ed2512807d902e9f72a40bb2453a501658e2ab0f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7bf59df84042190b68e7d2317aee4f80202ba945","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_object("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a74a57a_fe59635b","line":621,"updated":"2016-11-25 09:44:30.000000000","message":"Maybe a comment why you don\u0027t call get_objects() here would be beneficial for code readers. I was confused by it till I looked on comments in previous patchsets. Also I wonder whether we will remember why it\u0027s get_object() month from now.","commit_id":"c5005fe3a8c395314e68574996b17d5d61105b5a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4e93e55dd1bb1e6483113710f32a293d845bbc38","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        return bool(obj_db_api.get_object("},{"line_number":622,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":623,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a74a57a_f9532f37","line":621,"in_reply_to":"5a74a57a_fe59635b","updated":"2016-11-25 15:13:40.000000000","message":"Done","commit_id":"c5005fe3a8c395314e68574996b17d5d61105b5a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"63eb78409cfea3b1180fe63562ee7c5a881a96ab","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        \"\"\""},{"line_number":619,"context_line":"        if validate_filters:"},{"line_number":620,"context_line":"            cls.validate_filters(**kwargs)"},{"line_number":621,"context_line":"        # Succeed if at least a single object matches; no need to fetch more"},{"line_number":622,"context_line":"        return bool(obj_db_api.get_object("},{"line_number":623,"context_line":"            context, cls.db_model, **cls.modify_fields_to_db(kwargs))"},{"line_number":624,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a74a57a_b4f7fe89","line":621,"updated":"2016-11-25 15:22:23.000000000","message":"Oh, I originally thought it had to do something with using primary keys but that was just discussion that this will work.","commit_id":"9f6be0f9a2aa1faef85b5eaa81d9a788f71c770d"}],"neutron/objects/db/api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68a57ac428b3cc9cf962e406dfa9deb875417242","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def object_exists(context, model, **kwargs):"},{"line_number":104,"context_line":"    return bool(_get_filter_query(context, model, **kwargs).count())"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_7174e834","line":104,"updated":"2016-11-15 16:56:36.000000000","message":"do we need to count everything? can\u0027t we just extract .first() and return the result depending on whether it\u0027s present?","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"84d9afb41eef8758d4e08c422293f2a7d8ec8491","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def object_exists(context, model, **kwargs):"},{"line_number":104,"context_line":"    return bool(_get_filter_query(context, model, **kwargs).count())"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_c4196a7b","line":104,"in_reply_to":"7a77a97e_7174e834","updated":"2016-11-15 23:24:49.000000000","message":"Done","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bfb92430b4672d9893fd69c384c593d5a1b156ec","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def object_exist(context, model, **kwargs):"},{"line_number":104,"context_line":"    return bool(_get_filter_query(context, model, **kwargs).first())"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_69f70659","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":67},"updated":"2016-11-18 11:28:47.000000000","message":"just call get_object(context, model, **kwargs)","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"17b3ff7acb8c58ff9ae75506988029766de4a59a","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def object_exist(context, model, **kwargs):"},{"line_number":104,"context_line":"    return bool(_get_filter_query(context, model, **kwargs).first())"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_70407736","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":67},"in_reply_to":"7a77a97e_69f70659","updated":"2016-11-21 18:02:51.000000000","message":"I used get_objects since get_object needs primary keys to check if the object is present of not. With get_objects, we can check for non-primary key filters.","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"e8d5474a7785591bc3abf6a95f76987cff2fb305","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            context.session.delete(db_obj)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def objects_exist(context, model, **kwargs):"},{"line_number":104,"context_line":"    return bool(get_objects(context, model, **kwargs))"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_f4853bad","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":54},"updated":"2016-11-22 10:21:19.000000000","message":"Ihar made a good notice, we do not need objects_exist in db api module, it can be only implemented in NeutronDbObject class.","commit_id":"83ccdbf28c484ae7cc9c28e3243523bbe1f1d272"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"3f7f6d4e9589f983f08f5f5fe2033de12e5b5af1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            context.session.delete(db_obj)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def objects_exist(context, model, **kwargs):"},{"line_number":104,"context_line":"    return bool(get_objects(context, model, **kwargs))"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_1ee77113","line":104,"range":{"start_line":103,"start_character":0,"end_line":104,"end_character":54},"in_reply_to":"7a77a97e_f4853bad","updated":"2016-11-22 23:14:49.000000000","message":"Done. I removed them.","commit_id":"83ccdbf28c484ae7cc9c28e3243523bbe1f1d272"}],"neutron/tests/unit/objects/db/test_api.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68a57ac428b3cc9cf962e406dfa9deb875417242","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def test_object_exists(self):"},{"line_number":124,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        new_obj \u003d api.object_exists(self.ctxt, self.model, d\u003dobj.id)"},{"line_number":127,"context_line":"        self.assertIs(True, new_obj)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_91b6e4da","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":16},"updated":"2016-11-15 16:56:36.000000000","message":"it returns a boolean, not an object","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"84d9afb41eef8758d4e08c422293f2a7d8ec8491","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def test_object_exists(self):"},{"line_number":124,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        new_obj \u003d api.object_exists(self.ctxt, self.model, d\u003dobj.id)"},{"line_number":127,"context_line":"        self.assertIs(True, new_obj)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_e42666b9","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":16},"in_reply_to":"7a77a97e_91b6e4da","updated":"2016-11-15 23:24:49.000000000","message":"Done","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68a57ac428b3cc9cf962e406dfa9deb875417242","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        new_obj \u003d api.object_exists(self.ctxt, self.model, d\u003dobj.id)"},{"line_number":127,"context_line":"        self.assertIs(True, new_obj)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_71ab0875","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":26},"updated":"2016-11-15 16:56:36.000000000","message":"self.assertTrue","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"84d9afb41eef8758d4e08c422293f2a7d8ec8491","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        new_obj \u003d api.object_exists(self.ctxt, self.model, d\u003dobj.id)"},{"line_number":127,"context_line":"        self.assertIs(True, new_obj)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_44247aae","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":26},"in_reply_to":"7a77a97e_71ab0875","updated":"2016-11-15 23:24:49.000000000","message":"Done","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bfb92430b4672d9893fd69c384c593d5a1b156ec","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def test_object_exist(self):"},{"line_number":124,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        bool \u003d api.object_exist(self.ctxt, self.model, d\u003dobj.id)"},{"line_number":127,"context_line":"        self.assertTrue(bool)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_09b4d27d","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":12},"updated":"2016-11-18 11:28:47.000000000","message":"you override python keyword here. Rename into objects_exist. Or just put the expression inside assertTrue itself and avoid a variable.","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"17b3ff7acb8c58ff9ae75506988029766de4a59a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def test_object_exist(self):"},{"line_number":124,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        bool \u003d api.object_exist(self.ctxt, self.model, d\u003dobj.id)"},{"line_number":127,"context_line":"        self.assertTrue(bool)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_b04a0f54","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":12},"in_reply_to":"7a77a97e_09b4d27d","updated":"2016-11-21 18:02:51.000000000","message":"Done","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68a57ac428b3cc9cf962e406dfa9deb875417242","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"                          self._test_class.count, self.context,"},{"line_number":1461,"context_line":"                          fake_field\u003d\u0027xxx\u0027)"},{"line_number":1462,"context_line":""},{"line_number":1463,"context_line":"    def test_object_exists(self):"},{"line_number":1464,"context_line":"        for fields in self.obj_fields:"},{"line_number":1465,"context_line":"            self._make_object(fields).create()"},{"line_number":1466,"context_line":"        self.assertIs(True, self._test_class.object_exists(self.context))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_11d2d400","line":1463,"updated":"2016-11-15 16:56:36.000000000","message":"can you also add a test case that would return False? also maybe a case that would utilize validate_filters argument? finally, a case that would match on some specific object only?","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"84d9afb41eef8758d4e08c422293f2a7d8ec8491","unresolved":false,"context_lines":[{"line_number":1460,"context_line":"                          self._test_class.count, self.context,"},{"line_number":1461,"context_line":"                          fake_field\u003d\u0027xxx\u0027)"},{"line_number":1462,"context_line":""},{"line_number":1463,"context_line":"    def test_object_exists(self):"},{"line_number":1464,"context_line":"        for fields in self.obj_fields:"},{"line_number":1465,"context_line":"            self._make_object(fields).create()"},{"line_number":1466,"context_line":"        self.assertIs(True, self._test_class.object_exists(self.context))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_0403620e","line":1463,"in_reply_to":"7a77a97e_11d2d400","updated":"2016-11-15 23:24:49.000000000","message":"Done","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"68a57ac428b3cc9cf962e406dfa9deb875417242","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    def test_object_exists(self):"},{"line_number":1464,"context_line":"        for fields in self.obj_fields:"},{"line_number":1465,"context_line":"            self._make_object(fields).create()"},{"line_number":1466,"context_line":"        self.assertIs(True, self._test_class.object_exists(self.context))"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def test_db_obj(self):"},{"line_number":1469,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_b1bbe0c3","line":1466,"range":{"start_line":1466,"start_character":8,"end_line":1466,"end_character":26},"updated":"2016-11-15 16:56:36.000000000","message":"assertTrue","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"84d9afb41eef8758d4e08c422293f2a7d8ec8491","unresolved":false,"context_lines":[{"line_number":1463,"context_line":"    def test_object_exists(self):"},{"line_number":1464,"context_line":"        for fields in self.obj_fields:"},{"line_number":1465,"context_line":"            self._make_object(fields).create()"},{"line_number":1466,"context_line":"        self.assertIs(True, self._test_class.object_exists(self.context))"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def test_db_obj(self):"},{"line_number":1469,"context_line":"        obj \u003d self._make_object(self.obj_fields[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_240a1e22","line":1466,"range":{"start_line":1466,"start_character":8,"end_line":1466,"end_character":26},"in_reply_to":"7a77a97e_b1bbe0c3","updated":"2016-11-15 23:24:49.000000000","message":"Done","commit_id":"c6cf3f735c58f7f942ef1732e3873679c150a450"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bfb92430b4672d9893fd69c384c593d5a1b156ec","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"        self.assertTrue(self._test_class.object_exist(self.context))"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def test_object_exist_false(self):"},{"line_number":1469,"context_line":"        for fields in self.obj_fields:"},{"line_number":1470,"context_line":"            self._make_object(fields)"},{"line_number":1471,"context_line":"        self.assertFalse(self._test_class.object_exist(self.context))"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"    def test_object_exist_validate_filters(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_0962120a","line":1470,"range":{"start_line":1469,"start_character":8,"end_line":1470,"end_character":37},"updated":"2016-11-18 11:28:47.000000000","message":"I don\u0027t think you should do anything. It\u0027s self-obvious that object instantiation does not update database itself, you don\u0027t need those two lines.","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"17b3ff7acb8c58ff9ae75506988029766de4a59a","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"        self.assertTrue(self._test_class.object_exist(self.context))"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def test_object_exist_false(self):"},{"line_number":1469,"context_line":"        for fields in self.obj_fields:"},{"line_number":1470,"context_line":"            self._make_object(fields)"},{"line_number":1471,"context_line":"        self.assertFalse(self._test_class.object_exist(self.context))"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"    def test_object_exist_validate_filters(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_f072c7af","line":1470,"range":{"start_line":1469,"start_character":8,"end_line":1470,"end_character":37},"in_reply_to":"7a77a97e_0962120a","updated":"2016-11-21 18:02:51.000000000","message":"Done","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bfb92430b4672d9893fd69c384c593d5a1b156ec","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"        self.assertFalse(self._test_class.object_exist(self.context))"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"    def test_object_exist_validate_filters(self):"},{"line_number":1474,"context_line":"        for fields in self.obj_fields:"},{"line_number":1475,"context_line":"            self._make_object(fields).create()"},{"line_number":1476,"context_line":"        self.assertRaises(n_exc.InvalidInput,"},{"line_number":1477,"context_line":"                          self._test_class.object_exist, self.context,"},{"line_number":1478,"context_line":"                          fake_field\u003d\u0027xxx\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_a9375efd","line":1475,"range":{"start_line":1474,"start_character":8,"end_line":1475,"end_character":46},"updated":"2016-11-18 11:28:47.000000000","message":"again, you don\u0027t need those lines. The machinery will trigger exception before query even hits the database.","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"17b3ff7acb8c58ff9ae75506988029766de4a59a","unresolved":false,"context_lines":[{"line_number":1471,"context_line":"        self.assertFalse(self._test_class.object_exist(self.context))"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"    def test_object_exist_validate_filters(self):"},{"line_number":1474,"context_line":"        for fields in self.obj_fields:"},{"line_number":1475,"context_line":"            self._make_object(fields).create()"},{"line_number":1476,"context_line":"        self.assertRaises(n_exc.InvalidInput,"},{"line_number":1477,"context_line":"                          self._test_class.object_exist, self.context,"},{"line_number":1478,"context_line":"                          fake_field\u003d\u0027xxx\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_f080074c","line":1475,"range":{"start_line":1474,"start_character":8,"end_line":1475,"end_character":46},"in_reply_to":"7a77a97e_a9375efd","updated":"2016-11-21 18:02:51.000000000","message":"I was following the test case from test_count_invalid_filters() above. Anyway, I have removed them now.","commit_id":"0509c91cf00ea606252f5da38b9254fc72596e7c"}]}
