)]}'
{"neutron/agent/metadata/agent.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1d77df14d302dacbc31f777b28350bcec3f217c2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                return self._proxy_request(instance_id, req)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":99,"context_line":"                return webob.exc.HTTPNotFound(explanation\u003dunicode(msg))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        except Exception:"},{"line_number":102,"context_line":"            LOG.exception(_(\"Unexpected error.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQ9k%3D","line":99,"updated":"2013-08-02 22:29:30.000000000","message":"The agent is also something that does not interact with the client, so not sure why we need to add explanations to well HTTP status codes.  Also, why the explicit conversion to unicode here?","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"2c6bdfd9d569da5831da085aad70cd0fd6082347","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                return self._proxy_request(instance_id, req)"},{"line_number":97,"context_line":"            else:"},{"line_number":98,"context_line":"                msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":99,"context_line":"                return webob.exc.HTTPNotFound(explanation\u003dunicode(msg))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        except Exception:"},{"line_number":102,"context_line":"            LOG.exception(_(\"Unexpected error.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQvk%3D","line":99,"in_reply_to":"AAAAQn%2F%2FQ9k%3D","updated":"2013-08-03 01:42:35.000000000","message":"I wasn\u0027t really sure tbh if people would interact at any point with this API, and to be sure I added the messages just because there were already some HTTP exceptions that were raised with messages like the ones in line 105, 169 here.\n\nAs far as the unicode question, I was trying to follow the existing code (from the same lines mentioned above), wasn\u0027t sure if there was a reason why you guys were explicitly doing so.\n\nI will remove all this then, and the other similar changes in namespace_proxy also inside the agent package.","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1d77df14d302dacbc31f777b28350bcec3f217c2","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                \u0027response usually occurs when shared secrets do not match.\u0027"},{"line_number":158,"context_line":"            )"},{"line_number":159,"context_line":"            LOG.warn(msg)"},{"line_number":160,"context_line":"            return webob.exc.HTTPForbidden(explanation\u003dunicode(msg))"},{"line_number":161,"context_line":"        elif resp.status \u003d\u003d 404:"},{"line_number":162,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":163,"context_line":"            return webob.exc.HTTPNotFound(explanation\u003dunicode(msg))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQ9c%3D","line":160,"updated":"2013-08-02 22:29:30.000000000","message":"same question as above","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"2c6bdfd9d569da5831da085aad70cd0fd6082347","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                \u0027response usually occurs when shared secrets do not match.\u0027"},{"line_number":158,"context_line":"            )"},{"line_number":159,"context_line":"            LOG.warn(msg)"},{"line_number":160,"context_line":"            return webob.exc.HTTPForbidden(explanation\u003dunicode(msg))"},{"line_number":161,"context_line":"        elif resp.status \u003d\u003d 404:"},{"line_number":162,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":163,"context_line":"            return webob.exc.HTTPNotFound(explanation\u003dunicode(msg))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQvY%3D","line":160,"in_reply_to":"AAAAQn%2F%2FQ9c%3D","updated":"2013-08-03 01:42:35.000000000","message":"Done","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1d77df14d302dacbc31f777b28350bcec3f217c2","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            return webob.exc.HTTPForbidden(explanation\u003dunicode(msg))"},{"line_number":161,"context_line":"        elif resp.status \u003d\u003d 404:"},{"line_number":162,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":163,"context_line":"            return webob.exc.HTTPNotFound(explanation\u003dunicode(msg))"},{"line_number":164,"context_line":"        elif resp.status \u003d\u003d 409:"},{"line_number":165,"context_line":"            msg \u003d _(\u0027There was a conflict when trying to complete \u0027"},{"line_number":166,"context_line":"                    \u0027your request.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQ9Y%3D","line":163,"updated":"2013-08-02 22:29:30.000000000","message":"same","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"2c6bdfd9d569da5831da085aad70cd0fd6082347","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            return webob.exc.HTTPForbidden(explanation\u003dunicode(msg))"},{"line_number":161,"context_line":"        elif resp.status \u003d\u003d 404:"},{"line_number":162,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":163,"context_line":"            return webob.exc.HTTPNotFound(explanation\u003dunicode(msg))"},{"line_number":164,"context_line":"        elif resp.status \u003d\u003d 409:"},{"line_number":165,"context_line":"            msg \u003d _(\u0027There was a conflict when trying to complete \u0027"},{"line_number":166,"context_line":"                    \u0027your request.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQvU%3D","line":163,"in_reply_to":"AAAAQn%2F%2FQ9Y%3D","updated":"2013-08-03 01:42:35.000000000","message":"Done","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1d77df14d302dacbc31f777b28350bcec3f217c2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        elif resp.status \u003d\u003d 409:"},{"line_number":165,"context_line":"            msg \u003d _(\u0027There was a conflict when trying to complete \u0027"},{"line_number":166,"context_line":"                    \u0027your request.\u0027)"},{"line_number":167,"context_line":"            return webob.exc.HTTPConflict(explanation\u003dunicode(msg))"},{"line_number":168,"context_line":"        elif resp.status \u003d\u003d 500:"},{"line_number":169,"context_line":"            msg \u003d _("},{"line_number":170,"context_line":"                \u0027Remote metadata server experienced an internal server error.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQ9U%3D","line":167,"updated":"2013-08-02 22:29:30.000000000","message":"same","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"2c6bdfd9d569da5831da085aad70cd0fd6082347","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        elif resp.status \u003d\u003d 409:"},{"line_number":165,"context_line":"            msg \u003d _(\u0027There was a conflict when trying to complete \u0027"},{"line_number":166,"context_line":"                    \u0027your request.\u0027)"},{"line_number":167,"context_line":"            return webob.exc.HTTPConflict(explanation\u003dunicode(msg))"},{"line_number":168,"context_line":"        elif resp.status \u003d\u003d 500:"},{"line_number":169,"context_line":"            msg \u003d _("},{"line_number":170,"context_line":"                \u0027Remote metadata server experienced an internal server error.\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQvQ%3D","line":167,"in_reply_to":"AAAAQn%2F%2FQ9U%3D","updated":"2013-08-03 01:42:35.000000000","message":"Done","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"}],"neutron/plugins/nec/nec_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"1d77df14d302dacbc31f777b28350bcec3f217c2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            self.ofc.create_ofc_network(context, new_net[\u0027tenant_id\u0027],"},{"line_number":254,"context_line":"                                        new_net[\u0027id\u0027], new_net[\u0027name\u0027])"},{"line_number":255,"context_line":"        except (nexc.OFCException, nexc.OFCConsistencyBroken) as exc:"},{"line_number":256,"context_line":"            reason \u003d _(\"create_network() failed due to %s\") % exc.message"},{"line_number":257,"context_line":"            LOG.error(reason)"},{"line_number":258,"context_line":"            self._update_resource_status(context, \"network\", new_net[\u0027id\u0027],"},{"line_number":259,"context_line":"                                         OperationalStatus.ERROR)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQ%2Bg%3D","line":256,"updated":"2013-08-02 22:29:30.000000000","message":"This is a logging message. Why is this change required?","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"2c6bdfd9d569da5831da085aad70cd0fd6082347","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            self.ofc.create_ofc_network(context, new_net[\u0027tenant_id\u0027],"},{"line_number":254,"context_line":"                                        new_net[\u0027id\u0027], new_net[\u0027name\u0027])"},{"line_number":255,"context_line":"        except (nexc.OFCException, nexc.OFCConsistencyBroken) as exc:"},{"line_number":256,"context_line":"            reason \u003d _(\"create_network() failed due to %s\") % exc.message"},{"line_number":257,"context_line":"            LOG.error(reason)"},{"line_number":258,"context_line":"            self._update_resource_status(context, \"network\", new_net[\u0027id\u0027],"},{"line_number":259,"context_line":"                                         OperationalStatus.ERROR)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FQuw%3D","line":256,"in_reply_to":"AAAAQn%2F%2FQ%2Bg%3D","updated":"2013-08-03 01:42:35.000000000","message":"Done. Forgot to remove from ptach.","commit_id":"2f5a206171f1d7a7dbf95b80ae6831c08cfb16c9"}],"neutron/quota.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"54582c10a612cbda371c12fe761e7742f1235ce3","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @staticmethod"},{"line_number":150,"context_line":"    def update_quota_limit(context, tenant_id, resource, limit):"},{"line_number":151,"context_line":"        msg \u003d _(\u0027Access to this resource was deined.\u0027)"},{"line_number":152,"context_line":"        raise webob.exc.HTTPForbidden(msg)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FDXs%3D","line":151,"updated":"2013-08-07 21:15:25.000000000","message":"typo","commit_id":"8e020fddf013f1c57d468c6b8dc27a912059f1b4"},{"author":{"_account_id":7996,"name":"Luis A. Garcia","email":"luis@linux.vnet.ibm.com","username":"luisg"},"change_message_id":"133cc006ec6fb2b74758bedf8fe50d209bb2b780","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @staticmethod"},{"line_number":150,"context_line":"    def update_quota_limit(context, tenant_id, resource, limit):"},{"line_number":151,"context_line":"        msg \u003d _(\u0027Access to this resource was deined.\u0027)"},{"line_number":152,"context_line":"        raise webob.exc.HTTPForbidden(msg)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FDXA%3D","line":151,"in_reply_to":"AAAAQn%2F%2FDXs%3D","updated":"2013-08-07 21:19:12.000000000","message":"Done","commit_id":"8e020fddf013f1c57d468c6b8dc27a912059f1b4"}]}