)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8bf0e1d471a72e31ecc837aa58c5e350fd510483","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"        # TODO(kevinbenton): garbage collector that deletes ports that didn\u0027t"},{"line_number":1255,"context_line":"        # make it this far to handle servers dying in this process"},{"line_number":1256,"context_line":"        self._core_plugin.update_port(context.elevated(), external_port[\u0027id\u0027],"},{"line_number":1257,"context_line":"                                      {\u0027port\u0027: {\u0027device_id\u0027: fip_id})"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"        if self._is_dns_integration_supported:"},{"line_number":1260,"context_line":"            self._process_dns_floatingip_create_postcommit(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_bb408a08","line":1257,"range":{"start_line":1257,"start_character":67,"end_line":1257,"end_character":69},"updated":"2016-11-10 23:12:14.000000000","message":"Need to add a second closing }. This triggered all the failures","commit_id":"bec21d0877e84051e41a2e0bf2cb84736d1903c7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c1082425475f8c27fa4b311a4c277726cc95e3f5","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"        # TODO(kevinbenton): garbage collector that deletes ports that didn\u0027t"},{"line_number":1255,"context_line":"        # make it this far to handle servers dying in this process"},{"line_number":1256,"context_line":"        self._core_plugin.update_port(context.elevated(), external_port[\u0027id\u0027],"},{"line_number":1257,"context_line":"                                      {\u0027port\u0027: {\u0027device_id\u0027: fip_id})"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"        if self._is_dns_integration_supported:"},{"line_number":1260,"context_line":"            self._process_dns_floatingip_create_postcommit(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_729ee863","line":1257,"updated":"2016-11-12 02:50:17.000000000","message":"whoops. the machine i did this on didn\u0027t have flake8 :)","commit_id":"bec21d0877e84051e41a2e0bf2cb84736d1903c7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4a7dd2b1f31a13138e6d40bf1b340d41c1c2058c","unresolved":false,"context_lines":[{"line_number":1244,"context_line":"                description\u003dfip.get(\u0027description\u0027))"},{"line_number":1245,"context_line":"            # Update association with internal port"},{"line_number":1246,"context_line":"            # and define external IP address"},{"line_number":1247,"context_line":"            self._update_fip_assoc(context, fip,"},{"line_number":1248,"context_line":"                                   floatingip_db, external_port)"},{"line_number":1249,"context_line":"            context.session.add(floatingip_db)"},{"line_number":1250,"context_line":"            floatingip_dict \u003d self._make_floatingip_dict("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_c47deab2","line":1247,"updated":"2016-11-16 00:06:17.000000000","message":"In a DVR environment, this call goes to: https://github.com/openstack/neutron/blob/master/neutron/db/l3_dvr_db.py#L224. This method eventually attempts to update the port while we are inside the transaction: https://github.com/openstack/neutron/blob/master/neutron/db/l3_dvr_db.py#L1072. Since you are not setting \u0027GUARD_TRANSACTION\u0027 to False anymore, the port update fails. I think we need also to include neutron/db/l3_dvr_db.py in this patchset","commit_id":"44e52fb6a9e4d5665016e1618bdf13945d72bd9f"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9895077f9f160e6106e83034368306220ae75363","unresolved":false,"context_lines":[{"line_number":2531,"context_line":"                    None)"},{"line_number":2532,"context_line":""},{"line_number":2533,"context_line":"                with mock.patch(plugin_class + \u0027.create_port\u0027) as createport:"},{"line_number":2534,"context_line":"                    createport.return_value \u003d {\u0027fixed_ips\u0027: [], \u0027id\u0027: \u002744\u0027}"},{"line_number":2535,"context_line":"                    res \u003d self._create_floatingip("},{"line_number":2536,"context_line":"                        self.fmt, public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":2537,"context_line":"                        port_id\u003dp[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_f6b3ea4a","line":2534,"updated":"2016-11-18 15:08:00.000000000","message":"Hank Aaron, Vicks, Magnum ? :)","commit_id":"c9358687cae598143cad20fffd16c6c191985ca4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4d3f41f98a15bf972690a5a1b8232c925f50a6e2","unresolved":false,"context_lines":[{"line_number":2531,"context_line":"                    None)"},{"line_number":2532,"context_line":""},{"line_number":2533,"context_line":"                with mock.patch(plugin_class + \u0027.create_port\u0027) as createport:"},{"line_number":2534,"context_line":"                    createport.return_value \u003d {\u0027fixed_ips\u0027: [], \u0027id\u0027: \u002744\u0027}"},{"line_number":2535,"context_line":"                    res \u003d self._create_floatingip("},{"line_number":2536,"context_line":"                        self.fmt, public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":2537,"context_line":"                        port_id\u003dp[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_230ee68b","line":2534,"in_reply_to":"7a77a97e_f6b3ea4a","updated":"2016-11-20 01:18:13.000000000","message":":D\n\nI wish it were that meaningful. I think my fingers just happened to be on that number.","commit_id":"c9358687cae598143cad20fffd16c6c191985ca4"}]}