)]}'
{"devstack/lib/logging":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57f17cfcc12ed8cac319625f004ab496e075f0a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"function configure_logging_service_plugin {"},{"line_number":2,"context_line":"    neutron_service_plugin_class_add \"log\""},{"line_number":3,"context_line":"}"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"9f436f4f_40a02ef5","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":27},"updated":"2017-08-09 11:56:59.000000000","message":"you use \u0027log\u0027 somewhere and \u0027logging\u0027 elsewhere. Looks inconsistent. What is the difference? This applies to the filename too.","commit_id":"189e7beec6ece266add4efb9cd400c765c4abe93"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"7ca68bd90edc7ef5fe54dce6bd349b22ce1a3349","unresolved":false,"context_lines":[{"line_number":1,"context_line":"function configure_logging_service_plugin {"},{"line_number":2,"context_line":"    neutron_service_plugin_class_add \"log\""},{"line_number":3,"context_line":"}"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"9f436f4f_29650eb6","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":27},"in_reply_to":"9f436f4f_26c1bd55","updated":"2017-08-09 16:40:49.000000000","message":"I\u0027m confusing which option \u0027log\u0027 or \u0027logging\u0027 is better. Do you have any recommendation for me?","commit_id":"189e7beec6ece266add4efb9cd400c765c4abe93"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"f62b4bb34081775222223bda953f933edf791769","unresolved":false,"context_lines":[{"line_number":1,"context_line":"function configure_logging_service_plugin {"},{"line_number":2,"context_line":"    neutron_service_plugin_class_add \"log\""},{"line_number":3,"context_line":"}"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":20,"id":"9f436f4f_26c1bd55","line":1,"range":{"start_line":1,"start_character":19,"end_line":1,"end_character":27},"in_reply_to":"9f436f4f_40a02ef5","updated":"2017-08-09 16:06:39.000000000","message":"Actually, I\u0027m not sure what is the difference \u0027log\u0027 and \u0027logging\u0027. Do you think \u0027logging\u0027 suitable for this situation (for filename also)?","commit_id":"189e7beec6ece266add4efb9cd400c765c4abe93"}],"devstack/plugin.sh":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a496364e2d8153faee5192ef939200f8ffb35219","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            if is_service_enabled q-trunk neutron-trunk; then"},{"line_number":30,"context_line":"                configure_trunk_extension"},{"line_number":31,"context_line":"            fi"},{"line_number":32,"context_line":"            if is_service_enabled q-log neutron-log; then"},{"line_number":33,"context_line":"                configure_logging"},{"line_number":34,"context_line":"            fi"},{"line_number":35,"context_line":"            if is_service_enabled q-dns neutron-dns; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_bdcfae54","line":32,"range":{"start_line":32,"start_character":34,"end_line":32,"end_character":39},"updated":"2017-07-05 05:17:55.000000000","message":"do you need q- alias?","commit_id":"001a2a1e9b51496a93cb3028e3c6e7c95135ed69"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"98568506b564bc0627c750a833a9b5510fe6b3bc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            if is_service_enabled q-trunk neutron-trunk; then"},{"line_number":30,"context_line":"                configure_trunk_extension"},{"line_number":31,"context_line":"            fi"},{"line_number":32,"context_line":"            if is_service_enabled q-log neutron-log; then"},{"line_number":33,"context_line":"                configure_logging"},{"line_number":34,"context_line":"            fi"},{"line_number":35,"context_line":"            if is_service_enabled q-dns neutron-dns; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f1d235d_531649aa","line":32,"range":{"start_line":32,"start_character":34,"end_line":32,"end_character":39},"in_reply_to":"3f1d235d_bdcfae54","updated":"2017-07-05 06:54:39.000000000","message":"No, we don\u0027t. Thanks.","commit_id":"001a2a1e9b51496a93cb3028e3c6e7c95135ed69"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"20cb25519d6389775749d6c9a8c0e6a781eee7b3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            if is_service_enabled q-trunk neutron-trunk; then"},{"line_number":38,"context_line":"                configure_trunk_extension"},{"line_number":39,"context_line":"            fi"},{"line_number":40,"context_line":"            if is_service_enabled neutron-log; then"},{"line_number":41,"context_line":"                configure_log"},{"line_number":42,"context_line":"            fi"},{"line_number":43,"context_line":"            if is_service_enabled q-dns neutron-dns; then"}],"source_content_type":"text/x-sh","patch_set":34,"id":"df87a7cf_575419ff","line":40,"updated":"2017-12-07 21:58:08.000000000","message":"don\u0027t we need also check if \"q-log\" service is enabled like it is for any other service?","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"c578c50ee71f5f0657ce4077927020ba0030740c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            if is_service_enabled q-trunk neutron-trunk; then"},{"line_number":38,"context_line":"                configure_trunk_extension"},{"line_number":39,"context_line":"            fi"},{"line_number":40,"context_line":"            if is_service_enabled neutron-log; then"},{"line_number":41,"context_line":"                configure_log"},{"line_number":42,"context_line":"            fi"},{"line_number":43,"context_line":"            if is_service_enabled q-dns neutron-dns; then"}],"source_content_type":"text/x-sh","patch_set":34,"id":"df87a7cf_76646c4a","line":40,"in_reply_to":"df87a7cf_575419ff","updated":"2017-12-12 08:58:43.000000000","message":"I\u0027m not sure about that. Will consider in next update.","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"}],"neutron/services/logapi/common/exceptions.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a496364e2d8153faee5192ef939200f8ffb35219","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class LoggingTypeNotSupported(n_exc.Conflict):"},{"line_number":29,"context_line":"    message \u003d _(\"Logging type %(resource_type)s is not supported on \""},{"line_number":30,"context_line":"                \"port %(port)s\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_9dd8721e","line":29,"updated":"2017-07-05 05:17:55.000000000","message":"unrelated change","commit_id":"001a2a1e9b51496a93cb3028e3c6e7c95135ed69"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"98568506b564bc0627c750a833a9b5510fe6b3bc","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class LoggingTypeNotSupported(n_exc.Conflict):"},{"line_number":29,"context_line":"    message \u003d _(\"Logging type %(resource_type)s is not supported on \""},{"line_number":30,"context_line":"                \"port %(port)s\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_b36b5d1c","line":29,"in_reply_to":"3f1d235d_9dd8721e","updated":"2017-07-05 06:54:39.000000000","message":"Done","commit_id":"001a2a1e9b51496a93cb3028e3c6e7c95135ed69"}],"neutron/services/logapi/db_api.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a496364e2d8153faee5192ef939200f8ffb35219","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    #case4 logging for tenant"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        tenant_id \u003d sg_log[\u0027project_id\u0027]"},{"line_number":77,"context_line":"        LOG.debug(\u0027annp: tenant_id %s\u0027, tenant_id)"},{"line_number":78,"context_line":"        port_ids \u003d _get_ports_filter_in_tenant(context, tenant_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    ports \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_5ddf7a0c","line":77,"updated":"2017-07-05 05:17:55.000000000","message":"is this wip?","commit_id":"001a2a1e9b51496a93cb3028e3c6e7c95135ed69"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"98568506b564bc0627c750a833a9b5510fe6b3bc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    #case4 logging for tenant"},{"line_number":75,"context_line":"    else:"},{"line_number":76,"context_line":"        tenant_id \u003d sg_log[\u0027project_id\u0027]"},{"line_number":77,"context_line":"        LOG.debug(\u0027annp: tenant_id %s\u0027, tenant_id)"},{"line_number":78,"context_line":"        port_ids \u003d _get_ports_filter_in_tenant(context, tenant_id)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    ports \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_931f41b6","line":77,"in_reply_to":"3f1d235d_5ddf7a0c","updated":"2017-07-05 06:54:39.000000000","message":":) sorry made you confused. Done.","commit_id":"001a2a1e9b51496a93cb3028e3c6e7c95135ed69"}],"neutron/tests/contrib/hooks/log":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"20cb25519d6389775749d6c9a8c0e6a781eee7b3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"[[post-config|/$NEUTRON_CORE_PLUGIN_CONF]]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[network_log]"},{"line_number":6,"context_line":"local_output_log_base \u003d /tmp/test_log.log"}],"source_content_type":"text/plain","patch_set":34,"id":"df87a7cf_374f156c","line":6,"updated":"2017-12-07 21:58:08.000000000","message":"shouldn\u0027t this path be configurable?","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"c578c50ee71f5f0657ce4077927020ba0030740c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"[[post-config|/$NEUTRON_CORE_PLUGIN_CONF]]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[network_log]"},{"line_number":6,"context_line":"local_output_log_base \u003d /tmp/test_log.log"}],"source_content_type":"text/plain","patch_set":34,"id":"df87a7cf_56b92876","line":6,"in_reply_to":"df87a7cf_374f156c","updated":"2017-12-12 08:58:43.000000000","message":"Actually, I need this configuration in tempest test [1]. But I don\u0027t know how to configure local_output_log_base in neutron-tempest_plugin project. Is there any way to do that?\n\n[1] https://review.openstack.org/#/c/522704/3/neutron_tempest_plugin/scenario/admin/test_logging.py@35","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"}],"setup.cfg":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"20cb25519d6389775749d6c9a8c0e6a781eee7b3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    timestamp \u003d neutron.services.timestamp.timestamp_plugin:TimeStampPlugin"},{"line_number":83,"context_line":"    trunk \u003d neutron.services.trunk.plugin:TrunkPlugin"},{"line_number":84,"context_line":"    loki \u003d neutron.services.loki.loki_plugin:LokiPlugin"},{"line_number":85,"context_line":"    log \u003d neutron.services.logapi.logging_plugin:LoggingPlugin"},{"line_number":86,"context_line":"neutron.ml2.type_drivers \u003d"},{"line_number":87,"context_line":"    flat \u003d neutron.plugins.ml2.drivers.type_flat:FlatTypeDriver"},{"line_number":88,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"df87a7cf_f7544d00","line":85,"updated":"2017-12-07 21:58:08.000000000","message":"is this change related to devstack plugin?","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b5efd9249ee0e46d927a362b1ab1a489834a4551","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    timestamp \u003d neutron.services.timestamp.timestamp_plugin:TimeStampPlugin"},{"line_number":83,"context_line":"    trunk \u003d neutron.services.trunk.plugin:TrunkPlugin"},{"line_number":84,"context_line":"    loki \u003d neutron.services.loki.loki_plugin:LokiPlugin"},{"line_number":85,"context_line":"    log \u003d neutron.services.logapi.logging_plugin:LoggingPlugin"},{"line_number":86,"context_line":"neutron.ml2.type_drivers \u003d"},{"line_number":87,"context_line":"    flat \u003d neutron.plugins.ml2.drivers.type_flat:FlatTypeDriver"},{"line_number":88,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"df87a7cf_5c343e93","line":85,"in_reply_to":"df87a7cf_5a13f95c","updated":"2017-12-19 06:34:52.000000000","message":"It\u0027s not small change for logging feature because the name is touched by users in conf. I\u0027d lile to know why do we need to change it so the change should be divided.","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"14b59ffdda248667d8d50581bd96d207efac13e2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    timestamp \u003d neutron.services.timestamp.timestamp_plugin:TimeStampPlugin"},{"line_number":83,"context_line":"    trunk \u003d neutron.services.trunk.plugin:TrunkPlugin"},{"line_number":84,"context_line":"    loki \u003d neutron.services.loki.loki_plugin:LokiPlugin"},{"line_number":85,"context_line":"    log \u003d neutron.services.logapi.logging_plugin:LoggingPlugin"},{"line_number":86,"context_line":"neutron.ml2.type_drivers \u003d"},{"line_number":87,"context_line":"    flat \u003d neutron.plugins.ml2.drivers.type_flat:FlatTypeDriver"},{"line_number":88,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"df87a7cf_dc74ced1","line":85,"in_reply_to":"df87a7cf_5c343e93","updated":"2017-12-19 07:07:00.000000000","message":"Because \u0027api\u0027 seems redundant. So I\u0027d like to make the name looks consistent.","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"084c20278ac6e3087bd8097d8f2dd2fec1fc0c0c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    timestamp \u003d neutron.services.timestamp.timestamp_plugin:TimeStampPlugin"},{"line_number":83,"context_line":"    trunk \u003d neutron.services.trunk.plugin:TrunkPlugin"},{"line_number":84,"context_line":"    loki \u003d neutron.services.loki.loki_plugin:LokiPlugin"},{"line_number":85,"context_line":"    log \u003d neutron.services.logapi.logging_plugin:LoggingPlugin"},{"line_number":86,"context_line":"neutron.ml2.type_drivers \u003d"},{"line_number":87,"context_line":"    flat \u003d neutron.plugins.ml2.drivers.type_flat:FlatTypeDriver"},{"line_number":88,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"df87a7cf_d7f6e9d7","line":85,"in_reply_to":"df87a7cf_b73c85c8","updated":"2017-12-19 07:41:17.000000000","message":"Thanks. I\u0027ve proposed that at https://review.openstack.org/#/c/528977/. Could you please have a look?","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c6da56438e930a18710b87b42fcd9b0c6057d74f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    timestamp \u003d neutron.services.timestamp.timestamp_plugin:TimeStampPlugin"},{"line_number":83,"context_line":"    trunk \u003d neutron.services.trunk.plugin:TrunkPlugin"},{"line_number":84,"context_line":"    loki \u003d neutron.services.loki.loki_plugin:LokiPlugin"},{"line_number":85,"context_line":"    log \u003d neutron.services.logapi.logging_plugin:LoggingPlugin"},{"line_number":86,"context_line":"neutron.ml2.type_drivers \u003d"},{"line_number":87,"context_line":"    flat \u003d neutron.plugins.ml2.drivers.type_flat:FlatTypeDriver"},{"line_number":88,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"df87a7cf_5a13f95c","line":85,"in_reply_to":"df87a7cf_d61a18c4","updated":"2017-12-18 08:49:11.000000000","message":"I\u0027m not sure if it should be done in this patch. I would prefer to make separate patch with such change (which is IMO quite important change) and add proper description for it.\nOr, if for other core reviewers it would be fine, please maybe just add some info in commit message that there is also such change and why it is here.","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b85a0eead60f15b7921c4ee309773dbf512aeba2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    timestamp \u003d neutron.services.timestamp.timestamp_plugin:TimeStampPlugin"},{"line_number":83,"context_line":"    trunk \u003d neutron.services.trunk.plugin:TrunkPlugin"},{"line_number":84,"context_line":"    loki \u003d neutron.services.loki.loki_plugin:LokiPlugin"},{"line_number":85,"context_line":"    log \u003d neutron.services.logapi.logging_plugin:LoggingPlugin"},{"line_number":86,"context_line":"neutron.ml2.type_drivers \u003d"},{"line_number":87,"context_line":"    flat \u003d neutron.plugins.ml2.drivers.type_flat:FlatTypeDriver"},{"line_number":88,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"df87a7cf_b73c85c8","line":85,"in_reply_to":"df87a7cf_dc74ced1","updated":"2017-12-19 07:26:12.000000000","message":"Slawek and I didn\u0027t disagree the change itself. If you want to change it, please separate patches.","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"c578c50ee71f5f0657ce4077927020ba0030740c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    timestamp \u003d neutron.services.timestamp.timestamp_plugin:TimeStampPlugin"},{"line_number":83,"context_line":"    trunk \u003d neutron.services.trunk.plugin:TrunkPlugin"},{"line_number":84,"context_line":"    loki \u003d neutron.services.loki.loki_plugin:LokiPlugin"},{"line_number":85,"context_line":"    log \u003d neutron.services.logapi.logging_plugin:LoggingPlugin"},{"line_number":86,"context_line":"neutron.ml2.type_drivers \u003d"},{"line_number":87,"context_line":"    flat \u003d neutron.plugins.ml2.drivers.type_flat:FlatTypeDriver"},{"line_number":88,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":34,"id":"df87a7cf_d61a18c4","line":85,"in_reply_to":"df87a7cf_f7544d00","updated":"2017-12-12 08:58:43.000000000","message":"Actually, it\u0027s not related to devstack plugin. However, I\u0027d like to make the name of logging plugin looks consistence.","commit_id":"9d73d3019dc563a57629038fe5c488b5bca5e185"}]}
