)]}'
{"neutron/objects/plugins/ml2/base.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"86e305480390832c12838fa86ab2717423e2f35b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.objects import base"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class EndpointBase(base.NeutronDbObject):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    primary_keys \u003d [\u0027ip_address\u0027]"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_632c134b","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":41},"updated":"2016-11-15 20:37:58.000000000","message":"i might be missing something, can you please explain why this class is being added ?","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"74d945510643b9417e814e72e2fd8d9455ec1b69","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron.objects import base"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class EndpointBase(base.NeutronDbObject):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    primary_keys \u003d [\u0027ip_address\u0027]"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_cc19c17b","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":41},"in_reply_to":"7a77a97e_632c134b","updated":"2016-11-29 23:04:59.000000000","message":"This is a base class for endpoints, they\u0027ve in common the primary_key and the way to deal with ip_address field.","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":19591,"name":"Saisrikiran Mudigonda","email":"saisrikiran.mudigonda@intel.com","username":"saisrikiran"},"change_message_id":"9595e96d4f3604892ea4016b7df21d8699ae101e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":26,"context_line":"        result \u003d super(EndpointBase, cls).modify_fields_from_db(db_obj)"},{"line_number":27,"context_line":"        if \u0027ip_address\u0027 in result:"},{"line_number":28,"context_line":"            result[\u0027ip_address\u0027] \u003d netaddr.IPAddress(result[\u0027ip_address\u0027])"},{"line_number":29,"context_line":"        return result"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_63c3b789","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":74},"updated":"2016-11-10 18:01:19.000000000","message":"If result of ip_address is null, don\u0027t you need to throw an exception?","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"30b8371041f520a5c383daf3a5708cbacf475aa7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @classmethod"},{"line_number":25,"context_line":"    def modify_fields_from_db(cls, db_obj):"},{"line_number":26,"context_line":"        result \u003d super(EndpointBase, cls).modify_fields_from_db(db_obj)"},{"line_number":27,"context_line":"        if \u0027ip_address\u0027 in result:"},{"line_number":28,"context_line":"            result[\u0027ip_address\u0027] \u003d netaddr.IPAddress(result[\u0027ip_address\u0027])"},{"line_number":29,"context_line":"        return result"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_d1ea7f73","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":74},"in_reply_to":"9a629dbe_63c3b789","updated":"2016-11-11 01:17:11.000000000","message":"This is a primary key in the tables, so there is no way to be stored as null in the database.","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":19591,"name":"Saisrikiran Mudigonda","email":"saisrikiran.mudigonda@intel.com","username":"saisrikiran"},"change_message_id":"9595e96d4f3604892ea4016b7df21d8699ae101e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":33,"context_line":"        result \u003d super(EndpointBase, cls).modify_fields_to_db(fields)"},{"line_number":34,"context_line":"        if \u0027ip_address\u0027 in fields:"},{"line_number":35,"context_line":"            result[\u0027ip_address\u0027] \u003d cls.filter_to_str(result[\u0027ip_address\u0027])"},{"line_number":36,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_03c83ba7","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":74},"updated":"2016-11-10 18:01:19.000000000","message":"If result of ip_address is null, don\u0027t you need to throw an exception?","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"30b8371041f520a5c383daf3a5708cbacf475aa7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":33,"context_line":"        result \u003d super(EndpointBase, cls).modify_fields_to_db(fields)"},{"line_number":34,"context_line":"        if \u0027ip_address\u0027 in fields:"},{"line_number":35,"context_line":"            result[\u0027ip_address\u0027] \u003d cls.filter_to_str(result[\u0027ip_address\u0027])"},{"line_number":36,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_919ba717","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":74},"in_reply_to":"9a629dbe_03c83ba7","updated":"2016-11-11 01:17:11.000000000","message":"If this value is not set, sqlalchemy will raise an exception when it tries to stored in the database.","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"}],"neutron/objects/plugins/ml2/geneveallocation.py":[{"author":{"_account_id":19591,"name":"Saisrikiran Mudigonda","email":"saisrikiran.mudigonda@intel.com","username":"saisrikiran"},"change_message_id":"9595e96d4f3604892ea4016b7df21d8699ae101e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":48,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_e3050711","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":54},"updated":"2016-11-10 18:01:19.000000000","message":"The host field cannot be set to null in the Database, hence host field must be (nullable\u003dFalse)","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"30b8371041f520a5c383daf3a5708cbacf475aa7","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":48,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_51490fb6","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":54},"in_reply_to":"9a629dbe_e3050711","updated":"2016-11-11 01:17:11.000000000","message":"The model class defines this as nullable column[1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/models/plugins/ml2/geneveallocation.py#L39","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"}],"neutron/objects/plugins/ml2/greallocation.py":[{"author":{"_account_id":19591,"name":"Saisrikiran Mudigonda","email":"saisrikiran.mudigonda@intel.com","username":"saisrikiran"},"change_message_id":"9595e96d4f3604892ea4016b7df21d8699ae101e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue)"},{"line_number":48,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_6312d758","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":53},"updated":"2016-11-10 18:01:19.000000000","message":"The host field cannot be set to null in the Database, hence host field must be (nullable\u003dFalse)","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"30b8371041f520a5c383daf3a5708cbacf475aa7","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue)"},{"line_number":48,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_b1d0abca","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":53},"in_reply_to":"9a629dbe_6312d758","updated":"2016-11-11 01:17:11.000000000","message":"The model class defines this as nullable column[1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/models/plugins/ml2/gre_allocation_endpoints.py#L41","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"}],"neutron/objects/plugins/ml2/vxlanallocation.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e96224331d5774c474ebd3f717a285ed3509f69e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027udp_port\u0027: obj_fields.IntegerField(),"},{"line_number":48,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":49,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_22057579","line":47,"updated":"2016-11-25 13:19:05.000000000","message":"use PortRangeField","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"74d945510643b9417e814e72e2fd8d9455ec1b69","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027udp_port\u0027: obj_fields.IntegerField(),"},{"line_number":48,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":49,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_8c36e9e5","line":47,"in_reply_to":"5a74a57a_22057579","updated":"2016-11-29 23:04:59.000000000","message":"Done","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":19591,"name":"Saisrikiran Mudigonda","email":"saisrikiran.mudigonda@intel.com","username":"saisrikiran"},"change_message_id":"9595e96d4f3604892ea4016b7df21d8699ae101e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027udp_port\u0027: obj_fields.IntegerField(),"},{"line_number":48,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":49,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_e32c279b","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":54},"updated":"2016-11-10 18:01:19.000000000","message":"The host field cannot be set to null in the Database, hence host field must be (nullable\u003dFalse)","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"30b8371041f520a5c383daf3a5708cbacf475aa7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"},{"line_number":47,"context_line":"        \u0027udp_port\u0027: obj_fields.IntegerField(),"},{"line_number":48,"context_line":"        \u0027host\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":49,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_f1dea3db","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":54},"in_reply_to":"9a629dbe_e32c279b","updated":"2016-11-11 01:17:11.000000000","message":"The model class defines this as nullable column[1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/models/plugins/ml2/vxlanallocation.py#L42","commit_id":"019c960349a6e40d35bcce55ef2e4fccb8bfa31a"}]}
