)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"6f8b0d00687bd1735362d7e16f89f453af068212","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parse the output of ip route more robustly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The code parsing the output of ip route assumes that the outpu is the"},{"line_number":10,"context_line":"destination network, and then key/value pairs. This is not necessarily"},{"line_number":11,"context_line":"the case, as the output may contain flags."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_7ac4f55e","line":9,"range":{"start_line":9,"start_character":57,"end_line":9,"end_character":62},"updated":"2016-11-13 08:19:45.000000000","message":"nit: typo","commit_id":"943b55e5bd986cfe63fdc62d6e3848c925cf419d"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b466d73f54a8d0b242d69a312934bf3ee939bca7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Parse the output of ip route more robustly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The code parsing the output of ip route assumes that the outpu is the"},{"line_number":10,"context_line":"destination network, and then key/value pairs. This is not necessarily"},{"line_number":11,"context_line":"the case, as the output may contain flags."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_7aeeb5b5","line":9,"range":{"start_line":9,"start_character":57,"end_line":9,"end_character":62},"in_reply_to":"9a629dbe_7ac4f55e","updated":"2016-11-13 09:17:53.000000000","message":"Will fix.","commit_id":"943b55e5bd986cfe63fdc62d6e3848c925cf419d"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"204b683f4de802e7edecf1bd4a21b14063a98503","unresolved":false,"context_lines":[{"line_number":986,"context_line":"    return result"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"def get_routing_table(ip_version, namespace\u003dNone):"},{"line_number":990,"context_line":"    \"\"\"Return a list of dictionaries, each representing a route."},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    @param ip_version: the routes of version to return, for example 4"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_9c970eeb","line":989,"updated":"2016-11-12 10:22:16.000000000","message":"I don\u0027t see any tests in the tree that would cover different formats of the tool output. Please add those, preferrably first as a separate patch that adds coverage for what works right now; and then as a follow up your change here + more tests for the new format. That will ensure we don\u0027t break anything already working by the change.","commit_id":"943b55e5bd986cfe63fdc62d6e3848c925cf419d"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"b466d73f54a8d0b242d69a312934bf3ee939bca7","unresolved":false,"context_lines":[{"line_number":986,"context_line":"    return result"},{"line_number":987,"context_line":""},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"def get_routing_table(ip_version, namespace\u003dNone):"},{"line_number":990,"context_line":"    \"\"\"Return a list of dictionaries, each representing a route."},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    @param ip_version: the routes of version to return, for example 4"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_da334161","line":989,"in_reply_to":"9a629dbe_9c970eeb","updated":"2016-11-13 09:17:53.000000000","message":"I\u0027ll do that. Note however that I don\u0027t have a sample of every possible output of \u0027ip route\u0027. I\u0027ll produce a couple of examples using my environment. We could always add more.","commit_id":"943b55e5bd986cfe63fdc62d6e3848c925cf419d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"97d80e59b3105a6b004706658c88cc18973caa1f","unresolved":false,"context_lines":[{"line_number":968,"context_line":"}"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def _parse_ip_route_line(line):"},{"line_number":972,"context_line":"    \"\"\"Parse a line output from ip route."},{"line_number":973,"context_line":"    Example for output from ip route\""},{"line_number":974,"context_line":"    default via 192.168.3.120 dev wlp3s0  proto static  metric 1024"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_928520af","line":971,"range":{"start_line":971,"start_character":4,"end_line":971,"end_character":24},"updated":"2016-11-14 10:11:01.000000000","message":"I think parsing the lines via regexps will be easier. Seems like you search for keywords and take next arguments only.","commit_id":"626785a2b318db6612f7cefdee212f612b32f485"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537dc3d1426ebc03fedfc32769d1e10f62a61c89","unresolved":false,"context_lines":[{"line_number":968,"context_line":"}"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def _parse_ip_route_line(line):"},{"line_number":972,"context_line":"    \"\"\"Parse a line output from ip route."},{"line_number":973,"context_line":"    Example for output from ip route\""},{"line_number":974,"context_line":"    default via 192.168.3.120 dev wlp3s0  proto static  metric 1024"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_328c4f35","line":971,"range":{"start_line":971,"start_character":4,"end_line":971,"end_character":24},"in_reply_to":"9a629dbe_928520af","updated":"2016-11-14 12:17:58.000000000","message":"I am not sure we should rely on the order of arguments in the output. Making it order-agnostic seems problematic with a regular expression.","commit_id":"626785a2b318db6612f7cefdee212f612b32f485"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537dc3d1426ebc03fedfc32769d1e10f62a61c89","unresolved":false,"context_lines":[{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def _parse_ip_route_line(line):"},{"line_number":972,"context_line":"    \"\"\"Parse a line output from ip route."},{"line_number":973,"context_line":"    Example for output from ip route\""},{"line_number":974,"context_line":"    default via 192.168.3.120 dev wlp3s0  proto static  metric 1024"},{"line_number":975,"context_line":"    10.0.0.0/8 dev tun0  proto static  scope link  metric 1024"},{"line_number":976,"context_line":"    The first column is the destination, followed by key/value pairs and flags."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_92cd1b89","line":973,"range":{"start_line":973,"start_character":36,"end_line":973,"end_character":37},"updated":"2016-11-14 12:17:58.000000000","message":"what\u0027s that \" for ?","commit_id":"626785a2b318db6612f7cefdee212f612b32f485"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a5fef4687b1745fa90c1a76bf645b747278c65ca","unresolved":false,"context_lines":[{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def _parse_ip_route_line(line):"},{"line_number":972,"context_line":"    \"\"\"Parse a line output from ip route."},{"line_number":973,"context_line":"    Example for output from ip route\""},{"line_number":974,"context_line":"    default via 192.168.3.120 dev wlp3s0  proto static  metric 1024"},{"line_number":975,"context_line":"    10.0.0.0/8 dev tun0  proto static  scope link  metric 1024"},{"line_number":976,"context_line":"    The first column is the destination, followed by key/value pairs and flags."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_61d513b8","line":973,"range":{"start_line":973,"start_character":36,"end_line":973,"end_character":37},"in_reply_to":"9a629dbe_92cd1b89","updated":"2016-11-14 13:39:51.000000000","message":"Will remove","commit_id":"626785a2b318db6612f7cefdee212f612b32f485"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537dc3d1426ebc03fedfc32769d1e10f62a61c89","unresolved":false,"context_lines":[{"line_number":975,"context_line":"    10.0.0.0/8 dev tun0  proto static  scope link  metric 1024"},{"line_number":976,"context_line":"    The first column is the destination, followed by key/value pairs and flags."},{"line_number":977,"context_line":"    @param line A line output from ip route"},{"line_number":978,"context_line":"    @return: a list of dictionaries, each representing a route."},{"line_number":979,"context_line":"    \"\"\""},{"line_number":980,"context_line":"    line \u003d line.split()"},{"line_number":981,"context_line":"    result \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_155d75ec","line":978,"range":{"start_line":978,"start_character":13,"end_line":978,"end_character":63},"updated":"2016-11-14 12:17:58.000000000","message":"I don\u0027t think that\u0027s correct","commit_id":"626785a2b318db6612f7cefdee212f612b32f485"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"a5fef4687b1745fa90c1a76bf645b747278c65ca","unresolved":false,"context_lines":[{"line_number":975,"context_line":"    10.0.0.0/8 dev tun0  proto static  scope link  metric 1024"},{"line_number":976,"context_line":"    The first column is the destination, followed by key/value pairs and flags."},{"line_number":977,"context_line":"    @param line A line output from ip route"},{"line_number":978,"context_line":"    @return: a list of dictionaries, each representing a route."},{"line_number":979,"context_line":"    \"\"\""},{"line_number":980,"context_line":"    line \u003d line.split()"},{"line_number":981,"context_line":"    result \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_41e72fac","line":978,"range":{"start_line":978,"start_character":13,"end_line":978,"end_character":63},"in_reply_to":"9a629dbe_155d75ec","updated":"2016-11-14 13:39:51.000000000","message":"Will fix. Thanks for noticing.","commit_id":"626785a2b318db6612f7cefdee212f612b32f485"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fea3de768c176b21be1638cb2454ffc74d2eb933","unresolved":false,"context_lines":[{"line_number":964,"context_line":"_IP_ROUTE_PARSE_KEYS \u003d {"},{"line_number":965,"context_line":"    \u0027via\u0027: \u0027nexthop\u0027,"},{"line_number":966,"context_line":"    \u0027dev\u0027: \u0027device\u0027,"},{"line_number":967,"context_line":"    \u0027scope\u0027: \u0027scope\u0027,"},{"line_number":968,"context_line":"}"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_0d873762","line":967,"updated":"2016-11-15 03:35:42.000000000","message":"nit: trailing comma","commit_id":"ca854d7efeb4db1cbdaace1b67799323da4d2abb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"fea3de768c176b21be1638cb2454ffc74d2eb933","unresolved":false,"context_lines":[{"line_number":972,"context_line":"    \"\"\"Parse a line output from ip route."},{"line_number":973,"context_line":"    Example for output from ip route"},{"line_number":974,"context_line":"    default via 192.168.3.120 dev wlp3s0  proto static  metric 1024"},{"line_number":975,"context_line":"    10.0.0.0/8 dev tun0  proto static  scope link  metric 1024"},{"line_number":976,"context_line":"    The first column is the destination, followed by key/value pairs and flags."},{"line_number":977,"context_line":"    @param line A line output from ip route"},{"line_number":978,"context_line":"    @return: a dictionary representing a route."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_6d96eb95","line":975,"updated":"2016-11-15 03:35:42.000000000","message":"It would be good to have the failing example here as well.","commit_id":"ca854d7efeb4db1cbdaace1b67799323da4d2abb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e8eae8237d7e7c9ac45584d062655a49046e522a","unresolved":false,"context_lines":[{"line_number":969,"context_line":""},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"def _parse_ip_route_line(line):"},{"line_number":972,"context_line":"    \"\"\"Parse a line output from ip route."},{"line_number":973,"context_line":"    Example for output from \u0027ip route\u0027:"},{"line_number":974,"context_line":"    default via 192.168.3.120 dev wlp3s0  proto static  metric 1024"},{"line_number":975,"context_line":"    10.0.0.0/8 dev tun0  proto static  scope link  metric 1024"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_bec10b31","line":972,"updated":"2016-11-15 06:04:33.000000000","message":"\"Parse a line of output\" would sound more natural to me.","commit_id":"7647e3e56f630708ad4da12ba1af429d49ac1fc1"}]}
