)]}'
{"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"28f86eb0b54c688ee993ca6f7204bc1481cf694c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def _create_dvr_gateway(self, ex_gw_port, gw_interface_name):"},{"line_number":149,"context_line":"        snat_ns \u003d self._create_snat_namespace()"},{"line_number":150,"context_line":"        for port in self.get_snat_interfaces():"},{"line_number":151,"context_line":"            # connect snat_ports to br_int from SNAT namespace"},{"line_number":152,"context_line":"            self._plug_snat_port(port)"},{"line_number":153,"context_line":"        self._external_gateway_added(ex_gw_port, gw_interface_name,"},{"line_number":154,"context_line":"                                     snat_ns.name, preserve_ips\u003d[])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_44bf33d0","line":151,"updated":"2016-11-15 13:40:34.000000000","message":"I think this should stay where it was as it applies to all ports in the for() loop.  Plus it says \"snat_ports\"","commit_id":"4013295af5f7c991d86ab29fe67e56357cf79b22"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"13a482aa05e577c1de5fddd16de45f812e5c9791","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    def _create_dvr_gateway(self, ex_gw_port, gw_interface_name):"},{"line_number":149,"context_line":"        snat_ns \u003d self._create_snat_namespace()"},{"line_number":150,"context_line":"        for port in self.get_snat_interfaces():"},{"line_number":151,"context_line":"            # connect snat_ports to br_int from SNAT namespace"},{"line_number":152,"context_line":"            self._plug_snat_port(port)"},{"line_number":153,"context_line":"        self._external_gateway_added(ex_gw_port, gw_interface_name,"},{"line_number":154,"context_line":"                                     snat_ns.name, preserve_ips\u003d[])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_24187784","line":151,"in_reply_to":"7a77a97e_44bf33d0","updated":"2016-11-15 13:54:16.000000000","message":"Done","commit_id":"4013295af5f7c991d86ab29fe67e56357cf79b22"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"05fec051944f2d9749137cdfc1074804bd419315","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                               prefix\u003dprefix)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _plug_snat_port(self, port):"},{"line_number":139,"context_line":"        # create interface_name"},{"line_number":140,"context_line":"        interface_name \u003d self._get_snat_int_device_name(port[\u0027id\u0027])"},{"line_number":141,"context_line":"        self._internal_network_added("},{"line_number":142,"context_line":"            self.snat_namespace.name, port[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_c8d191cf","line":139,"updated":"2016-11-15 16:10:19.000000000","message":"Sorry to complain again, but looking at this after coffee :) seems silly to even have this comment as it\u0027s obvious what is happening, and other code in this file doesn\u0027t have it either.\n\nSo I think you\u0027re just down to moving that one comment and removing the other.","commit_id":"b641279fbf7f95aa0ed65a6b955d8c24e1a24677"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"858b94a8a8a6f11885c9994e9e71665b7b37956f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                               prefix\u003dprefix)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _plug_snat_port(self, port):"},{"line_number":139,"context_line":"        # create interface_name"},{"line_number":140,"context_line":"        interface_name \u003d self._get_snat_int_device_name(port[\u0027id\u0027])"},{"line_number":141,"context_line":"        self._internal_network_added("},{"line_number":142,"context_line":"            self.snat_namespace.name, port[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_ebb007f7","line":139,"in_reply_to":"7a77a97e_c8d191cf","updated":"2016-11-15 16:20:14.000000000","message":"I think we can have this comment","commit_id":"b641279fbf7f95aa0ed65a6b955d8c24e1a24677"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"abc0969a1827707294dd718dd2f3a2f5759f57e7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                               prefix\u003dprefix)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _plug_snat_port(self, port):"},{"line_number":139,"context_line":"        # create interface_name"},{"line_number":140,"context_line":"        interface_name \u003d self._get_snat_int_device_name(port[\u0027id\u0027])"},{"line_number":141,"context_line":"        self._internal_network_added("},{"line_number":142,"context_line":"            self.snat_namespace.name, port[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_1209e4dd","line":139,"in_reply_to":"7a77a97e_c8d191cf","updated":"2016-11-16 01:15:34.000000000","message":"Yes, this comment is optional, I will remove it.","commit_id":"b641279fbf7f95aa0ed65a6b955d8c24e1a24677"}]}
