)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"23ad5da49f798aa47819041f84e8396e287d7b70","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":379,"context_line":"                                cidr.network, mode, lease))"},{"line_number":380,"context_line":"                else:"},{"line_number":381,"context_line":"                    if cidr.prefixlen \u003c 64:"},{"line_number":382,"context_line":"                        continue"},{"line_number":383,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%d,%s\u0027 %"},{"line_number":384,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_797d71e6","line":381,"updated":"2016-11-16 19:07:40.000000000","message":"can you at least add a log message here with the subnet ID. this may help an admin trouble shoot (the /64 should already be a clear indication that something is fishy)","commit_id":"9e967872565710bce55bd77f5af407eb490cf3bc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bf3b138fa3c9f295ad6a4f8599de907ace559dfa","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":379,"context_line":"                                cidr.network, mode, lease))"},{"line_number":380,"context_line":"                else:"},{"line_number":381,"context_line":"                    if cidr.prefixlen \u003c 64:"},{"line_number":382,"context_line":"                        continue"},{"line_number":383,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%d,%s\u0027 %"},{"line_number":384,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_6da68411","line":381,"in_reply_to":"7a77a97e_797d71e6","updated":"2016-11-16 21:50:59.000000000","message":"yeah, i just threw this patch up in a hurry while working on something else. I\u0027m not even sure if this is the right fix. We may want to block subnets from having \u0027enable_dhcp\u0027 set to True with cidrs smaller than 64 on the server side. I need an IPv6 expert to chime in to see if this is a fundamental limitation of DHCPv6 or if it\u0027s just a dnsmasq issue.","commit_id":"9e967872565710bce55bd77f5af407eb490cf3bc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"030e29b92c4272f41891bee88d1308c40c942859","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":380,"context_line":"                                cidr.network, mode, lease))"},{"line_number":381,"context_line":"                else:"},{"line_number":382,"context_line":"                    if cidr.prefixlen \u003c 64:"},{"line_number":383,"context_line":"                        LOG.debug(\"Ignoring CIDR with prefix length \u003c 64: %s\","},{"line_number":384,"context_line":"                                  cidr)"},{"line_number":385,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_12c76b96","line":382,"updated":"2016-11-29 15:23:09.000000000","message":"While I don\u0027t have a use case for anything but /64, seems DHCPv6 does allow it so I\u0027m OK with this.  We\u0027ll see what John thinks.","commit_id":"5081a6a1ce1dd21bfb6014a5cbc67cbeffcca1c4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9751937e2756f0a6462d939456bc0303499163fc","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":380,"context_line":"                                cidr.network, mode, lease))"},{"line_number":381,"context_line":"                else:"},{"line_number":382,"context_line":"                    if cidr.prefixlen \u003c 64:"},{"line_number":383,"context_line":"                        LOG.debug(\"Ignoring CIDR with prefix length \u003c 64: %s\","},{"line_number":384,"context_line":"                                  cidr)"},{"line_number":385,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_890fbb2d","line":382,"updated":"2016-11-29 22:37:39.000000000","message":"dnsmasq seems to be okay with the larger ones so I\u0027ll not skip those for now here. I added to the functional test to cover those cases.","commit_id":"5081a6a1ce1dd21bfb6014a5cbc67cbeffcca1c4"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ce54280f840df32314036cc32784005800e4f419","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":380,"context_line":"                                cidr.network, mode, lease))"},{"line_number":381,"context_line":"                else:"},{"line_number":382,"context_line":"                    if cidr.prefixlen \u003c 64:"},{"line_number":383,"context_line":"                        LOG.debug(\"Ignoring CIDR with prefix length \u003c 64: %s\","},{"line_number":384,"context_line":"                                  cidr)"},{"line_number":385,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_12576b58","line":382,"in_reply_to":"5a74a57a_12c76b96","updated":"2016-11-29 15:32:57.000000000","message":"It might even be better to go one step further and skip prefixes that are anything other than 64. If this change is sufficient to avoid this particular bug then I\u0027m happy with it, but we should definitely discuss a ban on non-64 prefixes neutron-wide.","commit_id":"5081a6a1ce1dd21bfb6014a5cbc67cbeffcca1c4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6412206bc23a427caf44f137db3109249a1ea8bd","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                else:"},{"line_number":382,"context_line":"                    if cidr.prefixlen \u003c 64:"},{"line_number":383,"context_line":"                        LOG.debug(\"Ignoring CIDR with prefix length \u003c 64: %s\","},{"line_number":384,"context_line":"                                  cidr)"},{"line_number":385,"context_line":"                        continue"},{"line_number":386,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s,%d,%s\u0027 %"},{"line_number":387,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_0ca014a5","line":384,"updated":"2016-11-30 02:18:37.000000000","message":"It was suggested to add the subnet id here by someone offline, since we\u0027re waiting for a recheck i\u0027ll do it now.","commit_id":"ad958555a4518abc72c95cc37cd151c47ef61196"}]}