)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"22d21e97cfcf58dd83a6f2723b227537941817ed","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               loaded before starting the agent, otherwise it will fail"},{"line_number":56,"context_line":"               to start."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Depends-On: Id6bfd9595f0772a63d1096ef83ebbb6cd630fafd"},{"line_number":59,"context_line":"Change-Id: I9137ea017624ac92a05f73863b77f9ee4681bbe7"},{"line_number":60,"context_line":"Related-Bug: #1622914"},{"line_number":61,"context_line":"(cherry picked from commit e83a44b96a8e3cd81b7cc684ac90486b283a3507)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_5e3949d6","line":58,"updated":"2016-11-17 15:56:19.000000000","message":"is this right?","commit_id":"5148e7d9e6ae7de1691fcfd65eb9fc6fa4b730d2"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"033f8169c7477d9b7a184d6eeba10f68a41fe81b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               loaded before starting the agent, otherwise it will fail"},{"line_number":56,"context_line":"               to start."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Depends-On: Id6bfd9595f0772a63d1096ef83ebbb6cd630fafd"},{"line_number":59,"context_line":"Change-Id: I9137ea017624ac92a05f73863b77f9ee4681bbe7"},{"line_number":60,"context_line":"Related-Bug: #1622914"},{"line_number":61,"context_line":"(cherry picked from commit e83a44b96a8e3cd81b7cc684ac90486b283a3507)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_f4ccf1bc","line":58,"in_reply_to":"7a77a97e_5e3949d6","updated":"2016-11-17 17:32:06.000000000","message":"Good catch, I backported https://review.openstack.org/#/c/399142/ though it has the same Change-Id as the commit it was cherry-picked from. I don\u0027t know, how zuul works at such situation.","commit_id":"5148e7d9e6ae7de1691fcfd65eb9fc6fa4b730d2"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"893be0597a539128346d0ccbe0d2e1af4b027a85","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               loaded before starting the agent, otherwise it will fail"},{"line_number":56,"context_line":"               to start."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Depends-On: Id6bfd9595f0772a63d1096ef83ebbb6cd630fafd"},{"line_number":59,"context_line":"Change-Id: I9137ea017624ac92a05f73863b77f9ee4681bbe7"},{"line_number":60,"context_line":"Related-Bug: #1622914"},{"line_number":61,"context_line":"(cherry picked from commit e83a44b96a8e3cd81b7cc684ac90486b283a3507)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_43a5cc44","line":58,"in_reply_to":"7a77a97e_6a2f1888","updated":"2016-11-18 12:32:41.000000000","message":"No, grenade uses devstack so devstack patch is sufficient.","commit_id":"5148e7d9e6ae7de1691fcfd65eb9fc6fa4b730d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f88d36ffc2a1b566651e57ba07d53290dbb27b25","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               loaded before starting the agent, otherwise it will fail"},{"line_number":56,"context_line":"               to start."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Depends-On: Id6bfd9595f0772a63d1096ef83ebbb6cd630fafd"},{"line_number":59,"context_line":"Change-Id: I9137ea017624ac92a05f73863b77f9ee4681bbe7"},{"line_number":60,"context_line":"Related-Bug: #1622914"},{"line_number":61,"context_line":"(cherry picked from commit e83a44b96a8e3cd81b7cc684ac90486b283a3507)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_a9a11efa","line":58,"in_reply_to":"7a77a97e_6a2f1888","updated":"2016-11-18 11:11:06.000000000","message":"No. Grenade jobs in Newton run on Trusty only, and hence there is no more work needed. (There was an issue in gate definition lately where Xenial grenade jobs were executed on Newton patches in devstack, but that\u0027s now fixed).","commit_id":"5148e7d9e6ae7de1691fcfd65eb9fc6fa4b730d2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"33ae15664faec94753582bc8e3e494b1b0524d57","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               loaded before starting the agent, otherwise it will fail"},{"line_number":56,"context_line":"               to start."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Depends-On: Id6bfd9595f0772a63d1096ef83ebbb6cd630fafd"},{"line_number":59,"context_line":"Change-Id: I9137ea017624ac92a05f73863b77f9ee4681bbe7"},{"line_number":60,"context_line":"Related-Bug: #1622914"},{"line_number":61,"context_line":"(cherry picked from commit e83a44b96a8e3cd81b7cc684ac90486b283a3507)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_6a2f1888","line":58,"in_reply_to":"7a77a97e_f4ccf1bc","updated":"2016-11-17 18:10:30.000000000","message":"then I\u0027ll continue to ask: is there anything in grenade that needs to be done too?","commit_id":"5148e7d9e6ae7de1691fcfd65eb9fc6fa4b730d2"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"29f6831fd06947ecb0407a0c4740368481ac67b3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                    _(\"sysctl value %s not present on this system.\") % knob)"},{"line_number":120,"context_line":"            enabled \u003d utils.execute([\u0027sysctl\u0027, \u0027-b\u0027, knob])"},{"line_number":121,"context_line":"            if enabled !\u003d \u00271\u0027:"},{"line_number":122,"context_line":"                versionutils.report_deprecated_feature("},{"line_number":123,"context_line":"                    LOG,"},{"line_number":124,"context_line":"                    _LW(\u0027Bridge firewalling is disabled; enabling to make \u0027"},{"line_number":125,"context_line":"                        \u0027iptables firewall work. This may not work in future \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_675d9114","line":122,"updated":"2016-11-17 17:54:08.000000000","message":"We should not report a deprecation warning here because it\u0027s a backport.","commit_id":"5148e7d9e6ae7de1691fcfd65eb9fc6fa4b730d2"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"893be0597a539128346d0ccbe0d2e1af4b027a85","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                    _(\"sysctl value %s not present on this system.\") % knob)"},{"line_number":120,"context_line":"            enabled \u003d utils.execute([\u0027sysctl\u0027, \u0027-b\u0027, knob])"},{"line_number":121,"context_line":"            if enabled !\u003d \u00271\u0027:"},{"line_number":122,"context_line":"                versionutils.report_deprecated_feature("},{"line_number":123,"context_line":"                    LOG,"},{"line_number":124,"context_line":"                    _LW(\u0027Bridge firewalling is disabled; enabling to make \u0027"},{"line_number":125,"context_line":"                        \u0027iptables firewall work. This may not work in future \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_7aca661c","line":122,"in_reply_to":"7a77a97e_675d9114","updated":"2016-11-18 12:32:41.000000000","message":"Done","commit_id":"5148e7d9e6ae7de1691fcfd65eb9fc6fa4b730d2"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"08c2aa5237edd0229c38a5614263a22586b461d5","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            LOG.debug(\"Exception while extracting %(knob)s. \""},{"line_number":239,"context_line":"                      \"Exception: %(e)s\", {\u0027knob\u0027: knob, \u0027e\u0027: e})"},{"line_number":240,"context_line":"            return False"},{"line_number":241,"context_line":"        if out \u003d\u003d \u00270\u0027:"},{"line_number":242,"context_line":"            return False"},{"line_number":243,"context_line":"    return True"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_b1941c8b","line":241,"updated":"2016-11-18 15:36:10.000000000","message":"Am I reading this correctly? The sanity check will fail if the net.bridge.bridge-nf-call-*tables values are set to 0 but the modules are loaded, even though the runtime code in neutron will set the values to 1 and continue in that case? If so, it seems weird for the sanity check to fail when the runtime would be fine.","commit_id":"0982b51c0caa4849aaa1f0d26add3f5b97c6974f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0da9b30435e86591af7916dafd1a3126e9cf2832","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            LOG.debug(\"Exception while extracting %(knob)s. \""},{"line_number":239,"context_line":"                      \"Exception: %(e)s\", {\u0027knob\u0027: knob, \u0027e\u0027: e})"},{"line_number":240,"context_line":"            return False"},{"line_number":241,"context_line":"        if out \u003d\u003d \u00270\u0027:"},{"line_number":242,"context_line":"            return False"},{"line_number":243,"context_line":"    return True"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_630ab78b","line":241,"in_reply_to":"7a77a97e_716fe4fb","updated":"2016-11-18 16:05:30.000000000","message":"Done","commit_id":"0982b51c0caa4849aaa1f0d26add3f5b97c6974f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5232acd2d8763713638be4fad1ac02403d7a7916","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            LOG.debug(\"Exception while extracting %(knob)s. \""},{"line_number":239,"context_line":"                      \"Exception: %(e)s\", {\u0027knob\u0027: knob, \u0027e\u0027: e})"},{"line_number":240,"context_line":"            return False"},{"line_number":241,"context_line":"        if out \u003d\u003d \u00270\u0027:"},{"line_number":242,"context_line":"            return False"},{"line_number":243,"context_line":"    return True"},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_716fe4fb","line":241,"in_reply_to":"7a77a97e_b1941c8b","updated":"2016-11-18 15:51:45.000000000","message":"Yeah, maybe we don\u0027t really need that part of the check. As long as kernel modules are loaded, the code should do its job fine.\n\nIn Ocata, it was worth also checking the value because we issue a deprecation warning then. But since we removed it from the backport, maybe we should also just validate that the option is available.","commit_id":"0982b51c0caa4849aaa1f0d26add3f5b97c6974f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8e8abe0ff14ada3c5e7bf03694761bf430467d80","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    for proto in (\u0027arp\u0027, \u0027ip\u0027, \u0027ip6\u0027):"},{"line_number":235,"context_line":"        knob \u003d \u0027net.bridge.bridge-nf-call-%stables\u0027 % proto"},{"line_number":236,"context_line":"        if knob not in entries:"},{"line_number":237,"context_line":"            LOG.error(_LE(\"sysctl value %s not present on this system.\"), knob)"},{"line_number":238,"context_line":"            return False"},{"line_number":239,"context_line":"    return True"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_b74249ac","line":237,"updated":"2016-11-18 17:19:36.000000000","message":"this introduces a new translatable message, which is not desirable for backports. And I don\u0027t think it\u0027s really needed: the caller of the check already logs a warning. Can we use LOG.debug instead? Or maybe just skip the message completely?","commit_id":"2d3d774dfdb01954c9291901ca45ee89819aa1f9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"416a441b587914c028e42f31cd67935e799bc886","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    for proto in (\u0027arp\u0027, \u0027ip\u0027, \u0027ip6\u0027):"},{"line_number":235,"context_line":"        knob \u003d \u0027net.bridge.bridge-nf-call-%stables\u0027 % proto"},{"line_number":236,"context_line":"        if knob not in entries:"},{"line_number":237,"context_line":"            LOG.error(_LE(\"sysctl value %s not present on this system.\"), knob)"},{"line_number":238,"context_line":"            return False"},{"line_number":239,"context_line":"    return True"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_ad0f5835","line":237,"in_reply_to":"7a77a97e_8d461c79","updated":"2016-11-18 18:18:40.000000000","message":"Done","commit_id":"2d3d774dfdb01954c9291901ca45ee89819aa1f9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"547a4e7eba1739cbff206f880f204013ac68f568","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    for proto in (\u0027arp\u0027, \u0027ip\u0027, \u0027ip6\u0027):"},{"line_number":235,"context_line":"        knob \u003d \u0027net.bridge.bridge-nf-call-%stables\u0027 % proto"},{"line_number":236,"context_line":"        if knob not in entries:"},{"line_number":237,"context_line":"            LOG.error(_LE(\"sysctl value %s not present on this system.\"), knob)"},{"line_number":238,"context_line":"            return False"},{"line_number":239,"context_line":"    return True"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_8d461c79","line":237,"in_reply_to":"7a77a97e_b74249ac","updated":"2016-11-18 18:16:57.000000000","message":"I\u0027d rather provide at least the debug so user can know which one of tests failed.","commit_id":"2d3d774dfdb01954c9291901ca45ee89819aa1f9"}]}
