)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ab175d4a58e759dbbf06fdf9a0097e12597988d8","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        if not port[\u0027fixed_ips\u0027]:"},{"line_number":626,"context_line":"            msg \u003d _(\u0027Router port must have at least one fixed IP\u0027)"},{"line_number":627,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":628,"context_line":"        if router_id is not None:"},{"line_number":629,"context_line":"            self._notify_attaching_interface(context, router_id,"},{"line_number":630,"context_line":"                                             port[\u0027network_id\u0027])"},{"line_number":631,"context_line":"        return port"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_86c8af56","side":"PARENT","line":628,"updated":"2016-12-07 02:36:23.000000000","message":"these were added by to address a bgpvpn use case. Are we sure we\u0027re not regressing by removing these from here? Either way, router_id is no longer used now, so it should be safe to remove.","commit_id":"5e674bf738780d9d407f2f5948787e7d455b3922"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"95c3fe9e957813b574f98969a4dbca74c5e168a1","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        if not port[\u0027fixed_ips\u0027]:"},{"line_number":626,"context_line":"            msg \u003d _(\u0027Router port must have at least one fixed IP\u0027)"},{"line_number":627,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":628,"context_line":"        if router_id is not None:"},{"line_number":629,"context_line":"            self._notify_attaching_interface(context, router_id,"},{"line_number":630,"context_line":"                                             port[\u0027network_id\u0027])"},{"line_number":631,"context_line":"        return port"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_c1a7f1a4","side":"PARENT","line":628,"in_reply_to":"3a71b18c_811ed909","updated":"2016-12-07 03:07:32.000000000","message":"Let me add mathron who should be able to assist you.","commit_id":"5e674bf738780d9d407f2f5948787e7d455b3922"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3f0666b26b41be571fd7977a75384f8d6ca8deb9","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        if not port[\u0027fixed_ips\u0027]:"},{"line_number":626,"context_line":"            msg \u003d _(\u0027Router port must have at least one fixed IP\u0027)"},{"line_number":627,"context_line":"            raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":628,"context_line":"        if router_id is not None:"},{"line_number":629,"context_line":"            self._notify_attaching_interface(context, router_id,"},{"line_number":630,"context_line":"                                             port[\u0027network_id\u0027])"},{"line_number":631,"context_line":"        return port"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_811ed909","side":"PARENT","line":628,"in_reply_to":"3a71b18c_86c8af56","updated":"2016-12-07 03:03:52.000000000","message":"Yep, we still notify before attachment both by port and by subnet (L806 in the new version). The problem was that add_router_interface used to not call _notify_attaching_interface directly when adding by port so it was being done here.\n\nHowever, this did have some weird behavior that I didn\u0027t carry over. This would notify even if the router was already attached to a network and was just getting a port updated to add a new subnet. My patch now only notifies if it\u0027s a new port because the event is called BEFORE_CREATE.\n\nDo you think I should preserve the behavior and notify even if it\u0027s just an update?","commit_id":"5e674bf738780d9d407f2f5948787e7d455b3922"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ed477370cc372dece3323bb75e226bc72daefeaa","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        return port_id_specified, subnet_id_specified"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def _check_router_port(self, context, port_id, device_id,"},{"line_number":603,"context_line":"                           router_id\u003dNone):"},{"line_number":604,"context_line":"        \"\"\"Check that a port is available for an attachment to a router"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        :param context: The context of the request."}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_f19462e9","line":603,"updated":"2016-12-08 17:17:51.000000000","message":"Ah, yes.","commit_id":"e4b797c986194bdbf8294884ba52ce862ae1c1a6"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f2ea125c65bef7d6d56112930ebd60973d76aa35","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        return port_id_specified, subnet_id_specified"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    def _check_router_port(self, context, port_id, device_id,"},{"line_number":603,"context_line":"                           router_id\u003dNone):"},{"line_number":604,"context_line":"        \"\"\"Check that a port is available for an attachment to a router"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        :param context: The context of the request."}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_80868563","line":603,"range":{"start_line":603,"start_character":27,"end_line":603,"end_character":36},"updated":"2016-12-08 14:28:16.000000000","message":"shouldn\u0027t it be removed?","commit_id":"e4b797c986194bdbf8294884ba52ce862ae1c1a6"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f2ea125c65bef7d6d56112930ebd60973d76aa35","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            mgr \u003d p_utils.update_port_on_error("},{"line_number":802,"context_line":"                self._core_plugin, context, port[\u0027id\u0027], revert_value)"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        if new_port:"},{"line_number":805,"context_line":"            with mgr:"},{"line_number":806,"context_line":"                self._notify_attaching_interface(context, router_db\u003drouter,"},{"line_number":807,"context_line":"                                                 port\u003dport,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_6017a954","line":804,"range":{"start_line":804,"start_character":11,"end_line":804,"end_character":19},"updated":"2016-12-08 14:28:16.000000000","message":"I\u0027m not sure the name of this variable is appropriated, since in case of an attachment by port, no new port is created.","commit_id":"e4b797c986194bdbf8294884ba52ce862ae1c1a6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ed477370cc372dece3323bb75e226bc72daefeaa","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            mgr \u003d p_utils.update_port_on_error("},{"line_number":802,"context_line":"                self._core_plugin, context, port[\u0027id\u0027], revert_value)"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        if new_port:"},{"line_number":805,"context_line":"            with mgr:"},{"line_number":806,"context_line":"                self._notify_attaching_interface(context, router_db\u003drouter,"},{"line_number":807,"context_line":"                                                 port\u003dport,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_1198fe1a","line":804,"updated":"2016-12-08 17:17:51.000000000","message":"Yeah, it corresponds to a new locical router interface, regardless of whether or not there was a port provided.","commit_id":"e4b797c986194bdbf8294884ba52ce862ae1c1a6"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f2ea125c65bef7d6d56112930ebd60973d76aa35","unresolved":false,"context_lines":[{"line_number":838,"context_line":"                        port_id\u003dport[\u0027id\u0027],"},{"line_number":839,"context_line":"                        router_id\u003drouter_id,"},{"line_number":840,"context_line":"                        port\u003dport,"},{"line_number":841,"context_line":"                        new_interface\u003dnew_port,"},{"line_number":842,"context_line":"                        interface_info\u003dinterface_info)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        return self._make_router_interface_info("}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_5bd29e35","line":841,"range":{"start_line":841,"start_character":38,"end_line":841,"end_character":46},"updated":"2016-12-08 14:28:16.000000000","message":"In the case of an attachment by port, the port is only updated at line 700 as in line 742. So in this case this param should be false, am I wrong? \n\nI don\u0027t know what other part of the code is using the new_interface kwargs, so I don\u0027t have a strong opinion whether this implementation is good or not.","commit_id":"e4b797c986194bdbf8294884ba52ce862ae1c1a6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ed477370cc372dece3323bb75e226bc72daefeaa","unresolved":false,"context_lines":[{"line_number":838,"context_line":"                        port_id\u003dport[\u0027id\u0027],"},{"line_number":839,"context_line":"                        router_id\u003drouter_id,"},{"line_number":840,"context_line":"                        port\u003dport,"},{"line_number":841,"context_line":"                        new_interface\u003dnew_port,"},{"line_number":842,"context_line":"                        interface_info\u003dinterface_info)"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        return self._make_router_interface_info("}],"source_content_type":"text/x-python","patch_set":12,"id":"3a71b18c_319fba04","line":841,"updated":"2016-12-08 17:17:51.000000000","message":"It\u0027s still a new router interface if you attach by port. This event isn\u0027t to notify you about port creations, that\u0027s what the \u003cresources.PORT, events.AFTER_CREATE\u003e is for. This is to notify you about the logical \u0027router interface\u0027, which represents when a router is attached to something, whether or not is used a passed in port or it had to create it itself.","commit_id":"e4b797c986194bdbf8294884ba52ce862ae1c1a6"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"68f85ce5fddb3749b0990217157ea2a9e0f50306","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        # if not a new interface, the interface was added to a new subnet,"},{"line_number":327,"context_line":"        # which is the first in this list"},{"line_number":328,"context_line":"        subnet \u003d subnets[0]"},{"line_number":329,"context_line":"        if not subnet or subnet[\u0027ip_version\u0027] !\u003d 6:"},{"line_number":330,"context_line":"            return"},{"line_number":331,"context_line":"        # NOTE: For IPv6 additional subnets added to the same"},{"line_number":332,"context_line":"        # network we need to update the CSNAT port with respective"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_ea705d42","line":329,"updated":"2016-11-28 21:37:49.000000000","message":"nit: s/6/const.IPv6 but it was that way in the original","commit_id":"46aff35a26d7642b1bf1c50139e07cbce2babb64"}]}
