)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0e69d6c69af888d961b224387be9db6bbdea73bf","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            port_type\u003downer"},{"line_number":877,"context_line":"        )"},{"line_number":878,"context_line":"        try:"},{"line_number":879,"context_line":"            port_db \u003d self._core_plugin._make_port_dict(qry.one().port)"},{"line_number":880,"context_line":"        except exc.NoResultFound:"},{"line_number":881,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":882,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_c4ae3a2d","line":879,"updated":"2016-11-28 20:55:46.000000000","message":"nit: s/port_db/port","commit_id":"43636af17c91a53848ce985adf2b4dc8c5bf1ea3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"322683e1ba6efbf2f59ffc00ba351befa342535c","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            port_type\u003downer"},{"line_number":877,"context_line":"        )"},{"line_number":878,"context_line":"        try:"},{"line_number":879,"context_line":"            port_db \u003d self._core_plugin._make_port_dict(qry.one().port)"},{"line_number":880,"context_line":"        except exc.NoResultFound:"},{"line_number":881,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":882,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_49508ed4","line":879,"in_reply_to":"5a74a57a_c4ae3a2d","updated":"2016-12-06 11:50:06.000000000","message":"Done","commit_id":"43636af17c91a53848ce985adf2b4dc8c5bf1ea3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7b8912caecd99c1afa919b400cd1d49852635574","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            port_type\u003downer"},{"line_number":877,"context_line":"        )"},{"line_number":878,"context_line":"        try:"},{"line_number":879,"context_line":"            port \u003d self._core_plugin._make_port_dict(qry.one().port)"},{"line_number":880,"context_line":"        except exc.NoResultFound:"},{"line_number":881,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":882,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_46df7739","line":879,"updated":"2016-12-07 02:29:59.000000000","message":"please do not use a private method!","commit_id":"24f8c1fec2e104d63890aa09dd4f92dd70d61621"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9fae8596b021327bbafc4701531c2a33b49dbc7a","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            port_type\u003downer"},{"line_number":877,"context_line":"        )"},{"line_number":878,"context_line":"        try:"},{"line_number":879,"context_line":"            port \u003d self._core_plugin._make_port_dict(qry.one().port)"},{"line_number":880,"context_line":"        except exc.NoResultFound:"},{"line_number":881,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":882,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_9ce47eac","line":879,"in_reply_to":"3a71b18c_3cd36ad6","updated":"2016-12-07 03:51:33.000000000","message":"I am not suggesting to use a known public method instead :)","commit_id":"24f8c1fec2e104d63890aa09dd4f92dd70d61621"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ec43bf371fa268e453e9d58b2dffd3763a1761a3","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            port_type\u003downer"},{"line_number":877,"context_line":"        )"},{"line_number":878,"context_line":"        try:"},{"line_number":879,"context_line":"            port \u003d self._core_plugin._make_port_dict(qry.one().port)"},{"line_number":880,"context_line":"        except exc.NoResultFound:"},{"line_number":881,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":882,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_61cd3d65","line":879,"in_reply_to":"3a71b18c_46df7739","updated":"2016-12-07 03:12:04.000000000","message":"This comes at the cost of extra queries through the core plugin, but okay!","commit_id":"24f8c1fec2e104d63890aa09dd4f92dd70d61621"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4b82dc2cd3884c76d0c7a24a82677350b34589bd","unresolved":false,"context_lines":[{"line_number":876,"context_line":"            port_type\u003downer"},{"line_number":877,"context_line":"        )"},{"line_number":878,"context_line":"        try:"},{"line_number":879,"context_line":"            port \u003d self._core_plugin._make_port_dict(qry.one().port)"},{"line_number":880,"context_line":"        except exc.NoResultFound:"},{"line_number":881,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":882,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_3cd36ad6","line":879,"in_reply_to":"3a71b18c_61cd3d65","updated":"2016-12-07 03:51:12.000000000","message":"You figure out how to avoid the runtime cost.","commit_id":"24f8c1fec2e104d63890aa09dd4f92dd70d61621"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"76d2acfbb9b94f91ed16bed2b089b7ee64969034","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            port_type\u003downer"},{"line_number":879,"context_line":"        )"},{"line_number":880,"context_line":"        try:"},{"line_number":881,"context_line":"            port \u003d self._core_plugin.get_port(context, qry.one().port_id)"},{"line_number":882,"context_line":"        except n_exc.PortNotFound:"},{"line_number":883,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":884,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_1b9cc368","line":881,"range":{"start_line":881,"start_character":55,"end_line":881,"end_character":73},"updated":"2016-12-08 00:21:31.000000000","message":"kill it","commit_id":"17c82cef72e20c03e1314bbcbe2d238482bca08a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"627812498c2d23c072bc42be838792b9b97b3bc5","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            port_type\u003downer"},{"line_number":879,"context_line":"        )"},{"line_number":880,"context_line":"        try:"},{"line_number":881,"context_line":"            port \u003d self._core_plugin.get_port(context, qry.one().port_id)"},{"line_number":882,"context_line":"        except n_exc.PortNotFound:"},{"line_number":883,"context_line":"            raise l3.RouterInterfaceNotFound(router_id\u003drouter_id,"},{"line_number":884,"context_line":"                                             port_id\u003dport_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_25db031d","line":881,"range":{"start_line":881,"start_character":55,"end_line":881,"end_character":73},"in_reply_to":"3a71b18c_1b9cc368","updated":"2016-12-08 13:47:51.000000000","message":"can\u0027t kill it, have to confirm that the routerport record exists so users don\u0027t use this api to delete other ports. :)","commit_id":"17c82cef72e20c03e1314bbcbe2d238482bca08a"}],"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0e69d6c69af888d961b224387be9db6bbdea73bf","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                                         context, port, interface_info,"},{"line_number":433,"context_line":"                                         router_id, **kwargs):"},{"line_number":434,"context_line":"        \"\"\"Handler to cleanup distributed resources after intf removal.\"\"\""},{"line_number":435,"context_line":"        context \u003d context.elevated()"},{"line_number":436,"context_line":"        router \u003d self._get_router(context, router_id)"},{"line_number":437,"context_line":"        if not router.extra_attributes.distributed:"},{"line_number":438,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_ef66afb9","line":435,"updated":"2016-11-28 20:55:46.000000000","message":"Do we need to do this here?  Before we just elevated on L471","commit_id":"43636af17c91a53848ce985adf2b4dc8c5bf1ea3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"322683e1ba6efbf2f59ffc00ba351befa342535c","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                                         context, port, interface_info,"},{"line_number":433,"context_line":"                                         router_id, **kwargs):"},{"line_number":434,"context_line":"        \"\"\"Handler to cleanup distributed resources after intf removal.\"\"\""},{"line_number":435,"context_line":"        context \u003d context.elevated()"},{"line_number":436,"context_line":"        router \u003d self._get_router(context, router_id)"},{"line_number":437,"context_line":"        if not router.extra_attributes.distributed:"},{"line_number":438,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_e9231a54","line":435,"in_reply_to":"5a74a57a_ef66afb9","updated":"2016-12-06 11:50:06.000000000","message":"Now I don\u0027t remember why I made this change. Let me put it back.","commit_id":"43636af17c91a53848ce985adf2b4dc8c5bf1ea3"}]}
