)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"649603088f80adbb3324ee2d82eb5ab4f9182d64","unresolved":false,"context_lines":[{"line_number":17,"context_line":"The fix is to move the router update call out of update_subnet. This"},{"line_number":18,"context_line":"will make sure that the DB transactions as executed in update_subnet"},{"line_number":19,"context_line":"are completed. Consequently, information retrieved from the db and"},{"line_number":20,"context_line":"populated in the router update will be consistent."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I31cf4fcb1df4b0dc125d30050a3aba14d05dd7eb"},{"line_number":23,"context_line":"Closes-Bug: #1639033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_911c4b6c","line":20,"updated":"2016-11-21 11:36:11.000000000","message":"This commit message needs some cleanup. The only thing it mentions is removing the router update from update_subnet, but the majority of the change is a bunch of things on the agent side.\n\nAlso, if getting that out of the subnet transaction fixes the issue, I believe this change should have accomplished that for you. https://review.openstack.org/#/c/395972","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"be8ee98fb8ae1aeaaed9ff5c06bd73c783c74224","unresolved":false,"context_lines":[{"line_number":17,"context_line":"The fix is to move the router update call out of update_subnet. This"},{"line_number":18,"context_line":"will make sure that the DB transactions as executed in update_subnet"},{"line_number":19,"context_line":"are completed. Consequently, information retrieved from the db and"},{"line_number":20,"context_line":"populated in the router update will be consistent."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I31cf4fcb1df4b0dc125d30050a3aba14d05dd7eb"},{"line_number":23,"context_line":"Closes-Bug: #1639033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a71b18c_8e81684d","line":20,"in_reply_to":"7a77a97e_911c4b6c","updated":"2016-12-01 21:23:18.000000000","message":"with https://review.openstack.org/#/c/395972, router update now has the correct information. Now the question is: should the router update call be removed from update_subnet? If the answer is yes, then this change is still valid.\n\nAs you\u0027ve found out, there are changes in the agent side, which I need to describe in the commit message. Mainly:\n\n   - add router_id in the prefix_update notification. If removing router update from update_subnet is the right thing to do, then the router_id is useful when sending router update (see changes in l3_rpc.py)\n\n   - remove the method _internal_network_updated() (the method name has a leading underscore). With the latest code, the method is no longer needed . V6 addresses should have been updated with the call to internal_network_updated().","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"}],"neutron/agent/linux/pd.py":[{"author":{"_account_id":16934,"name":"Martin Roy","email":"lindycoder@gmail.com","username":"lindycoder"},"change_message_id":"af0788520c1c986c3035a7e6362eaaef7164bbf5","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                self._add_lla(router, bind_lla_with_mask)"},{"line_number":138,"context_line":"        if prefix_update:"},{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_26ed2db7","line":140,"updated":"2016-11-18 16:29:27.000000000","message":"So this method crafts and update and send it through this notifier and with your change you\u0027re kind of perverting a \"subnet\" dict into jamming a router id in a tuple...\n\nHave you thought about figuring around here which router you\u0027d want to update and instead of only sending a prefix update also sending an router update?","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"54c50ae935ccd4d9645d72ebafd7370336678f3d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                self._add_lla(router, bind_lla_with_mask)"},{"line_number":138,"context_line":"        if prefix_update:"},{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_529bc317","line":140,"in_reply_to":"7a77a97e_26ed2db7","updated":"2016-11-18 17:53:48.000000000","message":"I\u0027m not sure that I fully understand your comments. What the notifier does is this: whenever one or more pd-enabled subnets have prefix change, notify the neutron server with a prefix_update dictionary. Previously, the prefix update is a dictionary with subnet id as key, and the updated prefix as the value. It\u0027s to say that a subnet\u0027s prefix has changed to a particular value. \n\nThe above change is to add the router_id into the value. It\u0027s to say that a subnet\u0027s prefix has changed to a particular value on the router identified by the router_id.","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"ca74c8b50791f7f4081380d270ef2bdd7bbad4ac","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                self._add_lla(router, bind_lla_with_mask)"},{"line_number":138,"context_line":"        if prefix_update:"},{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d5eb3ada","line":140,"in_reply_to":"7a77a97e_48c232ea","updated":"2016-11-18 19:27:00.000000000","message":"if you read the commit message carefully, notification of router update is the responsibility of neutron server. In this particular case, the notification is moved from inside the update_subnet() to the l3_rpc.py to make sure data consistency.","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":16934,"name":"Martin Roy","email":"lindycoder@gmail.com","username":"lindycoder"},"change_message_id":"0dfbd689efd5be6321c5a4d375f620fb413779c4","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                self._add_lla(router, bind_lla_with_mask)"},{"line_number":138,"context_line":"        if prefix_update:"},{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_48c232ea","line":140,"in_reply_to":"7a77a97e_529bc317","updated":"2016-11-18 18:50:42.000000000","message":"Okay, pardon my missunderstanding i just felt that changing a string to a tuple would smell of adding new data to a value because it\u0027s convenient.\n\nSo at the other end (in your change in l3_rpc.py)  it seemed to me that it may not be l3_rpc\u0027s responsibility to update the routers.\n\nRather this PrefixDelegation class could be aware that it is changing prefixes for N subnets and that it will affect some routers and directly send the updates to the routers through a similar abstracted notification system.","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":16934,"name":"Martin Roy","email":"lindycoder@gmail.com","username":"lindycoder"},"change_message_id":"e92586d93735566dc2ef7b8af468a695fda39e1b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                self._add_lla(router, bind_lla_with_mask)"},{"line_number":138,"context_line":"        if prefix_update:"},{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_813d00c6","line":140,"in_reply_to":"7a77a97e_d5eb3ada","updated":"2016-11-18 21:35:30.000000000","message":"Ok i can\u0027t say i\u0027m well enough documented to fully understand the extent of the problem, but that was just an idea","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":16934,"name":"Martin Roy","email":"lindycoder@gmail.com","username":"lindycoder"},"change_message_id":"af0788520c1c986c3035a7e6362eaaef7164bbf5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"},{"line_number":144,"context_line":"        for subnet_id, pd_info in six.iteritems(router[\u0027subnets\u0027]):"},{"line_number":145,"context_line":"            self._delete_lla(router, pd_info.get_bind_lla_with_mask())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_26728d11","line":142,"updated":"2016-11-18 16:29:27.000000000","message":"The router object doesn\u0027t contain the router_id?","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"54c50ae935ccd4d9645d72ebafd7370336678f3d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"},{"line_number":144,"context_line":"        for subnet_id, pd_info in six.iteritems(router[\u0027subnets\u0027]):"},{"line_number":145,"context_line":"            self._delete_lla(router, pd_info.get_bind_lla_with_mask())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_f22e8fa3","line":142,"in_reply_to":"7a77a97e_26728d11","updated":"2016-11-18 17:53:48.000000000","message":"that\u0027s right. In the PrefixDelegation class, routers is a dictionary that\u0027s keyed by the router_id (Refer to the __init__()).","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":16934,"name":"Martin Roy","email":"lindycoder@gmail.com","username":"lindycoder"},"change_message_id":"e92586d93735566dc2ef7b8af468a695fda39e1b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"},{"line_number":144,"context_line":"        for subnet_id, pd_info in six.iteritems(router[\u0027subnets\u0027]):"},{"line_number":145,"context_line":"            self._delete_lla(router, pd_info.get_bind_lla_with_mask())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_01ec9028","line":142,"in_reply_to":"7a77a97e_b205f414","updated":"2016-11-18 21:35:30.000000000","message":"Well if you control the content of that dict you could add the id in it.  That would simplify the method calls.  Again just an idea ;)","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"ca74c8b50791f7f4081380d270ef2bdd7bbad4ac","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"},{"line_number":144,"context_line":"        for subnet_id, pd_info in six.iteritems(router[\u0027subnets\u0027]):"},{"line_number":145,"context_line":"            self._delete_lla(router, pd_info.get_bind_lla_with_mask())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_b205f414","line":142,"in_reply_to":"7a77a97e_d217d042","updated":"2016-11-18 19:27:00.000000000","message":"oh, the routers inside the PrefixDelegation class isn\u0027t the same as that passed in the kwargs in the remove_router call.\n\nThe general content of PrefixDelegation\u0027s router can be found at line 316","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"},{"author":{"_account_id":16934,"name":"Martin Roy","email":"lindycoder@gmail.com","username":"lindycoder"},"change_message_id":"0dfbd689efd5be6321c5a4d375f620fb413779c4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            LOG.debug(\"Update server with prefixes: %s\", prefix_update)"},{"line_number":140,"context_line":"            self.notifier(self.context, prefix_update)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def delete_router_pd(self, router_id, router):"},{"line_number":143,"context_line":"        prefix_update \u003d {}"},{"line_number":144,"context_line":"        for subnet_id, pd_info in six.iteritems(router[\u0027subnets\u0027]):"},{"line_number":145,"context_line":"            self._delete_lla(router, pd_info.get_bind_lla_with_mask())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_d217d042","line":142,"in_reply_to":"7a77a97e_f22e8fa3","updated":"2016-11-18 18:50:42.000000000","message":"What i meant is... if the router contains the id (router[\u0027id\u0027]? or router.router_id (see line 308)) when why pass in the ID and the Router?","commit_id":"4194c763d1c60fd9e37edfc320a81a40ff8a45a5"}]}
