)]}'
{"neutron/db/qos/models.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"217eafaaf99089747bda7937db69726b43c6cce1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        models_v2.Network,"},{"line_number":51,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":52,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":53,"context_line":"    revises_on_change \u003d (\u0027networks\u0027, )"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class QosPortPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_24121e63","line":53,"updated":"2016-11-22 11:24:48.000000000","message":"this should be \u0027network\u0027. It references the relationship on the mode.","commit_id":"2867ce116aa004f739ec19a10c915cdfcb89dee1"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"22607c542ca27b9b84cc68323ae0368efdd3d27d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        models_v2.Network,"},{"line_number":51,"context_line":"        backref\u003dsa.orm.backref(\"qos_policy_binding\", uselist\u003dFalse,"},{"line_number":52,"context_line":"                               cascade\u003d\u0027delete\u0027, lazy\u003d\u0027joined\u0027))"},{"line_number":53,"context_line":"    revises_on_change \u003d (\u0027networks\u0027, )"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class QosPortPolicyBinding(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a74a57a_2f4b152d","line":53,"in_reply_to":"7a77a97e_24121e63","updated":"2016-11-23 01:36:39.000000000","message":"Done. thanks","commit_id":"2867ce116aa004f739ec19a10c915cdfcb89dee1"}],"neutron/tests/tempest/api/test_revisions.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a6a09750ddbcb26f8cb9e976d27d9d2ee8323678","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        self.client.update_floatingip(b2[\u0027floatingip\u0027][\u0027id\u0027], port_id\u003dNone)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    @test.idempotent_id(\u0027gdh51ebc-df35-40oi-3h0b-g0w9hfwe5c39\u0027)"},{"line_number":266,"context_line":"    @test.requires_ext(extension\u003d\"router\", service\u003d\"network\")"},{"line_number":267,"context_line":"    def test_update_router_extra_attributes_bumps_revision(self):"},{"line_number":268,"context_line":"        subnet \u003d self.create_subnet(self.create_network())"},{"line_number":269,"context_line":"        router \u003d self.create_router(router_name\u003d\u0027r1\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_ac5e4c10","line":266,"updated":"2016-11-21 12:00:02.000000000","message":"probably a good idea to check for dvr here.","commit_id":"b723ed1af79c4efe509ca1a170b0035be66b5a6d"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"6d2be0ee9c4520d3127b171778fe988c6d775bc1","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        self.client.update_floatingip(b2[\u0027floatingip\u0027][\u0027id\u0027], port_id\u003dNone)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    @test.idempotent_id(\u0027gdh51ebc-df35-40oi-3h0b-g0w9hfwe5c39\u0027)"},{"line_number":266,"context_line":"    @test.requires_ext(extension\u003d\"router\", service\u003d\"network\")"},{"line_number":267,"context_line":"    def test_update_router_extra_attributes_bumps_revision(self):"},{"line_number":268,"context_line":"        subnet \u003d self.create_subnet(self.create_network())"},{"line_number":269,"context_line":"        router \u003d self.create_router(router_name\u003d\u0027r1\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_0bbb860f","line":266,"in_reply_to":"7a77a97e_ac5e4c10","updated":"2016-11-22 02:35:35.000000000","message":"Done","commit_id":"b723ed1af79c4efe509ca1a170b0035be66b5a6d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a58ac204cdf742ed9fb4c01ffc294a8f30ea298","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            port[\u0027id\u0027], qos_policy_id\u003dpolicy[\u0027id\u0027])"},{"line_number":301,"context_line":"        self.assertGreater(updated[\u0027port\u0027][\u0027revision_number\u0027],"},{"line_number":302,"context_line":"                           port[\u0027revision_number\u0027])"},{"line_number":303,"context_line":"        # disassociate"},{"line_number":304,"context_line":"        self.admin_client.update_port(port[\u0027id\u0027], qos_policy_id\u003dNone)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @test.idempotent_id(\u0027817da343-c6e4-445c-9519-a621f124dfbe\u0027)"},{"line_number":307,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_75aae471","line":304,"range":{"start_line":303,"start_character":8,"end_line":304,"end_character":69},"updated":"2016-11-24 18:43:54.000000000","message":"you do that because otherwise cleanup for the policy will fail right? I think you can\u0027t expect this line to be executed, instead you should register a cleanup with addCleanup.","commit_id":"f6b03f78f0bf80c18952e81dfcd1b6e47b03eb64"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"c63916488e2111d32f1d46a5b891cd54d93faf1a","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            port[\u0027id\u0027], qos_policy_id\u003dpolicy[\u0027id\u0027])"},{"line_number":301,"context_line":"        self.assertGreater(updated[\u0027port\u0027][\u0027revision_number\u0027],"},{"line_number":302,"context_line":"                           port[\u0027revision_number\u0027])"},{"line_number":303,"context_line":"        # disassociate"},{"line_number":304,"context_line":"        self.admin_client.update_port(port[\u0027id\u0027], qos_policy_id\u003dNone)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @test.idempotent_id(\u0027817da343-c6e4-445c-9519-a621f124dfbe\u0027)"},{"line_number":307,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_6f3be39c","line":304,"range":{"start_line":303,"start_character":8,"end_line":304,"end_character":69},"in_reply_to":"5a74a57a_75aae471","updated":"2016-11-25 06:34:26.000000000","message":"Exactly. If I do not disassociate here, I will hit \"QosPolicyInUse\" exception during cleanup. \n\nAnd If I delete this line and register an addCleanup here, in my local environment, I still hit \"QosPolicyInUse\" exception. Not sure if it is a good idea to register a cleanup after disassociation.","commit_id":"f6b03f78f0bf80c18952e81dfcd1b6e47b03eb64"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a58ac204cdf742ed9fb4c01ffc294a8f30ea298","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            network[\u0027id\u0027], qos_policy_id\u003dpolicy[\u0027id\u0027])"},{"line_number":313,"context_line":"        self.assertGreater(updated[\u0027network\u0027][\u0027revision_number\u0027],"},{"line_number":314,"context_line":"                           network[\u0027revision_number\u0027])"},{"line_number":315,"context_line":"        # disassociate"},{"line_number":316,"context_line":"        self.admin_client.update_network(network[\u0027id\u0027], qos_policy_id\u003dNone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_f5b434d2","line":316,"range":{"start_line":315,"start_character":8,"end_line":316,"end_character":75},"updated":"2016-11-24 18:43:54.000000000","message":"ditto?","commit_id":"f6b03f78f0bf80c18952e81dfcd1b6e47b03eb64"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a9ac03cc5779eb03825038fa3d38d30e2c0f31b","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                           port[\u0027revision_number\u0027])"},{"line_number":303,"context_line":"        # disassociate"},{"line_number":304,"context_line":"        self.admin_client.update_port(port[\u0027id\u0027], qos_policy_id\u003dNone)"},{"line_number":305,"context_line":"        self.addCleanup(self.admin_client.delete_qos_policy, policy[\u0027id\u0027])"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @test.idempotent_id(\u0027817da343-c6e4-445c-9519-a621f124dfbe\u0027)"},{"line_number":308,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_aca41ca6","line":305,"updated":"2016-11-25 12:32:39.000000000","message":"I don\u0027t think you got what I wanted to say in the previous PS. I meant that line 304 won\u0027t be executed if line 301 fails, then your cleanup will also fail to remove the policy. What you should do is register update_port as a cleanup (with addCleanup), not delete_qos_policy.","commit_id":"486c02babf808fd1cd3108fa4228c6310c4cd2fb"},{"author":{"_account_id":17491,"name":"Lujin Luo","email":"luo.lujin@jp.fujitsu.com","username":"Lujin"},"change_message_id":"3559414437ef351ef2280e4595dae78aeb4f95ae","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                           port[\u0027revision_number\u0027])"},{"line_number":303,"context_line":"        # disassociate"},{"line_number":304,"context_line":"        self.admin_client.update_port(port[\u0027id\u0027], qos_policy_id\u003dNone)"},{"line_number":305,"context_line":"        self.addCleanup(self.admin_client.delete_qos_policy, policy[\u0027id\u0027])"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @test.idempotent_id(\u0027817da343-c6e4-445c-9519-a621f124dfbe\u0027)"},{"line_number":308,"context_line":"    @test.requires_ext(extension\u003d\"qos\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_fd969b3c","line":305,"in_reply_to":"5a74a57a_aca41ca6","updated":"2016-11-28 01:05:28.000000000","message":"Ah, right. I misunderstood. Please check the updated PS.","commit_id":"486c02babf808fd1cd3108fa4228c6310c4cd2fb"}]}