)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8d55e9dc96b4dbf8d633b6198ad9d9dcc3b40690","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohit Malik \u003cmohit.malik@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-23 19:58:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: Remove get_reources() from get_pecan_resources()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4794033fe23304de767e0b0ad7b16d27b2527c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_90e25bd4","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":26},"updated":"2016-11-23 23:15:53.000000000","message":"resources","commit_id":"aab73389de7db65702d2c723f00a221da71163ed"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"92535e6105ac065611fa691a53aa1744acfdc213","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohit Malik \u003cmohit.malik@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-23 19:58:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: Remove get_reources() from get_pecan_resources()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4794033fe23304de767e0b0ad7b16d27b2527c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_076b1486","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":26},"in_reply_to":"5a74a57a_90e25bd4","updated":"2016-11-26 00:17:18.000000000","message":"oops. fixed","commit_id":"aab73389de7db65702d2c723f00a221da71163ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8d55e9dc96b4dbf8d633b6198ad9d9dcc3b40690","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-11-23 19:58:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pecan: Remove get_reources() from get_pecan_resources()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4794033fe23304de767e0b0ad7b16d27b2527c77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a74a57a_b38201ff","line":8,"updated":"2016-11-23 23:15:53.000000000","message":"Given the lengthy comment in https://review.openstack.org/#/c/401084/2/neutron/api/extensions.py@461, perhaps a little more background justifying the decision to remove this call is necessary","commit_id":"aab73389de7db65702d2c723f00a221da71163ed"}],"neutron/api/extensions.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8d55e9dc96b4dbf8d633b6198ad9d9dcc3b40690","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        \"\"\"Returns a list of PecanResourceExtension objects.\"\"\""},{"line_number":459,"context_line":"        resources \u003d []"},{"line_number":460,"context_line":"        for ext in self.extensions.values():"},{"line_number":461,"context_line":"            # TODO(blogan): this is being called because there are side effects"},{"line_number":462,"context_line":"            # that the get_resources method does, like registering plural"},{"line_number":463,"context_line":"            # mappings and quotas. The side effects that get_resources does"},{"line_number":464,"context_line":"            # should probably be moved to another extension method, but that"},{"line_number":465,"context_line":"            # should be done some other time."},{"line_number":466,"context_line":"            resources.extend(ext.get_pecan_resources())"},{"line_number":467,"context_line":"        return resources"},{"line_number":468,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_d087730d","line":465,"range":{"start_line":461,"start_character":12,"end_line":465,"end_character":45},"updated":"2016-11-23 23:15:53.000000000","message":"Has this comment been taken into consideration before removing the call to ext.get_resources()? If the answer is yes, the comment needs to be removed","commit_id":"aab73389de7db65702d2c723f00a221da71163ed"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"92535e6105ac065611fa691a53aa1744acfdc213","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        \"\"\"Returns a list of PecanResourceExtension objects.\"\"\""},{"line_number":459,"context_line":"        resources \u003d []"},{"line_number":460,"context_line":"        for ext in self.extensions.values():"},{"line_number":461,"context_line":"            # TODO(blogan): this is being called because there are side effects"},{"line_number":462,"context_line":"            # that the get_resources method does, like registering plural"},{"line_number":463,"context_line":"            # mappings and quotas. The side effects that get_resources does"},{"line_number":464,"context_line":"            # should probably be moved to another extension method, but that"},{"line_number":465,"context_line":"            # should be done some other time."},{"line_number":466,"context_line":"            resources.extend(ext.get_pecan_resources())"},{"line_number":467,"context_line":"        return resources"},{"line_number":468,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_27ff30ab","line":465,"range":{"start_line":461,"start_character":12,"end_line":465,"end_character":45},"in_reply_to":"5a74a57a_d087730d","updated":"2016-11-26 00:17:18.000000000","message":"I will talk to blogan about it. To me, it seems not related to get_resources().","commit_id":"aab73389de7db65702d2c723f00a221da71163ed"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"18c9d2cc57b7e804eb8239d46eb7c3d118dc6ca5","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        resources \u003d []"},{"line_number":460,"context_line":"        for ext in self.extensions.values():"},{"line_number":461,"context_line":"            # TODO(blogan): this is being called because there are side effects"},{"line_number":462,"context_line":"            # that the get_resources method does, like registering plural"},{"line_number":463,"context_line":"            # mappings and quotas. The side effects that get_resources does"},{"line_number":464,"context_line":"            # should probably be moved to another extension method, but that"},{"line_number":465,"context_line":"            # should be done some other time."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_2941b9a9","side":"PARENT","line":462,"range":{"start_line":462,"start_character":23,"end_line":462,"end_character":36},"updated":"2016-11-27 16:17:58.000000000","message":"Cool, please talk to blogan, let me know and I\u0027ll gladly remove the -1. Without the call to ext.get_resources() in line 466, this reference becomes meaningless. The deeper question, though, is how the side effects that the comment mentions are being achieved. Or, are they not necessary anymore?","commit_id":"6dc8dae79bdb380d1b044ebfaaafb1fb0086ffa9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"18c9d2cc57b7e804eb8239d46eb7c3d118dc6ca5","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        for ext in self.extensions.values():"},{"line_number":461,"context_line":"            # TODO(blogan): this is being called because there are side effects"},{"line_number":462,"context_line":"            # that the get_resources method does, like registering plural"},{"line_number":463,"context_line":"            # mappings and quotas. The side effects that get_resources does"},{"line_number":464,"context_line":"            # should probably be moved to another extension method, but that"},{"line_number":465,"context_line":"            # should be done some other time."},{"line_number":466,"context_line":"            ext.get_resources()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_694731bc","side":"PARENT","line":463,"range":{"start_line":463,"start_character":57,"end_line":463,"end_character":70},"updated":"2016-11-27 16:17:58.000000000","message":"Ditto","commit_id":"6dc8dae79bdb380d1b044ebfaaafb1fb0086ffa9"}]}