)]}'
{"doc/source/devref/effective_neutron.rst":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e572a3704548c7b2399f96a3722650e4d761361","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  visibility (as these patches are brought up to the attention of the core team"},{"line_number":217,"context_line":"  during team meetings). More details in `review guidelines"},{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When your feature depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the missing features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_9b11e85f","line":219,"range":{"start_line":219,"start_character":12,"end_line":219,"end_character":19},"updated":"2017-02-24 21:24:09.000000000","message":"Consider replacing this with \u0027code\u0027 or \u0027patch\u0027. This way we don\u0027t repeat \u0027feature\u0027 several times in the same sentence","commit_id":"577245244123f078c8e66a7cb707e8373178de73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f0dd0cfb270bb64e0f923e79cbd28cfb00e8e1fe","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  visibility (as these patches are brought up to the attention of the core team"},{"line_number":217,"context_line":"  during team meetings). More details in `review guidelines"},{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When your feature depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the missing features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_4e7c0cec","line":219,"range":{"start_line":219,"start_character":12,"end_line":219,"end_character":19},"in_reply_to":"da36d5c6_9b11e85f","updated":"2017-02-24 21:39:08.000000000","message":"Done","commit_id":"577245244123f078c8e66a7cb707e8373178de73"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9e572a3704548c7b2399f96a3722650e4d761361","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When your feature depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the missing features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"},{"line_number":223,"context_line":"  distributions may decide to backport needed features into older versions."},{"line_number":224,"context_line":"  Instead, sanity checks validate actual features by attempting to use them."}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_bb46ac78","line":221,"range":{"start_line":221,"start_character":31,"end_line":221,"end_character":38},"updated":"2017-02-24 21:24:09.000000000","message":"I think this should be \u0027expected\u0027","commit_id":"577245244123f078c8e66a7cb707e8373178de73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f0dd0cfb270bb64e0f923e79cbd28cfb00e8e1fe","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When your feature depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the missing features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"},{"line_number":223,"context_line":"  distributions may decide to backport needed features into older versions."},{"line_number":224,"context_line":"  Instead, sanity checks validate actual features by attempting to use them."}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_ce70fc0d","line":221,"range":{"start_line":221,"start_character":31,"end_line":221,"end_character":38},"in_reply_to":"da36d5c6_bb46ac78","updated":"2017-02-24 21:39:08.000000000","message":"Done","commit_id":"577245244123f078c8e66a7cb707e8373178de73"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b9515256cf0965f07ac3ea8b758abab3b99d0fd7","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  visibility (as these patches are brought up to the attention of the core team"},{"line_number":217,"context_line":"  during team meetings). More details in `review guidelines"},{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When your code depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the expected features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da36d5c6_1d7c08b4","line":219,"range":{"start_line":219,"start_character":2,"end_line":219,"end_character":16},"updated":"2017-02-25 04:18:10.000000000","message":"may be \u0027When the code or a patch\u0027 looks better ?","commit_id":"49ed765e4900de67a57785f7ca6ed758bc5b2988"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8751aa3119dc4eca60f552e25889a0e261a71ecb","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  visibility (as these patches are brought up to the attention of the core team"},{"line_number":217,"context_line":"  during team meetings). More details in `review guidelines"},{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When your code depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the expected features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a30ddce_2dcb3974","line":219,"range":{"start_line":219,"start_character":2,"end_line":219,"end_character":16},"in_reply_to":"9a30ddce_ea72e7ac","updated":"2017-03-06 22:27:05.000000000","message":"``your code`` sounds little aggressive, it is fine either but I feel ``When a patch or the code`` looks better. it can be any patch or code submission in neutron","commit_id":"49ed765e4900de67a57785f7ca6ed758bc5b2988"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cfaf3117d87b708a72730197e15b994aae96c837","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  visibility (as these patches are brought up to the attention of the core team"},{"line_number":217,"context_line":"  during team meetings). More details in `review guidelines"},{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When your code depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the expected features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a30ddce_ea72e7ac","line":219,"range":{"start_line":219,"start_character":2,"end_line":219,"end_character":16},"in_reply_to":"da36d5c6_1d7c08b4","updated":"2017-03-06 21:49:16.000000000","message":"Not sure if it\u0027s better. How exactly?","commit_id":"49ed765e4900de67a57785f7ca6ed758bc5b2988"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f9801c0a21b99da7762f24fb0d0beefd1936a006","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  visibility (as these patches are brought up to the attention of the core team"},{"line_number":217,"context_line":"  during team meetings). More details in `review guidelines"},{"line_number":218,"context_line":"  \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":219,"context_line":"* When a patch or the code depends on a new feature in kernel or in any platform tools"},{"line_number":220,"context_line":"  (dnsmasq, ip, Open vSwitch etc.), consider introducing a new sanity check to"},{"line_number":221,"context_line":"  validate deployments for the expected features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7ffa3b31_9f79befd","line":219,"range":{"start_line":219,"start_character":55,"end_line":219,"end_character":61},"updated":"2017-04-18 15:13:33.000000000","message":"s/the kernel","commit_id":"80a7ac47dd0db4a61ff1f74364b41cd895add3a5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f9801c0a21b99da7762f24fb0d0beefd1936a006","unresolved":false,"context_lines":[{"line_number":221,"context_line":"  validate deployments for the expected features. Note that sanity checks *must"},{"line_number":222,"context_line":"  not* check for version numbers of underlying platform tools because"},{"line_number":223,"context_line":"  distributions may decide to backport needed features into older versions."},{"line_number":224,"context_line":"  Instead, sanity checks validate actual features by attempting to use them."},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"Eventlet concurrent model"},{"line_number":227,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7ffa3b31_ff67a250","line":224,"range":{"start_line":224,"start_character":25,"end_line":224,"end_character":33},"updated":"2017-04-18 15:13:33.000000000","message":"s/should validate","commit_id":"80a7ac47dd0db4a61ff1f74364b41cd895add3a5"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"84dadcc8e458618214d971317a0ff2466cd74a0a","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    help\u003d_(\u0027Check netns permission settings\u0027)),"},{"line_number":299,"context_line":"    BoolOptCallback(\u0027dnsmasq_version\u0027, check_dnsmasq_version,"},{"line_number":300,"context_line":"                    help\u003d_(\u0027Check minimal dnsmasq version\u0027),"},{"line_number":301,"context_line":"                    deprecated_for_removal\u003dTrue),"},{"line_number":302,"context_line":"    BoolOptCallback(\u0027ovsdb_native\u0027, check_ovsdb_native,"},{"line_number":303,"context_line":"                    help\u003d_(\u0027Check ovsdb native interface support\u0027)),"},{"line_number":304,"context_line":"    BoolOptCallback(\u0027ovs_conntrack\u0027, check_ovs_conntrack,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_83486dce","line":301,"updated":"2017-03-06 20:26:14.000000000","message":"I think it will be helpful to add removal_version\u003d\"Queens\" so that it\u0027s clear when it\u0027s safe to remove it. Thoughts?","commit_id":"49ed765e4900de67a57785f7ca6ed758bc5b2988"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cfaf3117d87b708a72730197e15b994aae96c837","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    help\u003d_(\u0027Check netns permission settings\u0027)),"},{"line_number":299,"context_line":"    BoolOptCallback(\u0027dnsmasq_version\u0027, check_dnsmasq_version,"},{"line_number":300,"context_line":"                    help\u003d_(\u0027Check minimal dnsmasq version\u0027),"},{"line_number":301,"context_line":"                    deprecated_for_removal\u003dTrue),"},{"line_number":302,"context_line":"    BoolOptCallback(\u0027ovsdb_native\u0027, check_ovsdb_native,"},{"line_number":303,"context_line":"                    help\u003d_(\u0027Check ovsdb native interface support\u0027)),"},{"line_number":304,"context_line":"    BoolOptCallback(\u0027ovs_conntrack\u0027, check_ovs_conntrack,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_4a4bf359","line":301,"in_reply_to":"ba2be162_83486dce","updated":"2017-03-06 21:49:16.000000000","message":"I don\u0027t think it\u0027s supported by oslo.config?\n\nhttps://docs.openstack.org/developer/oslo.config/cfg.html#option-deprecation","commit_id":"49ed765e4900de67a57785f7ca6ed758bc5b2988"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"84dadcc8e458618214d971317a0ff2466cd74a0a","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                    help\u003d_(\u0027Check keepalived IPv6 support\u0027)),"},{"line_number":310,"context_line":"    BoolOptCallback(\u0027dibbler_version\u0027, check_dibbler_version,"},{"line_number":311,"context_line":"                    help\u003d_(\u0027Check minimal dibbler version\u0027),"},{"line_number":312,"context_line":"                    deprecated_for_removal\u003dTrue),"},{"line_number":313,"context_line":"    BoolOptCallback(\u0027ipset_installed\u0027, check_ipset,"},{"line_number":314,"context_line":"                    help\u003d_(\u0027Check ipset installation\u0027)),"},{"line_number":315,"context_line":"    BoolOptCallback(\u0027ip6tables_installed\u0027, check_ip6tables,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_e315a99b","line":312,"updated":"2017-03-06 20:26:14.000000000","message":"ditto","commit_id":"49ed765e4900de67a57785f7ca6ed758bc5b2988"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8a4124ed5e6df838d7744acfd0380ada962c7e7f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    help\u003d_(\u0027Check netns permission settings\u0027)),"},{"line_number":299,"context_line":"    BoolOptCallback(\u0027dnsmasq_version\u0027, check_dnsmasq_version,"},{"line_number":300,"context_line":"                    help\u003d_(\u0027Check minimal dnsmasq version\u0027),"},{"line_number":301,"context_line":"                    deprecated_for_removal\u003dTrue),"},{"line_number":302,"context_line":"    BoolOptCallback(\u0027ovsdb_native\u0027, check_ovsdb_native,"},{"line_number":303,"context_line":"                    help\u003d_(\u0027Check ovsdb native interface support\u0027)),"},{"line_number":304,"context_line":"    BoolOptCallback(\u0027ovs_conntrack\u0027, check_ovs_conntrack,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_f57b9b79","line":301,"range":{"start_line":301,"start_character":47,"end_line":301,"end_character":49},"updated":"2017-03-07 06:27:32.000000000","message":"oslo.config supports an option named \u0027deprecated_since\u0027 [1]. I think we can use this to mention it\u0027s deprecated in Pike which will implicitly state removal_version is Queens.\n[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L778-L781","commit_id":"b1557fe0a74750cc7289c433a5f18de7f2ac0fae"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"386ce9fe87720434a8b88435583a5a1173db63a2","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                    help\u003d_(\u0027Check netns permission settings\u0027)),"},{"line_number":299,"context_line":"    BoolOptCallback(\u0027dnsmasq_version\u0027, check_dnsmasq_version,"},{"line_number":300,"context_line":"                    help\u003d_(\u0027Check minimal dnsmasq version\u0027),"},{"line_number":301,"context_line":"                    deprecated_for_removal\u003dTrue),"},{"line_number":302,"context_line":"    BoolOptCallback(\u0027ovsdb_native\u0027, check_ovsdb_native,"},{"line_number":303,"context_line":"                    help\u003d_(\u0027Check ovsdb native interface support\u0027)),"},{"line_number":304,"context_line":"    BoolOptCallback(\u0027ovs_conntrack\u0027, check_ovs_conntrack,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_f43e13b7","line":301,"range":{"start_line":301,"start_character":47,"end_line":301,"end_character":49},"in_reply_to":"9a30ddce_f57b9b79","updated":"2017-03-07 21:20:38.000000000","message":"Done","commit_id":"b1557fe0a74750cc7289c433a5f18de7f2ac0fae"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e7e9392a88852db4c2b5d208c06bf65171e488a7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"# missing hwaddr matching in dnsmasq \u003c 2.67, a better version of the check"},{"line_number":110,"context_line":"# would actually start dnsmasq server and issue a DHCP request using a IPv6"},{"line_number":111,"context_line":"# DHCP client."},{"line_number":112,"context_line":"def check_dnsmasq_version():"},{"line_number":113,"context_line":"    result \u003d checks.dnsmasq_version_supported()"},{"line_number":114,"context_line":"    if not result:"},{"line_number":115,"context_line":"        LOG.error(_LE(\u0027The installed version of dnsmasq is too old. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_728dd330","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":25},"updated":"2017-03-07 22:22:54.000000000","message":"Shouldn\u0027t necessary to specify a deprecation mechanism to this method thru removals.remove decorator?","commit_id":"80a7ac47dd0db4a61ff1f74364b41cd895add3a5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7491e6b4995c2ecaeea8ce7ce000a187b6639e86","unresolved":false,"context_lines":[{"line_number":109,"context_line":"# missing hwaddr matching in dnsmasq \u003c 2.67, a better version of the check"},{"line_number":110,"context_line":"# would actually start dnsmasq server and issue a DHCP request using a IPv6"},{"line_number":111,"context_line":"# DHCP client."},{"line_number":112,"context_line":"def check_dnsmasq_version():"},{"line_number":113,"context_line":"    result \u003d checks.dnsmasq_version_supported()"},{"line_number":114,"context_line":"    if not result:"},{"line_number":115,"context_line":"        LOG.error(_LE(\u0027The installed version of dnsmasq is too old. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_48adf686","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":25},"in_reply_to":"9a30ddce_728dd330","updated":"2017-03-10 18:45:12.000000000","message":"No I don\u0027t think so. Anyone importing from neutron/cmd/ should stop doing it, it\u0027s explicitly wrong to do.","commit_id":"80a7ac47dd0db4a61ff1f74364b41cd895add3a5"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e7e9392a88852db4c2b5d208c06bf65171e488a7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    return result"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def check_dibbler_version():"},{"line_number":131,"context_line":"    result \u003d checks.dibbler_version_supported()"},{"line_number":132,"context_line":"    if not result:"},{"line_number":133,"context_line":"        LOG.error(_LE(\u0027The installed version of dibbler-client is too old. \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a30ddce_528fef22","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":25},"updated":"2017-03-07 22:22:54.000000000","message":"ditto: line 112","commit_id":"80a7ac47dd0db4a61ff1f74364b41cd895add3a5"}]}