)]}'
{"doc/source/devref/effective_neutron.rst":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6032968ef9a552913e8c91d1d733968ee5223e7f","unresolved":false,"context_lines":[{"line_number":215,"context_line":"  Instead, sanity checks validate actual features by attempting to use them."},{"line_number":216,"context_line":"* When your patch requires a new platform tool or a new feature in an existing"},{"line_number":217,"context_line":"  tool, check if common platforms (Ubuntu, CentOS, Debian) ship packages with"},{"line_number":218,"context_line":"  needed features. If not, revisit the direction of the patch, or talk to"},{"line_number":219,"context_line":"  distributions in advance to request missing features, or gracefully handle"},{"line_number":220,"context_line":"  missing functionality in code."},{"line_number":221,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_8d4cde71","line":218,"range":{"start_line":218,"start_character":2,"end_line":218,"end_character":17},"updated":"2016-11-24 14:48:32.000000000","message":"the aforementioned feature","commit_id":"c667f3308de09c19fbf4e7f32ef7ed2dba21ad38"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6032968ef9a552913e8c91d1d733968ee5223e7f","unresolved":false,"context_lines":[{"line_number":216,"context_line":"* When your patch requires a new platform tool or a new feature in an existing"},{"line_number":217,"context_line":"  tool, check if common platforms (Ubuntu, CentOS, Debian) ship packages with"},{"line_number":218,"context_line":"  needed features. If not, revisit the direction of the patch, or talk to"},{"line_number":219,"context_line":"  distributions in advance to request missing features, or gracefully handle"},{"line_number":220,"context_line":"  missing functionality in code."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Eventlet concurrent model"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_ed77129d","line":219,"range":{"start_line":219,"start_character":46,"end_line":219,"end_character":54},"updated":"2016-11-24 14:48:32.000000000","message":"support","commit_id":"c667f3308de09c19fbf4e7f32ef7ed2dba21ad38"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ed50a2000fe8d4e7623920e8ffba5d5a564a0ed9","unresolved":false,"context_lines":[{"line_number":217,"context_line":"  tool, check if common platforms (Ubuntu, CentOS, Debian) ship packages with"},{"line_number":218,"context_line":"  the aforementioned feature. If not, revisit the direction of the patch, or"},{"line_number":219,"context_line":"  talk to distributions in advance to request missing feature support, or"},{"line_number":220,"context_line":"  gracefully handle missing functionality in code."},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Eventlet concurrent model"},{"line_number":223,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a71b18c_9f13585c","line":220,"updated":"2016-12-01 19:25:20.000000000","message":"I am thinking this is more appropriately placed in [1] or both, in that I\u0027d be almost tempted to say that such a feature requires spec-level attention.\n\n[1] http://docs.openstack.org/developer/neutron/policies/blueprints.html","commit_id":"369e6a70ab141c550923842b7c6c85c1ccf299ab"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b691d40e26e6ce9432a367524a6bc67f17427088","unresolved":false,"context_lines":[{"line_number":207,"context_line":"Document common pitfalls as well as good practices done when invoking system commands"},{"line_number":208,"context_line":"and interacting with linux utils."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* When your patch requires a new platform tool or a new feature in an existing"},{"line_number":211,"context_line":"  tool, check if common platforms ship packages with the aforementioned"},{"line_number":212,"context_line":"  feature. Also, tag such a patch with ``UpgradeImpact``. More details in"},{"line_number":213,"context_line":"  `review guidelines \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_4e8e142f","line":210,"range":{"start_line":210,"start_character":6,"end_line":210,"end_character":11},"updated":"2016-12-10 00:04:34.000000000","message":"can we use s/any/your ?","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d6f976226df07fc1bef4caae1cd8fc516ed99441","unresolved":false,"context_lines":[{"line_number":207,"context_line":"Document common pitfalls as well as good practices done when invoking system commands"},{"line_number":208,"context_line":"and interacting with linux utils."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* When your patch requires a new platform tool or a new feature in an existing"},{"line_number":211,"context_line":"  tool, check if common platforms ship packages with the aforementioned"},{"line_number":212,"context_line":"  feature. Also, tag such a patch with ``UpgradeImpact``. More details in"},{"line_number":213,"context_line":"  `review guidelines \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_8495dd89","line":210,"range":{"start_line":210,"start_character":6,"end_line":210,"end_character":11},"in_reply_to":"3a71b18c_4e8e142f","updated":"2016-12-19 09:37:43.000000000","message":"I will use \u0027a\u0027.","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4c346aafa66dbf8b6be0f5bf9d3ea6ce38afc6a0","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* When your patch requires a new platform tool or a new feature in an existing"},{"line_number":211,"context_line":"  tool, check if common platforms ship packages with the aforementioned"},{"line_number":212,"context_line":"  feature. Also, tag such a patch with ``UpgradeImpact``. More details in"},{"line_number":213,"context_line":"  `review guidelines \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Eventlet concurrent model"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_cef784d1","line":212,"range":{"start_line":212,"start_character":39,"end_line":212,"end_character":56},"updated":"2016-12-09 23:54:07.000000000","message":"I\u0027d add (as these patches are brought up to the attention of the core team during the team meeting).","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d6f976226df07fc1bef4caae1cd8fc516ed99441","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"* When your patch requires a new platform tool or a new feature in an existing"},{"line_number":211,"context_line":"  tool, check if common platforms ship packages with the aforementioned"},{"line_number":212,"context_line":"  feature. Also, tag such a patch with ``UpgradeImpact``. More details in"},{"line_number":213,"context_line":"  `review guidelines \u003chttp://docs.openstack.org/developer/neutron/policies/code-reviews.html#neutron-spec-review-practices\u003e`_."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Eventlet concurrent model"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_24d40946","line":212,"range":{"start_line":212,"start_character":39,"end_line":212,"end_character":56},"in_reply_to":"3a71b18c_cef784d1","updated":"2016-12-19 09:37:43.000000000","message":"Done","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"}],"doc/source/policies/code-reviews.rst":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4c346aafa66dbf8b6be0f5bf9d3ea6ce38afc6a0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  a supported platform (examples of those platforms are latest Ubuntu LTS or"},{"line_number":20,"context_line":"  CentOS). Runtime dependencies include but are not limited to: kernel, daemons"},{"line_number":21,"context_line":"  and tools as defined in ``oslo.rootwrap`` filter files, runlevel management"},{"line_number":22,"context_line":"  systems, as well as other elements of Neutron execution environment."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  #. All such changes must be tagged with ``UpgradeImpact`` in their commit"},{"line_number":25,"context_line":"     messages."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_ee17e0eb","line":22,"updated":"2016-12-09 23:54:07.000000000","message":"shall we mention winz too here?","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d6f976226df07fc1bef4caae1cd8fc516ed99441","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  a supported platform (examples of those platforms are latest Ubuntu LTS or"},{"line_number":20,"context_line":"  CentOS). Runtime dependencies include but are not limited to: kernel, daemons"},{"line_number":21,"context_line":"  and tools as defined in ``oslo.rootwrap`` filter files, runlevel management"},{"line_number":22,"context_line":"  systems, as well as other elements of Neutron execution environment."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  #. All such changes must be tagged with ``UpgradeImpact`` in their commit"},{"line_number":25,"context_line":"     messages."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_04a0eda4","line":22,"in_reply_to":"3a71b18c_ee17e0eb","updated":"2016-12-19 09:37:43.000000000","message":"Let me add a general note. If you think that we should be more specific about particular *versions* of win32 platform we support, tell me. Though I think it could as well go into a follow-up if need be.","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4c346aafa66dbf8b6be0f5bf9d3ea6ce38afc6a0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"     messages."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  #. Reviewers are then advised to make an effort to check if the newly"},{"line_number":28,"context_line":"     proposed runtime dependency is fulfilled on supported platforms."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  #. Reviewers and authors are also advised to use existing gate and"},{"line_number":31,"context_line":"     experimental platform specific jobs to validate those patches."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_4ec0d450","line":28,"updated":"2016-12-09 23:54:07.000000000","message":"I\u0027d add: by posting comment \u0027check experimental\u0027. CI will execute and report back a baseline of neutron tests for platforms of interest and will provide feedback on the effect of the runtime change required.","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d6f976226df07fc1bef4caae1cd8fc516ed99441","unresolved":false,"context_lines":[{"line_number":25,"context_line":"     messages."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  #. Reviewers are then advised to make an effort to check if the newly"},{"line_number":28,"context_line":"     proposed runtime dependency is fulfilled on supported platforms."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  #. Reviewers and authors are also advised to use existing gate and"},{"line_number":31,"context_line":"     experimental platform specific jobs to validate those patches."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_e49bf170","line":28,"in_reply_to":"3a71b18c_4ec0d450","updated":"2016-12-19 09:37:43.000000000","message":"Isn\u0027t it what the next bullet point in the list (line 30) suggests? Let me add some more meat there instead.","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"507b329bdfa3eedb20a024c0039ae6391b8c5fe0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  #. Reviewers and authors are also advised to use existing gate and"},{"line_number":31,"context_line":"     experimental platform specific jobs to validate those patches."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  #. If review identifies that the proposed change would break a supported"},{"line_number":34,"context_line":"     platform, advise to rework the patch so that it\u0027s no longer breaking the"},{"line_number":35,"context_line":"     platform. One of common ways of achieving that is gracefully falling back"},{"line_number":36,"context_line":"     to alternative means on older platforms, another is hiding the new code"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_21b57e30","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":25},"updated":"2016-12-09 15:33:48.000000000","message":"nit: If a reviewer identifies","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75c0e433fc9780d5914b1f88d8cfc938dc61aad0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  #. Reviewers and authors are also advised to use existing gate and"},{"line_number":31,"context_line":"     experimental platform specific jobs to validate those patches."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  #. If review identifies that the proposed change would break a supported"},{"line_number":34,"context_line":"     platform, advise to rework the patch so that it\u0027s no longer breaking the"},{"line_number":35,"context_line":"     platform. One of common ways of achieving that is gracefully falling back"},{"line_number":36,"context_line":"     to alternative means on older platforms, another is hiding the new code"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_276904fa","line":33,"range":{"start_line":33,"start_character":5,"end_line":33,"end_character":25},"in_reply_to":"3a71b18c_21b57e30","updated":"2016-12-09 20:18:56.000000000","message":"I don\u0027t see how it\u0027s better. What if the author identified it during review? :)","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"507b329bdfa3eedb20a024c0039ae6391b8c5fe0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     experimental platform specific jobs to validate those patches."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  #. If review identifies that the proposed change would break a supported"},{"line_number":34,"context_line":"     platform, advise to rework the patch so that it\u0027s no longer breaking the"},{"line_number":35,"context_line":"     platform. One of common ways of achieving that is gracefully falling back"},{"line_number":36,"context_line":"     to alternative means on older platforms, another is hiding the new code"},{"line_number":37,"context_line":"     behind a conditional, potentially controlled with a ``oslo.config``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_a1cd0eb9","line":34,"range":{"start_line":34,"start_character":15,"end_line":34,"end_character":42},"updated":"2016-12-09 15:33:48.000000000","message":"nit: s/he must advise to rework on the patch","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75c0e433fc9780d5914b1f88d8cfc938dc61aad0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     experimental platform specific jobs to validate those patches."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  #. If review identifies that the proposed change would break a supported"},{"line_number":34,"context_line":"     platform, advise to rework the patch so that it\u0027s no longer breaking the"},{"line_number":35,"context_line":"     platform. One of common ways of achieving that is gracefully falling back"},{"line_number":36,"context_line":"     to alternative means on older platforms, another is hiding the new code"},{"line_number":37,"context_line":"     behind a conditional, potentially controlled with a ``oslo.config``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_877818c6","line":34,"range":{"start_line":34,"start_character":15,"end_line":34,"end_character":42},"in_reply_to":"3a71b18c_a1cd0eb9","updated":"2016-12-09 20:18:56.000000000","message":"These are guidelines on how to review code. Obviously it\u0027s directed towards reviewers.","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8ac96938b883e64d84a6b8073a1734f028f6dbc6","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  #. If review identifies that the proposed change would break a supported"},{"line_number":34,"context_line":"     platform, advise to rework the patch so that it\u0027s no longer breaking the"},{"line_number":35,"context_line":"     platform. One of common ways of achieving that is gracefully falling back"},{"line_number":36,"context_line":"     to alternative means on older platforms, another is hiding the new code"},{"line_number":37,"context_line":"     behind a conditional, potentially controlled with a ``oslo.config``"},{"line_number":38,"context_line":"     option."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a71b18c_c76f53fa","line":35,"range":{"start_line":35,"start_character":19,"end_line":35,"end_character":21},"updated":"2016-12-12 00:09:31.000000000","message":"of the","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d6f976226df07fc1bef4caae1cd8fc516ed99441","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  #. If review identifies that the proposed change would break a supported"},{"line_number":34,"context_line":"     platform, advise to rework the patch so that it\u0027s no longer breaking the"},{"line_number":35,"context_line":"     platform. One of common ways of achieving that is gracefully falling back"},{"line_number":36,"context_line":"     to alternative means on older platforms, another is hiding the new code"},{"line_number":37,"context_line":"     behind a conditional, potentially controlled with a ``oslo.config``"},{"line_number":38,"context_line":"     option."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_c4ac358f","line":35,"range":{"start_line":35,"start_character":19,"end_line":35,"end_character":21},"in_reply_to":"3a71b18c_c76f53fa","updated":"2016-12-19 09:37:43.000000000","message":"Done","commit_id":"53193c42e64377f96f5d644d7a8b154ae3498e58"}]}