)]}'
{"neutron/agent/linux/openvswitch_firewall/rules.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e9ba4060f5e5ae885d791fb4dbb64ae6e3dde96c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        pass"},{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        if (rule.get(\u0027ethertype\u0027) \u003d\u003d n_consts.IPv6 and"},{"line_number":87,"context_line":"                protocol \u003d\u003d n_consts.PROTO_NAME_ICMP):"},{"line_number":88,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.PROTO_NUM_IPV6_ICMP"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.IP_PROTOCOL_MAP.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_5b18f684","line":87,"updated":"2017-01-03 06:50:05.000000000","message":"consider checking the protocol first then it will save a cycle","commit_id":"82cdb9b7fa26a41b75a5caf7bafc7abd882076cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8ec96b33aadd2179cd11fed5a697ce710790c179","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.PROTO_NUM_IPV6_ICMP"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.IP_PROTOCOL_MAP.get("},{"line_number":91,"context_line":"                protocol, protocol)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    flows \u003d create_port_range_flows(flow_template, rule)"},{"line_number":94,"context_line":"    return flows or [flow_template]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_9d1e330a","line":91,"updated":"2017-01-18 11:00:03.000000000","message":"In the new code, when \u0027protocol\u0027 key is contained in rule and rule[\u0027protocol\u0027] is None, flow_template[\u0027nw_proto\u0027] will be None.\nPreviously flow_template[\u0027nw_proto\u0027] \u003d None is not registered. Does this change have any side-effect?","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fa244f071735c0bf86aa29fadaebc45c855af9fb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.PROTO_NUM_IPV6_ICMP"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.IP_PROTOCOL_MAP.get("},{"line_number":91,"context_line":"                protocol, protocol)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    flows \u003d create_port_range_flows(flow_template, rule)"},{"line_number":94,"context_line":"    return flows or [flow_template]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_9c63231a","line":91,"in_reply_to":"7a3c09a3_80d16625","updated":"2017-01-20 09:41:07.000000000","message":"Thanks Akihiro for spotting this, It has catastrophic impact. I owe you a beer!","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d1c3c2859da137cdf766dfcd003cb640a154942","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.PROTO_NUM_IPV6_ICMP"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            flow_template[\u0027nw_proto\u0027] \u003d n_consts.IP_PROTOCOL_MAP.get("},{"line_number":91,"context_line":"                protocol, protocol)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    flows \u003d create_port_range_flows(flow_template, rule)"},{"line_number":94,"context_line":"    return flows or [flow_template]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_80d16625","line":91,"in_reply_to":"7a3c09a3_9d1e330a","updated":"2017-01-18 11:05:47.000000000","message":"Good catch! I need to test it and also check, whether passing None as protocol is a valid value.","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"}],"neutron/tests/fullstack/test_securitygroup.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"49f3c5ff592ea364f73fa45f5f0b0c0d64f66494","unresolved":false,"context_lines":[{"line_number":100,"context_line":"             4. a security group update takes effect,"},{"line_number":101,"context_line":"             5. a remote security group member addition works, and"},{"line_number":102,"context_line":"             6. an established connection stops by deleting a SG rule."},{"line_number":103,"context_line":"             7. test other protocol functionality by using SCTP protol"},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        index_to_sg \u003d [0, 0, 1]"},{"line_number":106,"context_line":"        if self.firewall_driver \u003d\u003d \u0027iptables_hybrid\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_3cd49dbb","line":103,"range":{"start_line":103,"start_character":64,"end_line":103,"end_character":70},"updated":"2017-01-17 14:05:12.000000000","message":"meganit: protol-\u003eprotocol","commit_id":"544fd4bc3cb64c4bf0cd49844971553794c793d2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"327c384178e54033c2bdcb84aef8966674d57203","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # the recommended way to add test is to expand this method, not"},{"line_number":94,"context_line":"    # adding another."},{"line_number":95,"context_line":"    def test_securitygroup(self):"},{"line_number":96,"context_line":"        \"\"\"Tests if a security groups rule are working, by confirming"},{"line_number":97,"context_line":"        that 1. connection from allowed security group is allowed,"},{"line_number":98,"context_line":"             2. connection from elsewhere is blocked,"},{"line_number":99,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_2088cbc4","line":96,"range":{"start_line":96,"start_character":38,"end_line":96,"end_character":42},"updated":"2017-01-17 23:37:51.000000000","message":"s/rules","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fa244f071735c0bf86aa29fadaebc45c855af9fb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    # the recommended way to add test is to expand this method, not"},{"line_number":94,"context_line":"    # adding another."},{"line_number":95,"context_line":"    def test_securitygroup(self):"},{"line_number":96,"context_line":"        \"\"\"Tests if a security groups rule are working, by confirming"},{"line_number":97,"context_line":"        that 1. connection from allowed security group is allowed,"},{"line_number":98,"context_line":"             2. connection from elsewhere is blocked,"},{"line_number":99,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a3905b3_9aaa75d3","line":96,"range":{"start_line":96,"start_character":38,"end_line":96,"end_character":42},"in_reply_to":"7a3c09a3_2088cbc4","updated":"2017-01-20 09:41:07.000000000","message":"Done","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"327c384178e54033c2bdcb84aef8966674d57203","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # 7. check SCTP is supported by security group"},{"line_number":223,"context_line":"        self.assert_no_connection("},{"line_number":224,"context_line":"            vms[1].namespace, vms[0].namespace, vms[0].ip,"},{"line_number":225,"context_line":"            net_helpers.NetcatTester.SCTP)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.safe_client.create_security_group_rule("},{"line_number":228,"context_line":"            tenant_uuid, sgs[0][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_205d2b47","line":225,"updated":"2017-01-17 23:37:51.000000000","message":"No port number?","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8ec96b33aadd2179cd11fed5a697ce710790c179","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # 7. check SCTP is supported by security group"},{"line_number":223,"context_line":"        self.assert_no_connection("},{"line_number":224,"context_line":"            vms[1].namespace, vms[0].namespace, vms[0].ip,"},{"line_number":225,"context_line":"            net_helpers.NetcatTester.SCTP)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.safe_client.create_security_group_rule("},{"line_number":228,"context_line":"            tenant_uuid, sgs[0][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_9d8713b4","line":225,"in_reply_to":"7a3c09a3_205d2b47","updated":"2017-01-18 11:00:03.000000000","message":"dst_port becomes an optional parameter in this patch.\nWe are testing SCTP protocol here, so I don\u0027t think it is required.","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9d1c3c2859da137cdf766dfcd003cb640a154942","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        # 7. check SCTP is supported by security group"},{"line_number":223,"context_line":"        self.assert_no_connection("},{"line_number":224,"context_line":"            vms[1].namespace, vms[0].namespace, vms[0].ip,"},{"line_number":225,"context_line":"            net_helpers.NetcatTester.SCTP)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.safe_client.create_security_group_rule("},{"line_number":228,"context_line":"            tenant_uuid, sgs[0][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_40c93eab","line":225,"in_reply_to":"7a3c09a3_9d8713b4","updated":"2017-01-18 11:05:47.000000000","message":"Akihiro is correct, the subject to test here is that protocols can be accepted as numbers - the SCTP doesn\u0027t require a port number to establish connection, so it\u0027s not needed. I think in case we need port number in the future, it can be introduced later.","commit_id":"0c71f62fb77be0969d0eb2bcd58943f2535782bd"}]}
